| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
Un-nest for clarity.
Re-land of http://crrev.com/1318823008 while preserving config ordering.
Review URL: https://codereview.chromium.org/1307223010
Cr-Commit-Position: refs/heads/master@{#346964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1318823008/ )
Reason for revert:
This breaks why these configs exist in the first place and seriously breaks the clang/win gn build (which is what these configs exist for).
Original issue's description:
> Un-nest configs in GN files.
>
> People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
>
> Un-nest for clarity.
>
> Committed: https://crrev.com/4af2eac8e84692d94f88504ab6e0b244b88dddcb
> Cr-Commit-Position: refs/heads/master@{#346461}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1316843006
Cr-Commit-Position: refs/heads/master@{#346695}
|
|
|
|
|
|
|
|
|
|
| |
People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
Un-nest for clarity.
Review URL: https://codereview.chromium.org/1318823008
Cr-Commit-Position: refs/heads/master@{#346461}
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw@chromium.org
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1237953003
Cr-Commit-Position: refs/heads/master@{#339357}
|
|
|
|
|
|
|
|
|
|
|
| |
This also changes all the references to http://code.google.com/p/open-vcdiff
to point to https://github.com/google/open-vcdiff
BUG=510860
Review URL: https://codereview.chromium.org/1242533003
Cr-Commit-Position: refs/heads/master@{#339282}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Application of https://codereview.chromium.org/962003002/.
TBR=keybuk@chromium.org
R=brettw@chromium.org
BUG=456014
Review URL: https://codereview.chromium.org/960413003
Cr-Commit-Position: refs/heads/master@{#318574}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other misc fixes including:
Add "data_deps" to the templates in BUILDCONFIG. This was renamed from "datadeps" a while ago but both are still supported.
extension_management_test_util.cc includes a generated file policy_constants. GYP generates this with an extra "policy" directory but GN doesn't. The way GYP has the dirs set up, though, using only one "policy" works (and this is what other files do) so I just changed the include.
TBR=dpranke
Review URL: https://codereview.chromium.org/824373003
Cr-Commit-Position: refs/heads/master@{#310276}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excluded mojo because I think that needs to happen on the other side.
At gn --version = 306668 for which roll is in CQ.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/774353003
Cr-Commit-Position: refs/heads/master@{#306708}
|
|
|
|
|
|
|
|
|
| |
BUG=321833
TBR=brettw
Review URL: https://codereview.chromium.org/722513003
Cr-Commit-Position: refs/heads/master@{#303892}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
TBR=wtc@chromium.org
BUG=354261
Review URL: https://codereview.chromium.org/419073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's no longer needed.
BUG=308740
R=scottmg@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/404443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=
R=mark@chromium.org
Review URL: https://codereview.chromium.org/308123006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274271 0039d316-1c4b-4281-b951-d872f2087c98
|