summaryrefslogtreecommitdiffstats
path: root/sql
Commit message (Collapse)AuthorAgeFilesLines
* [sql] Fix error in Preload size.shess2015-04-211-1/+1
| | | | | | | | | | Was using file size rather than limiting to file size. BUG=none Review URL: https://codereview.chromium.org/1096113002 Cr-Commit-Position: refs/heads/master@{#326064}
* [sql] Also call ShouldIgnoreSqliteError() in Release build.shess2015-04-101-4/+4
| | | | | | | | | | | | https://crrev.com/92a2ab1f1d0cdff39e6d506c4cb6a80038baeeb3 put the test (which has a side effect) in DLOG_IF which doesn't apply in Release builds. BUG=none Review URL: https://codereview.chromium.org/1075993003 Cr-Commit-Position: refs/heads/master@{#324697}
* Fix sql_unittest on iOS using SDK 8.2sdefresne2015-04-101-1/+1
| | | | | | | | | | | | According to testing, sqlite3 version used on iOS (3008005) already returns SQLITE_NOTADB, so update SQLConnectionTest.RazeNOTADB to ignore that error from that version. BUG=475511,475512 Review URL: https://codereview.chromium.org/1075243002 Cr-Commit-Position: refs/heads/master@{#324648}
* [sql] Change DoesStuffExist() to work with ScopedErrorIgnorer.shess2015-04-093-14/+58
| | | | | | | | | | | | | | | This not working was preventing certain corruption-testing tests from being written. Also modified Does{Table,Index,Column}Exist() to reflect that these names are _not_ case sensitive. It is not possible to have distinct tables [Foo] and [foo]. BUG=none Review URL: https://codereview.chromium.org/1069313004 Cr-Commit-Position: refs/heads/master@{#324337}
* [sql] Stop building fts2.shess2015-03-112-33/+10
| | | | | | | | | | | | | | | | | | Long ago, Chromium used fts2 for history full-text search. It was later replaced by fts3, and even later that feature was deleted entirely. fts2 is no longer used in the browser at all, so stop compiling it. Since SQLite is used by WebSQL, in theory this could affect web authors, but WebSQL uses an authorizer to allow only specific virtual table types. fts2 is not one of those types, I have verified manually that fts2 tables cannot be created using WebSQL. BUG=455817 Review URL: https://codereview.chromium.org/999573003 Cr-Commit-Position: refs/heads/master@{#320135}
* Update existing uses of /wd4267 to use the GN configbrettw2015-02-191-7/+5
| | | | | | | | | | This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read. Minor updates to Win64 build, including some fixes for size_t to int conversions. Review URL: https://codereview.chromium.org/929793006 Cr-Commit-Position: refs/heads/master@{#317162}
* Import SQLite 3.8.7.4.Scott Hess2015-02-108-23/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ran through the import script in third_party/sqlite/README.Chromium, including the SQLite test suite. There are a few pager errors which are because of a change required for WebDatabase support (documented in README). SQLite changes are at http://www.sqlite.org/changes.html , Chromium previously used 3.7.6.3. All patches were applied and the results reviewed to make sure backported patches were safe to remove, and retained patches were still covering what was necessary. Keep fts4 disabled, and also the new fts3 virtual table and unicode61 tokenizer. Once enabled, these are very hard to disable, and there doesn't seem to be any pressure to enable them. Other SQLITE_* flags were reviewed for applicability, none looked essential. Fixes to Chromium: - In recovery.cc, pk_column now follows the documentation. - Short garbage files now see SQLITE_NOTADB rather than SQLITE_IOERR_SHORT_READ. - Adjust to allow clients to use ScopedErrorIgnore without adding dependencies. - More-specific SQLITE_CONSTRAINT_* errors aren't necessary. - Force recovery test to scan table rather than index. BUG=340757 TEST=*EVERYTHING* continues to work. R=michaeln@chromium.org Review URL: https://codereview.chromium.org/901033002 Cr-Commit-Position: refs/heads/master@{#315646}
* Add SQLite feature test to verify working foreign key support.engedy2015-01-221-1/+39
| | | | | | | | | | This low-level test specifically ensures that foreign key support will not break upon importing a new SQLite version or changing compile-time flags. BUG=437865 Review URL: https://codereview.chromium.org/856343002 Cr-Commit-Position: refs/heads/master@{#312596}
* [sql] Enable HAVE_USLEEP for more platforms.shess2015-01-211-0/+17
| | | | | | | | | | | | HAVE_USLEEP affects SQLite's sleep implementation, which is used when SQLite waits for a lock to clear. Browser databases are generally uncontended, but this case could happen for WebDatabase in the renderer. BUG=none Review URL: https://codereview.chromium.org/827523004 Cr-Commit-Position: refs/heads/master@{#312460}
* Move the test template to //testing/test.gni (part 2)qsr2015-01-211-0/+2
| | | | | | | | | | | | This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni It also update the test template to automatically build an apk on Android. R=cjhopman@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/824263004 Cr-Commit-Position: refs/heads/master@{#312396}
* [sql] Test that a Chromium fts change is actually in place.shess2015-01-101-0/+34
| | | | | | | | | | | | | | In working on a new import of SQLite, I found the patch resulting from: http://codereview.chromium.org/14176 This only touches fts2, not fts3. These tests verify that both versions work in the way the patch implies. BUG=340757 Review URL: https://codereview.chromium.org/844443002 Cr-Commit-Position: refs/heads/master@{#310922}
* replace COMPILE_ASSERT with static_assert in sql/mostynb2015-01-061-5/+5
| | | | | | | | BUG=442514 Review URL: https://codereview.chromium.org/825313002 Cr-Commit-Position: refs/heads/master@{#310006}
* Standardize usage of virtual/override/final specifiers in sql/.dcheng2014-12-227-25/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/817403002 Cr-Commit-Position: refs/heads/master@{#309480}
* Misc. warning fixes/cleanuppkasting2014-12-121-2/+3
| | | | | | | | | BUG=81439 TEST=none Review URL: https://codereview.chromium.org/777853003 Cr-Commit-Position: refs/heads/master@{#308182}
* Replace OVERRIDE with its C++11 counterparts in src/sqlr.nagaraj2014-10-151-2/+2
| | | | | | | | | | | This step is a complete search for OVERRIDE to replace it with its lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/639753004 Cr-Commit-Position: refs/heads/master@{#299655}
* Make FTS2 inclusion in SQLite optionalthe_jk2014-10-032-3/+7
| | | | | | | | | | | | | | | Only platforms/products that need to support old history files need FTS2 support in the included SQLite library. BUG=418082 R=shess@chromium.org R=michaeln@chromium.org R=erikwright@chromium.org Review URL: https://codereview.chromium.org/606033002 Cr-Commit-Position: refs/heads/master@{#298022}
* Rename all isolate_dependency_* to files.maruel2014-10-012-2/+1
| | | | | | | | | | | | | Merges the lists when relevant. This simplify the management significantly. Remove the .isolate from the '*_run' target 'includes' section. TBR=vadimsh@chromium.org BUG=swarming:148 Review URL: https://codereview.chromium.org/614923005 Cr-Commit-Position: refs/heads/master@{#297633}
* Mark gtest and gmock as testonly in GN.Brett Wilson2014-09-081-0/+1
| | | | | | | | | | | This updates the targets that depend on these to also be test-only. BUG=http://crbug.com/412064 R=jamesr@chromium.org, tfarina@chromium.org Review URL: https://codereview.chromium.org/551933002 Cr-Commit-Position: refs/heads/master@{#293808}
* Change base/file_utils.h includes to base/files/file_utils.h in gin, ↵thestig2014-09-058-8/+8
| | | | | | | | | | google_apis, printing, sql, ui, and webkit. TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org Review URL: https://codereview.chromium.org/529273002 Cr-Commit-Position: refs/heads/master@{#293479}
* Move StringToLowerASCII to base namespacebrettw@chromium.org2014-08-071-1/+1
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/448853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for re-enabling more MSVC level 4 warnings: misc edition #2pkasting@chromium.org2014-07-181-2/+2
| | | | | | | | | | | | | | | | | | This contains fixes for the following sorts of issues: * Assignment inside conditional * Taking the address of a temporary * Octal escape sequence terminated by decimal number * Signedness mismatch * Possibly-uninitialized local variable This also contains a small number of cleanups to nearby code (e.g. no else after return). BUG=81439 TEST=none Review URL: https://codereview.chromium.org/382673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Test recovery of corrupt golden file.shess@chromium.org2014-07-109-2/+221
| | | | | | | | | | | | | Manually modify a SQLite database to have the problem described by the bug, then test that it can be recovered. Also, infrastructure to introduce testing data to sql/ tests. BUG=387868 Review URL: https://codereview.chromium.org/355093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282197 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Land binary golden file for test.shess@chromium.org2014-07-081-0/+0
| | | | | | | | | | | recovery_387868 is modified to have a specific form of corruption. BUG=387868 TBR=michaeln@chromium.org Review URL: https://codereview.chromium.org/372823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281787 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows build, add Sandbox implementation.brettw@chromium.org2014-06-021-1/+1
| | | | | | | | R=scottmg@chromium.org Review URL: https://codereview.chromium.org/301193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274160 0039d316-1c4b-4281-b951-d872f2087c98
* Add GN build files for sql and google_apis.brettw@chromium.org2014-05-281-0/+94
| | | | | | | | R=scottmg@chromium.org, scottmg Review URL: https://codereview.chromium.org/298293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273343 0039d316-1c4b-4281-b951-d872f2087c98
* Android: cleanup gtest_target_type conditions.bulach@chromium.org2014-05-171-4/+2
| | | | | | | | | | | | For a long time (crrev.com/133053) OS==android implies: gtest_target_type=shared_library Cleanup the spurious conditions and obsolete TODOs. BUG= Review URL: https://codereview.chromium.org/278443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove {linux|android}_use_tcmalloc and switch to use_allocator in Chromium.dmikurube@chromium.org2014-05-071-2/+1
| | | | | | | | | | | | | | If this change breaks some bots, please try restarting the bot before reverting it. http://crrev.com/264460 may not be effective yet until restarting. See the bug and http://crrev.com/255129 for the details. BUG=345554 Review URL: https://codereview.chromium.org/258433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused input_shlib_pathcjhopman@chromium.org2014-04-171-1/+0
| | | | | | | | | | This path is now only inferred from test_suite_name. TBR=darin NOTRY=true Review URL: https://codereview.chromium.org/226353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264666 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all uses of GG_LONGLONG and GG_ULONGLONG.viettrungluu@chromium.org2014-04-081-2/+2
| | | | | | | | | | | | | | | | | | | 123LL and 123ULL now work everywhere. You can also use INT64_C and UINT64_C (from <stdint.h>) in Chromium code (we force-define __STDC_CONSTANT_MACROS). (And sometimes you can just use static_cast<(u)int64_t>.) Don't remove their definitions yet, because some macros that are multiply-defined (in an identical way) rely on them. D'oh. R=brettw@chromium.org TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262147 Review URL: https://codereview.chromium.org/218953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262147 "Remove all uses of GG_LONGLONG and GG_ULONGLONG."scottmg@chromium.org2014-04-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | > Remove all uses of GG_LONGLONG and GG_ULONGLONG. > > 123LL and 123ULL now work everywhere. You can also use INT64_C and > UINT64_C (from <stdint.h>) in Chromium code (we force-define > __STDC_CONSTANT_MACROS). (And sometimes you can just use > static_cast<(u)int64_t>.) > > Don't remove their definitions yet, because some macros that are > multiply-defined (in an identical way) rely on them. D'oh. > > R=brettw@chromium.org > TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org > > Review URL: https://codereview.chromium.org/218953003 TBR=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/227743006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262165 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all uses of GG_LONGLONG and GG_ULONGLONG.viettrungluu@chromium.org2014-04-071-2/+2
| | | | | | | | | | | | | | | | | 123LL and 123ULL now work everywhere. You can also use INT64_C and UINT64_C (from <stdint.h>) in Chromium code (we force-define __STDC_CONSTANT_MACROS). (And sometimes you can just use static_cast<(u)int64_t>.) Don't remove their definitions yet, because some macros that are multiply-defined (in an identical way) rely on them. D'oh. R=brettw@chromium.org TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org Review URL: https://codereview.chromium.org/218953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262147 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup found while mucking with search engines code:pkasting@chromium.org2014-04-012-15/+6
| | | | | | | | | | | | | | | | | | | | | | | * Don't handle DCHECK failure * Remove NOTREACHED()/LOG(ERROR) from cases that look like they could legitimately happen * All lines of args should begin at the same position * WebDataService::SetDefaultSearchProvider() doesn't actually need a full TemplateURL, just an ID * Use GetCachedStatement correctly, and in more places * Make KeywordTableTest a friend of KeywordTable to reduce FRIEND_TEST declarations and in preparation for making Add/Update/RemoveKeyword private * Data members should be private, not protected * Function declarations: all args on first line or one arg per line * Fix misspelling BUG=none TEST=none R=shess@chromium.org Review URL: https://codereview.chromium.org/217613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260933 0039d316-1c4b-4281-b951-d872f2087c98
* Add unistd.h include in a file using geteuid().thakis@chromium.org2014-03-311-4/+0
| | | | | | | | | | | (Also delete two dead methods in other files.) BUG=31877 NOTRY=true Review URL: https://codereview.chromium.org/218133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260569 0039d316-1c4b-4281-b951-d872f2087c98
* Move ScopedFILE to base namespace and scoped_file.hbrettw@chromium.org2014-03-172-5/+7
| | | | | | | | R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/196073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257518 0039d316-1c4b-4281-b951-d872f2087c98
* Add use_allocator instead of linux_use_tcmalloc to switch the allocator.dmikurube@chromium.org2014-03-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change is to add a new build option 'use_allocator' which will replace 'linux_use_tcmalloc' in the future. It doesn't change the behavior immediately. The migration plan is as follows: 1) (this change) ... Add 'use_allocator' and set its default to "see_use_tcmalloc". ... Change allocator conditions to check use_allocator firstly. ... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc". ... NO IMPACT without specifying use_allocator explicitly. 2) Change Blink to accept use_allocator. http://crrev.com/177053003/ 3) Change gyp to accept use_allocator. http://crrev.com/178643004/ 4) PSA the transition period to chromium-dev@. 5) (after the PSA-ed transition period) ... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default. ... Remove all linux_use_tcmalloc. ... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified. At the point of this change (1), linux_use_tcmalloc is still used by default because 'use_allocator%': "see_use_tcmalloc". As written in http://crbug.com/345554, linux_use_tcmalloc would be confusing to have more options about allocators. We plan to: A) enable gperftools' heap-profiler with non-tcmalloc allocator, B) add a new memory allocator instead of tcmalloc. BUG=345554, 339604, 341349 R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org Review URL: https://codereview.chromium.org/177353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
* ui/base/resource: Remove dependency on net's big_endian implementation.tfarina@chromium.org2014-02-261-1/+1
| | | | | | | | | | | | | | | | To remove this dependency we ended up moving big_endian* to base/, since besides ui/, big_endian is also used by other top-level modules: chrome/utility/, cloud_print, media/cast This way we removed one more net dependency from ui/base/. BUG=299841 TEST=ui_unittests R=tony@chromium.org,mark@chromium.org,hclam@chromium.org,vitalybuka@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/145873006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253510 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in ppapi/, printing/, remoting/, rlz/, ↵avi@chromium.org2013-12-252-3/+3
| | | | | | | | | | | | sandbox/, skia/, sql/, sync/, tools/, webkit/, win8/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/121123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242502 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Rewrite Connection::Preload() in terms of file reading.shess@chromium.org2013-12-212-27/+51
| | | | | | | | | | | | | | | r204860 rewrote sqlite3_preload() to read the file without placing the data in the SQLite cache to improve memory footprint. No reports of performance degradation ensued. This CL rewrites Connection::Preload() to use the SQLite file handle to read the data, and backs out the preload-cache.patch from third_party/sqlite/. BUG=243949 Review URL: https://codereview.chromium.org/116443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242225 0039d316-1c4b-4281-b951-d872f2087c98
* AppCache: Run a quick integrity check on the sqlite database when opening. ↵michaeln@chromium.org2013-12-163-9/+73
| | | | | | | | | | | | If the test fails, delete the appcache directory and start afresh. NOTRY=true TBR=sky BUG=318544 Review URL: https://codereview.chromium.org/104593010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240937 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239400 "Revert 239280 "Move more file_util functions to b..."thakis@chromium.org2013-12-082-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke all bots 9_9 > Revert 239280 "Move more file_util functions to base namespace." > > dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32). > This CL is the only in the intersection of CLs in the first failing build on > the two builders, so giving a speculative revert a try (rlarocque already > tried a clobber, it didn't help). > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806 > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544 > > > > Move more file_util functions to base namespace. > > > > TBR=sky > > > > Review URL: https://codereview.chromium.org/109043002 > > TBR=brettw@chromium.org > > Review URL: https://codereview.chromium.org/105823009 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/100923007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239401 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239280 "Move more file_util functions to base namespace."thakis@chromium.org2013-12-082-5/+5
| | | | | | | | | | | | | | | | | | | | | | | dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32). This CL is the only in the intersection of CLs in the first failing build on the two builders, so giving a speculative revert a try (rlarocque already tried a clobber, it didn't help). http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806 http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544 > Move more file_util functions to base namespace. > > TBR=sky > > Review URL: https://codereview.chromium.org/109043002 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/105823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239400 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Recovery code for "Top Sites" database.shess@chromium.org2013-12-085-86/+147
| | | | | | | | | | | | | | | | | | | | Port recovery code from thumbnail_database.cc to top_sites_database.cc. Also retry Init() in case the recovery code fixes things (a quarter to a third of databases have problems detected during open). Extend sql::Recovery::AutoRecoverTable() to handle DOUBLE columns. Abstract out sql::test::CorruptTableOrIndex() to ease writing corruption tests. IWYU pass on various files. BUG=321852 Review URL: https://codereview.chromium.org/86653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239377 0039d316-1c4b-4281-b951-d872f2087c98
* Move more file_util functions to base namespace.brettw@chromium.org2013-12-073-7/+7
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/109043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239280 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetFileSize, NormalizeFilePath to base namespacebrettw@chromium.org2013-12-042-2/+2
| | | | | | | | | BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/102873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238722 0039d316-1c4b-4281-b951-d872f2087c98
* Convert string16 to base::string16 in content.brettw@chromium.org2013-12-032-10/+10
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/102593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Annotate sql::Recovery failure cases.shess@chromium.org2013-11-281-9/+128
| | | | | | | | | | | | | | | A large number of thumbnail_database.cc recovery failures are in building the scoped recovery instance. Break down failure cases for sql::Recovery to see if there is any action to be taken. Additionally, track failure calling sql::Recovery::Recovered(). BUG=109482 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/83323005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237680 0039d316-1c4b-4281-b951-d872f2087c98
* Move Posix file utils to the base namespace.brettw@chromium.org2013-11-272-23/+23
| | | | | | | | | BUG= R=rvargas@chromium.org Review URL: https://codereview.chromium.org/89523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237642 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235595 "Revert 235492 "[sql] Recover Favicons v5 database..."kinuko@chromium.org2013-11-186-21/+636
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 235492 "[sql] Recover Favicons v5 databases, with more re..." > > Speculative revert to find the cause for Mac size regression > (will revert this revert later) > > > [sql] Recover Favicons v5 databases, with more recovery automation. > > > > An entirely automated recovery system runs afoul of questions about > > whether the corrupt database's schema can be trusted. > > sql::Recovery::AutoRecoverTable() uses a schema created by the caller > > to construct the recovery virtual table and then copies the data over. > > > > sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify > > accessing meta-table info in the corrupt database. > > > > sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to > > simplify common testing operations. > > > > Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using > > these changes, and add a v5 recovery path. Additionally handle > > deprecated versions. > > > > BUG=240396,109482 > > > > Review URL: https://codereview.chromium.org/50493012 > > TBR=shess@chromium.org > > Review URL: https://codereview.chromium.org/74933002 TBR=kinuko@chromium.org Review URL: https://codereview.chromium.org/74953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235604 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235492 "[sql] Recover Favicons v5 databases, with more re..."kinuko@chromium.org2013-11-186-636/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speculative revert to find the cause for Mac size regression (will revert this revert later) > [sql] Recover Favicons v5 databases, with more recovery automation. > > An entirely automated recovery system runs afoul of questions about > whether the corrupt database's schema can be trusted. > sql::Recovery::AutoRecoverTable() uses a schema created by the caller > to construct the recovery virtual table and then copies the data over. > > sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify > accessing meta-table info in the corrupt database. > > sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to > simplify common testing operations. > > Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using > these changes, and add a v5 recovery path. Additionally handle > deprecated versions. > > BUG=240396,109482 > > Review URL: https://codereview.chromium.org/50493012 TBR=shess@chromium.org Review URL: https://codereview.chromium.org/74933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235595 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Recover Favicons v5 databases, with more recovery automation.shess@chromium.org2013-11-166-21/+636
| | | | | | | | | | | | | | | | | | | | | | | An entirely automated recovery system runs afoul of questions about whether the corrupt database's schema can be trusted. sql::Recovery::AutoRecoverTable() uses a schema created by the caller to construct the recovery virtual table and then copies the data over. sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify accessing meta-table info in the corrupt database. sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to simplify common testing operations. Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using these changes, and add a v5 recovery path. Additionally handle deprecated versions. BUG=240396,109482 Review URL: https://codereview.chromium.org/50493012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235492 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-29 02:39:31 +0000