summaryrefslogtreecommitdiffstats
path: root/storage/common
Commit message (Collapse)AuthorAgeFilesLines
* Media Galleries Partial Deprecation: Remove iPhoto support.tommycli2016-03-182-5/+0
| | | | | | | | | | Axes about 2900 SLOC and iPhoto support. Affects Mac OSX only. BUG=542912 Review URL: https://codereview.chromium.org/1805203002 Cr-Commit-Position: refs/heads/master@{#382034}
* Remove use of UnescapeRule::URL_SPECIAL_CHARS from filesystem logic.mmenke2016-03-041-1/+2
| | | | | | | | | | | | | | | | We're removing this, in favor of PATH_SEPARATORS and URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to avoid any security issues with this, going forward. Permission checking is done in ParseFileSystemSchemeURL, so unescaping them should be safe, though this is different from how file URLs are handled. BUG=589257 Review URL: https://codereview.chromium.org/1761083002 Cr-Commit-Position: refs/heads/master@{#379209}
* Move IsValidOriginIdentifier into appropriate headerjsbell2016-03-032-0/+7
| | | | | | | | | | | It should live with the other DatabaseIdentifier-wrangling functions. BUG=591240 R=michaeln@chromium.org Review URL: https://codereview.chromium.org/1753403002 Cr-Commit-Position: refs/heads/master@{#379023}
* Add IPV6 URL support to DatabaseIdentifiersjsbell2016-03-021-3/+38
| | | | | | | | | | | ... and add "bad character" checks to the Blink impl. BUG=568467 R=mkwst@chromium.org,michaeln@chromium.org Review URL: https://codereview.chromium.org/1721973002 Cr-Commit-Position: refs/heads/master@{#378835}
* storage: Add out-of-line copy ctors for complex classes.vmpstr2016-02-264-0/+7
| | | | | | | | | | | | | This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=piman@chromium.org, dcheng@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1734523003 Cr-Commit-Position: refs/heads/master@{#377983}
* Switch to standard integer types in storage/.avi2015-12-2113-11/+31
| | | | | | | | | BUG=138542 TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/1541933002 Cr-Commit-Position: refs/heads/master@{#366458}
* Remove kuint64max.avi2015-12-093-23/+30
| | | | | | | | BUG=138542, 488550 Review URL: https://codereview.chromium.org/1502503004 Cr-Commit-Position: refs/heads/master@{#364133}
* [BlobAsync] Patch 4: Browser Classes & Logic.dmurph2015-12-021-0/+2
| | | | | | | | | | | | | | | | | | | This patch encompasses all browser classes and logic for blob async transportation. This is a no-op. Patches: 1: https://codereview.chromium.org/1287303002 (committed) 2: https://codereview.chromium.org/1288373002 (committed) 3: https://codereview.chromium.org/1292523002 (committed) 4: https://codereview.chromium.org/1098853003 Hookup: https://codereview.chromium.org/1234813004 See https://bit.ly/BlobStorageRefactor BUG=375297 Review URL: https://codereview.chromium.org/1098853003 Cr-Commit-Position: refs/heads/master@{#362802}
* Run gn --format over all .gn filesagrieve2015-11-201-1/+1
| | | | | | | | | | | | | | | | The recent formatter alphebetizing change is causing a lot of noise in code reviews. Figured it'd be worth a clean-up CL. Exact command I ran: find . -name "*.gn*" -exec gn format --in-place "{}" \; TBR=ddorwin@chromium.org BUG=554928 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1464873002 Cr-Commit-Position: refs/heads/master@{#360891}
* Do not call stat() when reading directories via File API.mtomasz2015-11-152-15/+4
| | | | | | | | | | | | | It's very heavy, and on the JavaScript side the metadata is discarded anyway, and another call is used to obtain it. TEST=All existing tests should pass. Tested manually with MTP and chrome://quota-internals, then filesystem://.../isolated in the browser. BUG=None Review URL: https://codereview.chromium.org/1432403003 Cr-Commit-Position: refs/heads/master@{#359768}
* [BlobAsync] Patch 3: Renderer Classes & Logicdmurph2015-10-316-62/+70
| | | | | | | | | | | | | | | | | Note: This patch is a no-op. Patches: 1: https://codereview.chromium.org/1287303002 2: https://codereview.chromium.org/1288373002 3: https://codereview.chromium.org/1292523002 4: https://codereview.chromium.org/1098853003 Hookup: https://codereview.chromium.org/1234813004 BUG=375297 Review URL: https://codereview.chromium.org/1292523002 Cr-Commit-Position: refs/heads/master@{#357258}
* [BlobAsync] Patch 2: Common Constantsdmurph2015-10-318-0/+375
| | | | | | | | | | | | | | | | | | | | This CL contains constants for the Blob Async Transport refactor. Note: This CL is currently a no-op, hookup is in the 'Hookup' patch. Patches: 1: https://codereview.chromium.org/1287303002 (Committed!) 2: https://codereview.chromium.org/1288373002 3: https://codereview.chromium.org/1292523002 4: https://codereview.chromium.org/1098853003 Hookup: https://codereview.chromium.org/1234813004 BUG=375297 Review URL: https://codereview.chromium.org/1288373002 Cr-Commit-Position: refs/heads/master@{#357248}
* WebSQL: Avoid running nested message loops during renderer shutdown.michaeln2015-10-292-34/+28
| | | | | | | | | | Instead, block the main thread while waiting for databases to close. If they don't close quickly enough, use CHECK to end the process. BUG=472618 Review URL: https://codereview.chromium.org/1413093004 Cr-Commit-Position: refs/heads/master@{#356755}
* Remove base::MessageLoop::{Quit,QuitClosure} functionski.stfu2015-10-231-1/+1
| | | | | | | | | | | | | This patch removes aliases for base::MessageLoop::QuitWhenIdle & base::MessageLoop::QuitWhenIdleClosure, and includes minor formatting changes made by using git cl-format. BUG=131220 TEST= R=danakj@chromium.org,brettw@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1390513002 Cr-Commit-Position: refs/heads/master@{#355763}
* Convert remaining StringToLowerASCII to ToLowerASCII.brettw2015-08-111-1/+1
| | | | | | | | | | | | | | | | | | | | | Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece. http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did std::string old_header_name_lowercase(name); where it actually meant std::string old_header_name_lowercase(old_header_name); I fixed this. There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call. There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call. NOPRESUBMIT=true (for touching code with wstrings) Review URL: https://codereview.chromium.org/1282363003 Cr-Commit-Position: refs/heads/master@{#342869}
* Replace StringToLowerASCII with base::ToLowerASCIIbrettw2015-08-061-2/+2
| | | | | | | | | | | | | | Standardize on using string pieces and returning strings. Remove in-place version (this was only used in a couple places and they were not performance-critical). De-templatize the character versions of ToUpperASCII/ToLowerASCII. This would lead to bizarre errors if you pass other things (like a string). This is so little code, it's now just duplicated. I renamed StringToLowerASCII to just be ToLowerASCII so you can pass whatever you want to ToLowerASCII and it does the right thing. This seems simpler to me. This replaces all calls of StringToUpperASCII to the new form. The lowercase version is more common and will be done in a separate pass. Review URL: https://codereview.chromium.org/1280473002 Cr-Commit-Position: refs/heads/master@{#342219}
* Fix gn check errors for storage/common:commonagrieve2015-07-081-0/+1
| | | | | | | | | | | | | | | | | | | | Once blink headers are added as sources (https://codereview.chromium.org/1222673004/), if you run the following command line, you will get errors like this: $ gn check ERROR at //storage/common/fileapi/file_system_util.h:17:11: Include not allowed. ^------------------------------------------------ It is not in any dependency of //storage/common:common The include file is in the target(s): //third_party/WebKit/public:blink_headers which should somehow be reachable. BUG=367595 Review URL: https://codereview.chromium.org/1222733002 Cr-Commit-Position: refs/heads/master@{#337904}
* Added characters that look like padlocks to URL unescaping blacklist.mgiuca2015-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This blacklists the following Unicode characters: - U+1F50F LOCK WITH INK PEN - U+1F510 CLOSED LOCK WITH KEY - U+1F512 LOCK - U+1F513 OPEN LOCK This prevents LOCK characters from appearing in a URL in the Chrome UI, potentially looking like an SSL padlock icon (e.g., "google.com/🔒" is now displayed as "google.com/%F0%9F%94%92"). This presented a spoofing risk due to a few complications: 1. In RTL mode, the end of the URL (path/query) is aligned right up against the right edge of the Omnibox, where the SSL padlock is usually displayed. 2. On Mac, ChromeOS, and Android, LOCK characters are displayed in colour, making them more convincing. Note: These characters will still be unescaped when using the SPOOFING_AND_CONTROL_CHARS unescape rule (used for decoding data URLs, previously known as CONTROL_CHARS). BUG=495934,421332 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1180393003 Cr-Commit-Position: refs/heads/master@{#335870}
* Create blobs from Disk Cache entries.gavinp2015-06-192-0/+14
| | | | | | | | | | | | | | This CL allows blobs to be backed by disk cache entries, and also migrates the Cache Storage Cache implementation to use this functionality. This is very useful in the ServiceWorker case, as the existing implementation was copying entire disk cache entries to RAM before serving them to consumers. BUG=None Review URL: https://codereview.chromium.org/1108083002 Cr-Commit-Position: refs/heads/master@{#335185}
* Move StringToUpperASCII to base namespacebrettw2015-06-091-2/+2
| | | | | | | | | | Removes some unnecessary base:: qualifications in the base files I touched. clang-formatted file_util_unittest because lots of wrapping changed with this removal (seems to be a big improvement). BUG= Review URL: https://codereview.chromium.org/1171973003 Cr-Commit-Position: refs/heads/master@{#333560}
* Discard duplicate includes of files from storage/pranay.kumar2015-05-201-1/+0
| | | | | | | | | | | | As any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes). A trivial way to fix these is by removing such an include from the .cc file. So this CL removes all includes from $X.cc files where the $X.h has the same include to confirm to the style guide. BUG=460988 Review URL: https://codereview.chromium.org/1139323003 Cr-Commit-Position: refs/heads/master@{#330693}
* Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in complete ↵pranay.kumar2015-05-042-4/+4
| | | | | | | | | | | | | | | | | storage module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Review URL: https://codereview.chromium.org/1120553002 Cr-Commit-Position: refs/heads/master@{#328095}
* Apply automatic range checks to content enum types across IPC.payal.pandey2015-04-301-0/+2
| | | | | | | | | | | This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Review URL: https://codereview.chromium.org/1101053002 Cr-Commit-Position: refs/heads/master@{#327687}
* Apply gn format with 'sources' sorting to src/scottmg2015-02-281-1/+1
| | | | | | | | | | | | Application of https://codereview.chromium.org/962003002/. TBR=keybuk@chromium.org R=brettw@chromium.org BUG=456014 Review URL: https://codereview.chromium.org/960413003 Cr-Commit-Position: refs/heads/master@{#318574}
* Update existing uses of /wd4267 to use the GN configbrettw2015-02-191-3/+3
| | | | | | | | | | This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read. Minor updates to Win64 build, including some fixes for size_t to int conversions. Review URL: https://codereview.chromium.org/929793006 Cr-Commit-Position: refs/heads/master@{#317162}
* [Storage] Consolidation of BlobItems with small sizedmurph2015-01-231-0/+20
| | | | | | | | | | | | | | https://bit.ly/AutoBlobToDisk R=michaeln, piman BUG=375297 Committed: https://crrev.com/4e45f41babddb10985c8c0afb9b0b6b9e8356094 Cr-Commit-Position: refs/heads/master@{#312770} Review URL: https://codereview.chromium.org/821913004 Cr-Commit-Position: refs/heads/master@{#312907}
* [Storage] Blob Storage Refactoring pt 1:dmurph2015-01-237-541/+0
| | | | | | | | | | | | | | | | | | | * Renaming classes to be more descriptive. * Changing smart pointers to reflect strict ownership model. * Adding pointers to facilitate future resource swapping. * Remove renderer-side dependency on blob_data.h This patch makes all of the far-reaching changes that effect everyone that uses the blob storage context. Subsequent changes should only effect the blob infrastructure. https://bit.ly/AutoBlobToDisk BUG=375297 Review URL: https://codereview.chromium.org/810403004 Cr-Commit-Position: refs/heads/master@{#312800}
* Revert of [Storage] Consoliation of BlobItems with small size (patchset #8 ↵kochi2015-01-231-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:140001 of https://codereview.chromium.org/821913004/) Reason for revert: This caused regression on some layout tests. e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28deps%29/builds/35407 fast/files/read-blob-async.html fast/files/workers/worker-read-blob-async.html fast/files/workers/worker-read-blob-sync.html fast/files/workers/worker-read-file-constructor-async.html http/tests/local/blob/send-data-blob.html http/tests/navigation/beacon-same-origin.html http/tests/websocket/bufferedAmount-after-send.html Original issue's description: > [Storage] Consolidation of BlobItems with small size > https://bit.ly/AutoBlobToDisk > > R=michaeln, piman > BUG=375297 > > Committed: https://crrev.com/4e45f41babddb10985c8c0afb9b0b6b9e8356094 > Cr-Commit-Position: refs/heads/master@{#312770} TBR=michaeln@chromium.org,piman@chromium.org,dmurph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=375297 Review URL: https://codereview.chromium.org/869763003 Cr-Commit-Position: refs/heads/master@{#312782}
* [Storage] Consolidation of BlobItems with small sizedmurph2015-01-231-0/+20
| | | | | | | | | | | https://bit.ly/AutoBlobToDisk R=michaeln, piman BUG=375297 Review URL: https://codereview.chromium.org/821913004 Cr-Commit-Position: refs/heads/master@{#312770}
* Refactor storage::CopySyncOption into storage::FlushPolicy.mtomasz2014-12-111-13/+12
| | | | | | | | | | | | | This is a follow up CL in order to perform further cleanup. The storage:: CopySyncOption and storage::FileWriterDelegate::FlushPolicy enums have been merged. TEST=Refactoring only. All current tests should pass. BUG=440293 Review URL: https://codereview.chromium.org/772713005 Cr-Commit-Position: refs/heads/master@{#307833}
* Flush on completion of copying.mtomasz2014-12-081-0/+7
| | | | | | | | | | | | The COPY_SYNC_OPTION_SYNC flag was missing when registering FSP file systems. As a result, when copying between file systems the last chunk could be lost. TEST=Tested manually in Files app. BUG=439830 Review URL: https://codereview.chromium.org/778103003 Cr-Commit-Position: refs/heads/master@{#307219}
* Delete the old WebSocket implementation from net/ricea2014-11-081-2/+0
| | | | | | | | | | | The removal of NetworkDelegate::OnBeforeSocketStreamConnect() is in http://crrev.com/652363005 so not too many reviewers will need to review this more-complex CL. BUG=423201 TEST=net_unittests, browser_tests Review URL: https://codereview.chromium.org/679273005 Cr-Commit-Position: refs/heads/master@{#303387}
* Convert ARRAYSIZE_UNSAFE -> arraysize in storage/.viettrungluu2014-10-161-1/+1
| | | | | | | | | R=michaeln@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/657303002 Cr-Commit-Position: refs/heads/master@{#299885}
* Apply automatic range checks to storage enum types across IPC.anujk.sharma2014-09-261-0/+1
| | | | | | | | | | | This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Review URL: https://codereview.chromium.org/603673003 Cr-Commit-Position: refs/heads/master@{#296887}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in [r-t]*/thestig2014-09-121-1/+1
| | | | | | | | TBR=sergeyu@chromium.org,cpu@chromium.org,thakis@chromium.org,jamesr@chromium.org,zea@chromium.org,nduca@chromium.org Review URL: https://codereview.chromium.org/560883003 Cr-Commit-Position: refs/heads/master@{#294543}
* Random fixes for scoped_refptr operator T* removal.dcheng2014-09-051-1/+1
| | | | | | | | | BUG=110610 TBR=caitkp, michaeln, rockot, sievers, sky, willchan Review URL: https://codereview.chromium.org/543893002 Cr-Commit-Position: refs/heads/master@{#293453}
* Move fileapi-related files from webkit/common/ to storage/common/ and set up ↵pilgrim2014-09-0426-0/+2328
redirect headers BUG=338338 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/524983002 Cr-Commit-Position: refs/heads/master@{#293228}
generated by cgit v1.1 at 2024-05-18 17:23:38 +0000