summaryrefslogtreecommitdiffstats
path: root/sync/sync_tests.gypi
Commit message (Collapse)AuthorAgeFilesLines
* [Sync] Rename to (Processor|Worker)EntityTracker for clarity.maxbogue2016-03-011-2/+2
| | | | | | | | | | | | The names ModelTypeEntity and EntityTracker did not express the purposes and the similarities between the classes well. They are each essentially internal to their respective components, and they each handle the logic of tracking what's necessary for an entity in that component. I think these names are much clearer. Review URL: https://codereview.chromium.org/1739423002 Cr-Commit-Position: refs/heads/master@{#378348}
* [Sync] Remove backup/rollback logic from Synczea2016-02-241-4/+0
| | | | | | | | BUG=586596 Review URL: https://codereview.chromium.org/1703173002 Cr-Commit-Position: refs/heads/master@{#377370}
* [Sync] USS: Load data for pending commits on startup.maxbogue2016-02-231-2/+0
| | | | | | | | | | | | | | | | | | | | | | This change also includes fairly massive changes to how the SMTP test file works. Specifically, there is now a SimpleStore for data and metadata, and the tests have been modified to assert against the stores. This was done to allow for more intuitive, flexible testing. Other minor changes: - Cleaned up some unnecessary functions in SMTP and ModelTypeEntity. - Added helper functions for accessing ModelTypeEntity objects. - Removed FakeMetadataChangeList. Simple* is sufficient for testing. - Switch to using map[k] = v over map.insert(make_pair(k, v)) as the former looks cleaner and does not silently fail if a value for k already exists in the map. BUG=569642 Review URL: https://codereview.chromium.org/1697563003 Cr-Commit-Position: refs/heads/master@{#377047}
* [Sync] Initial integration between DeviceInfoService and ModelTypeStore.skym2016-02-091-0/+2
| | | | | | | | BUG=582460, 543405, 543404 Review URL: https://codereview.chromium.org/1662593002 Cr-Commit-Position: refs/heads/master@{#374398}
* allocator cleanup: remove dependencies on allocator from all targetsprimiano2016-01-281-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Overview of the cleanup: ------------------------ - In the context of the discussion in https://goo.gl/K2m649 our illustrious base/ owners suggested that having base being the only target depending on allocator (and having the other targets inherit that recursively) would be a more scalable solution, as opposite to having to remember to add an exec -> allocator to each target. - This base -> allocator dep landed in crrev.com/1616793003. - After that CL, until this point, many targets got two paths that lead to allocator: 1. The indirect one via base (content_shell -> base -> allocator) which is what we want to preserve. 2. The direct one (content_shell -> allocator) which is the inconsistent one we want to drop. This CL gets rid of all the instances of 2. The nice property of this sequencing of CLs is that the effect of this large change on the final .ninja files is minimal. See details below. Effect on the produced ninja files: ----------------------------------- GYP, Linux, static build: https://paste.ee/p/RaJLj Just some small reordering of include paths. Dropping --rdynamic (as expected) in keyboard_unittests GN, Linux, static build: https://paste.ee/p/zYtrQ Various targets lose the dependency on allocator.stamp (expected, the order is enforced by depending on base which depends on allocator.stamp) GN, Android (both component and static are similar): https://paste.ee/p/Iq6DD As above. GN, Linux, component build: https://paste.ee/p/jHUmv This is the most juicy change. As expected all the ODR goes away and random targets stop re-linking tcmalloc .o files. GYP, Win, static: https://paste.ee/p/j0IjL Extremely minimal changes: All.ninja stops depending on libcmt.lib. Sounds fine as base (which depends on that) is definitely depending on libcmt. GN, Win, static: https://paste.ee/p/Q6zTo Minimal change, like Linux GN, dropping dependencies on the .stamp files. BUG=564618 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1647453002 Cr-Commit-Position: refs/heads/master@{#372167}
* Use MetadataChangeList and EntityChangeList in SharedModelTypeProcessorstanisc2016-01-121-0/+2
| | | | | | | | BUG=569678,569636 Review URL: https://codereview.chromium.org/1565503003 Cr-Commit-Position: refs/heads/master@{#369009}
* [Sync] Adding interface methods and impl for data batch, renamed impl.skym2015-12-041-0/+1
| | | | | | | | BUG=543405 Review URL: https://codereview.chromium.org/1485213003 Cr-Commit-Position: refs/heads/master@{#363245}
* USS: Introduce dependency of SharedModelTypeProcessor on ModelTypeServicestanisc2015-12-031-0/+2
| | | | | | | | BUG=561821 Review URL: https://codereview.chromium.org/1486363002 Cr-Commit-Position: refs/heads/master@{#363066}
* ModelTypeEntity refactoring to use EntityData and EntityMetadatastanisc2015-12-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | 1) Changed existing ModelTypeEntity to be based on EntityMetadata, client key, and EntityDataPtr. Changed the class construction functions slighly to better reuse the code and to be able to pass the data without copying. 2) Moved model_type_entity* files next to shared_model_type_processor* 3) Did initial implementation of the data caching, although it might still need some refinement. The code that prepares commit request data structure now uses the cached EntityDataPtr. 4) Made necessary changes in SharedModelTypeProcessor to ensure that all existing tests pass. Had to disable two re-encryption tests because they expect the data received in updates to be cached in ModelTypeEntity which isn't the case anymore. BUG=517657, 553638 Review URL: https://codereview.chromium.org/1471293005 Cr-Commit-Position: refs/heads/master@{#362475}
* Port ChromeSyncShell build rules to GNpkotwicz2015-11-251-2/+1
| | | | | | | | | | BUG=475612 R=agrieve, newt, pvalenzuela, zea TBR=brettw for .gn whitelisting usage fo gypi_to_gn in protocol_sources.gni Review URL: https://codereview.chromium.org/1458353002 Cr-Commit-Position: refs/heads/master@{#361561}
* [Sync] Implementation of ModelTypeStoreBackendpavely2015-11-121-0/+1
| | | | | | | | | | | | | | | | | I'm adding implementation of ModelTypeStoreBackend. The object lives on backend thread and performs actual calls to leveldb. ModelTypeStoreImpl will use interface of backend to work with database. Implementation of ModelTypeStoreImpl methods that work with this backend will be landed in separate CL. R=stanisc@chromium.org BUG=517663 TEST=Covered by sync_unit_tests. No externally observable behavior. Review URL: https://codereview.chromium.org/1436573002 Cr-Commit-Position: refs/heads/master@{#359442}
* Change EntityData and EntityMetadata according to the design doc.stanisc2015-11-111-0/+1
| | | | | | | | BUG=553638 Review URL: https://codereview.chromium.org/1430343002 Cr-Commit-Position: refs/heads/master@{#358993}
* [Sync] Add ModelTypeStore implementation.pavely2015-11-031-0/+1
| | | | | | | | | | | | | | In this change I added ModelTypeStoreImpl and ModelTypeStoreBackend classes. This change only deals with classes initialization and threading. To make life of reviewer easier I will add actual IO operations in separate change. BUG=517663 R=stanisc@chromium.org Review URL: https://codereview.chromium.org/1421833004 Cr-Commit-Position: refs/heads/master@{#357660}
* [Sync] ModelTypeStore interface.pavely2015-11-031-0/+2
| | | | | | | | | | | | | This change introduces ModelTypeStore interface and FakeModelTypeStore implementation for writing tests for components depending on ModelTypeStore. R=stanisc@chromium.org,skym@chromium.org BUG=517663 Review URL: https://codereview.chromium.org/1422083002 Cr-Commit-Position: refs/heads/master@{#357618}
* [Sync] Introduce EntityData and EntityMetadata.maxbogue2015-10-291-1/+1
| | | | | | | | BUG=536895 Review URL: https://codereview.chromium.org/1421663004 Cr-Commit-Position: refs/heads/master@{#356899}
* [Sync] Move ModelTypeProcessor* and rename *Impl to Shared*.maxbogue2015-10-091-1/+1
| | | | | | | | BUG=536895 Review URL: https://codereview.chromium.org/1382743004 Cr-Commit-Position: refs/heads/master@{#353323}
* USS: Refactoring of ModelTypeProcessorImpl to not dependstanisc2015-10-061-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | on SyncContextProxy This is an incremental change, a part of the larger NonBlockingDataTypeController refactoring. The following changes are included: 1) Some of ModelTypeProcessorImpl methods are changed/renamed to be closer to the new design: - Enable --> Start - Disconnect --> Stop - IsPreferred --> IsEnabled 2) ModelTypeProcessorImpl::Start gets a callback that it uses to return ActivationContext back to the controller. 3) ModelTypeProcessorImpl doesn't use SyncContextProxy anymore. 4) InjectableSyncContextProxy isn't needed anymore. 5) Some minor changes in NonBlockingDataTypeController to make it closer to the eventual implementation based on DataTypeController. More specifically, it doesn't pass SyncContextProxy to the processor anymore and instead receives and passes through the activation context. BUG=515962 Review URL: https://codereview.chromium.org/1389433002 Cr-Commit-Position: refs/heads/master@{#352661}
* Isolate sync_unittests_apk.stip2015-10-031-0/+19
| | | | | | | | | BUG=525873 R=maruel@chromium.org,pavely@chromium.org,jbudorick@chromium.org Review URL: https://codereview.chromium.org/1381003003 Cr-Commit-Position: refs/heads/master@{#352200}
* [Sync] Rename ModelTypeSyncWorkerImpl to ModelTypeWorkerpavely2015-09-031-1/+1
| | | | | | | | | | | | | Following renames are in this change: ModelTypeSyncWorkerImpl -> ModelTypeWorker ModelTypeSyncWorkerWrapper -> CommitQueueProxy BUG=515964 R=stanisc@chromium.org Review URL: https://codereview.chromium.org/1328743004 Cr-Commit-Position: refs/heads/master@{#347173}
* [Sync] Rename ModelTypeSyncProxyImpl to ModelTypeProcessorImpl.maxbogue2015-09-011-1/+1
| | | | | | | | BUG=522308 Review URL: https://codereview.chromium.org/1310663006 Cr-Commit-Position: refs/heads/master@{#346728}
* ModelTypeSyncProxy -> ModelTypeProcessorgangwu2015-08-311-4/+4
| | | | | | | | | | ModelTypeSyncWorker -> CommitQueue BUG=525830 Review URL: https://codereview.chromium.org/1325453003 Cr-Commit-Position: refs/heads/master@{#346521}
* Sync: allow FakeServer injection of bookmark folderspvalenzuela2015-07-011-2/+0
| | | | | | | | | | | | | | | | This CL modifies the Sync fake server infrastructure to support adding bookmark folders on the server-side for integration tests. A test case has also been added that serves as a usage example. This CL also deletes the EntityBuilder class. This class was originally intended to be a superclass for all entity-specific builders. However, bookmarks is the only type that utilizes a builder. BUG=365774 Review URL: https://codereview.chromium.org/1218593004 Cr-Commit-Position: refs/heads/master@{#336961}
* Convert sync_unit_tests to run exclusively on Swarmingmaruel2015-06-301-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0 configs already ran on Swarming 29 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert sync_unit_tests R=dpranke@chromium.org,maniscalco@chromium.org TBR= BUG=98637 Review URL: https://codereview.chromium.org/1218143002 Cr-Commit-Position: refs/heads/master@{#336905}
* Move base_java_test_support dep from sync_java to test target.yfriedman2015-06-221-0/+1
| | | | | | | | | | It's a test-only target which shouldn't be used from application code. Saves 200 methods in debug. BUG=272790 Review URL: https://codereview.chromium.org/1196733002 Cr-Commit-Position: refs/heads/master@{#335544}
* Sync: Initial implementation of EntryProtoFieldPtr.stanisc2015-06-151-0/+1
| | | | | | | | | | | | | | EntryProtoFieldPtr will be used in EntryKernel to enable sharing of EntitySpecifics and AttachmentMetadata. This patch introduces EntryProtoFieldPtr, the wrapper class for the shareable sync data, and adds a couple of unit tests for it. BUG=499443 Review URL: https://codereview.chromium.org/1170423002 Cr-Commit-Position: refs/heads/master@{#334469}
* [Android] Generate scripts at build time to run android tests.mikecase2015-06-031-0/+1
| | | | | | | | | | | Making changes so that at build time scripts will be generated that can be used to easily run tests. BUG=490781 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1120883002 Cr-Commit-Position: refs/heads/master@{#332518}
* Remove Test Accounts service clientpvalenzuela2015-05-151-40/+0
| | | | | | | | | | | This service was used as part of a previous Sync end-to-end testing effort and is no longer used. BUG=NONE Review URL: https://codereview.chromium.org/1138113003 Cr-Commit-Position: refs/heads/master@{#330144}
* Update folder hierarchy to match java package name.Newton Allen2015-05-131-1/+1
| | | | | | | | | | | | | | Files in chrome/android/sync_shell/javatests use the org.chromium.chrome.browser.sync Java package, but were located under src/chromium/chrome/browser/sync. This fixes the problem by adding an "org" directory. R=nyquist@chromium.org, pvalenzuela@chromium.org TBR=manisicalco@chromium.org Review URL: https://codereview.chromium.org/1132173003 Cr-Commit-Position: refs/heads/master@{#329547}
* [Sync] Erase sync DB when corruptedmaniscalco2015-04-301-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | Directory now registers to be notified of catastrophic sync DB errors. Upon notification, Directory triggers an unrecoverable sync error which causes ProfileSyncService to delete the sync DB. Add integration test that verifies the sync DB is deleted when DB corruption is detected. Remove unused member variable allow_failure_for_test_ from DirectoryBackingStore. Add MockUnrecoverableErrorHandler to assist in writing tests for Directory. BUG=470993 Committed: https://crrev.com/90a7f8d3e3b3a2aac43e71a93eac2731f084945c Cr-Commit-Position: refs/heads/master@{#327120} Review URL: https://codereview.chromium.org/1082893003 Cr-Commit-Position: refs/heads/master@{#327766}
* Revert of [Sync] Erase sync DB when corrupted (patchset #4 id:60001 of ↵vkuzkokov2015-04-281-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1082893003/) Reason for revert: Test fails on Win7 bots. see crbug.com/481895 Original issue's description: > [Sync] Erase sync DB when corrupted > > Directory now registers to be notified of catastrophic sync DB errors. > Upon notification, Directory triggers an unrecoverable sync error which > causes ProfileSyncService to delete the sync DB. > > Add integration test that verifies the sync DB is deleted when DB > corruption is detected. > > Remove unused member variable allow_failure_for_test_ from > DirectoryBackingStore. > > Add MockUnrecoverableErrorHandler to assist in writing tests for > Directory. > > BUG=470993 > > Committed: https://crrev.com/90a7f8d3e3b3a2aac43e71a93eac2731f084945c > Cr-Commit-Position: refs/heads/master@{#327120} TBR=zea@chromium.org,pvalenzuela@chromium.org,maniscalco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470993 Review URL: https://codereview.chromium.org/1104423005 Cr-Commit-Position: refs/heads/master@{#327264}
* [Sync] Erase sync DB when corruptedmaniscalco2015-04-271-0/+4
| | | | | | | | | | | | | | | | | | | | | Directory now registers to be notified of catastrophic sync DB errors. Upon notification, Directory triggers an unrecoverable sync error which causes ProfileSyncService to delete the sync DB. Add integration test that verifies the sync DB is deleted when DB corruption is detected. Remove unused member variable allow_failure_for_test_ from DirectoryBackingStore. Add MockUnrecoverableErrorHandler to assist in writing tests for Directory. BUG=470993 Review URL: https://codereview.chromium.org/1082893003 Cr-Commit-Position: refs/heads/master@{#327120}
* [Sync] Update DirectoryBackingStore to detect Sync DB corruptionmaniscalco2015-04-141-0/+1
| | | | | | | | | | | | | | | | | | | | | Leverage sql::Connection's error handling mechanism to detect "catastrophic" errors like SQLITE_CORRUPT. Add unit tests that verify behavior of SetCatastrophicErrorHandler and trigger DB corruption. Because handler is not installed by default, this change will have no impact on Sync's behavior. A future change will connect Directory to DirectoryBackingStore's to ensure Sync is shutdown when DB corruption occurs. This change depends on https://codereview.chromium.org/1069313004/. BUG=470993 Review URL: https://codereview.chromium.org/1072093002 Cr-Commit-Position: refs/heads/master@{#325135}
* Sync: Add FakeServer verification API for Sessionspvalenzuela2015-04-121-0/+2
| | | | | | | | | | | | | | This CL adds a new class, SessionsHierarchy, that allows tests to verify the structure and contents of the Sessions entities stored in FakeServer. A desktop test class has also been modified to make use of this API. BUG=469892 Review URL: https://codereview.chromium.org/1064413005 Cr-Commit-Position: refs/heads/master@{#324799}
* Sync: Generalize entity injection in Android testspvalenzuela2015-04-101-0/+37
| | | | | | | | | | | | | | | This CL introduces build infrastructure to generate Java objects from sync protobufs. This allows Java tests to create the EntitySpecifics of entities that they would like to inject. As of this CL, only entities with unique client tags (e.g., preferences, typed URLs) are supported for injection. BUG=365774 Review URL: https://codereview.chromium.org/998373004 Cr-Commit-Position: refs/heads/master@{#324558}
* [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.pavely2015-03-111-1/+1
| | | | | | | | | | | | | | | | | | | | In this change: - Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00 - Remove AttachmenService::GetStore. Now attachment store is owned by model type, there is no need to get it from AttachmentService - Introduce AttachmentReferrer. There is no functionality behind it yet and interface is not complete for it. These will come in the next change. BUG=457735 R=maniscalco@chromium.org TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests) Committed: https://crrev.com/6adcada8a799057c31c0f17550c9e2747a8df847 Cr-Commit-Position: refs/heads/master@{#319733} Review URL: https://codereview.chromium.org/986743004 Cr-Commit-Position: refs/heads/master@{#320015}
* Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of ↵bnc2015-03-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | referrer. (patchset #2 id:20001 of https://codereview.chromium.org/986743004/) Reason for revert: I think this CL is responsible for tree closing compile failure https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26672/steps/compile/logs/stdio. Original issue's description: > [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. > > In this change: > - Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00 > - Remove AttachmenService::GetStore. Now attachment store is owned by > model type, there is no need to get it from AttachmentService > - Introduce AttachmentReferrer. There is no functionality behind it yet > and interface is not complete for it. These will come in the next change. > > BUG=457735 > R=maniscalco@chromium.org > TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests) > > Committed: https://crrev.com/6adcada8a799057c31c0f17550c9e2747a8df847 > Cr-Commit-Position: refs/heads/master@{#319733} TBR=maniscalco@chromium.org,cjhopman@chromium.org,pavely@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457735 Review URL: https://codereview.chromium.org/996473005 Cr-Commit-Position: refs/heads/master@{#319760}
* [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.pavely2015-03-091-1/+1
| | | | | | | | | | | | | | | | | In this change: - Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00 - Remove AttachmenService::GetStore. Now attachment store is owned by model type, there is no need to get it from AttachmentService - Introduce AttachmentReferrer. There is no functionality behind it yet and interface is not complete for it. These will come in the next change. BUG=457735 R=maniscalco@chromium.org TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests) Review URL: https://codereview.chromium.org/986743004 Cr-Commit-Position: refs/heads/master@{#319733}
* Sort GYP and GN files under syncsatorux2015-02-181-6/+6
| | | | | | | | | | | | For tools/sort_sources.py to be useful, existing GYP and GN files should be sorted. BUG=456014 TEST=everything should build as before Review URL: https://codereview.chromium.org/915893004 Cr-Commit-Position: refs/heads/master@{#316743}
* Create a Android Sync integration test for typed URLspvalenzuela2015-02-061-0/+4
| | | | | | | | | | | | | | | This is a re-land of https://codereview.chromium.org/862113005/ This CL introduces JNI plumbing for one method of the FakeServer's verification API. One test (testUploadTypedUrl) has been added to use the API; it types a URL on the client and verifies that the URL was sent to the server. BUG=NONE Review URL: https://codereview.chromium.org/884073005 Cr-Commit-Position: refs/heads/master@{#315088}
* Revert of Create a Android Sync integration test for typed URLs (patchset #4 ↵miguelg2015-01-301-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:140001 of https://codereview.chromium.org/862113005/) Reason for revert: This is breaking building chrome/android:chrome_sync_shell_test_apk with gn due to a dependency to the autogenerated enum org.chromium.ui.base.PageTransition; I am not sure why no bots failed when landing it (we don't seem to have gn builder upstream for android?) but reverting it locally makes it build again. To repro: Reapply the patch and run gn gen out/Release --args='is_debug=false os="android" cpu_arch="arm" use_goma=true goma_dir="/usr/local/google/clank/goma/goma"' ninja -C out/Release -j 200 chrome/android:chrome_sync_shell_test_apk Original issue's description: > Create a Android Sync integration test for typed URLs > > This CL introduces JNI plumbing for one method of the FakeServer's > verification API. One test (testUploadTypedUrl) has been added to use > the API; it types a URL on the client and verifies that the URL was > sent to the server. > > BUG=NONE > > Committed: https://crrev.com/cba424b9309c8c75d0a3797b9b228f7ef11425e4 > Cr-Commit-Position: refs/heads/master@{#313824} TBR=nyquist@chromium.org,maxbogue@chromium.org,zea@chromium.org,pvalenzuela@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Review URL: https://codereview.chromium.org/881753003 Cr-Commit-Position: refs/heads/master@{#313898}
* Create a Android Sync integration test for typed URLspvalenzuela2015-01-291-0/+1
| | | | | | | | | | | | | This CL introduces JNI plumbing for one method of the FakeServer's verification API. One test (testUploadTypedUrl) has been added to use the API; it types a URL on the client and verifies that the URL was sent to the server. BUG=NONE Review URL: https://codereview.chromium.org/862113005 Cr-Commit-Position: refs/heads/master@{#313824}
* Sync: Attachment Store APIs for accessing attachment metadatastanisc2014-11-211-0/+1
| | | | | | | | | | | | | | | | | | | Introduced two new API methods to AttachmentStoreBase: - ReadMetadata - ReadAllMetadata Added unimplemented overrides for these two methods into 5 classes that derive from AttachmentStoreBase. For now the only class that has a real implementation and unit test coverage of the new methods is AttachmentStoreHandle. I'll provide implementation and test coverage for all other classes in the next change. BUG=435205 Review URL: https://codereview.chromium.org/736093003 Cr-Commit-Position: refs/heads/master@{#305168}
* Introduce AttachmentStore metadata recordpavely2014-10-251-0/+1
| | | | | | | | | | | | | This change handles different errors during attachment store open: - create record for empty database - fail if record is corrupt or of newer version. BUG=424304 R=maniscalco@chromium.org Review URL: https://codereview.chromium.org/647553009 Cr-Commit-Position: refs/heads/master@{#301270}
* Implementation of OnDiskAttachmentStore.pavely2014-10-171-0/+2
| | | | | | | | | | | | | | In this change only attachment payload is stored, support for metadata will be in separate change. Also in_memory_attachment_store_unittest is moved into test_template. This test is now used for both stores. BUG= R=maniscalco@chromium.org Review URL: https://codereview.chromium.org/652723003 Cr-Commit-Position: refs/heads/master@{#300041}
* Make chrome_shell_apk buildcjhopman2014-10-131-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This mostly just adds the chrome_shell_apk build definition and those of a whole bunch of targets. Adds a simple check that when DEPRECATED_java_in_dir is used, it actually includes the "src" at the end (GYP just assumes that you really meant that java files are in <(java_in_dir)/src). Makes the call to process_resources only generate R.java for extra packages when being run as part of the apk step (otherwise, for example, both chrome resources and content resources would contain an R.java for net resources and compilation would fail). Depends on https://codereview.chromium.org/581273004/ Adds the following targets -- and enables ~300 more (550 counting template-generated inner targets): //chrome:chrome_android_core //chrome/android:chrome_strings_grd //chrome/android:chrome_java //chrome/android:activity_type_ids_javagen //chrome/android:app_banner_metrics_ids_javagen //chrome/android:resource_id_javagen //chrome/android:profile_account_management_metrics_javagen //chrome/android:profile_sync_service_model_type_selection_javagen //chrome/android:toolbar_model_security_levels_javagen //chrome/android:tab_load_status_javagen //chrome/android:chrome_shell_base //chrome/android:chrome_shell //chrome/android:chrome_sync_shell //chrome/android:chrome_shell_resources //chrome/android:chrome_shell_java //chrome/android:chrome_shell_assets //chrome/android:chrome_shell_apk //chrome/android:chrome_sync_shell_apk //components/bookmarks:bookmarks_java //components/bookmarks:bookmarks_jni_headers //components/bookmarks:bookmark_type_javagen //components/dom_distiller/android:dom_distiller_core_java //components/dom_distiller/android:dom_distiller_core_font_family_javagen //components/dom_distiller/android:dom_distiller_core_theme_javagen //components/enhanced_bookmarks:jni_headers //components/enhanced_bookmarks/android:enhanced_bookmarks_java //components/gcm_driver:gcm_driver_java //components/gcm_driver:jni_headers //components/navigation_interception/android:navigation_interception_java //components/variations:variations_java //components/web_contents_delegate_android:web_contents_delegate_android //components/web_contents_delegate_android:web_contents_delegate_android_java //components/web_contents_delegate_android:web_contents_delegate_android_jni_headers //printing:printing_java //sync:fake_server_jni //sync:sync_java_test_support //sync:test_support_sync_fake_server_android //sync:sync_unit_tests_apk //sync/android:sync_java //sync/android:sync_javatests BUG=359249 TBR=ben Review URL: https://codereview.chromium.org/570203002 Cr-Commit-Position: refs/heads/master@{#299381}
* Reland Refactor FakeAttachmentStorepavely2014-10-021-1/+2
| | | | | | | | | | | | | | Refactor FakeAttachmentStore into AttachmentStoreProxy and InMemoryAttachmentStore backend. Break AttachmentStore interface into AttachmentStoreBase (common interface for backends) and AttachmentStore (referenced by datatype and AttachmentService). BUG= R=maniscalco@chromium.org Review URL: https://codereview.chromium.org/616983002 Cr-Commit-Position: refs/heads/master@{#297951}
* Revert of Refactor FakeAttachmentStore (patchset #3 id:40001 of ↵sergeyv2014-09-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/601553004/) Reason for revert: Speculative revert: looks like it causes failures on the Linux asan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/8113 Original issue's description: > Refactor FakeAttachmentStore > > Refactor FakeAttachmentStore into AttachmentStoreProxy and > InMemoryAttachmentStore backend. Break AttachmentStore interface into > AttachmentStoreBase (common interface for backends) and AttachmentStore > (referenced by datatype and AttachmentService). > > BUG= > R=maniscalco@chromium.org > > Committed: https://crrev.com/6ae2b341c73909cf902078446346d6c900273409 > Cr-Commit-Position: refs/heads/master@{#297339} TBR=maniscalco@chromium.org,pavely@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/619563002 Cr-Commit-Position: refs/heads/master@{#297379}
* Refactor FakeAttachmentStorepavely2014-09-301-1/+2
| | | | | | | | | | | | | | Refactor FakeAttachmentStore into AttachmentStoreProxy and InMemoryAttachmentStore backend. Break AttachmentStore interface into AttachmentStoreBase (common interface for backends) and AttachmentStore (referenced by datatype and AttachmentService). BUG= R=maniscalco@chromium.org Review URL: https://codereview.chromium.org/601553004 Cr-Commit-Position: refs/heads/master@{#297339}
* Update AttachmentServiceImpl to retry attachment uploads.maniscalco2014-09-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Add TaskQueue, a class that provides retry and backoff semantics for tasks. Used by AttachmentServiceImpl. AttachmentUploaderImpl and AttachmentDownloaderImpl now differentiate between transient and non-transient errors. Almost all errors are assumed to be transient. "403 Forbidden" is the exception and is returned by the sync server if attachment are disabled for the user. Transient errors encountered during attachment upload will be retried with exponential backoff (using TaskQueue and BackoffEntry). The idea is to consolidate retry logic at the AttachmentServiceImpl level. In a future CL, changes in network connectivity will affect retry and backoff. BUG=372622, 380437 Review URL: https://codereview.chromium.org/554743004 Cr-Commit-Position: refs/heads/master@{#294195}
* Remove package_name from java_apk.gypihjd2014-09-051-1/+0
| | | | | | | | | | | | | | | | | | This change completes the removal of package_name from build/java_apk.gyp and removes it from all the places which still refer to it. 'package_name' used to be how you specified the intermediate directory when building an APK. Now we use the target name and includers no longer need to set the intermediate directory explicitly. However one use in java_apk for setting additional resources files seems to have crept through the refactoring. BUG=405963 Review URL: https://codereview.chromium.org/487223003 Cr-Commit-Position: refs/heads/master@{#293498}
generated by cgit v1.1 at 2024-05-22 05:43:03 +0000