| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This code is part of the chromium tree, not pulled in by DEPS. So
we should let people change the code freely. Currently every time you
change this code, a presubmit warning is given. Let's not do that.
R=jam, jochen, sky
Review URL: https://codereview.chromium.org/1476893004
Cr-Commit-Position: refs/heads/master@{#361745}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unlike most things in third_party and like Blink, BoringSSL is unversioned and
maintained by us. It is rolled via DEPS in third_party/boringssl/src, but still
has Chromium-specific build files checked into the third_party/boringssl
directory. Shush presubmit complaining on DEPS rolls when those files change.
The one time we might wish to update README.chromium is if something about the
license changes, but that would be signaled via a DEPS change and not picked up
by this PRESUBMIT rule anyway.
BUG=none
Review URL: https://codereview.chromium.org/1454303002
Cr-Commit-Position: refs/heads/master@{#360609}
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=primiano@chromium.org
Review URL: https://codereview.chromium.org/1365653002 .
Cr-Commit-Position: refs/heads/master@{#350327}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we expect a certain format for the "License:" field, it's better to
check it earlier -- during the presubmit stage, so people won't get
surprises later.
Also, updated the license checking code to accept multiple licenses if
one of them is compatible with Android.
BUG=168324
R=dannyb@google.com, mkosiba@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/146803006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Removing a third_party directory raises an exception since it tries to
open the deleted README.chromium file. Instead, try to make sure files
are being deleted.
2) Editing PRESUBMIT.py gives errors about not having edited README.chromium.
Ignore the files in third_party that are not directories.
TBR=cdn@chromium.org
Review URL: https://codereview.chromium.org/21217004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will simplify the addition of a tool to check licenses for the purpose of
the Android WebView build.
See also http://codereview.chromium.org/10827099
Also adds other missing fields to these README.chromium files as required by
presubmit checks and fixes a regex used to enforce this.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10821103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Allow spaces in the "Name:" field and colors in "Version:".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6893125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No behavior change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6825059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looked at the wrong file contents for its checks, and it had
a redundant check for name. The "Security Critical" text had a
different spelling than in README.chromium.template.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6820055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=N/A
TEST=N/A
Review URL: http://codereview.chromium.org/6816003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
and contain the proper meta data when files within third_party are modified.
Also fixed _CheckNoInterfacesInBase() which was broken on win32 as the path seperator was hardcoded.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6713009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80051 0039d316-1c4b-4281-b951-d872f2087c98
|