| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rewrite white-space property for contenteditable=plaintext-only elements as:
normal -> pre-wrap
nowrap -> pre
pre-line -> pre-wrap
because whitespace collapsing doesn't make sense in plain-text editing.
The new behavior matches to Microsoft Edge for TEXTAREA.
BUG=595491
Review URL: https://codereview.chromium.org/1813663002
Cr-Commit-Position: refs/heads/master@{#381668}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is plain-text editable and the incoming fragment is plain-text.
The purposes of this CL:
* Do not modify incoming text for plain-text editing. We unexpectedly converted
EOL characters for TEXTAREA.
* Improve performance of text insertion in plain-text editing.
BUG=2007,410417,453802,528491,586772,591697
Review URL: https://codereview.chromium.org/1780413002
Cr-Commit-Position: refs/heads/master@{#380527}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
INPUT/TEXTAREA.
Re-ordering an internal placeholder element and innerEditor element fixes
this issue.
BUG=560649
TEST=automated
Review URL: https://codereview.chromium.org/1478573002
Cr-Commit-Position: refs/heads/master@{#361534}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When InlineTextBox's isLeftToRightDirection() is false, the text should
be composed in a reverse direction, and underline or other decorations
should be composed in the correct direction.
Since start is just based on underline's start value, but when drawn
it should be right to the underline's end value, so it should be reversed.
Also fixes TextInputController::SetComposition to draw
underlines
correctly by setting correct properties and not selecting the composition.
BUG=551752
Review URL: https://codereview.chromium.org/1444253002
Cr-Commit-Position: refs/heads/master@{#360726}
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/chromium/src/+/4a57b23c
BUG=548596
TBR=wkorman@chromium.org
Review URL: https://codereview.chromium.org/1455893002 .
Cr-Commit-Position: refs/heads/master@{#360285}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks caret rendering at rightmost edge of some situations.
This reverts commit 5fdc15a7ec5c12ea3a708796c8cb3338c474f0fa.
BUG=548596,523969
TBR=chrishtr
Review URL: https://codereview.chromium.org/1451103005
Cr-Commit-Position: refs/heads/master@{#360247}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates expectations for tests that expect an instant scroll such
that they pass when smooth scroll is enabled.
Note:
- Some of the tests are re-written, but most of them apply the following change:
shouldBe('scrollLeft', 'expectedScrollLeft)
shouldBe('scrollTop', 'expectedScrollTop') -->
shouldBecomeEqual('scrollLeft == expectedScrollLeft && scrollTop ==
expectedScrollTop', 'true')
'shouldBecomeEqual' waits asynchronously until the condition is true.
- Some of the tests just expect a certain scroll offset and are not really
testing scroll-behavior. For those tests, the scrollAnimatorEnabled setting
is turned off by default.
internals.settings.setScrollAnimatorEnabled(false)
BUG=575
Review URL: https://codereview.chromium.org/1413493005
Cr-Commit-Position: refs/heads/master@{#358572}
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/blink?view=revision&revision=202350
BUG=474759
TBR=wkorman@chromium.org
Review URL: https://codereview.chromium.org/1351643002 .
git-svn-id: svn://svn.chromium.org/blink/trunk@202360 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f6affa7d47725fc64302da597c87e4b8493b5c25.
Original change: http://crrev.com/1284783003
Restoring removal of long-stale FIXME as ToT is fine without it and
if it surfaces other issues we'd like to continue the cleanup.
BUG=523969
TBR=jbroman
Review URL: https://codereview.chromium.org/1348613004
git-svn-id: svn://svn.chromium.org/blink/trunk@202350 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/blink?view=revision&revision=202221
BUG=474759
TBR=wkorman@chromium.org
Review URL: https://codereview.chromium.org/1340883004 .
git-svn-id: svn://svn.chromium.org/blink/trunk@202229 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 0e054f07273d9f5104b4b3926dc438fa794436fe.
Causes caret to disappear at edge of input fields in some situations.
BUG=523969,474759
Review URL: https://codereview.chromium.org/1334383002
git-svn-id: svn://svn.chromium.org/blink/trunk@202221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/blink?view=revision&revision=200378
BUG=474759
TBR=wkorman@chromium.org
Review URL: https://codereview.chromium.org/1284123002 .
git-svn-id: svn://svn.chromium.org/blink/trunk@200384 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
BUG=474759
Review URL: https://codereview.chromium.org/1284783003
git-svn-id: svn://svn.chromium.org/blink/trunk@200378 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
| |
BUG=392046
TBR=ksakamoto@chromium.org
Review URL: https://codereview.chromium.org/1212753002
git-svn-id: svn://svn.chromium.org/blink/trunk@197935 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace most uses of body.scrollTop/Left with scrollingElement so that
we can experiment with turning the ScrollTopLeftInterop feature on and
off without too much pain.
BUG=157855
Review URL: https://codereview.chromium.org/1133693002
git-svn-id: svn://svn.chromium.org/blink/trunk@195624 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
Have this test-only method gracefully handle the case where it is
attempted used in a document having no editable element.
R=haraken
BUG=483639
Review URL: https://codereview.chromium.org/1122593004
git-svn-id: svn://svn.chromium.org/blink/trunk@194870 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
| |
by user.
BUG=458429
Review URL: https://codereview.chromium.org/914573004
git-svn-id: svn://svn.chromium.org/blink/trunk@192799 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/blink/trunk@191050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
| |
BUG=400339
R=eae@chromium.org,leviw@chromium.org
TEST=editing/input/orphan-set-selection-range.html
Review URL: https://codereview.chromium.org/945873003
git-svn-id: svn://svn.chromium.org/blink/trunk@190609 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
| |
BUG=450612
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/931633003
git-svn-id: svn://svn.chromium.org/blink/trunk@190326 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
BUG=421268
Review URL: https://codereview.chromium.org/637763002
git-svn-id: svn://svn.chromium.org/blink/trunk@183941 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTMLTextAreaElement.setSelectionRange(start,end) changes focus if |start| is not
|end|.
However, HTMLTextAreaElement.setSelectionRange should not change focus in any
condition.
FireFox follows such behavior at least.
Source/core/html/HTMLTextFormControlElement.cpp/h:
- Let setSelectionRange not change focus without the ChangeFocus option.
- SelectionOption option is used to change text selection like select() calling
on disabled input field.
- 278L: We must set 'forward' direction if direction is 'none' on not Mac.
- FrameSelection.setSelection is called when selectionOption is ChangeSelection
or this TextFormControl element is already focused.
Source/core/html/HTMLTextAreaElement.cpp/h:
- Change setValueCommon to call setSelectionRange except for initialize.
- setSelectionRange calls update layout, which needs updated validity so call
setNeedsValidityCheck earlier.
LayoutTests/fast/forms/selection-setSelectionRange-focusing.html:
- Added test. Check focus not to be changed.
LayoutTests/fast/forms/textarea-selection-preservation.html:
- Add test cases resetting selection. This is following the FireFox behavior.
(Other layout tests):
- Some tests expect setSelectionRange to change focus, thus I add extra focus.
- Some tests expect resetting value of textarea to change selection to 0, thus I
add extra setSelectionRange(0, 0);
TEST=LayoutTests/fast/forms/selection-setSelectionRange-focusing.html, textarea-
selection-preservation.html
BUG=393504
Review URL: https://codereview.chromium.org/392573002
git-svn-id: svn://svn.chromium.org/blink/trunk@178822 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some layout tests call setPosition(node, offset) with large |offset| which is larger than |node|'s length but it is invalid in the standard:
https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-collapse
A typically case is that, image following HTML:
<div>text</div>
if you want to set a caret to between 'x' and 't', you should call Selection.setPostion(div.firstChild, 3).
However, many layout tests call Selection.setPosition(div, 3), which is invalid.
Many of those tests want to just set a caret to a last position of the node so this CL changes to call setPosition(node, node.childNodes.length).
I'm going to change Selection.setPosition to throw an exception for such a invalid call through Range.setStart/End.
This CL is similar to previous one:
https://src.chromium.org/viewvc/blink?revision=173167&view=revision
BUG=
Review URL: https://codereview.chromium.org/272703007
git-svn-id: svn://svn.chromium.org/blink/trunk@173629 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
Selection.setPosition is an alias of Selection.collapse and is not a standard function.
We take a UMA of setPosition and I'm going to obsolete it.
BUG=
Review URL: https://codereview.chromium.org/268753006
git-svn-id: svn://svn.chromium.org/blink/trunk@173482 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
| |
Password generation will use this to more easily edit generated passwords.
BUG=318977
Review URL: https://codereview.chromium.org/135963005
git-svn-id: svn://svn.chromium.org/blink/trunk@165900 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused a bunch of test flakiness. The onload appears to be firing
after we dump the text in some cases. Don't really understand how
that's happening.
Didn't revert the compositing/gestures tests since that was just removing
unused includes of js-test.js from reftests.
R=kbr@chromium.org
TBR=kbr@chromium.org
BUG=316429, 316425, 316460
Review URL: https://codereview.chromium.org/66113002
git-svn-id: svn://svn.chromium.org/blink/trunk@161658 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All key events with the command key were marked as isSystemKey which
prevents Blink from handling them.
Command-B and Command-I are OS X standard key bindings but OS X doesn't handle them and we don't have them
in the menubar so we need to handle them inside Blink.
I also removed some unused lines from keyDownEntries in EditorClientImpl.cpp.
BUG=308680
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161459
Review URL: https://codereview.chromium.org/39073002
git-svn-id: svn://svn.chromium.org/blink/trunk@161607 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bunch of cases of having TEST COMPLETE get printed
after shouldBe lines.
-Make the compositing/gestures/gesture-tapHighlight reftests
not needlessly import js-test.js.
-Fix some webgl tests to set jsTestIsAsync.
-Change successfullyParsed to always be a boolean instead of undefined.
-Some tests never fire an onload event, so they now don't print TEST COMPLETE.
Review URL: https://codereview.chromium.org/59793005
git-svn-id: svn://svn.chromium.org/blink/trunk@161493 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke compile on Linux/Aura.
> Command-B and Command-I should work in contenteditable
>
> All key events with the command key were marked as isSystemKey which
> prevents Blink from handling them.
>
> Command-B and Command-I are OS X standard key bindings but OS X doesn't handle them and we don't have them
> in the menubar so we need to handle them inside Blink.
>
> I also removed some unused lines from keyDownEntries in EditorClientImpl.cpp.
>
> BUG=308680
>
> Review URL: https://codereview.chromium.org/39073002
TBR=keishi@chromium.org
Review URL: https://codereview.chromium.org/62633002
git-svn-id: svn://svn.chromium.org/blink/trunk@161460 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All key events with the command key were marked as isSystemKey which
prevents Blink from handling them.
Command-B and Command-I are OS X standard key bindings but OS X doesn't handle them and we don't have them
in the menubar so we need to handle them inside Blink.
I also removed some unused lines from keyDownEntries in EditorClientImpl.cpp.
BUG=308680
Review URL: https://codereview.chromium.org/39073002
git-svn-id: svn://svn.chromium.org/blink/trunk@161459 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move fast/js/resources/js-test-pre.js and
fast/js/resources/leak-check.js to the root resources
directory. They're used mostly by tests outside of fast/js.
Also, rename js-test-pre.js to js-test.js now that there's
no js-test-post.js.
TBR because it's impossible to review 6819 file changes in rietveld.
TBR=eae@chromium.org
Review URL: https://codereview.chromium.org/58533003
git-svn-id: svn://svn.chromium.org/blink/trunk@161296 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
There turn out to be three copies of js-test-pre/post in the tree.
This deletes the one used by all but ~100 tests.
TBR=eae@chromium.org
Review URL: https://codereview.chromium.org/48903019
git-svn-id: svn://svn.chromium.org/blink/trunk@161210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
Will delete the file in a followup patch.
Review URL: https://codereview.chromium.org/54473004
git-svn-id: svn://svn.chromium.org/blink/trunk@161115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ID access is safer than holding a RefPtr because an element accessed by its ID
is always in a DOM tree.
- We need to keep HTMLTextFormControlElement::innerTextElement()
because some classes call it.
- The ID name is "inner-editor", not "innerTextElement" or something like it.
"innerTextElement" is confusing with Element::innerText. We're going to rename
it later.
BUG=none
TEST=Update existing automated tests for internal markup changes.
Review URL: https://codereview.chromium.org/47873002
git-svn-id: svn://svn.chromium.org/blink/trunk@160692 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes unused member functions from WebClientView:
- shouldApplyStyle
- shouldChangeSelectedRange
- shouldDeleteRange
- shouldBeginEditing
- shouldEndEditing
- shouldInsertNode
- shouldInsertText
- didBeginEditing
- didEndEditing
Changes in test expectation texts are updated by machinery, find+xargs+sed.
BUG=302013
TEST=n/a; no behavior changes, existing tests cover this patch
R=tkent@chromium.org
Review URL: https://codereview.chromium.org/26237004
git-svn-id: svn://svn.chromium.org/blink/trunk@159279 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rule of thumb here is: if in strict mode, documentElement element
should be used to operate over scrollTop/Left properties.
When in quirks mode, use 'body' element.
CL fixes many layout tests caught by an UseCount/Console warning
being added by https://codereview.chromium.org/26489005/ that
were abusing the relaxed body.scrollTop/Left support Blink currently has.
The exception is LayoutTests/jquery/offset.html, where jQuery on purpose
uses both documentElement and body elements, for cross engine support.
R=Julien Chaffraix, Dan Beam
Review URL: https://codereview.chromium.org/26472003
git-svn-id: svn://svn.chromium.org/blink/trunk@159195 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use locally installed Ahem font instead of loading it as WebFont,
because WebFont may not be available at the point the test code executes.
Until WebFont is available, local font with the same name used to be used
as fallback, but that behavior has changed in r156182.
BUG=261029
Review URL: https://chromiumcodereview.appspot.com/23026008
git-svn-id: svn://svn.chromium.org/blink/trunk@156195 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
BUG=270000
Review URL: https://chromiumcodereview.appspot.com/22331011
git-svn-id: svn://svn.chromium.org/blink/trunk@155820 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/blink?view=revision&revision=154767
BUG=263058
TBR=eae@chromium.org
Review URL: https://codereview.chromium.org/19529005
git-svn-id: svn://svn.chromium.org/blink/trunk@154827 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
- moveParagraphBackward/movePargraphForward to document.execCommand()
- Key bindings (Ctrl+Up/Down) for them for Windows.
BUG=38097
R=tkent@chromium.org
Review URL: https://codereview.chromium.org/17828002
git-svn-id: svn://svn.chromium.org/blink/trunk@153120 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Editor::cancelCompositionIfSelectionIsInvalid() only gets called when
Editor::respondToChangedSelection() is called, however is certain cases
(e.g. http://jsfiddle.net/LaNQ4/5/show/ ) the selection does not change
(just the offsets) and respondToChangedSelection() is not called.
On Linux, this bug can be seen when typing using ibus and JS deletes
the value of the focused field. The composition popup does not disappear.
Video before the change:
https://docs.google.com/a/google.com/file/d/0B-AevY72N_3qVE9BWGxsMnNId3M/edit?usp=sharing
Video after the change:
https://docs.google.com/a/google.com/file/d/0B-AevY72N_3qWWEwbmNmTnFHYWc/edit?usp=sharing
It also breaks Android typing too.
BUG=242715
TEST=editing/input/setting-input-value-cancel-ime-composition.html
Review URL: https://chromiumcodereview.appspot.com/15651002
git-svn-id: svn://svn.chromium.org/blink/trunk@151334 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
This should just be removing redundant baselines.
TBR=abarth@chromium.org
git-svn-id: svn://svn.chromium.org/blink/trunk@149122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means that there are no longer any expected results in
LayoutTests/platform/chromium/..., so this location is removed from the
fallback path.
Also updates an inspector tool and a rebaseline unit test.
BUG=229807
R=abarth,pfeldman
Review URL: https://codereview.chromium.org/14166003
git-svn-id: svn://svn.chromium.org/blink/trunk@148246 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unreviewed expectations update.
A remaining textual fix.
* editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@142331 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unreviewed expectations update.
Round 8. Outstanding mac failure.
* editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/chromium/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
* platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
git-svn-id: svn://svn.chromium.org/blink/trunk@142300 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unreviewed expectations update.
Round 1. Some tests that have existing expectations.
* editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
* platform/chromium-linux-x86/editing/input: Removed.
* platform/chromium-linux/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-linux/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-win-xp/editing/input: Removed.
* platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
* platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
* platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
* platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
* platform/efl-wk2/editing/input: Added.
* platform/efl-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
* platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
git-svn-id: svn://svn.chromium.org/blink/trunk@142277 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=107757
Reviewed by Hajime Morita.
Remove document as a parameter since there's already one associated with internals.
Source/WebCore:
No new tests, this refactors some testing code and is covered by
exisiting tests.
* testing/Internals.cpp:
(WebCore::Internals::isPreloaded):
(WebCore::Internals::createContentElement):
(WebCore::Internals::absoluteCaretBounds):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
LayoutTests:
* editing/input/editable-container-with-word-wrap-normal.html:
* editing/selection/caret-alignment-for-vertical-text.html:
* editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html:
* editing/selection/caret-in-div-containing-br-in-vertical-mode.html:
* editing/selection/caret-in-empty-inline-1.html:
* editing/selection/caret-in-empty-inline-2.html:
* editing/selection/internal-caret-rect.html:
* fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
(createContentWithText):
(appendShadow):
(appendShadowDeep):
* fast/dom/shadow/content-element-includer.html:
* fast/dom/shadow/content-element-renderers.html:
* fast/dom/shadow/content-selector-query.html:
* fast/dom/shadow/create-content-element.html:
* fast/dom/shadow/shadow-contents-fallback-dynamic.html:
* fast/dom/shadow/shadow-contents-fallback.html:
* fast/dom/shadow/shadow-contents-select.html:
* fast/preloader/scan-body-from-head-import.html:
* http/tests/loading/preload-append-scan.php:
git-svn-id: svn://svn.chromium.org/blink/trunk@140710 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=105574
Patch by Chris Hopman <cjhopman@google.com> on 2013-01-18
Reviewed by Simon Fraser.
Source/WebCore:
When scrolling to reveal an overflow layer, the required scroll was
being calculated in absolute coordinates. To properly account for
transforms, this calculation should be done in the local coordinates
of the renderBox.
Tests: editing/input/reveal-selection-transformed-overflow-parent.html
editing/input/reveal-selection-transformed-textarea.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
When scrolling to reveal an overflow layer, calculate the required
scroll in the local coordinates of the RenderBox.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteToLocalQuad):
(WebCore):
* rendering/RenderObject.h:
(RenderObject):
Add function to convert an absolute quad to a local quad.
LayoutTests:
* editing/input/reveal-caret-of-transformed-input-scrollable-parent.html: Added.
* editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added.
Test that when scrolling an overflow layer to reveal a rect, the rect
passed to the parent to scroll is calculated properly.
* editing/input/reveal-caret-of-transformed-multiline-input.html: Added.
* editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added.
Test that scrolling to reveal a rect works properly on a transformed
overflow layer.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
git-svn-id: svn://svn.chromium.org/blink/trunk@140202 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=80838
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-11
Reviewed by Ryosuke Niwa.
Source/WebCore:
Currently newline characters are replaced with spaces when pasted
to text input. This behavior was introduced in r37539, with the
intention to follow the FireFox's behavior (see
https://bugs.webkit.org/show_bug.cgi?id=20461). However, FireFox
truncates newlines at the end of pasted text, instead of replacing
them with spaces. So this patch changes TextFieldInputType to cut
trailing newlines of inserted text.
Test: fast/forms/paste-multiline-text-input.html
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
Truncates trailing newlines.
LayoutTests:
Verify that trailing newlines are stripped when pasted into text inputs.
* editing/input/paste-text-ending-with-interchange-newline-expected.txt:
Updated the expectation.
* fast/forms/paste-multiline-text-input.html:
Changed to use document.execCommand to mimic pasting, because setting
input.value attribute does not trigger beforeTextInserted event.
Added a test case to test trailing newlines.
git-svn-id: svn://svn.chromium.org/blink/trunk@131032 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=93287
Patch by Pravin D <pravind.2k4@gmai.com> on 2012-08-06
Reviewed by Ryosuke Niwa.
The testcase uses 'End' keypress event emulation to scroll the caret to the end of the line. As the behavior of 'End' keypress
is platform dependent, replacing it platform independent code.
* editing/input/editable-container-with-word-wrap-normal-expected.txt:
* editing/input/editable-container-with-word-wrap-normal.html:
Replaced 'End' keypress event with testRunner's execCommand() to make testcase behavior independent of platform.
git-svn-id: svn://svn.chromium.org/blink/trunk@124806 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|