| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements Event.relatedTargetScoped flag, which is set to false by default and should be set to true only if the event is trusted and has a related target or if the user sets it to true.
See the spec here: https://w3c.github.io/webcomponents/spec/shadow/#dfn-relatedtargetscoped-flag
BUG=589782
TBR=holte@chromium.org
Review URL: https://codereview.chromium.org/1817453002
Cr-Commit-Position: refs/heads/master@{#381929}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990
Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
Cr-Commit-Position: refs/heads/master@{#372596}
Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d
Cr-Commit-Position: refs/heads/master@{#376103}
Review URL: https://codereview.chromium.org/1637813002
Cr-Commit-Position: refs/heads/master@{#376395}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1637813002/ )
Reason for revert:
Breaks devtools. Landed without devtools review.
Original issue's description:
> Change Event.deepPath to a method
>
> In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
> See the discussion here: https://github.com/w3c/webcomponents/issues/361
> Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
> See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
> BUG=531990
>
> Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
> Cr-Commit-Position: refs/heads/master@{#372596}
>
> Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d
> Cr-Commit-Position: refs/heads/master@{#376103}
TBR=samli@chromium.org,hayato@chromium.org,kochi@chromium.org,kojii@chromium.org,yuzus@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=531990
Review URL: https://codereview.chromium.org/1710893003
Cr-Commit-Position: refs/heads/master@{#376223}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990
Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
Cr-Commit-Position: refs/heads/master@{#372596}
Review URL: https://codereview.chromium.org/1637813002
Cr-Commit-Position: refs/heads/master@{#376103}
|
|
|
|
|
|
|
|
|
|
|
| |
Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/bpbq0Rcpauk/cnpJtHddAgAJ
BUG=357112
Review URL: https://codereview.chromium.org/1681923002
Cr-Commit-Position: refs/heads/master@{#374434}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1637813002/ )
Reason for revert:
This breaks new DevTools frontend while remote debugging old backends.
Original issue's description:
> Change Event.deepPath to a method
>
> In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
> See the discussion here: https://github.com/w3c/webcomponents/issues/361
> Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
> See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
> BUG=531990
>
> Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
> Cr-Commit-Position: refs/heads/master@{#372596}
TBR=samli@chromium.org,hayato@chromium.org,kochi@chromium.org,kojii@chromium.org,yuzus@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=531990
Review URL: https://codereview.chromium.org/1651193003
Cr-Commit-Position: refs/heads/master@{#372713}
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990
Review URL: https://codereview.chromium.org/1637813002
Cr-Commit-Position: refs/heads/master@{#372596}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Spec is described here: http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042
Review URL: https://codereview.chromium.org/1586563005
Cr-Commit-Position: refs/heads/master@{#371747}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Spec is the link below.
http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath
This feature is guarded by ShadowDOMV1 RuntimeEnabled flag.
BUG=531990
Review URL: https://codereview.chromium.org/1577163003
Cr-Commit-Position: refs/heads/master@{#370652}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The deprecation message for synchronous XHR references the XHR spec over
HTTP, even though there is an HTTPS version. This updates that
reference and all the relevant test expectations.
BUG=546043
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/1411843003
Cr-Commit-Position: refs/heads/master@{#355373}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per specs[1,2] the "progress" event of type ProgressEvent fired at
FileReader objects should not be cancelable. Blink doesn't respond to
a preventDefault() anyway - this is probably just an oversight.
[1] https://w3c.github.io/FileAPI/
[2] https://xhr.spec.whatwg.org/#firing-events-using-the-progressevent-interface
BUG=509782
R=kinuko@chromium.org
Review URL: https://codereview.chromium.org/1230113009
git-svn-id: svn://svn.chromium.org/blink/trunk@199467 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the Event.isTrusted support behind an TrustedEvents experimental
feature flag. The trusted flag is set at the point of event dispatch
just before any event processing on the event takes place.
There are 5 spots where the trusted events are set
1) EventTarget::eventDispatch (from C++)
2) EventTarget::eventDispatchForBindings (from JS)
3) LocalDOMWindow::dispatchEvent (from C++) with special semantics about target
4) SimulatedMouseEvent constructor (these events are generated
by the EventDispatcher itself)
5) Node::dispatchScopedEvent
Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/cEJvjWg9bqg
BUG=334015
Review URL: https://codereview.chromium.org/1233233003
git-svn-id: svn://svn.chromium.org/blink/trunk@199071 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
BUG=496247,277124
Review URL: https://codereview.chromium.org/1165703009
git-svn-id: svn://svn.chromium.org/blink/trunk@196556 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
expected results
Due to https://codereview.chromium.org/1137103003/, "chrome" scheme is added to the list of CORS-enabled schemes in content, which appears on CONSOLE ERROR lines in the expected results.
This CL adds "chrome" to the expected results.
BUG=489672
Review URL: https://codereview.chromium.org/1139053004
git-svn-id: svn://svn.chromium.org/blink/trunk@196125 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per discussion in crrev.com/1054303003, we should refer to
the enum as "type" not "interface" in the warning.
BUG=471967
R=haraken@chromium.org,bashi1@chromium.org
Review URL: https://codereview.chromium.org/1061923002
git-svn-id: svn://svn.chromium.org/blink/trunk@193284 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
r192987 drops enum names from error messages, but they
shouldn't be dropped.
BUG=471967
Review URL: https://codereview.chromium.org/1054303003
git-svn-id: svn://svn.chromium.org/blink/trunk@193096 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
We should throw a TypeError when an invalid enum value is passed
as an element of Sequence or Array.
BUG=471967
Review URL: https://codereview.chromium.org/1047993002
git-svn-id: svn://svn.chromium.org/blink/trunk@192987 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
| |
As per discussion on https://codereview.chromium.org/871013007/
logging the message for invalid enum type
in binding code.
Review URL: https://codereview.chromium.org/955413002
git-svn-id: svn://svn.chromium.org/blink/trunk@192603 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not assume the presence of a frame() when performing the mixed content
checks in ResourceFetcher::canRequest().
R=mkwst@chromium.org
BUG=461225
Review URL: https://codereview.chromium.org/995783002
git-svn-id: svn://svn.chromium.org/blink/trunk@191636 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
As [NoInterfaceObject] removed in latest specs:
https://xhr.spec.whatwg.org/#xmlhttprequesteventtarget
BUG=448766
Review URL: https://codereview.chromium.org/848173003
git-svn-id: svn://svn.chromium.org/blink/trunk@189416 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was pointed out at W3C bug 21066[1] that Event.path API
should return an array of EventTarget, not NodeList, and
also it should include Window object except for the 'load'
event as described in the HTML spec.
LayoutTests/fast/dom/shadow/event-path.html was changed to
a script test to ensure not only types but also instances
are correct.
Exiting test expectations are updated to include the Window
object, and added one test to test that the 'load' event
does not include the Window object.
One imported/web-platform-tests fails due to this spec
change and marked as Failure, until the PR[2] is merged
and imported.
[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=21066
[2] https://github.com/w3c/web-platform-tests/pull/1524
BUG=442632
TEST=fast/dom/shadow/event-path-load.html, fast/dom/shadow/event-path-window-load.html
Review URL: https://codereview.chromium.org/849783002
git-svn-id: svn://svn.chromium.org/blink/trunk@188594 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
idl interface.
This CL introduces a separate idl file for ClipboardEvent derived from Event interface and avoids using the
custom binding required for handling of clipboardData attribute.
R=haraken@chromium.org
BUG=345519
Review URL: https://codereview.chromium.org/797583002
git-svn-id: svn://svn.chromium.org/blink/trunk@187069 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL shows a message in developer tools console, warning that the sync xhr may
hamper responsiveness.
This was shown as per the spec suggestion: https://xhr.spec.whatwg.org/#sync-warning
BUG=392311
Review URL: https://codereview.chromium.org/585873002
git-svn-id: svn://svn.chromium.org/blink/trunk@184788 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
BUG=415463
Review URL: https://codereview.chromium.org/577173002
git-svn-id: svn://svn.chromium.org/blink/trunk@182297 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
embedder." (breaks multiple tests)
TBR=kozyatinskiy
This reverts commit c1e6f4baa282563f21a3cec81ba8fb0bae00534d.
BUG=
Review URL: https://codereview.chromium.org/542623004
git-svn-id: svn://svn.chromium.org/blink/trunk@181366 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing the patch on behalf of kozyatinskiy@chromium.org.
Original patch: https://codereview.chromium.org/531603002/
BUG=408121
TBR=kozyatinskiy
Review URL: https://codereview.chromium.org/536363002
git-svn-id: svn://svn.chromium.org/blink/trunk@181364 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
We are planning to return ReadableStream as "stream" response type. In preparation
to do so, this CL makes XHR moves exsisting "stream" response type to "legacystream".
BUG=401396
Review URL: https://codereview.chromium.org/449803002
git-svn-id: svn://svn.chromium.org/blink/trunk@179853 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For attempted cross-origin requests to unsupported CORS URLs, extend the
error reporting to also apply to non-simple requests that would require
a preflight. It is also bound to fail.
R=abarth@chromium.org,tyoshino@chromium.org
BUG=389751
Review URL: https://codereview.chromium.org/389053003
git-svn-id: svn://svn.chromium.org/blink/trunk@178091 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://fetch.spec.whatwg.org/#forbidden-header-name .
BUG=373120
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177762
Review URL: https://codereview.chromium.org/378183003
git-svn-id: svn://svn.chromium.org/blink/trunk@178023 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/378183003/)
Reason for revert:
Caused browser_tests failure
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/37851
OutOfProcessPPAPITest.URLLoader3
PPAPINaClGLibcTest.URLLoader3
PPAPINaClNewlibTest.URLLoader3
PPAPINaClPNaClTest.URLLoader3
PPAPITest.URLLoader3
Original issue's description:
> Update XMLHttpRequest forbidden header names.
>
> See http://fetch.spec.whatwg.org/#forbidden-header-name .
>
> BUG=373120
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177762
TBR=abarth@chromium.org,yhirano@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373120
Review URL: https://codereview.chromium.org/385493002
git-svn-id: svn://svn.chromium.org/blink/trunk@177786 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
| |
See http://fetch.spec.whatwg.org/#forbidden-header-name .
BUG=373120
Review URL: https://codereview.chromium.org/378183003
git-svn-id: svn://svn.chromium.org/blink/trunk@177762 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
v8::Function::Call reports a message when there is a v8::TryCatch with
is_verbose_ set. On the other hand, when the recursion level is too deep,
ScriptController::callFunction doesn't call v8::Function::Call and simply
throws a RangeError exception.
That is a problem when we don't want to rethrow the exception.
This CL makes V8ScriptRunner::callFunction and V8ScriptRunner::runCompiledScript
call a v8 function throwing a stack overflow exception when the recursion level
is too deep.
This is a preparation to make v8::TryCatch nestable.
BUG=362388
Review URL: https://codereview.chromium.org/358073003
git-svn-id: svn://svn.chromium.org/blink/trunk@177715 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than only doing it for http(s) URLs. This matches the XHR2 spec and
Firefox. This also avoids having to support the downloadToFile + synchronous
load combination in the resource loader stack.
Update tests according and add an assertion.
BUG=354188
Review URL: https://codereview.chromium.org/206223005
git-svn-id: svn://svn.chromium.org/blink/trunk@169702 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Have XMLHttpRequest.responseXML return an XMLDocument instead of a Document
when the response is of XML MIME type. This behavior is consistent with
Firefox 27 and IE11.
R=arv, tkent
BUG=350923
TEST=http/tests/xmlhttprequest/responsexml-type.html
Review URL: https://codereview.chromium.org/197103005
git-svn-id: svn://svn.chromium.org/blink/trunk@169080 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The usage of these is so high that complaining about them is likely to
make developers ignore console warnings:
http://www.chromestatus.com/metrics/feature/timeline/popularity/137
http://www.chromestatus.com/metrics/feature/timeline/popularity/162
Spec bugs filed to maybe make them standard instead:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=25001
https://www.w3.org/Bugs/Public/show_bug.cgi?id=25002
Discussion on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/eplNSf8oDfw/0kB2gD0lQHgJ
BUG=none
Review URL: https://codereview.chromium.org/194173002
git-svn-id: svn://svn.chromium.org/blink/trunk@168918 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Configure incoming ExceptionState with the calling context instead of
detailing at the point where the exception is raised.
To support throwing context-sensitive TypeErrors, extend
ExceptionState::throwTypeError() to also embellish its incoming
messages.
R=mkwst
BUG=270033
Review URL: https://codereview.chromium.org/96793002
git-svn-id: svn://svn.chromium.org/blink/trunk@162909 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When dispatching XMLHttpRequest progress events, for upload as well as
normal/download, supply the required 'loaded' and 'total' properties
on the events, if available, for better reporting to scripts.
Previously just left as 0. The new behavior mirrors what other
implementations are doing.
R=tyoshino,abarth
BUG=318727
Review URL: https://codereview.chromium.org/79953004
git-svn-id: svn://svn.chromium.org/blink/trunk@162689 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) and replace by
the V8TRYCATCH_FOR_V8STRINGRESOURCE_*() macros. This makes sure that we properly abort
execution when an exception is thrown by v8::Value::ToString().
R=haraken
TEST=fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html
TEST=fast/frames/frame-set-location-badstring.html
TEST=fast/xmlhttprequest/xmlhttprequest-open-exceptions.html
TEST=http/tests/local/formdata/send-form-data-with-bad-string.html
Review URL: https://codereview.chromium.org/74133005
git-svn-id: svn://svn.chromium.org/blink/trunk@162150 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move fast/js/resources/js-test-pre.js and
fast/js/resources/leak-check.js to the root resources
directory. They're used mostly by tests outside of fast/js.
Also, rename js-test-pre.js to js-test.js now that there's
no js-test-post.js.
TBR because it's impossible to review 6819 file changes in rietveld.
TBR=eae@chromium.org
Review URL: https://codereview.chromium.org/58533003
git-svn-id: svn://svn.chromium.org/blink/trunk@161296 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
| |
There turn out to be three copies of js-test-pre/post in the tree.
This deletes the one used by all but ~100 tests.
TBR=eae@chromium.org
Review URL: https://codereview.chromium.org/48903019
git-svn-id: svn://svn.chromium.org/blink/trunk@161210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than tagging every console message with "CONSOLE MESSAGE", this
patch adds the message level. "CONSOLE ERROR" and "CONSOLE WARNING", for
instance ("CONSOLE DEBUG" is less awesome, but whatever).
This requires touching practically every test expectation ever. Sorry. :(
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/26770004
git-svn-id: svn://svn.chromium.org/blink/trunk@159570 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hidden behind the --enable-experimental-webkit-features flag.
Original Streams API spec is:
https://dvcs.w3.org/hg/streams-api/raw-file/tip/Overview.htm
How to read data from Stream in JavaScript is still under
discussion at this thread
http://lists.w3.org/Archives/Public/public-webapps/2013AprJun/0706.html
but integration with XHR is not controversial.
So, to allow APIs depending on Stream but not on JavaScript
Stream read/write API to start development (e.g. Media Source
Extensions API
https://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html),
I'd like to land XHR integration part.
BUG=169957
Review URL: https://chromiumcodereview.appspot.com/18883002
git-svn-id: svn://svn.chromium.org/blink/trunk@157609 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
BUG=119256
Review URL: https://chromiumcodereview.appspot.com/23445015
git-svn-id: svn://svn.chromium.org/blink/trunk@156961 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for BeforeUnloadEvent as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/#beforeunloadevent
BeforeUnloadEvent has a returnValue attribute. Setting returnValue to a non-empty
string in an event handler causes the user agent should ask the user to confirm
that they wish to unload the document. This is equivalent to returning a non-empty
string in the EventHandler:
http://www.whatwg.org/specs/web-apps/current-work/#onbeforeunloadeventhandler
BeforeUnloadEvent and returnValue are already supported by IE and Firefox. Previously,
Blink was passing a base Event type to the beforeunload event handlers instead of
a BeforeUnloadEvent.
Note that this patch also deprecates Event.returnValue. This used to be an IE
extension but this is no longer supported by IE (nor Firefox). The standard
preventDefault() should be used instead (supported in IE >= 9).
BUG=277851
Review URL: https://chromiumcodereview.appspot.com/22893051
git-svn-id: svn://svn.chromium.org/blink/trunk@156916 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative revert for Chromium OS test failures on browser_tests:
KeyboardOperations/FileManagerBrowserTest.Test/3
KeyboardOperations/FileManagerBrowserTest.Test/4
KeyboardOperations/FileManagerBrowserTest.Test/5
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%282%29&number=17612
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASAN%20Tests%20%281%29&number=11554
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASAN%20Tests%20%282%29&number=11976
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29&number=9424
> Add support for BeforeUnloadEvent
>
> Add support for BeforeUnloadEvent as per the specification:
> http://www.whatwg.org/specs/web-apps/current-work/#beforeunloadevent
>
> BeforeUnloadEvent has a returnValue attribute. Setting returnValue to a non-empty
> string in an event handler causes the user agent should ask the user to confirm
> that they wish to unload the document. This is equivalent to returning a non-empty
> string in the EventHandler:
> http://www.whatwg.org/specs/web-apps/current-work/#onbeforeunloadeventhandler
>
> BeforeUnloadEvent and returnValue are already supported by IE and Firefox. Previously,
> Blink was passing a base Event type to the beforeunload event handlers instead of
> a BeforeUnloadEvent.
>
> Note that this patch also removes support for Event.returnValue. This used to be
> an IE extension but this is no longer supported by IE (nor Firefox) so the
> compatibility risk should be low. Applications use preventDefault() nowadays to
> do this and only fallback to Event.returnValue to support older versions of IE
> (IE < 9).
>
> BUG=277851
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156654
>
> Review URL: https://chromiumcodereview.appspot.com/22893051
TBR=ch.dumez@sisa.samsung.com
Review URL: https://codereview.chromium.org/23464008
git-svn-id: svn://svn.chromium.org/blink/trunk@156802 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for BeforeUnloadEvent as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/#beforeunloadevent
BeforeUnloadEvent has a returnValue attribute. Setting returnValue to a non-empty
string in an event handler causes the user agent should ask the user to confirm
that they wish to unload the document. This is equivalent to returning a non-empty
string in the EventHandler:
http://www.whatwg.org/specs/web-apps/current-work/#onbeforeunloadeventhandler
BeforeUnloadEvent and returnValue are already supported by IE and Firefox. Previously,
Blink was passing a base Event type to the beforeunload event handlers instead of
a BeforeUnloadEvent.
Note that this patch also removes support for Event.returnValue. This used to be
an IE extension but this is no longer supported by IE (nor Firefox) so the
compatibility risk should be low. Applications use preventDefault() nowadays to
do this and only fallback to Event.returnValue to support older versions of IE
(IE < 9).
BUG=277851
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156654
Review URL: https://chromiumcodereview.appspot.com/22893051
git-svn-id: svn://svn.chromium.org/blink/trunk@156774 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add support for BeforeUnloadEvent
>
> Add support for BeforeUnloadEvent as per the specification:
> http://www.whatwg.org/specs/web-apps/current-work/#beforeunloadevent
>
> BeforeUnloadEvent has a returnValue attribute. Setting returnValue to a non-empty
> string in an event handler causes the user agent should ask the user to confirm
> that they wish to unload the document. This is equivalent to returning a non-empty
> string in the EventHandler:
> http://www.whatwg.org/specs/web-apps/current-work/#onbeforeunloadeventhandler
>
> BeforeUnloadEvent and returnValue are already supported by IE and Firefox. Previously,
> Blink was passing a base Event type to the beforeunload event handlers instead of
> a BeforeUnloadEvent.
>
> Note that this patch also removes support for Event.returnValue. This used to be
> an IE extension but this is no longer supported by IE (nor Firefox) so the
> compatibility risk should be low. Applications use preventDefault() nowadays to
> do this and only fallback to Event.returnValue to support older versions of IE
> (IE < 9).
>
> BUG=277851
>
> Review URL: https://chromiumcodereview.appspot.com/22893051
TBR=ch.dumez@sisa.samsung.com
Review URL: https://codereview.chromium.org/23382014
git-svn-id: svn://svn.chromium.org/blink/trunk@156696 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for BeforeUnloadEvent as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/#beforeunloadevent
BeforeUnloadEvent has a returnValue attribute. Setting returnValue to a non-empty
string in an event handler causes the user agent should ask the user to confirm
that they wish to unload the document. This is equivalent to returning a non-empty
string in the EventHandler:
http://www.whatwg.org/specs/web-apps/current-work/#onbeforeunloadeventhandler
BeforeUnloadEvent and returnValue are already supported by IE and Firefox. Previously,
Blink was passing a base Event type to the beforeunload event handlers instead of
a BeforeUnloadEvent.
Note that this patch also removes support for Event.returnValue. This used to be
an IE extension but this is no longer supported by IE (nor Firefox) so the
compatibility risk should be low. Applications use preventDefault() nowadays to
do this and only fallback to Event.returnValue to support older versions of IE
(IE < 9).
BUG=277851
Review URL: https://chromiumcodereview.appspot.com/22893051
git-svn-id: svn://svn.chromium.org/blink/trunk@156654 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
| |
BUG=270033
Review URL: https://chromiumcodereview.appspot.com/23041002
git-svn-id: svn://svn.chromium.org/blink/trunk@156212 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than throwing the generic 'SecurityError' text, this patch adds
information about the reasons behind the throw in order to improve the
developer experience.
BUG=152212
Review URL: https://chromiumcodereview.appspot.com/22689002
git-svn-id: svn://svn.chromium.org/blink/trunk@155860 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|