| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/qcBNCz8A5eY/KX4y6GtPAQAJ
BUG=586595
TEST=offlineaudiocontext-constructor.html updated
Review URL: https://codereview.chromium.org/1686253006
Cr-Commit-Position: refs/heads/master@{#382635}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable mouse wheel scrolling for the hit test and transformed events so
that they are consistent for event generation.
Add main thread scrolling reason as it is always running on compositor.
These changes are necessary because with change
https://codereview.chromium.org/1806103002/ wheel gestures are
now sent on mouse wheel events. If change https://codereview.chromium.org/1776843003/
is attempted to be landed it will fail these layout tests.
Fix the layout tests independent of enabling the wheel
gestures.
BUG=568183
Review URL: https://codereview.chromium.org/1818993002
Cr-Commit-Position: refs/heads/master@{#382308}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding pointerout/over/enter/leave to one of the
touch tests to make sure we do fire those in the
case of pointerdown/up as well as pointerdown/cancel.
BUG=595439
Review URL: https://codereview.chromium.org/1815683002
Cr-Commit-Position: refs/heads/master@{#382291}
|
|
|
|
|
|
|
|
| |
This is just a cleanup and has no behavioral or logic change.
Review URL: https://codereview.chromium.org/1820723002
Cr-Commit-Position: refs/heads/master@{#382288}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CompositorAnimationPlayer owned by a ScrollableArea's ProgrammaticScrollAnimator
is not initially attached to any layer. As a result,
ScrollAnimatorCompositorCoordinator::addAnimation returns false the first time
a programmatic scroll is initiated.
This CL attaches the animation player to the correct layer when
::updateCompositorState is called. To do so, we need the CompositorAnimationTimeline
from the ScrollingCoordinator of a ScrollableArea. This CL exposes the timeline from
the subclasses of ScrollableArea.
BUG=592799
Review URL: https://codereview.chromium.org/1801753002
Cr-Commit-Position: refs/heads/master@{#381379}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable and remove flag for runtime-enabled feature "IterableCollections"
This adds Symbol.iterator to WebIDL interfaces containing both an attribute named "length",
and an integer-indexed property getter, per http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this applies to the
following interfaces:
CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList, DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement, HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList, TouchList, and
webkitSpeechGrammarList.
In addition to the above interfaces, the NodeList interface is granted the methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.
Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FWu2lHOCbNg
BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org, philipj@opera.com
Review URL: https://codereview.chromium.org/1777483012
Cr-Commit-Position: refs/heads/master@{#381249}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is taking care of firing gotpointercapture and
lostpointercapture events based on the status of the
pointer capture and whether the element is still in
the document or not.
BUG=592280
Review URL: https://codereview.chromium.org/1774913004
Cr-Commit-Position: refs/heads/master@{#381061}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At this moment, there is a race condition in this layout tests. This
layout tests includes the following steps:
1). Send a blob to worker
2). Right after that, both worker and main start creating ImageBitmap
from the blob.
3). Worker send the created ImageBitmap to main.
4). Get a Image from the blob using URL.createObjectURL(blob), Once this
Image is loaded, compare this Image with the ImageBitmaps created
in main and worker, they should have the same pixel data.
Now the problem here is that the main thread could wait for the Image to
be loaded and while in the meantime still wait for the created ImageBitmap
from worker. And there is a race condition here because one of them could
happen first and there is no guarantee to that.
This CL make changes such that the Image onload returns a promise. Also,
worker returning the ImageBitmap also returns a promise. We compare
the pixel data only when both promises are resolved. In this case, there
will be no race condition.
BUG=594196
Review URL: https://codereview.chromium.org/1792623002
Cr-Commit-Position: refs/heads/master@{#380992}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1788503005
Cr-Commit-Position: refs/heads/master@{#380960}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In createImageBitmap(Blob), the method creates an ImageDecoder
in a background thread, does the image decoding in the same thread, and
pass the ImageDecoder back to the main thread for creating an ImageBitmap.
This is causing the data race problem because the ImageDecoder
does some non-atomic reference counts internally.
This CL should fix the data race problem. In particular, we let the
ImageDecoder does image decoding in the background thread, and creates
a SkImage from the ImageDecoder, and pass the SkImage across threads.
Because SkImage is thread-safe RefCnted, this solves the data race
problem. In order to let postTask taking a SkImage, this CL changes
the CrossThreadCopier so that it can take an object that is SkRefCnt.
Locally I was able to repro the test case reported in the bug by
using the tsan build. With this CL the data race goes away.
Also, an existing layout tests that have data race condition
is changed.
BUG=593224
Review URL: https://codereview.chromium.org/1781613002
Cr-Commit-Position: refs/heads/master@{#380609}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL ships Node.rootNode independently from other ShadowDOM features, in response to requests from web developers.
LGTM-ed on this thread : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LpXX7Svx8IY
BUG=531990
Review URL: https://codereview.chromium.org/1783693002
Cr-Commit-Position: refs/heads/master@{#380363}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes uninitialized pointerTypes for WebTouchPoint.
Also fixes a few missing pointerType=mouse.
BUG=557817
Review URL: https://codereview.chromium.org/1760183002
Cr-Commit-Position: refs/heads/master@{#380238}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds scoped clip/scroll property in BoxClipper and BlockPainter.
It associates normal flow display items with the correct property nodes.
BUG=537409
Review URL: https://codereview.chromium.org/1652313003
Cr-Commit-Position: refs/heads/master@{#379995}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink and cc have different notions of scroll offset - Blink's is relative to
the scroll origin which is non-zero in RTL documents.
The CompositorScrollOffsetAnimationCurve must work entirely in cc scroll offsets
since it is handed over to cc which doesn't know about the scroll origin.
This patch teaches ScrollAnimator and ProgrammaticScrollAnimator to convert in
both directions when creating and using the curve object.
BUG=581264
Review URL: https://codereview.chromium.org/1776503002
Cr-Commit-Position: refs/heads/master@{#379974}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shipping the experiment has blockers as defined in
https://crbug.com/565736 that are not satisfied in M50.
This essentially reverts https://crrev.com/1662183002.
When re-enabling copy the TEST instructions from there.
BUG=591820
Review URL: https://codereview.chromium.org/1763923002
Cr-Commit-Position: refs/heads/master@{#379864}
|
|
|
|
|
|
|
|
|
|
|
| |
Transform is applied to display:inline-block/inline-transform so there's
no need to suppress compositor animations here.
BUG=592803
Review URL: https://codereview.chromium.org/1775743002
Cr-Commit-Position: refs/heads/master@{#379744}
|
|
|
|
|
|
|
|
| |
BUG=584380
Review URL: https://codereview.chromium.org/1739163004
Cr-Commit-Position: refs/heads/master@{#379656}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding setPointerCapture and releasePointerCapture APIs
It's the first one in a series of planned changes to implement capture.
Adds basic capturing capabilities for mouse using the set and release APIs.
We will cover got/lost firing in crbug/592280.
Transition events for mouse is blocking on crbug/587955.
BUG=580169
Review URL: https://codereview.chromium.org/1635863006
Cr-Commit-Position: refs/heads/master@{#379558}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method allows a service worker to get a promise that resolves with the
Client object matching a given id.
Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk
Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-153978848
Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-method
CL: https://codereview.chromium.org/1439333002/ and https://codereview.chromium.org/1731823003/
Test result: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=clients-get
BUG=552310
Review URL: https://codereview.chromium.org/1743163002
Cr-Commit-Position: refs/heads/master@{#378678}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove webkit-background-composite as it is a non-standard property
(only supported by WebKit and Blink) and has low usage. Deprecation
message was in M50.
For the blink-dev discussion on this property visit:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/background-composite/blink-dev/thxrbc8XOmc/lu1iZZfNAgAJ
Note: Meant to land after M50 branch point
BUG=498588
Review URL: https://codereview.chromium.org/1734863003
Cr-Commit-Position: refs/heads/master@{#378607}
|
|
|
|
|
|
|
|
| |
BUG=490608
Review URL: https://codereview.chromium.org/1755803002
Cr-Commit-Position: refs/heads/master@{#378594}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Intent to ship: https://groups.google.com/a/chromium.org/forum/?pli=1#!topic/blink-dev/yEdXn35VwVw
The primary motivation is to enable simpler/better testing for Web Bluetooth. The Web Bluetooth feature is preparing to ship behind the Experimental Framework, and has already landed the code to integrate with the EF.
BUG=538593
Review URL: https://codereview.chromium.org/1702363003
Cr-Commit-Position: refs/heads/master@{#378087}
|
|
|
|
|
|
|
|
| |
BUG=588182
Review URL: https://codereview.chromium.org/1729483002
Cr-Commit-Position: refs/heads/master@{#377981}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the regression caused by a V8 change at http://crrev.com/1435273002 .
http://crrev.com/1435273002 changed a way to show the name of objects, and
Blink is now showing the wrong name for the interface prototype objects.
Before http://crrev.com/1435273002 :
console> HTMLBodyElement.prototype
=> HTMLBodyElement {}
Now:
console> HTMLBodyElement.prototype
=> HTMLElement {}
With this CL:
console> HTMLBodyElement.prototype
=> HTMLBodyElement {}
This CL mainly focuses to fix the regression. Since the regression
happened back in M49 and the wrong name is very confusing for JS developers,
we might want to merge this fix into M49 branch. However, this fix has the
following side effect, so we might not want to merge this fix into M49.
[Side effect]
Before:
console> Object.prototype.toString.call(HTMLBodyElement.prototype)
=> [object Object]
After:
console> Object.prototype.toString.call(HTMLBodyElement.prototype)
=> [object HTMLBodyElement]
(This side effect is correct in terms of the spec, but it breaks
the backward compatibility with the older versions of Chrome.)
Note that interface prototype objects, platform objects, etc. are expected
to have a class string, which should be implemented with @@toStringTag in
ES2015. This is what V8 now expects Blink to use.
cf. http://heycam.github.io/webidl/#dfn-class-string
This CL adds @@toStringTag only to interface prototype objects, not to
other objects such as platform objects. The reason is because we might or
might not want to merge this fix into M49, so we'd like to minimize the
change for now.
BUG=585028
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/1685543002
Cr-Commit-Position: refs/heads/master@{#377890}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Store buttons field of pointer events to be able to set
button value to no-button when buttons field has no
change. A recent change in spec changed the meaning of
the button field to:
"the button whose state-change fired the event"
(unlike MouseEvent.button which means "the last button
that changed").
BUG=583331
Review URL: https://codereview.chromium.org/1710533002
Cr-Commit-Position: refs/heads/master@{#377576}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To simulate position:sticky, some websites have JS code that conditionally
attaches position:fixed depending on the scroll offset. This CL finishes the
the animations on MT before switching to compositor scrolling.
ScrollingCoordinator proxys the call to clear main thread scrolling reasons to
ScrollAnimator which calls weblayer->clearMTSReasons when the scroll offset
animation is finished. ScrollAnimator adds a temporary main thread scrolling
reason until the animation is finished.
BUG=581875
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1648293003
Cr-Commit-Position: refs/heads/master@{#377476}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This extends the interface, which previously just had append(), with
inspection/mutation methods: delete(), get(), getAll(), has(), set(),
as well as the "iterable" methods: forEach(), entries(), keys(),
values() and [Symbol.iterator]()
These have been experimental for ages; flip the switch to stable and
update "webexposed" expectations.
Docs: https://developer.mozilla.org/en-US/docs/Web/API/FormData
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/T-XfJ6tqw4g/-oxP_3pVDwAJ
BUG=412991
R=tkent@chromium.org
Review URL: https://codereview.chromium.org/1732103002
Cr-Commit-Position: refs/heads/master@{#377395}
|
|
|
|
|
|
|
|
|
|
|
| |
Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/jjwLLSG_hGY/Ovi-nvEeDwAJ
BUG=463116
Review URL: https://codereview.chromium.org/1726743002
Cr-Commit-Position: refs/heads/master@{#377283}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch enables the Credential Management API by default.
It also converts the existing CLI flag into a `base::Feature`, which will allow
us to hook it up to Finch as a kill-switch in case it asplodes the internets.
This feature flag can be removed after ~a release, once we're confident that
we're not breaking things.
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0
BUG=576705
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1720403003
Cr-Commit-Position: refs/heads/master@{#377276}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In slimming paint v2, backface visibility is a property of a paint
chunks (aka a sequence of display items with the same paint props). This
patch adds a new bool to PaintChunkProperties for whether a chunk's
backface is hidden.
LocalBorderBoxProperties has been refactored to only contain the local
border box properties and not all paint chunk properties, which should
make it more clear that paint chunk properties (such as the new
backfaceHidden property) are not set in the paint property tree builder.
There is a large remaining task to implement preserves3D which is the
common usecase for backface visibility.
Backface-visibility is treated as stacking context property in this
change, as it is currently in blink. A followup email to public-fx will
be sent out for more clarification.
BUG=587236
Review URL: https://codereview.chromium.org/1715113002
Cr-Commit-Position: refs/heads/master@{#376922}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To ship the SourceBuffer.mode attribute that enables switching between
'segments' and 'sequence' AppendModes, and to ship the non-default 'sequence'
AppendMode logic, this CL removes the SourceBuffer.mode attribute from being
conditioned by the 'MediaSourceExperimental' RuntimeEnabled flag.
Some other not-yet-compliant MSE features like VideoPlaybackQuality
and TrackDefaults remain behind that flag for the moment.
Note that this CL makes the mode attribute and logic always available in the
build (it is not moved behind some other RuntimeEnabled flag.) The referenced
tests run with the flag, so layout test coverage should not be changed by this
CL (with the obvious exception of the changed virtual/stable expectation).
Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/rBpD6CU8VM4/dgzEBq2-CwAJ
R=philipj@opera.com
BUG=249422,586376,239506
TEST=http/tests/media/media-source/mediasource-sourcebuffer-mode.html,
http/tests/media/media-source/mediasource-sequencemode-append-buffer.html,
http/tests/media/media-source/mediasource-appendstream-quota-exceeded.html,
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
Review URL: https://codereview.chromium.org/1701173002
Cr-Commit-Position: refs/heads/master@{#376800}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Three LGTMs were received on the Intent to Ship thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Vga32co0YMQ
This patch exposes the PushMessagingData object, as well as the
PushSubscription.getKey() method and the PushEvent.data property.
BUG=486040, 568106
Review URL: https://codereview.chromium.org/1693373002
Cr-Commit-Position: refs/heads/master@{#376739}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing this attribute enables testing the global webexposed interface
for these two objects.
R=philipj@opera.com
BUG=249422
Review URL: https://codereview.chromium.org/1713463003
Cr-Commit-Position: refs/heads/master@{#376394}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To conform to the new names in the spec:
* BluetoothGATTRemoteServer -> BluetoothRemoteGATTServer
* BluetoothGATTService -> BluetoothRemoteGATTService
* BluetoothGATTCharacteristic -> BluetoothRemoteGATTCharacteristic
BUG=582567
Review URL: https://codereview.chromium.org/1708053002
Cr-Commit-Position: refs/heads/master@{#376312}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The prefixed versions will be retained as aliases for the unprefixed ones.
Might take some decades before the world wide web has stopped using them,
so we probably cannot deprecate (and remove) them any time soon.
Most tests are still prefixed. Will clean that up in due course. For now, just
unprefix one random unit test and one random LayoutTest.
BUG=492297
Review URL: https://codereview.chromium.org/1710003002
Cr-Commit-Position: refs/heads/master@{#376249}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/pWSb_tq13Kg/Dmk59Fb9AQAJ
The removed Android test depended on defaultCharset. There is already
another test that verifies that the setting affects the default
encoding: LayoutTests/http/tests/download/default-encoding.html
BUG=567738
Review URL: https://codereview.chromium.org/1707473002
Cr-Commit-Position: refs/heads/master@{#376170}
|
|
|
|
|
|
|
|
|
|
| |
There are already plenty of tests for this in LayoutTests/fast/multicol/
BUG=492297
Review URL: https://codereview.chromium.org/1704883002
Cr-Commit-Position: refs/heads/master@{#376167}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that this only adds support for these properties on specified and computed
style level, and does not extend the functionality in the layout engine. In
particular, we don't support break-(after|before):(avoid|left|right) any better
than before (i.e. we just recognize the values and do nothing about them in the
engine).
The (page|-webkit-column)-break-(after|before|inside) properties are treated as
shorthands for their break-(after|before|inside) counterparts, in accordance
with the spec.
This CL intends to make as few behavioral changes on computed style level as
humanly possible, apart from actually allowing the new properties. In order to
achieve that, we go against the spec when it comes to mapping between the three
modern break-(after|before|inside) properties and the old-fashioned ones. More
specifically, we map "right" and "left" values to "always", and we even support
those values on -webkit-column-break-(after|before), which is just bogus, but
this is how it's always been. We also violate the spec when it comes to mapping
"avoid" values. While the spec says that e.g. page-break-inside:avoid should
simply map to break-inside:avoid, we map it to avoid-page, so that the computed
value of -webkit-column-break-inside isn't affected by such a declaration.
There WILL be some minor behavioral changes, no matter how hard we try, though:
Since there's now just one property for each of before, after and inside
(instead of two - one for page and one for column), declaration sequences like
"page-break-inside:avoid; -webkit-column-break-inside:auto;" will not behave
like before. This will now become "break-inside:auto" (from the
-webkit-column-break-inside declaration), effectively allowing page breaks
inside.
The new test behaves exactly as it would have without the code changes in this
CL, apart from recognizing break-after, break-before and break-inside.
BUG=223068,492297
Review URL: https://codereview.chromium.org/1681273003
Cr-Commit-Position: refs/heads/master@{#376148}
|
|
|
|
|
|
|
|
|
|
|
| |
Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/lqknEaUYCJM/UbNahDDMAwAJ
BUG=568261
Review URL: https://codereview.chromium.org/1700233002
Cr-Commit-Position: refs/heads/master@{#375759}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a followup CL to https://codereview.chromium.org/1629403003/ which
aligns classList and relList to the current spec.
It makes these DOMTokenLists settable, by adding a PutForwards=value parameter
in their IDL definitions.
BUG=584612
Review URL: https://codereview.chromium.org/1696393002
Cr-Commit-Position: refs/heads/master@{#375593}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL tackles the merging of the two token lists, in order to simplify both implementation and spec.
I2InS: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/sXT-rWAd0kk
BUG=584612
Review URL: https://codereview.chromium.org/1629403003
Cr-Commit-Position: refs/heads/master@{#375574}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds firing of pointerover/enter when touch
starts on an element, and pointerout/leave when touch
ends.
This CL also includes some refactoring around
our PointerEvents code. We isolated:
- PE handling details off from EventHandler,
- PE states & dispatches into PointerEventManager, and
- PE creation & id-management into PointerEventFactory.
BUG=583376
Review URL: https://codereview.chromium.org/1670073004
Cr-Commit-Position: refs/heads/master@{#375261}
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/chromium/src/+/e028ce68b
BUG=586181
TBR=fmalita@chromium.org
Review URL: https://codereview.chromium.org/1696473002 .
Cr-Commit-Position: refs/heads/master@{#374991}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables Web Bluetooth through experimental frameworks in supported platforms.
Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8
Adds the APIExperimentEnabled extended binding so that the bindings are visible
to domains specified by the Experimental Framework.
Also adds WebBluetooth to frames and BluetoothDispatcherHost to processes' filters for supported platforms.
TEST=Manual testing required:
Launch chrome with the following command line flag:
--enable-blink-features=ExperimentalFramework and perform the following tests:
On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
be "Bluetooth Works".
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
be "Bluetooth Unavailable".
On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
be "Bluetooth blocked".
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
be "Bluetooth Unavailable".
Launch Chrome with the following command line flags:
--enable-blink-features=ExperimentalFramework --enable-web-bluetooth
On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
be "Bluetooth Works".
On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
be "Bluetooth Works".
BUG=584113
Review URL: https://codereview.chromium.org/1662183002
Cr-Commit-Position: refs/heads/master@{#374954}
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium.googlesource.com/chromium/src/+/0c7e2f7bc
BUG=581355
TBR=fmalita@chromium.org
Review URL: https://codereview.chromium.org/1690803002 .
Cr-Commit-Position: refs/heads/master@{#374776}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement and plumb the renotify flag. This flag controls whether alert sound, lights,
and vibration are played again when a notification replaces a previous notification.
Changes for this issue are covered by Intent to Implement and Ship: Notification Renotify.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/k5n129-lM1A
BUG=442133
Review URL: https://codereview.chromium.org/1656243002
Cr-Commit-Position: refs/heads/master@{#374709}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add connect,close,terminate events to replace statechange event.
Add custom PresentationConnectionCloseEvent for close event.
TODOs in later patches:
- plumb close event from content/ and MR.
- deprecate statechange.
BUG=574233,574234,579360
Review URL: https://codereview.chromium.org/1651253002
Cr-Commit-Position: refs/heads/master@{#374567}
|
|
|
|
|
|
|
|
|
|
|
| |
Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/bpbq0Rcpauk/cnpJtHddAgAJ
BUG=357112
Review URL: https://codereview.chromium.org/1681923002
Cr-Commit-Position: refs/heads/master@{#374434}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can have another scroll come in while there is an animation that is waiting
to be aborted on the compositor. This CL adds handling for this case.
This CL also ensures that we only update compositor animations from the
updateCompositorAnimations function, where the document lifecycle state is
CompositingClean.
BUG=584067
Review URL: https://codereview.chromium.org/1678713002
Cr-Commit-Position: refs/heads/master@{#374313}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relative by default.
This patch does the following:
- makes deviceorientation relative by default on android,
- enables deviceorientationabsolute events in stable.
These features have been behind experimental-features flag since M48.
For the discussion about this change see e.g. blink-dev thread:
https://goo.gl/4TD4xV
The corresponsing specification:
http://w3c.github.io/deviceorientation/spec-source-orientation.html
Summarized the reasons are the following:
- compatibility of 'deviceorientation' with Safari on iOS,
- 'deviceorientation' does not require magnetometer anymore,
- better usability of 'deviceorientation' for VR applications,
- dedicated 'deviceorientationabsolute' event for AR applications.
BUG=520546,397824
TEST=http://timvolodine.github.io/deviceorientation-test/
Review URL: https://codereview.chromium.org/1677593002
Cr-Commit-Position: refs/heads/master@{#374133}
|