| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.
The purpose of this CL is similar to crrev.com/14021015.
BUG=574317
TEST=n/a
Review URL: https://codereview.chromium.org/1564773002
Cr-Commit-Position: refs/heads/master@{#369491}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated using the following command line:
$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh
BUG=None
R=dpranke@chromium.org,scottmg@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1415753003
Cr-Commit-Position: refs/heads/master@{#357493}
|
|
|
|
|
|
|
|
|
|
|
|
| |
People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
Un-nest for clarity.
Re-land of http://crrev.com/1318823008 while preserving config ordering.
Review URL: https://codereview.chromium.org/1307223010
Cr-Commit-Position: refs/heads/master@{#346964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1318823008/ )
Reason for revert:
This breaks why these configs exist in the first place and seriously breaks the clang/win gn build (which is what these configs exist for).
Original issue's description:
> Un-nest configs in GN files.
>
> People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
>
> Un-nest for clarity.
>
> Committed: https://crrev.com/4af2eac8e84692d94f88504ab6e0b244b88dddcb
> Cr-Commit-Position: refs/heads/master@{#346461}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1316843006
Cr-Commit-Position: refs/heads/master@{#346695}
|
|
|
|
|
|
|
|
|
|
| |
People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
Un-nest for clarity.
Review URL: https://codereview.chromium.org/1318823008
Cr-Commit-Position: refs/heads/master@{#346461}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It defines YY_USE_CONST when building mesa to fix this warning, disables
-Wincompatible-pointer-types for the other third-party libraries that
trigger it and fixes some underspecified dependencies in
third_party/libwebp.
BUG=504696
Review URL: https://codereview.chromium.org/1226583002
Cr-Commit-Position: refs/heads/master@{#338227}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Cloud Print Windows service uses WTL, and one of the headers uses
an assignment inside a conditional (atlgdi.h), which triggers this clang
warning.
BUG=505302
TBR=scottbyer@chromium.org,vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/1214113010
Cr-Commit-Position: refs/heads/master@{#336964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu
as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate.
R=brettw@chromium.org
TBR=ddorwin@chromium.org
EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
BUG=344767
Review URL: https://codereview.chromium.org/913373002
Cr-Commit-Position: refs/heads/master@{#317223}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses gn binary at head.
No intended functionality change.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/779473002
Cr-Commit-Position: refs/heads/master@{#306567}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/734603004
Cr-Commit-Position: refs/heads/master@{#304859}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Let BUILD.gn build the same files on Windows as the gyp file does.
* Remove -msse2 flag, that's on globally
* On win/clang, pass -msse4.2 -mclmul flags to fix clang/wi
complaining about unsupported intrinsics
BUG=82385
R=dpranke@chromium.org, hans@chromium.org
TBR=brettw
Review URL: https://codereview.chromium.org/742583003
Cr-Commit-Position: refs/heads/master@{#304695}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-disable chromium_code for third_party/zlib
- suppress a few size_t -> int conversion warnings
- suppress /wd4121 (structure padding) by default;
was suppressed in GYP but not GN.
Also disable ffmpeg, which doesn't work in the 64-bit build yet.
R=scottmg@chromium.org
TBR=brettw@chromium.org
BUG=432375, 167187
Review URL: https://codereview.chromium.org/737633002
Cr-Commit-Position: refs/heads/master@{#304542}
|
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org, brettw@chromium.org
BUG=354261
Review URL: https://codereview.chromium.org/709593004
Cr-Commit-Position: refs/heads/master@{#303366}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version uses a "pthread_once" implementation, using Windows
synchronisation primitives, imported from tcmalloc.
Previous CLs:
https://codereview.chromium.org/677713002/
https://codereview.chromium.org/552123005
This version of the CL also runs fine on Windows Server 2003.
These optimisations have been published on zlib mailing list and at
https://github.com/jtkukunas/zlib/
This change merges the following optimisation patches:
- "For x86, add CPUID check."
- "Adds SSE2 optimized hash shifting to fill_window."
- "add SSE4.2 optimized hash function"
- "add PCLMULQDQ optimized CRC folding"
From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the
current zlib version in Chromium.
The optimisations are enabled at runtime if all the necessary CPU features are
present. As the optimisations require extra cflags to enable the compiler to
use the instructions the optimisations are held in their own static library
with a stub implementation to allow linking on other platforms.
TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
improvement seen on RoboHornet benchmark on Linux Desktop
BUG=401517
Review URL: https://codereview.chromium.org/678423002
Cr-Commit-Position: refs/heads/master@{#302799}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:40001 of https://codereview.chromium.org/677713002/)
Reason for revert:
Speculatively reverting because XP Tests (1) is having failures.
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)
Original issue's description:
> Reland "Integrate SIMD optimisations for zlib"
>
> This reland adds an MSan suppression entry to work around gaps in MSan's
> support for some of the intrinsics this patch uses. This version also inlines
> the insert_string_sse function as it uses inline assembly and therefore does
> not need to be in the static library.
>
> Original CL: https://codereview.chromium.org/552123005
>
> These optimisations have been published on zlib mailing list and at
> https://github.com/jtkukunas/zlib/
>
> This change merges the following optimisation patches:
> - "For x86, add CPUID check."
> - "Adds SSE2 optimized hash shifting to fill_window."
> - "add SSE4.2 optimized hash function"
> - "add PCLMULQDQ optimized CRC folding"
>
> From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the
> current zlib version in Chromium.
>
> The optimisations are enabled at runtime if all the necessary CPU features are
> present. As the optimisations require extra cflags to enable the compiler to
> use the instructions the optimisations are held in their own static library
> with a stub implementation to allow linking on other platforms.
>
> TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
> improvement seen on RoboHornet benchmark on Linux Desktop
> BUG=401517
>
> Committed: https://crrev.com/a5022d5eab6f77889aceed6ab0ccaf44a657ffc4
> Cr-Commit-Position: refs/heads/master@{#301162}
TBR=agl@chromium.org,hans@chromium.org,robert.bradford@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=401517
Review URL: https://codereview.chromium.org/665203006
Cr-Commit-Position: refs/heads/master@{#301221}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reland adds an MSan suppression entry to work around gaps in MSan's
support for some of the intrinsics this patch uses. This version also inlines
the insert_string_sse function as it uses inline assembly and therefore does
not need to be in the static library.
Original CL: https://codereview.chromium.org/552123005
These optimisations have been published on zlib mailing list and at
https://github.com/jtkukunas/zlib/
This change merges the following optimisation patches:
- "For x86, add CPUID check."
- "Adds SSE2 optimized hash shifting to fill_window."
- "add SSE4.2 optimized hash function"
- "add PCLMULQDQ optimized CRC folding"
From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the
current zlib version in Chromium.
The optimisations are enabled at runtime if all the necessary CPU features are
present. As the optimisations require extra cflags to enable the compiler to
use the instructions the optimisations are held in their own static library
with a stub implementation to allow linking on other platforms.
TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
improvement seen on RoboHornet benchmark on Linux Desktop
BUG=401517
Review URL: https://codereview.chromium.org/677713002
Cr-Commit-Position: refs/heads/master@{#301162}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/552123005/)
Reason for revert:
Strong candidate for: multiple Linux MSan test failures with:
SUMMARY: MemorySanitizer: use-of-uninitialized-value ??:0 ??
Including: CompressionUtilsTest.GzipCompression
Original issue's description:
> Integrate SIMD optimisations for zlib
>
> These optimisations have been published on zlib mailing list and at
> https://github.com/jtkukunas/zlib/
>
> This change merges the following optimisation patches:
> - "For x86, add CPUID check."
> - "Adds SSE2 optimized hash shifting to fill_window."
> - "add SSE4.2 optimized hash function"
> - "add PCLMULQDQ optimized CRC folding"
>
> From Jim Kukunas <james.t.kukunas@linux.intel.com> and adapts them to the
> current zlib version in Chromium.
>
> The optimisations are enabled at runtime if all the necessary CPU features are
> present. As the optimisations require extra cflags to enable the compiler to
> use the instructions the optimisations are held in their own static library
> with a stub implementation to allow linking on other platforms.
>
> TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
> improvement seen on RoboHornet benchmark on Linux Desktop
> BUG=401517
>
> Committed: https://crrev.com/e045ec106de29562ae94eafccde49a7b73848471
> Cr-Commit-Position: refs/heads/master@{#300866}
TBR=agl@chromium.org,nathan.d.ciobanu@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=401517
Review URL: https://codereview.chromium.org/671163003
Cr-Commit-Position: refs/heads/master@{#300889}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These optimisations have been published on zlib mailing list and at
https://github.com/jtkukunas/zlib/
This change merges the following optimisation patches:
- "For x86, add CPUID check."
- "Adds SSE2 optimized hash shifting to fill_window."
- "add SSE4.2 optimized hash function"
- "add PCLMULQDQ optimized CRC folding"
From Jim Kukunas <james.t.kukunas@linux.intel.com> and adapts them to the
current zlib version in Chromium.
The optimisations are enabled at runtime if all the necessary CPU features are
present. As the optimisations require extra cflags to enable the compiler to
use the instructions the optimisations are held in their own static library
with a stub implementation to allow linking on other platforms.
TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
improvement seen on RoboHornet benchmark on Linux Desktop
BUG=401517
Review URL: https://codereview.chromium.org/552123005
Cr-Commit-Position: refs/heads/master@{#300866}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/461903002
Cr-Commit-Position: refs/heads/master@{#289133}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a TODO about private symbols on GCC.
Moves many third party BUILD.gn files from the secondary tree to the main one.
Fixes the dependencies on Linux so "gn check" passes again.
BUG=367595
R=scottmg@chromium.org
Previous review: https://codereview.chromium.org/256153003/
Review URL: https://codereview.chromium.org/264463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> GN build improvements.
>
> Fixes a TODO about private symbols on GCC.
>
> Moves many third party BUILD.gn files from the secondary tree to the main one.
>
> Fixes the dependencies on Linux so "gn check" passes again.
>
> BUG=367595
> R=scottmg@chromium.org
>
> Review URL: https://codereview.chromium.org/256153003
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/257243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Fixes a TODO about private symbols on GCC.
Moves many third party BUILD.gn files from the secondary tree to the main one.
Fixes the dependencies on Linux so "gn check" passes again.
BUG=367595
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/256153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266932 0039d316-1c4b-4281-b951-d872f2087c98
|