| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=N/A
TEST=N/A
Review URL: http://codereview.chromium.org/6816003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the explicit dependency on base/scoped_ptr.h.
Also set chromium_code=1, as all compile warnings/errors with that setting
have been fixed.
BUG=77804
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80431
Review URL: http://codereview.chromium.org/6794042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the explicit dependency on base/scoped_ptr.h.
Also set chromium_code=1, as all compile warnings/errors with that setting
have been fixed.
BUG=77804
TEST=
Review URL: http://codereview.chromium.org/6794042
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6792046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the explicit dependency on base/scoped_ptr.h.
Also set chromium_code=1, as all compile warnings/errors with that setting
have been fixed.
BUG=77804
TEST=
Review URL: http://codereview.chromium.org/6794042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch originally by Pascal Massimino:
http://codereview.chromium.org/6760004/
Review URL: http://codereview.chromium.org/6793035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/6720028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This is a reland of r80810.)
1) Got an upstream diff 346:371 from svn
2) Pruned files from the diff that we don't have, as well as
descriptor.pb.*
3) Applied and fixed the merge failures.
4) Copied the code (less descriptor.pb.*) back into the svn source.
5) Manually fixed descriptor.pb.* and plugin.pb.* there.
6) Ran ./generate_descriptor_proto.sh and copied the updated files back.
7) Added new source files to the protoc target in protobuf.gyp.
BUG=none
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/6737030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r80180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Got an upstream diff 346:371 from svn
2) Pruned files from the diff that we don't have, as well as
descriptor.pb.*
3) Applied and fixed the merge failures.
4) Copied the code (less descriptor.pb.*) back into the svn source.
5) Manually fixed descriptor.pb.* and plugin.pb.* there.
6) Ran ./generate_descriptor_proto.sh and copied the updated files back.
7) Added new source files to the protoc target in protobuf.gyp.
BUG=none
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/6737030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and contain the proper meta data when files within third_party are modified.
Also fixed _CheckNoInterfacesInBase() which was broken on win32 as the path seperator was hardcoded.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6713009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enables [wk_]png_get_image_width, [wk_]png_get_image_height, and
[wk_]png_get_interlace_type, required for
https://bugs.webkit.org/show_bug.cgi?id=54406.
This is needed to allow WebKit to build with libpng 1.5, which no longer allows
direct access to the underlying struct members without using the "easy access"
accessors.
BUG=webkit:54406
TEST=That patch can land without breaking Chromium
Review URL: http://codereview.chromium.org/6708113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'm going to use this to write layout test checksums to the
expected png files.
Review URL: http://codereview.chromium.org/6696085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Part of http://codereview.chromium.org/6730044/)
Submitting exe separately to allow testing on trybots.
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/6735002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
will crash if free'ed memory is accessed (hoping to detect the
memory corrupters).
Landed the original CL to get results from stability tests.
BUG=76891
TBR=jar
Review URL: http://codereview.chromium.org/6676098
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/6732018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
will crash if free'ed memory is accessed (hoping to detect the
memory corrupters).
BUG=76891
TBR=jar
Review URL: http://codereview.chromium.org/6676098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabled the TCMalloc double-free detection,
which should restore much of the performance loss
caused by this experiment (to find double frees,
if any). This should resolve bug 76640
As an alternate experiment to better illuminate our
memory corruption problem, this CL also enables
WinHeap (default Windows allocator) in the browser
process. There is a chance that this will cause a
very tiny reduction in performance, but it will surely
increase our crash rate (based on what we saw recently
on the dev channel).
BUG=76640
r=rtenneti
Review URL: http://codereview.chromium.org/6705027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
R=tony@chromium.org,darin@chromium.org
Review URL: http://codereview.chromium.org/6729004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I forgot to update the README.chromium in r62331 to mention that we have local
changes to this code now.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6685102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6714022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows from abysmal to merely poor. The vsnprintf() implementation in MSVC's libc does not conform to C99, and returns -1 if the given buffer is too small to hold the given format. Passing it NULL and a size of zero returns the number of chars required.
BUG=NONE
TEST=all GPU layout tests
R=kbr
Review URL: http://codereview.chromium.org/6711035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74589
TEST=unit tested
Review URL: http://codereview.chromium.org/6711017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
up after myself from revision 78316.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6665039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/6677080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't think I want to ship this to dev or stable, but
I think it may be valuable to try on our canary
builds.
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
ALthough I haven't been able to demonstrate a
problem on the bots, I'm pretty psyched to try
to find something in the field with this change.
The perf loss is very low, and I think that the
likely cause for TCMalloc cross-linked-list
corruption (double frees) will be detected
(I can hope!)
R=mbelshe
BUG=75921
Review URL: http://codereview.chromium.org/6683029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The next step is a presubmit rule that will make people use the template.
We are doing this so that we can better track dependancy versions.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6610030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
read a non-existant libwebp.a file from the disk.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch originally by Pascal Massimino.
Review URL: http://codereview.chromium.org/6677038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll revert as soon as the builds kick off.
TBR=willchan
Review URL: http://codereview.chromium.org/6677037
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6693013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'll revert as soon as the builds kick off.
TBR=willchan
Review URL: http://codereview.chromium.org/6677037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add third party python library PLY. This CL contains unmodified
soruces for lex.py, yacc.py, __init__.py and README. LICENSE is a
copy of the license from the README and README.chromium describes
the changes.
BUG=74978
TEST=none
Review URL: http://codereview.chromium.org/6673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[I just wanted to kick a reliability run with it as a test]
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
I did a first landing of this patch to test perf impact
and see what corruption it surfaced in:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77941
It appears that Windows is not using TCMalloc on our bots.
TBR=mbelshe
Review URL: http://codereview.chromium.org/6683027
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6682020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
I did a first landing of this patch to test perf impact
and see what corruption it surfaced in:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77941
It appears that Windows is not using TCMalloc on our bots.
TBR=mbelshe
Review URL: http://codereview.chromium.org/6683027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll land and revert this quickly, to see what
impact it has on performance.
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
TBR=mbelshe
Review URL: http://codereview.chromium.org/6679021
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6679029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll land and revert this quickly, to see what
impact it has on performance.
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
TBR=mbelshe
Review URL: http://codereview.chromium.org/6679021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also, create new class for representing a path to a frame.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6612052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to avoid having to change a bunch of build/release configuration files
everytime ICU version is changed.
This will bring in the following two CLs in ICU and googleurl:
http://codereview.chromium.org/6625032
http://codereview.chromium.org/6623060
BUG=74076
TEST=Chrome can be built and a binary built runs fine with an accompanying Chrome CL in place.
Review URL: http://codereview.chromium.org/6624060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I did some measurements with a Release build of chrome, both manually and via the page cycler tests. It seems that a simple empty blocking event listener can add anywhere from a 1 to 30ms delay to request times, largely depending on how many requests are in the queue (when many requests come at once, the last ones to be processed by the extension are delayed the longest).
From page cycler data (on my local machine), the average increase in page load time seems to be around 6ms. This is independent of total page load time (which makes sense).
BUG=60101
TEST=covered by apitests
Review URL: http://codereview.chromium.org/6574049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(incl. the full Uyghur translations)
Review URL: http://codereview.chromium.org/6628062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6625029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Compiles, Unittests
Review URL: http://codereview.chromium.org/6626010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
For a detailed description see part #1, http://codereview.chromium.org/6478005/
BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/6532034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
scrollable pages as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6574015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73716
TEST=none
Review URL: http://codereview.chromium.org/6549014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Despite obvious warnings about not using this flag
in deployment, we are turning off sqlite sync in ChromeOS
and relying on the underlying journaling filesystem
to do error recovery properly. It's much faster.
BUG=chromium-os:12328
TEST=Build both with and without SQLITE_NO_SYNC, and measured power
usage at the SATA rail. Power reduction is about 2-3%, and light use
so far produced no data corruption.
Review URL: http://codereview.chromium.org/6544025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toggle atom.
See: http://code.google.com/p/selenium/source/detail?r=11476
Patch by jleyba@chromium.org.
Original review at http://codereview.chromium.org/6541011
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6541042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generated from the WebDriver repository at r11446.
There are several notable changes with this new version:
* The atoms are no longer defined using wchar_t
* The atoms are defined as multi-line strings instead of an array of strings,
eliminating the need for unnecessary concatenations on each use.
* The atoms constants have been moved into a new namespace (webdriver::atoms).
* Previously, each atom defined a named JS function; now each atom defines
an anonymous function, so the call pattern had to be adjusted slightly.
With this change, we can enable the element finding functional tests (there
are still some bugs with the child element finding tests that need to be
tracked down).
I've also disabled a page loading test because it is flaky in my client.
BUG=none
TEST=none
Patch by jleyba@chromium.org.
Original review at http://codereview.chromium.org/6524045
Review URL: http://codereview.chromium.org/6531003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71130
Review URL: http://codereview.chromium.org/6523009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74966 0039d316-1c4b-4281-b951-d872f2087c98
|