summaryrefslogtreecommitdiffstats
path: root/ui/base/ime/input_method_observer.h
Commit message (Collapse)AuthorAgeFilesLines
* Split ui/base/ime into a new component (reland with windows GN fix)spang2015-02-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The IME code in ui/base/ime depends on ui/ozone to support keyboard control (via the InputController interface). This dependency is currently missing from the build. Unfortunately, we cannot simply add this dependency, because ui/ozone depends on code from ui/base/cursor and ui/base/resource (for cursor bitmaps). Break this cycle by componentizing ui/base/ime & add a dependency from the new ui/base/ime component to ui/ozone. This also helps clean things up a bit because iOS builds ui/base but not ui/base/ime. So there is already a fault line here. The handful of IME tests are left as part of ui_base_unittests. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) TBR=jam Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 Cr-Commit-Position: refs/heads/master@{#314815} Review URL: https://codereview.chromium.org/889323003 Cr-Commit-Position: refs/heads/master@{#314860}
* Revert of Split ui/base/ime into a new component (patchset #4 id:60001 of ↵ccameron2015-02-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/889323003/) Reason for revert: Windows builds failing with ERROR at //ui/base/ime/BUILD.gn:170:5: Undefined variable for +=. libs += [ "imm32.lib" ] ^--- I don't have something with this name in scope now. http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4403/steps/gn/logs/stdio (perhaps missed a .gn update)? Original issue's description: > Split ui/base/ime into a new component > > The IME code in ui/base/ime depends on ui/ozone to support keyboard > control (via the InputController interface). This dependency is > currently missing from the build. > > Unfortunately, we cannot simply add this dependency, because ui/ozone > depends on code from ui/base/cursor and ui/base/resource > (for cursor bitmaps). > > Break this cycle by componentizing ui/base/ime & add a dependency > from the new ui/base/ime component to ui/ozone. > > This also helps clean things up a bit because iOS builds ui/base > but not ui/base/ime. So there is already a fault line here. > > The handful of IME tests are left as part of ui_base_unittests. > > BUG=445627 > TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && > ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) > TBR=jam > > Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 > Cr-Commit-Position: refs/heads/master@{#314815} TBR=sky@chromium.org,thakis@chromium.org,jam@chromium.org,yukishiino@chromium.org,spang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445627 Review URL: https://codereview.chromium.org/895363005 Cr-Commit-Position: refs/heads/master@{#314823}
* Split ui/base/ime into a new componentspang2015-02-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | The IME code in ui/base/ime depends on ui/ozone to support keyboard control (via the InputController interface). This dependency is currently missing from the build. Unfortunately, we cannot simply add this dependency, because ui/ozone depends on code from ui/base/cursor and ui/base/resource (for cursor bitmaps). Break this cycle by componentizing ui/base/ime & add a dependency from the new ui/base/ime component to ui/ozone. This also helps clean things up a bit because iOS builds ui/base but not ui/base/ime. So there is already a fault line here. The handful of IME tests are left as part of ui_base_unittests. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) TBR=jam Review URL: https://codereview.chromium.org/889323003 Cr-Commit-Position: refs/heads/master@{#314815}
* Limit display of the virtual keyboard to state changes triggered from a user ↵kevers@chromium.org2014-01-201-0/+4
| | | | | | | | | | | | | | gesture. This patch reuses OnTextInputStateChanged, which was previously Android specific, but which includes not only type information, but whether the virtual keyboard should be displayed. This is the first step in consolidating the IPC messages between RenderWidget and RenderWidgetHostView for IME messages. Ideally, we can phase out OnTextInputTypeChanged in favor of the approach used by Android across all platforms. BUG=289659, 294191, 331690 Review URL: https://codereview.chromium.org/29943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245932 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Rename ui_export.h to ui_base_export.htfarina@chromium.org2014-01-061-2/+2
| | | | | | | | | | | | Also renames UI_EXPORT to UI_BASE_EXPORT. BUG=299841 TEST=None, no functional changes TBR=ben@chromium.org Review URL: https://codereview.chromium.org/93863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243050 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unused callbacks from ui::InputMethodObserveryukawa@chromium.org2013-11-231-9/+0
| | | | | | | | | | | | | This CL removes following callbacks from ui::InputMethodObserver because no one depends on them. - ui::InputMethodObserver::OnUntranslatedIMEMessage - ui::InputMethodObserver::OnInputLocaleChanged BUG=322038 TEST=covered by unittest Review URL: https://codereview.chromium.org/82603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236962 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unsafe typecast in interactive_ui_tests when the virtual keyboard is ↵kevers@chromium.org2013-10-031-0/+25
| | | | | | | | | | | enabled. BUG=247746 TEST=interactive_ui_tests: TextInput_TextInputStateChangedTest Review URL: https://codereview.chromium.org/25705003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226820 0039d316-1c4b-4281-b951-d872f2087c98
* Delayed loading of the virtual keyboard.bryeung@chromium.org2013-04-171-0/+4
| | | | | | | | | | | | | | | Don't create the virtual keyboard until it is first shown. This helps prevent some start-up races. Also clean-up some of the object ownership between KeyboardController and KeyboardLayoutManager. Each pointer exists in only one or the other object now. BUG=none Review URL: https://codereview.chromium.org/13932030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194580 0039d316-1c4b-4281-b951-d872f2087c98
* Control visibility of the virtual keyboard.bryeung@chromium.org2013-04-121-0/+26
Add an observer to InputMethod. This makes the InputMethod the gatherer of text input state changes, which are then distributed to interested parties. The KeyboardController becomes an InputMethod::Observer, and shows/hides the keyboard as appropriate. BUG=227128 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193662 Review URL: https://codereview.chromium.org/13207003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193965 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-23 15:17:57 +0000