| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move content specific stuff to content subdir.
KeyboardControllerProxy -> KeyboardUI
Restructure targets.
R=sky@chromium.org
http://crbug.com/332504
Review URL: https://codereview.chromium.org/1392713002
Cr-Commit-Position: refs/heads/master@{#353441}
|
|
|
|
|
|
|
|
| |
BUG=489366
Review URL: https://codereview.chromium.org/1167733002
Cr-Commit-Position: refs/heads/master@{#333954}
|
|
|
|
|
|
|
|
| |
BUG=484699
Review URL: https://codereview.chromium.org/1128173003
Cr-Commit-Position: refs/heads/master@{#330169}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes KeyboardControllerProxy take in a BrowserContext in the
constructor. A new KeyboardControllerProxy is created via
ash::Shell::CreateKeyboard() when the BrowserContext changes
BUG=431448
TEST=None
Review URL: https://codereview.chromium.org/711843002
Cr-Commit-Position: refs/heads/master@{#304707}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=sky@chromium.org
Review URL: https://codereview.chromium.org/670923003
Cr-Commit-Position: refs/heads/master@{#301914}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623293004
Cr-Commit-Position: refs/heads/master@{#298839}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=370412
TEST=
1. open virtual keyboard in google.com
2. virtual keyboard window should have the default shadow
Review URL: https://codereview.chromium.org/280273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in native code and in VK's javascript code through window.resizeTo
It sometimes creates conflict and cause strange animation issues.
In this CL, the window height logic in native side is removed.
The default window height is set to 0 and we expect javascript
will set the window to correct height.
If window is resized from a non zero height to another non
zeor height, we current dont do any animation.
BUG=363622
Review URL: https://codereview.chromium.org/240443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=352360
Review URL: https://codereview.chromium.org/211933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=354657
Review URL: https://codereview.chromium.org/208633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is created.
BUG=353023
TEST=None
Review URL: https://codereview.chromium.org/201563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=352360
Review URL: https://codereview.chromium.org/196653017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When user login, a new virtual keyboard is created. If the old virtual keyboard
was showing before user login, we need to notfiy keyboard bounds observers that
old virtual keyboard window occupy no space on screen. Otherwise, Ash still thinks
the work area should exclude virtual keyboard area even the keyboard is not showing.
This CL fixed the bug.
BUG=342524
Review URL: https://codereview.chromium.org/159473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds animation observer to both show and hide virtual
keyboard animation. And some tasks that should be done after
animation finished is moved to the correct place.
BUG=336257
Review URL: https://codereview.chromium.org/140823016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
visibility API in its web contents.
BUG=chromium:316524
TEST=Locally verified in sandbox.
Review URL: https://codereview.chromium.org/97013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:316524
TEST=Locally verified on sandbox of ChromeOS on Linux.
Review URL: https://codereview.chromium.org/91443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=268949
Review URL: https://chromiumcodereview.appspot.com/23792006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OnTextInputBoxFocused is called when an input box gets focus. The function has
a parameter called inputContext which contains "type" field. The type can be
"password", "number" or "text".
BUG=268949
Review URL: https://chromiumcodereview.appspot.com/23724027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
voice input
BUG=238350
TEST=
1. navigate to chrome://flags
2. turn on virtual keyboard flag
3. login again. focus on any input box (virtual keyboard should show up)
4. press "mic" button, it should turn to green.
5. speak
6. result should be displayed in the input box
Review URL: https://chromiumcodereview.appspot.com/14646041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
shown/hidden.
BUG=none
R=ben@chromium.org, bryeung@chromium.org
Review URL: https://codereview.chromium.org/14310003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When the keyboard is shown, scroll any focused editable node of the
currently active WebContents into view.
BUG=235157
Review URL: https://chromiumcodereview.appspot.com/14212006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this change, executables that want to use the keyboard need to:
* add 'keyboard' and 'keyboard_resources' as dependencies. Repacking
keyboard_resources.pak is no longer necessary.
* call keyboard::InitializeKeyboard() during startup. This installs
the necessary pak file, and sets up a WebUIControllerFactory to
make sure the keyboard gets the correct WebUIController.
* create a KeyboardControllerProxy and a KeyboardController.
BUG=none
Review URL: https://codereview.chromium.org/14241037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an observer to InputMethod. This makes the InputMethod the gatherer of text input state changes, which are then distributed to interested parties.
The KeyboardController becomes an InputMethod::Observer, and shows/hides the keyboard as appropriate.
BUG=227128
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193662
Review URL: https://codereview.chromium.org/13207003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Control visibility of the virtual keyboard.
>
> Add an observer to InputMethod. This makes the InputMethod the gatherer of text input state changes, which are then distributed to interested parties.
>
> The KeyboardController becomes an InputMethod::Observer, and shows/hides the keyboard as appropriate.
>
> BUG=227128
>
> Review URL: https://chromiumcodereview.appspot.com/13207003
TBR=bryeung@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an observer to InputMethod. This makes the InputMethod the gatherer of text input state changes, which are then distributed to interested parties.
The KeyboardController becomes an InputMethod::Observer, and shows/hides the keyboard as appropriate.
BUG=227128
Review URL: https://chromiumcodereview.appspot.com/13207003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Introduces ui/keyboard/ which contains generic code for the control of the keyboard (right now, just creation of the container window).
Also includes the necessary changes to ash so that the keyboard is (always) displayed on ChromeOS builds when the --enable-virtual-keyboard flag is present.
BUG=226986
Review URL: https://codereview.chromium.org/13164002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193378 0039d316-1c4b-4281-b951-d872f2087c98
|