summaryrefslogtreecommitdiffstats
path: root/ui/platform_window
Commit message (Collapse)AuthorAgeFilesLines
* gn format //uiscottmg2014-12-032-4/+2
| | | | | | | | | | | | | No intended functionality change. (Binary used includes https://codereview.chromium.org/774753004/) R=brettw@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/776763002 Cr-Commit-Position: refs/heads/master@{#306568}
* Move all event related devices from ui/events/ to ui/events/devices/dnicoara2014-11-041-1/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/685793002 Cr-Commit-Position: refs/heads/master@{#302647}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-291-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=sky@chromium.org Review URL: https://codereview.chromium.org/670923003 Cr-Commit-Position: refs/heads/master@{#301914}
* Send the proper event time when dispatching mouse event on windows aura.lfg2014-10-221-1/+1
| | | | | | | | | | * Fixes app_shell_browsertests on windows. BUG=399363 Review URL: https://codereview.chromium.org/663203006 Cr-Commit-Position: refs/heads/master@{#300591}
* Revert of Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when ↵brettw2014-10-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/647573002/) Reason for revert: This was not the cause of the regression. See http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6569 Original issue's description: > Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/644443002/) > > Reason for revert: > Only cl that seems related to http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561 falures. > > Original issue's description: > > ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed > > > > This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run. > > > > BUG=421536 > > > > Committed: https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c > > Cr-Commit-Position: refs/heads/master@{#298926} > > TBR=ben@chromium.org,hansmuller@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=421536 > > Committed: https://crrev.com/b93c31988a55a9cb2a328e39520f56788585b542 > Cr-Commit-Position: refs/heads/master@{#298985} TBR=ben@chromium.org,hansmuller@chromium.org,jwd@chromium.org NOTREECHECKS=true NOTRY=true BUG=421536 Review URL: https://codereview.chromium.org/642953003 Cr-Commit-Position: refs/heads/master@{#298999}
* Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ↵jwd2014-10-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/644443002/) Reason for revert: Only cl that seems related to http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561 falures. Original issue's description: > ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed > > This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run. > > BUG=421536 > > Committed: https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c > Cr-Commit-Position: refs/heads/master@{#298926} TBR=ben@chromium.org,hansmuller@chromium.org NOTREECHECKS=true NOTRY=true BUG=421536 Review URL: https://codereview.chromium.org/647573002 Cr-Commit-Position: refs/heads/master@{#298985}
* ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is ↵hansmuller2014-10-091-0/+1
| | | | | | | | | | | | closed This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run. BUG=421536 Review URL: https://codereview.chromium.org/644443002 Cr-Commit-Position: refs/heads/master@{#298926}
* replace OVERRIDE and FINAL with override and final in ui/mostynb2014-10-092-28/+28
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623293004 Cr-Commit-Position: refs/heads/master@{#298839}
* Fix most of the "gn check" errors in ui/*Brett Wilson2014-08-281-0/+6
| | | | | | | | | | | | | Some errors remain but these are circular includes that can't be fixed in the build files only. Enable views_unittests and wm_unittests now that they compile BUG= R=sky@chromium.org, tfarina@chromium.org Review URL: https://codereview.chromium.org/513313002 Cr-Commit-Position: refs/heads/master@{#292445}
* platform_window: Add SetCursor & MoveCursorTospang@chromium.org2014-07-316-0/+17
| | | | | | | | | | | | These are for hooking up WindowTreeHost::SetCursorNative & WindowTreeHost::MoveCursorToNative. This is the interface change only to allow an incremental conversion. BUG=392280 Review URL: https://codereview.chromium.org/431683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286709 0039d316-1c4b-4281-b951-d872f2087c98
* GN: Add GN rules for mojo_shell targetjamesr@chromium.org2014-07-294-0/+43
| | | | | | | | | | | This adds GN rules for mojo_shell and all of its dependencies on linux in the static build. BUG=397679 Review URL: https://codereview.chromium.org/414323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286143 0039d316-1c4b-4281-b951-d872f2087c98
* Distinguish between keystroke and character events.kpschoedel@chromium.org2014-07-252-3/+3
| | | | | | | | | | | | | | | | | | | | As described in its class comment, a ui::KeyEvent can be either of two distinct kinds. When constructing a ui::KeyEvent from a native event, the distinction is made by a new IsCharFromNative() call, in the same way that other ui::Event properties are determined, instead of having the caller inspect the native event itself. Removing the redundant |is_char| parameter from constructors also prevent accidental synthetic `mixed' events that consuming code does not handle. Incidentally, while KeyEvent constructor calls are being touched, use EF_NONE instead of 0 to make that argument's purpose clear. BUG=380349 TEST=unit_tests,ash_unittests,events_unittests,ui_unittests,interactive_ui_tests Review URL: https://codereview.chromium.org/404203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285605 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Use PlatformWindow from WindowTreeHostWin.sadrul@chromium.org2014-07-233-0/+24
| | | | | | | | | | | | | | | | | With this patch, both Windows and Ozone implementations use PlatformWindow for interacting with the native windowing system. Eventually, the X11 implementations will also use this, and WindowTreeHost will have a single implementation on all platforms. BUG=none R=ben@chromium.org Previously landed in r284850, but reverted in r284905 because it broke a multi- window ash unit-test on Windows. The test is now disabled (r284931). Review URL: https://codereview.chromium.org/400413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284986 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 284850 "aura: Use PlatformWindow from WindowTreeHostWin."markusheintz@chromium.org2014-07-233-24/+0
| | | | | | | | | | | | | | | | | | | | > aura: Use PlatformWindow from WindowTreeHostWin. > > With this patch, both Windows and Ozone implementations use PlatformWindow for > interacting with the native windowing system. Eventually, the X11 implementations > will also use this, and WindowTreeHost will have a single implementation on all > platforms. > > BUG=none > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/400413002 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/410873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284905 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Use PlatformWindow from WindowTreeHostWin.sadrul@chromium.org2014-07-233-0/+24
| | | | | | | | | | | | | | With this patch, both Windows and Ozone implementations use PlatformWindow for interacting with the native windowing system. Eventually, the X11 implementations will also use this, and WindowTreeHost will have a single implementation on all platforms. BUG=none R=ben@chromium.org Review URL: https://codereview.chromium.org/400413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284850 0039d316-1c4b-4281-b951-d872f2087c98
* win32: Add a PlatformWindow implementation for Windows.sadrul@chromium.org2014-07-227-4/+305
| | | | | | | | | | | | Use this implementation for mojo native_viewport. It will also be used for aura WindowTreeHost in subsequent patches. BUG=none R=ben@chromium.org Review URL: https://codereview.chromium.org/405813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284752 0039d316-1c4b-4281-b951-d872f2087c98
* x11: Listen for and process XInput2 events.sadrul@chromium.org2014-07-182-0/+58
| | | | | | | | | | | | Use XInput2 events for mouse, keyboard, and touch events in X11Window. This allows interacting with mojo_shell with touch. BUG=361137 R=sky@chromium.org Review URL: https://codereview.chromium.org/399743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283996 0039d316-1c4b-4281-b951-d872f2087c98
* x11: Do not listen for XI2 mouse events for X11Window.sadrul@chromium.org2014-07-161-3/+0
| | | | | | | | | | | | X11 implementation of PlatformWindow does not correctly process XInput2 yet. So do not listen for mouse-events there. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/394323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283524 0039d316-1c4b-4281-b951-d872f2087c98
* ui/platform_window: Introduce PlatformWindow for windowing primitives.sadrul@chromium.org2014-07-1510-0/+581
Instead of implementing the native windowing primitives for aura, mojo, ozone etc., have a single implementation in ui/platform_window, and use that in the rest of the places. To start off, this CL provides an X11 implementation of the new interface, and use it for mojo native-viewport. BUG=361137 R=ben@chromium.org, spang@chromium.org Review URL: https://codereview.chromium.org/391583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283213 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-31 14:34:22 +0000