summaryrefslogtreecommitdiffstats
path: root/ui/wm/public
Commit message (Collapse)AuthorAgeFilesLines
* ash/wm: Remove dead code.sadrul2016-01-302-111/+0
| | | | | | | | | | | | | | | | | | | This removes the following code: . DispatcherRunLoop, because it is used only in three unit-tests, two of which are disabled. . DispatcherClient, because it is used only by DispatcherRunLoop. . Implementions of DispatcherClient for dekstop (DesktopDispatcherClient) and chromeos (NestedAcceleratorController). . NestedAcceleratorDispatcher, since NestedAcceleratorController was the only thing using it. . NestedAcceleratorDelegate, since NestedAcceleratorDispatcher was the only thing using it. BUG=none Review URL: https://codereview.chromium.org/1647933002 Cr-Commit-Position: refs/heads/master@{#372548}
* Remove ui/gfx/screen_type_delegate.hscottmg2016-01-271-2/+1
| | | | | | | | | | | | | | This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is now only one Screen instance. It's still a runtime-installed thing for test purposes. TBR=various owners for trivial changes R=oshima@chromium.org, sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1608733002 Cr-Commit-Position: refs/heads/master@{#371676}
* Switch to standard integer types in ui/wm/.avi2015-12-243-2/+2
| | | | | | | | | BUG=138542 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1544153002 Cr-Commit-Position: refs/heads/master@{#366831}
* Added an ActivationReason parameter to ↵bruthig2015-06-051-4/+16
| | | | | | | | | | | | | | | | | | | | ActivationChangeObserver::OnWindowActivated(...). TEST=FocusControllerApiTest.DuplicateActivationEvents TEST=FocusControllerApiTest.ActivationEvents TEST=FocusControllerMouseEventTest.DuplicateActivationEvents TEST=FocusControllerMouseEventTest.ActivationEvents TEST=FocusControllerGestureEventTest.DuplicateActivationEvents TEST=FocusControllerGestureEventTest.ActivationEvents TEST=FocusControllerHideTest.ActivationEvents TEST=FocusControllerDestructionTest.ActivationEvents TEST=FocusControllerRemovalTest.ActivationEvents BUG=489813, 489814 Review URL: https://codereview.chromium.org/1151133003 Cr-Commit-Position: refs/heads/master@{#333048}
* Disable drag-and-drop on login flow to avoid hanging.ginkage2015-03-132-0/+95
| | | | | | | | | BUG=464118 TEST=manual Review URL: https://codereview.chromium.org/992173004 Cr-Commit-Position: refs/heads/master@{#320574}
* Pass location in screen coordinates to DragDropClient::StartDragAndDrop()pkotwicz2015-02-241-3/+3
| | | | | | | | | | | | | | | | This CL: - Avoids converting from screen coordinates in WebContentsViewAura::StartDragging() and back to screen coordinates in DragDropController::StartDragAndDrop() - Passes the location in the correct coordinates to StartDragAndDrop() in DragDownloadItem() in drag_download_item_views.cc BUG=456619 TEST=Manual, see bug Review URL: https://codereview.chromium.org/901563005 Cr-Commit-Position: refs/heads/master@{#317888}
* Tooltip Cleanuposhima2015-02-191-0/+8
| | | | | | | | | | | | | | | This is prep for tooltip improvement: https://codereview.chromium.org/924433002/ (WIP) * Consolidated GetMaxWidth * Eliminate screen type argument. This can be obtained from tooltip window. * Move tooltip truncate code from TooltipManager to TooltipController BUG=None TEST=no functional change. all test should pass. Review URL: https://codereview.chromium.org/916423002 Cr-Commit-Position: refs/heads/master@{#317081}
* Cleanup: Update the path to gfx size headers.tfarina2015-01-031-1/+1
| | | | | | | | | | | | | The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=compiles TBR=sky@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/832953002 Cr-Commit-Position: refs/heads/master@{#309873}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=avi@chromium.org Review URL: https://codereview.chromium.org/681873003 Cr-Commit-Position: refs/heads/master@{#301447}
* replace OVERRIDE and FINAL with override and final in ui/mostynb2014-10-091-1/+1
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623293004 Cr-Commit-Position: refs/heads/master@{#298839}
* Remove unused method.ben@chromium.org2014-07-151-4/+0
| | | | | | | | | TBR=sky@chromium.org BUG=none Review URL: https://codereview.chromium.org/396473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283222 0039d316-1c4b-4281-b951-d872f2087c98
* Aura tooltips do not move on mouse move in case of many neighboringmboc@opera.com2014-06-132-1/+17
| | | | | | | | | | | | | | | views with the same tooltip label BUG=Aura tooltips do not move on mouse move in case of many neighboring views with the same tooltip label. This can be really uncomfortable when working with lots of tabs with the same address on the tab strip. Try creating ~30 startpage tabs and hover over one of them, then move the cursor to others. The tooltip will just sit in the place where it was first shown. Review URL: https://codereview.chromium.org/213833018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277010 0039d316-1c4b-4281-b951-d872f2087c98
* wm: Change the DispatcherClient interface.sadrul@chromium.org2014-05-292-2/+54
| | | | | | | | | | | | | | Instead of having RunWithDispatcher() to start a nested message-loop, and a corresponding QuitNestedMessageLoop() to terminate it, have a DispatcherRunLoop object that is similar to base::RunLoop for starting a nested message loop for a specified DispatcherClient. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/280483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273634 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Move GetCursor() method from WindowDelegate to its own delegate ↵ben@chromium.org2014-03-272-59/+0
| | | | | | | | | | | | | | | | | | | | | | | interface CursorDelegate. (https://codereview.chromium.org/211733003/) Reason for revert: http://crbug.com/357015 Original issue's description: > Move GetCursor() method from WindowDelegate to its own delegate interface CursorDelegate. > > R=sky@chromium.org > http://crbug.com/308845 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259631 TBR=sky@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/213383007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259805 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetCursor() method from WindowDelegate to its own delegate interface ↵ben@chromium.org2014-03-262-0/+59
| | | | | | | | | | | CursorDelegate. R=sky@chromium.org http://crbug.com/308845 Review URL: https://codereview.chromium.org/211733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259631 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 259580 "Move wm/public into wm target"ben@chromium.org2014-03-2612-50/+55
| | | | | | | | | | | | | | | > Move wm/public into wm target > > TBR=sky@chromium.org > http://crbug/com/308710 > > Review URL: https://codereview.chromium.org/209383003 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/213033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259589 0039d316-1c4b-4281-b951-d872f2087c98
* Move wm/public into wm targetben@chromium.org2014-03-2612-55/+50
| | | | | | | | | TBR=sky@chromium.org http://crbug/com/308710 Review URL: https://codereview.chromium.org/209383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259580 0039d316-1c4b-4281-b951-d872f2087c98
* Move some code from aura/client to wm/publicben@chromium.org2014-03-2123-0/+893
| | | | | | | | | | | Still building as part of the aura target, will fix that in a future step. TBR=sky@chromium.org http://crbug.com/308710 Review URL: https://codereview.chromium.org/206453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258651 0039d316-1c4b-4281-b951-d872f2087c98
* Move wm/core to wm namespace.ben@chromium.org2014-03-142-91/+0
| | | | | | | | | | | | | | | | Also sets up new targets for wm_core, wm_core_unittests, etc. R=sky@chromium.org TBR=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256839 Review URL: https://codereview.chromium.org/196063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257183 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move wm/core to wm namespace."dmichael@chromium.org2014-03-132-0/+91
| | | | | | | | | | | | This reverts commit 521c703f8d62fa698c3e88287c64d8d23f9ac675. Broke gyp BUG= Review URL: https://codereview.chromium.org/199263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256846 0039d316-1c4b-4281-b951-d872f2087c98
* Move wm/core to wm namespace.ben@chromium.org2014-03-132-91/+0
| | | | | | | | | | | | | | Also sets up new targets for wm_core, wm_core_unittests, etc. R=sky@chromium.org TBR=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256680 Review URL: https://codereview.chromium.org/196063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256839 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move wm/core to wm namespace."dmichael@chromium.org2014-03-122-0/+91
| | | | | | | | | | | | | | This reverts commit 067d7fe616a07011b9e2d2609fc65af8db6a7dfb. Broke the build: http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/63598/steps/compile/logs/stdio BUG= TBR=ben Review URL: https://codereview.chromium.org/198283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256686 0039d316-1c4b-4281-b951-d872f2087c98
* Move wm/core to wm namespace.ben@chromium.org2014-03-122-91/+0
| | | | | | | | | | | | Also sets up new targets for wm_core, wm_core_unittests, etc. R=sky@chromium.org TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/196063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256680 0039d316-1c4b-4281-b951-d872f2087c98
* events: Add a few more masked window targeter for Widgets with hit-test masks.sadrul@chromium.org2014-01-181-2/+2
| | | | | | | | | | | | | | | Notable changes: * Add a BubbleWindowTargeter that can be used for bubbles (and use it for tray-bubble and app-list bubble). * Change the wm::MaskedWindowTargeter to fall-back to the default WindowTargeter if setting the mask fails. BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/132233015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245757 0039d316-1c4b-4281-b951-d872f2087c98
* keyboard: Install a masked window-targeter in the keyboard container.sadrul@chromium.org2014-01-161-0/+1
| | | | | | | | | | | | | Install a masked window-targeter in the keyboard container so that event targetting works correctly when used with EventProcessor for dispatching events. BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/139613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245048 0039d316-1c4b-4281-b951-d872f2087c98
* Moves management of transients out of Windowsky@chromium.org2014-01-071-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And into TransientWindowManager. Additionally moves handling of NULL layer stacking into TransientStackingWindowClient. The tests that were exercising these code paths have all been moved to ui/views/corewm. Also wires up TransientStackingWindowClient in a couple of places that didn't have it. The order of removing from transient parent as well as destroying of transient children is slightly differently than before. To get the order exactly as it was would require some new specific observer functions. I'm hoping we don't need those. Hopefully this doesn't cause issues, if it does I'll revisit. I ended up exposing convenience functions. That's because typing something like: views::corewm::TransientWindowManager::Get(window)->AddTransientChild() was too much for me. There is also some subtlety in so far as the Get() function that takes a const Window* may return NULL, where as non-const never returns NULL. Lastly I had to make Window friend TransientWindowManager. This is temporary until I create a specific TransientWindowManagerObserver that contains the two transient related observer functions in WindowObserver. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/115453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243368 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Add a window-targeter for windows with hit-test masks.sadrul@chromium.org2014-01-071-0/+38
| | | | | | | | | | | | | | Use the masked-window targeter for the touch-selection handlers. Subsequent patches will install similar targeters for the other windows that use hit-test masks, which will allow getting rid of some hit-test mask related API from aura and views. BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/122573005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243287 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Add an EasyResizeWindowTargeter.sadrul@chromium.org2014-01-061-0/+48
| | | | | | | | | | | | | | | | | | Add EasyResizeWindowTargeter to allow easily resizing windows with mouse/touch with the new event-dispatch code. This will eventually allow getting rid of Window::SetHitTestBoundsOverrideOuter() once the new event-dispatch code is used for all event types. This patch installs an EasyResizeWindowTargeter for the shelf and status-area widgets. Subsequent CLs will install such targeters for the toplevel windows too. Collateral change includes adding some dependencies on wm_public (in DEPS and gyp). BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/118553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243177 0039d316-1c4b-4281-b951-d872f2087c98
* wm: public window_types.tfarina@chromium.org2013-12-191-0/+36
Patch manually generated by: $ git grep -l aura::client::WINDOW_TYPE | xargs sed -i -e 's/aura::client::WINDOW_TYPE/ui::wm::WINDOW_TYPE/g' $ git commit -a -m. $ git clang-format HEAD^ --style=Chromium $ git commit -a -m. * Move window_types.h header from ui/aura/client/ to ui/wm/public/ BUG=319638 TEST=ash_unittests, aura_unittests, views_unittests, unit_tests R=ben@chromium.org Review URL: https://codereview.chromium.org/115153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241752 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-31 21:15:28 +0000