summaryrefslogtreecommitdiffstats
path: root/ui/wm
Commit message (Collapse)AuthorAgeFilesLines
* Apply automated fixits for Chrome clang plugin to views_unittests.dcheng2015-04-211-3/+3
| | | | | | | | | | Working on trimming down plugin warnings on the Windows clang build. BUG=467287 Review URL: https://codereview.chromium.org/1085753004 Cr-Commit-Position: refs/heads/master@{#326116}
* ui: Use a PaintRecorder to access the Canvas for painting.danakj2015-04-071-3/+4
| | | | | | | | | | | | | Don't use the canvas() from the PaintContext so that we can have the PaintContext be backed by a DisplayItemList instead in the future. Access to the Canvas should be done through a PaintRecorder. R=sadrul BUG=466426 Review URL: https://codereview.chromium.org/1064133003 Cr-Commit-Position: refs/heads/master@{#324137}
* Pass a ui::PaintContext from ui::Layer to layer delegates.danakj2015-04-042-4/+5
| | | | | | | | | | | | | | | | | | | This is a plumbing CL to create a ui::PaintContext that wraps a gfx::Canvas up in ui::Layer. This is passed to every LayerDelegate, and also through to aura::WindowDelegates and views::NativeWidgetDelegates to eventually reach views::View as well. This way ui::PaintContext is created in one place (for compositor paints, there are other places painting to bitmaps we'll address later). And in the future the ui::PaintContext can be backed by a display list instead of a canvas. R=sky BUG=466426 Review URL: https://codereview.chromium.org/1057873004 Cr-Commit-Position: refs/heads/master@{#323855}
* aura: Remove layerless windows.danakj2015-04-032-12/+12
| | | | | | | | | | | | | | | | Layerless windows are only used in unit tests today, and add complexity in that a NativeWidgetAura can not rely on there being a layer present. In practice, having a layer per Window is not unreasonable overhead, and is simpler. The way to render something into the same layer is to use a separate View instead of a separate Window. R=sky BUG=466426 Review URL: https://codereview.chromium.org/1050713002 Cr-Commit-Position: refs/heads/master@{#323610}
* wm: Remove use of WindowTracker for each mouse event since it's never used.sadrul2015-04-021-3/+0
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1055033002 Cr-Commit-Position: refs/heads/master@{#323552}
* Prevent capture from transferring touch event streams.tdresser2015-03-183-19/+6
| | | | | | | | | | | | | Previously event capture would transfer part of the event stream. Now capture just cancels all events that aren't targeted to the capturing window. BUG=460366 TEST=WindowTest.TransferCaptureTouchEvents Review URL: https://codereview.chromium.org/959853002 Cr-Commit-Position: refs/heads/master@{#321128}
* Change ui::wm::Shadow to pass ImageSkia instead of SkBitmap.hshi2015-03-171-1/+1
| | | | | | | | | | | | | | This allows ui::Layer to take scale factor into consideration when updating the cc::NinePatchLayer. BUG=466950 R=danakj@chromium.org R=oshima@chromium.org TBR=sky@chromium.org TEST=verify on HiDPI display as well as HiDPI + LowDPI extended mode that shadows are correct. Review URL: https://codereview.chromium.org/1002393002 Cr-Commit-Position: refs/heads/master@{#320974}
* Disable drag-and-drop on login flow to avoid hanging.ginkage2015-03-132-0/+95
| | | | | | | | | BUG=464118 TEST=manual Review URL: https://codereview.chromium.org/992173004 Cr-Commit-Position: refs/heads/master@{#320574}
* ui: More work to make Linux 'gn check' clean.tfarina2015-03-101-0/+1
| | | | | | | | | | | | | | | | | Tested on Linux with the following command lines: $ gn gen out-gn $ gn check out-gn //ui/* More work is needed to get this enabled on .gn. BUG=367595,376000 TEST=see above R=sky@chromium.org Review URL: https://codereview.chromium.org/988463003 Cr-Commit-Position: refs/heads/master@{#319895}
* base: Stop passing a non-const ref to ObserverListBase::Iterator.danakj2015-03-091-4/+4
| | | | | | | | | | | | Pass a pointer instead, as per the style guide. Also makes the constructor explicit (all callsites already are explicit). BUG=464816 TBR=blundell@chromium.org,agl,dmichael,garykac Review URL: https://codereview.chromium.org/982413002 Cr-Commit-Position: refs/heads/master@{#319674}
* Remove link_chrome_on_windows GN flag.brettw2015-03-021-34/+32
| | | | | | | | This flag was used to disable linking when the bots were too behind. It's not needed any more. Review URL: https://codereview.chromium.org/974543002 Cr-Commit-Position: refs/heads/master@{#318795}
* Remove wm::SHADOW_TYPE_RECTANGULAR_ALWAYS_ACTIVE.jackhou2015-02-253-65/+1
| | | | | | | | | | | | | This was added for athena here: https://codereview.chromium.org/455543004 Since athena has been deleted, this is no longer used. BUG=440818 Review URL: https://codereview.chromium.org/954123002 Cr-Commit-Position: refs/heads/master@{#318110}
* Pass location in screen coordinates to DragDropClient::StartDragAndDrop()pkotwicz2015-02-241-3/+3
| | | | | | | | | | | | | | | | This CL: - Avoids converting from screen coordinates in WebContentsViewAura::StartDragging() and back to screen coordinates in DragDropController::StartDragAndDrop() - Passes the location in the correct coordinates to StartDragAndDrop() in DragDownloadItem() in drag_download_item_views.cc BUG=456619 TEST=Manual, see bug Review URL: https://codereview.chromium.org/901563005 Cr-Commit-Position: refs/heads/master@{#317888}
* Add TransientChildWindowActivationTest() in focus_controller_unittests.cc.xdai2015-02-191-0/+25
| | | | | | | | | | The parent window's visibility change should not change its transient child's window modality property. BUG=447743 Review URL: https://codereview.chromium.org/944483002 Cr-Commit-Position: refs/heads/master@{#317148}
* Tooltip Cleanuposhima2015-02-191-0/+8
| | | | | | | | | | | | | | | This is prep for tooltip improvement: https://codereview.chromium.org/924433002/ (WIP) * Consolidated GetMaxWidth * Eliminate screen type argument. This can be obtained from tooltip window. * Move tooltip truncate code from TooltipManager to TooltipController BUG=None TEST=no functional change. all test should pass. Review URL: https://codereview.chromium.org/916423002 Cr-Commit-Position: refs/heads/master@{#317081}
* Add time_stamp parameter to MouseEvent constructorrobert.bradford2015-02-182-8/+9
| | | | | | | | | | | | | | | | | | In order to allow the use of accurate kernel timestamps in the events from Ozone it is necessary to add a parameter to the constructor for MouseEvent. This CL was partially generated from using a clang tool with some manual changes for files not included in my build and to add header files as necessary. This change fills in all users of the newly added time_stamp parameter with a call into ui::EventTimeForNow() which was the original behaviour used by the constructor. BUG=450341 TEST=Build on all try bots and all unit tests pass. Review URL: https://codereview.chromium.org/934653002 Cr-Commit-Position: refs/heads/master@{#316869}
* Sort GYP files under uisatorux2015-02-181-8/+8
| | | | | | | | | | | | For tools/sort_sources.py to be useful, existing GYP files should be sorted. BUG=456014 TEST=everything should build as before Review URL: https://codereview.chromium.org/918953005 Cr-Commit-Position: refs/heads/master@{#316729}
* Sort GN files under uisatorux2015-02-181-7/+7
| | | | | | | | | | | | For tools/sort_sources.py to be useful, existing GN files should be sorted. BUG=456014 TEST=everything should build as before Review URL: https://codereview.chromium.org/928963002 Cr-Commit-Position: refs/heads/master@{#316719}
* When switching between users, the window that belongs toxdai2015-02-171-3/+3
| | | | | | | | | | | | | | | | | the old user gets hidden, which also hides all its transient child windows. That will clear the transient window's modal property and set it to a normal window - which is incorrect. Based on the comments above the code that clears the window's modality state, we move this line out into OnWindowDestroying(). BUG=447743 Review URL: https://codereview.chromium.org/838033006 Cr-Commit-Position: refs/heads/master@{#316646}
* Split ui/base/ime into a new component (reland with windows GN fix)spang2015-02-052-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The IME code in ui/base/ime depends on ui/ozone to support keyboard control (via the InputController interface). This dependency is currently missing from the build. Unfortunately, we cannot simply add this dependency, because ui/ozone depends on code from ui/base/cursor and ui/base/resource (for cursor bitmaps). Break this cycle by componentizing ui/base/ime & add a dependency from the new ui/base/ime component to ui/ozone. This also helps clean things up a bit because iOS builds ui/base but not ui/base/ime. So there is already a fault line here. The handful of IME tests are left as part of ui_base_unittests. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) TBR=jam Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 Cr-Commit-Position: refs/heads/master@{#314815} Review URL: https://codereview.chromium.org/889323003 Cr-Commit-Position: refs/heads/master@{#314860}
* Revert of Split ui/base/ime into a new component (patchset #4 id:60001 of ↵ccameron2015-02-052-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/889323003/) Reason for revert: Windows builds failing with ERROR at //ui/base/ime/BUILD.gn:170:5: Undefined variable for +=. libs += [ "imm32.lib" ] ^--- I don't have something with this name in scope now. http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4403/steps/gn/logs/stdio (perhaps missed a .gn update)? Original issue's description: > Split ui/base/ime into a new component > > The IME code in ui/base/ime depends on ui/ozone to support keyboard > control (via the InputController interface). This dependency is > currently missing from the build. > > Unfortunately, we cannot simply add this dependency, because ui/ozone > depends on code from ui/base/cursor and ui/base/resource > (for cursor bitmaps). > > Break this cycle by componentizing ui/base/ime & add a dependency > from the new ui/base/ime component to ui/ozone. > > This also helps clean things up a bit because iOS builds ui/base > but not ui/base/ime. So there is already a fault line here. > > The handful of IME tests are left as part of ui_base_unittests. > > BUG=445627 > TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && > ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) > TBR=jam > > Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 > Cr-Commit-Position: refs/heads/master@{#314815} TBR=sky@chromium.org,thakis@chromium.org,jam@chromium.org,yukishiino@chromium.org,spang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445627 Review URL: https://codereview.chromium.org/895363005 Cr-Commit-Position: refs/heads/master@{#314823}
* Split ui/base/ime into a new componentspang2015-02-052-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | The IME code in ui/base/ime depends on ui/ozone to support keyboard control (via the InputController interface). This dependency is currently missing from the build. Unfortunately, we cannot simply add this dependency, because ui/ozone depends on code from ui/base/cursor and ui/base/resource (for cursor bitmaps). Break this cycle by componentizing ui/base/ime & add a dependency from the new ui/base/ime component to ui/ozone. This also helps clean things up a bit because iOS builds ui/base but not ui/base/ime. So there is already a fault line here. The handful of IME tests are left as part of ui_base_unittests. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) TBR=jam Review URL: https://codereview.chromium.org/889323003 Cr-Commit-Position: refs/heads/master@{#314815}
* Remove more targets from GN Windows build.brettw2015-02-021-32/+34
| | | | | | | | | | Targets will be removed until the bot is green. TBR=dpranke Review URL: https://codereview.chromium.org/886323002 Cr-Commit-Position: refs/heads/master@{#314104}
* Add presubmit check for scoped_ptr usage.tfarina2015-01-231-2/+1
| | | | | | | | | | | | | | | The entries were all found by the following command line: $ g grep -nE '\bscoped_ptr<.*?>\(\)' ui/ BUG=None TEST=app_list_unittests, aura_unittests, events_unittests, message_center_unittests,views_unittests, ... R=sky@chromium.org Review URL: https://codereview.chromium.org/855023003 Cr-Commit-Position: refs/heads/master@{#312885}
* Move the test template to //testing/test.gni (part 2)qsr2015-01-211-0/+1
| | | | | | | | | | | | This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni It also update the test template to automatically build an apk on Android. R=cjhopman@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/824263004 Cr-Commit-Position: refs/heads/master@{#312396}
* GN: Add -Wl,-z defs on linux and fix errorsjamesr2015-01-211-0/+6
| | | | | | | | | | | | This tells the linker to resolve symbols for shared libraries at build time, not run time. This alerts developers much earlier that their dependencies are underspecified. BUG=371125 Review URL: https://codereview.chromium.org/843583006 Cr-Commit-Position: refs/heads/master@{#312317}
* Revert of Revert of linux/gyp: Find missing symbols at build time, not ↵thakis2015-01-191-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | runtime. (patchset #1 id:1 of https://codereview.chromium.org/835223006/) Reason for revert: not on cq => doesn't qualify for reverts. will fix live. Original issue's description: > Revert of linux/gyp: Find missing symbols at build time, not runtime. (patchset #10 id:180001 of https://codereview.chromium.org/854753002/) > > Reason for revert: > Breaks compile on chromium.webkit/Linux Tests (dbg) and probably also chromium.lkgr/ASAN Debug > > http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29?numbuilds=50 > http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug > > Original issue's description: > > linux/gyp: Find missing symbols at build time, not runtime. > > > > Limited to very few cases for now (non-chromeos, non-android, > > non-official, component builds only). > > > > BUG=371125 > > TBR=piman,dalecurtis > > > > Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e > > Cr-Commit-Position: refs/heads/master@{#312020} > > > > Committed: https://crrev.com/fdaea4c9e63c845db9c009d236205e7ed4fcb663 > > Cr-Commit-Position: refs/heads/master@{#312032} > > TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,machenbach@chromium.org,thakis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=371125 > > Committed: https://crrev.com/6019325be9a7a4195368d8d4362047e1a4381541 > Cr-Commit-Position: refs/heads/master@{#312068} TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,machenbach@chromium.org,timloh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371125 Review URL: https://codereview.chromium.org/860623002 Cr-Commit-Position: refs/heads/master@{#312070}
* Revert of linux/gyp: Find missing symbols at build time, not runtime. ↵timloh2015-01-191-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #10 id:180001 of https://codereview.chromium.org/854753002/) Reason for revert: Breaks compile on chromium.webkit/Linux Tests (dbg) and probably also chromium.lkgr/ASAN Debug http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29?numbuilds=50 http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug Original issue's description: > linux/gyp: Find missing symbols at build time, not runtime. > > Limited to very few cases for now (non-chromeos, non-android, > non-official, component builds only). > > BUG=371125 > TBR=piman,dalecurtis > > Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e > Cr-Commit-Position: refs/heads/master@{#312020} > > Committed: https://crrev.com/fdaea4c9e63c845db9c009d236205e7ed4fcb663 > Cr-Commit-Position: refs/heads/master@{#312032} TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,machenbach@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371125 Review URL: https://codereview.chromium.org/835223006 Cr-Commit-Position: refs/heads/master@{#312068}
* linux/gyp: Find missing symbols at build time, not runtime.thakis2015-01-171-0/+7
| | | | | | | | | | | | | | | Limited to very few cases for now (non-chromeos, non-android, non-official, component builds only). BUG=371125 TBR=piman,dalecurtis Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e Cr-Commit-Position: refs/heads/master@{#312020} Review URL: https://codereview.chromium.org/854753002 Cr-Commit-Position: refs/heads/master@{#312032}
* Revert of linux/gyp: Find missing symbols at build time, not runtime. ↵thestig2015-01-171-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #9 id:160001 of https://codereview.chromium.org/854753002/) Reason for revert: Broke Ozone: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/10001 gyp: Dependency '/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/build/linux/system.gyp:x11#target' not found while trying to load target /b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/content/content_shell_and_tests.gyp:test_netscape_plugin#target Original issue's description: > linux/gyp: Find missing symbols at build time, not runtime. > > Limited to very few cases for now (non-chromeos, non-android, > non-official, component builds only). > > BUG=371125 > TBR=piman,dalecurtis > > Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e > Cr-Commit-Position: refs/heads/master@{#312020} TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371125 Review URL: https://codereview.chromium.org/851313004 Cr-Commit-Position: refs/heads/master@{#312028}
* linux/gyp: Find missing symbols at build time, not runtime.thakis2015-01-171-0/+7
| | | | | | | | | | | | Limited to very few cases for now (non-chromeos, non-android, non-official, component builds only). BUG=371125 TBR=piman,dalecurtis Review URL: https://codereview.chromium.org/854753002 Cr-Commit-Position: refs/heads/master@{#312020}
* ui/wm: Cleanup - remove unused private field.tfarina2015-01-131-3/+0
| | | | | | | | | | BUG=447445 TEST=wm_unittests R=sky@chromium.org Review URL: https://codereview.chromium.org/833543004 Cr-Commit-Position: refs/heads/master@{#311173}
* Fix regression due to https://codereview.chromium.org/757863002pkotwicz2015-01-132-6/+15
| | | | | | | | | | | | | The intent of https://codereview.chromium.org/757863002 was to make whether an aura::Window's layer has a NULL delegate not affect the aura::Window stacking order. This CL removes the logic that I forgot to remove in the initial CL. BUG=443433 TEST=TransientWindowStackingClientTest.StackAboveClosingWindow Review URL: https://codereview.chromium.org/850553003 Cr-Commit-Position: refs/heads/master@{#311163}
* Move UserActivityDetector to ui/base/user_activity/.derat2015-01-096-450/+0
| | | | | | | | | | | | | | Move UserActivityDetector and UserActivityObserver out of ui/wm/core/ so that other classes in ui/base/ can depend on them. This is needed in order to be able to later move chrome/browser/idle_chromeos.cc out of chrome/ so that the chrome.idle API can eventually be moved to extensions/. BUG=446320 Review URL: https://codereview.chromium.org/833893003 Cr-Commit-Position: refs/heads/master@{#310773}
* LayerAnimator should withdraw from processing animation queue when its ↵ljagielski2015-01-071-0/+17
| | | | | | | | | | delegate becomes nullptr. BUG= Review URL: https://codereview.chromium.org/795113002 Cr-Commit-Position: refs/heads/master@{#310354}
* Don't show the shadow for maximized/fullscreen windowoshima2015-01-072-1/+35
| | | | | | | | | | | | BUG=407966 TEST=covered by unit test. Committed: https://crrev.com/deecdafa38a9effc737acde28e82a32cc527a1b5 Cr-Commit-Position: refs/heads/master@{#309272} Review URL: https://codereview.chromium.org/778283002 Cr-Commit-Position: refs/heads/master@{#310190}
* Use template specialization to generate WindowProperty code.oshima2015-01-072-2/+2
| | | | | | | | | | | | | | They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE(). BUG=None R=sadrul@chromium.org Committed: https://crrev.com/f62e152bb7a13135a597d9766eb79551d3a24a73 Cr-Commit-Position: refs/heads/master@{#309252} Review URL: https://codereview.chromium.org/801953002 Cr-Commit-Position: refs/heads/master@{#310179}
* Cleanup: Update the path to gfx size headers.tfarina2015-01-035-6/+6
| | | | | | | | | | | | | The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=compiles TBR=sky@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/832953002 Cr-Commit-Position: refs/heads/master@{#309873}
* Cleanup: Update the path to gfx rect headers.tfarina2014-12-314-5/+5
| | | | | | | | | | | | | The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=compiles TBR=sky@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/823133004 Cr-Commit-Position: refs/heads/master@{#309814}
* Make callers of CommandLine use it via the base:: namespace.avi2014-12-231-1/+1
| | | | | | | | | | | | Covers testing/, tools/, ui/, and win8/. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/819223002 Cr-Commit-Position: refs/heads/master@{#309538}
* Cleanup: Update the path to insets and point headers.tfarina2014-12-234-4/+4
| | | | | | | | | | | | | The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=unit_tests, content_unittests, extensions_unittests ... TBR=sky@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/823703003 Cr-Commit-Position: refs/heads/master@{#309523}
* Revert "Don't show the shadow for maximized/fullscreen window"reillyg2014-12-192-35/+1
| | | | | | | | | | | | | This reverts commit deecdafa38a9effc737acde28e82a32cc527a1b5. BUG= TBR=oshima@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/797503006 Cr-Commit-Position: refs/heads/master@{#309288}
* Revert of Use template specialization to generate WindowProperty code ↵chirantan2014-12-192-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #8 id:330001 of https://codereview.chromium.org/801953002/) Reason for revert: This is breaking chrome on chrome os builds: In file included from ../../ui/aura/client/screen_position_client.cc:7:0: ../../ui/aura/window_property.h:115:58: error: specialization of 'template<class T> void aura::Window::SetProperty(const aura::WindowProperty<T>*, T)' in different namespace [-fpermissive] const aura::WindowProperty<T >* property, T value) { \ ^ ../../ui/aura/window_property.h:127:5: note: in expansion of macro 'DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE' DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(, T) ^ ../../ui/aura/client/screen_position_client.cc:9:1: note: in expansion of macro 'DECLARE_WINDOW_PROPERTY_TYPE' DECLARE_WINDOW_PROPERTY_TYPE(aura::client::ScreenPositionClient*) ^ In file included from ../../ui/aura/client/screen_position_client.h:9:0, from ../../ui/aura/client/screen_position_client.cc:5: ../../ui/aura/window.h:297:8: error: from definition of 'template<class T> void aura::Window::SetProperty(const aura::WindowProperty<T>*, T)' [-fpermissive] void SetProperty(const WindowProperty<T>* property, T value); ^ Original issue's description: > Use template specialization to generate WindowProperty code. > > They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE(). > > BUG=None > R=sadrul@chromium.org > > Committed: https://crrev.com/f62e152bb7a13135a597d9766eb79551d3a24a73 > Cr-Commit-Position: refs/heads/master@{#309252} TBR=sadrul@chromium.org,sky@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Seems like nobody is around. LGTM. I'm broken by this as well. Review URL: https://codereview.chromium.org/814313002 Cr-Commit-Position: refs/heads/master@{#309285}
* Don't show the shadow for maximized/fullscreen windowoshima2014-12-192-1/+35
| | | | | | | | | BUG=407966 TEST=covered by unit test. Review URL: https://codereview.chromium.org/778283002 Cr-Commit-Position: refs/heads/master@{#309272}
* Use template specialization to generate WindowProperty code.oshima2014-12-192-2/+2
| | | | | | | | | | | They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE(). BUG=None R=sadrul@chromium.org Review URL: https://codereview.chromium.org/801953002 Cr-Commit-Position: refs/heads/master@{#309252}
* ui/wm: Cleanup usage of scoped_ptr.tfarina2014-12-173-6/+5
| | | | | | | | | | | | | | | | * Return nullptr whenever possible. * Use make_scoped_ptr() when possible (less typing/noise). Entries found with the following command line: $ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)' ui/wm BUG=None R=sky@chromium.org Review URL: https://codereview.chromium.org/792603003 Cr-Commit-Position: refs/heads/master@{#308738}
* Fix releasing capture in Ozonepkotwicz2014-12-165-41/+271
| | | | | | | | | | | | | | In CrOS Ozone, WindowTreeHost::SetCapture() is not a no-op (unlike CrOS X11). This CL makes CaptureController::SetCapture() release capture on the WindowTreeHost which has native capture regardless of which WindowTreeHost the aura::Window with capture is currently in. BUG=423383 TEST=None Review URL: https://codereview.chromium.org/780273003 Cr-Commit-Position: refs/heads/master@{#308649}
* Use 0.2f opacity only when the shadow animation is applied.oshima2014-12-121-21/+11
| | | | | | | | | | | The opacity stays 0.2f if the window is created and shown in inactive state because the opacity is set back to 1.0f only when the animation is applied. This CL uses 1.0f opacity as initial opacity and when transitioning from/to small shadow. BUG=433574 TEST=manual test. See the bug for repro step. Review URL: https://codereview.chromium.org/798673002 Cr-Commit-Position: refs/heads/master@{#308187}
* Remove a condition to prevent focus on captured window.mukai2014-12-092-16/+19
| | | | | | | | | | | | | | | | As I commented on the issue 402272, this condition was added to prevent fullscreen cancel when a context menu window comes up (see crbug.com/174731 for the details). However, that bug doesn't make sense because fullscreen isn't cancelled anymore when another window gets the focus. R=sky@chromium.org TEST=manually -- see the bug line. Also this doesn't make regression on crbug.com/174731 with http://www.flashvideofactory.com/test/demofullscreen345.html BUG=402272 Review URL: https://codereview.chromium.org/753223004 Cr-Commit-Position: refs/heads/master@{#307518}
* Fix a minor typo: dispostion -> dispositionsungmann.cho2014-12-051-2/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/771253003 Cr-Commit-Position: refs/heads/master@{#307029}
generated by cgit v1.1 at 2025-02-04 18:54:36 +0000