| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10392152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119965
TEST=LauncherViewTest.LauncherItemStatus
Review URL: https://chromiumcodereview.appspot.com/10386212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=xiyuan@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10408009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
present.
Review URL: https://chromiumcodereview.appspot.com/10386185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=128242
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10399081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=128242
R=ben@chromium.org
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10399044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Manual
Review URL: https://chromiumcodereview.appspot.com/9877015
TBR=pkotwicz@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137752
Review URL: https://chromiumcodereview.appspot.com/10383236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If you use a mouse then left click reorders and control-left click
changes the visible tabs.
. If you use a touch device left click moves the set of visible tabs
and if you right click (corresponds to long press) then you reorder.
Additionally we don't allow detaching on metro.
BUG=123274
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10399073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Window::SetVisible.
Widget::Show does not take effect if it's called while the hide animation is running.
This CL modifies Window::SetVisible to check Layer's target visibility instead of Layer's current visibility so that Window::Show takes effect even when Window::Hide followed immediately by Window::Show.
Also modified the widnow animation code so that Layer's target visibility is correctly set.
BUG=127863
TEST=Tried repro steps (see BUG) and didn't crash. Passed aura_unittests and aura_shell_unittests.
Review URL: https://chromiumcodereview.appspot.com/10387146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
using the combo box.
Review URL: https://chromiumcodereview.appspot.com/10382227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clicking on Desktop
Bug=None
Test=Manual
Review URL: https://chromiumcodereview.appspot.com/9877015
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383236
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of touch events
For a sequence of {touchstart, touchmove*, touchend} events, compute the rectangle that encloses all of the circles/ellipses corresponding to the touch events. If the hardware is capable of collecting radius_x or radius_y, use the maximum of these two values as the radii values for the touch region. Otherwise use a default radius value of 15.
BUG=122190
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10262023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Manual
Review URL: https://chromiumcodereview.appspot.com/9877015
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scale factor.
Return the best match for a requested scale factor when fetching raw image data from ResourceBundle.
TBR=aa,abodenha
BUG=123611
TEST=ResourceBundle.LoadImageResourceBytes
Review URL: https://chromiumcodereview.appspot.com/10387010
TBR=flackr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=128566
TEST=views_unittests:WidgetTest.ActivationCapture
Review URL: https://chromiumcodereview.appspot.com/10383234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Return the best match for a requested scale factor when fetching raw image data from ResourceBundle.
TBR=aa,abodenha
BUG=123611
TEST=ResourceBundle.LoadImageResourceBytes
Review URL: https://chromiumcodereview.appspot.com/10387010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't why this fixes it, but somehow having a SelectionModel << logging operator in the gfx namespace makes Visual Studio fail to find the << logging operator for string16 arguments.
Per discussion with Scott, we decided to remove the << operators altogether and replace them with a ToString() function to be consistent with Rect, Size, etc.
TEST=Check that adding a "LOG(INFO) << text();" line to RenderTextWin compiles.
Review URL: https://chromiumcodereview.appspot.com/10332205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Defer selection of the text in an unfocused omnibox until
the release event. Otherwise, all of the text starting from
the left side is selected when the user is trying to
highlight just a portion of the URL.
BUG=128126
TEST=added, also did manual testing
Review URL: https://chromiumcodereview.appspot.com/10386173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10407022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Manual
Review URL: https://chromiumcodereview.appspot.com/10389109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
BUG=108171
Review URL: https://chromiumcodereview.appspot.com/10026013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben, sadrul
BUG=124726
TEST=See http://codereview.chromium.org/10391177/
Review URL: https://chromiumcodereview.appspot.com/10387180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10310067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, Ash accelerators are handled at a very early stage, right after a native key event is received by aura::RootWindowHost. This CL change the way of handling Ash accelerators as follows to make it more App friendly:
1. If no window is focused, handle an Ash accelerator immediately in ash/accelerators/accelerator_filter.cc in the same way as before.
2. Otherwise, do not handle it in ash/accelerators/accelerator_filter.cc but let a custom views::FocusManager handle it (see ash/shell.cc). There are 3 types of scenarios here depending on the type of the focused window:
2-a. If the focused window is a browser, and the browser is not for an app, let the custom focus manager pre-handle Ash accelerators before passing it to the browser (see PreHandleKeyboardEvent() in chrome/browser/ui/views/frame/browser_view.cc).
2-b. If the focused window is a browser, and the browser is for an app, let the app handle Ash accelerators first (see chrome/browser/ui/views/frame/browser_view.cc). If the accelerator is not consumed by the app, let the custom focus manager handle it.
2-c. If the focused window is not a browser, let the window handle Ash accelerators first. If the accelerator is not consumed by the window, then let the custom focus manager handle it. This means a WebView without the chrome/browser/ui/ layer can handle Ash accelerators first whenever needed.
Other changes:
chrome/browser/ui/views/frame/browser_view.cc:
Support ET_KEY_RELEASED accelerators in BrowserView::PreHandleKeyboardEvent().
ui/views/focus/focus_manager.cc:
Support ET_KEY_RELEASED accelerators. Also fix code for handing VKEY_MENU so that the Shift+Alt+ET_KEY_RELEASED accelerator for Ash could be handled correctly.
This CL depends on http://codereview.chromium.org/10377158/ (by jochen), https://chromiumcodereview.appspot.com/10388023, http://codereview.chromium.org/10389035/, and https://chromiumcodereview.appspot.com/10332051/, and should not be submitted until the 4 CLs are landed.
BUG=123856
TEST=ran aura_shell_unittests
TEST=manual; launch Chromoting app as a window, connect to a Chromoting server, focus Chrome on the remote machine, press Ctrl-n, confirm a new window is opened on the remote machine.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135791
Review URL: https://chromiumcodereview.appspot.com/10134036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Manual
Review URL: https://chromiumcodereview.appspot.com/10389109
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Manual
Review URL: https://chromiumcodereview.appspot.com/10389109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=125964
TEST=none.
Review URL: https://chromiumcodereview.appspot.com/10383199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky,sadrul
BUG=124724
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10388177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105165
TEST=updated compositor test to cover OnDeviceScaleFactorChagned.
Review URL: https://chromiumcodereview.appspot.com/10391165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119492
TEST=manually done
Review URL: https://chromiumcodereview.appspot.com/10386124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/10406014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DispatcherLinux may not always receive all events (e.g. when a menu is running a
nested message-loop). So install it a message-pump observer, so that all X
events go through the DL.
Also, turn off the check for X-event consistency on release builds.
BUG=128183
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10377161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were two issues:
1. RTL wrapping was simply not happening if your UI language locale was not RTL. Which made FORCE_RTL_DIRECTIONALITY not work.
2. RTL wrapping was not being applied in the SizeStringInt() path, which resulted in an inconsistency between the needed width for SizeStringInt() and DrawStringInt(), causing a problem with the label code resulting in truncation.
This CL fixes both issues.
BUG=128073, 105550
TEST=See testcases attached to bug.
Review URL: https://chromiumcodereview.appspot.com/10384168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10332209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename text_to_display_when_empty -> placehodler_text;
- Draw placeholder text when there is no user text;
BUG=none.
TEST=none.
Review URL: https://chromiumcodereview.appspot.com/10310131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Step2.
- Move ui/gfx/gfx_resources.grd to ui/base/native_theme/native_theme_resources.grd
-Updated gyp/DEPS/py files to use new target.
-Removed old files.
I had to keep the gfx_resources.pak as DumpRendererTree depends on it. I'll update DumpRendererTree first and then remove copy of gfx_resources.pak.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10377155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This disables window manager borders, and supports dragging of the
skyline, as well as resizing from the corners.
This patch also moves our ::Atom caching out of RootWindowHostLinux and into its own Singleton.
BUG=125106
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10381063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from SkBitmap to ImageSkia easier.
Notable changes:
- ImageSkia can be cheaply copied
- Added extractSubset, will remove after SkBitmaps have been converted to ImageSkia
- Modified API to look more like SkBitmap
Review URL: https://chromiumcodereview.appspot.com/10245003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
suggestion.
Frontbuffer drop was hinged onto the discardBackbuffer message. Since only a single discard mess is sent now, and since discarding backbuffer comes first, a message frontbuffer drop was waiting for would never come.
This cl just refactors to decouple the two allocations and should be functionally equivalent to current behaviour, except it does not make assumptions about when discard messages should come through.
BUG=126542
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10388010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben,brettw,hclam
Review URL: https://chromiumcodereview.appspot.com/10391121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test failures are ignored for now.
TBR=mark@chromium.org,tsepez@chromium.org
BUG=125059
TEST=
Review URL: https://chromiumcodereview.appspot.com/10387086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix some simple lints while here.
BUG=122498
Review URL: https://chromiumcodereview.appspot.com/10381051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IsCursorablePosition().
This moves the implementation of IndexOfAdjacentGrapheme() entirely into the base class, removing the need for platform-specific implementations.
This rewrite exposed a couple of problems in RenderTextLinux::IsCursorablePosition() that caused some tests to fail. The fixes are also included.
Also includes additional test coverage for UTF16 surrogate pairs, which was only caught by a Linux-specific password censorship test.
BUG=125664
TEST=Existing unit tests.
Review URL: https://chromiumcodereview.appspot.com/10389148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I goofed when testing my change in http://crrev.com/137029, which had broken this.
The issue is that _multiline_ labels with the empty string as the text actually do have a height of 0. (Only non-multiline labels have a height of one line even if their content is the empty string.)
This change fixes the issue by not setting the multiline flag for empty lines.
BUG=126297
TEST=Try an alert() with \n's in it.
Review URL: https://chromiumcodereview.appspot.com/10310176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=128158
Review URL: https://chromiumcodereview.appspot.com/10310167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without this we can attempt to use an incompatible config/context.
BUG=chromium-os:27980
TEST=Works on Tegra and Mesa softpipe (formerly not working).
Review URL: https://chromiumcodereview.appspot.com/10391081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Stage 1. Copy files to new directory so that try job can test next CL (http://codereview.chromium.org/10391145/).
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10384187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I missed this in https://chromiumcodereview.appspot.com/10386108/ . Thanks to tfarina for noticing.
BUG=90078
TEST=none
TBR=ben
Review URL: https://chromiumcodereview.appspot.com/10377151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10377114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123057
TEST=manually done
Review URL: https://chromiumcodereview.appspot.com/10386085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137181 0039d316-1c4b-4281-b951-d872f2087c98
|