| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes.
Review URL: https://codereview.chromium.org/12163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
follow up on https://codereview.chromium.org/11648027/
Instead of cracking FileSystemURL in its ctor (somewhat magically, using singleton IsolatedContext and SystemExternalMountPoints), require FileSystemURL to be cracked explicitly.
The FileSystemURL can be cracked using specific MountPoints implementation or using specific FileSystemContext which will select available MountPoints implementation that should be used to crack the url.
(CrackURL/CreateCrackedFileSystemURL methods).
Modify FileSystemURL usages to use new cracking methods.
BUG=158837
TEST=content_unittests: IsolatedContextTest.* ExternalMountPointsTest.* FileSystemContextTest.*
Review URL: https://chromiumcodereview.appspot.com/11787028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move mount point info bookeeping from CrosMountPointProvider to ExternalMountPoints.
Add some tests for CrosMountPointProvider.
BUG=158837
TEST=content_unittests:CrosMountPointProvider*
TBR=benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11648027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add necessary std includes
- TODO: -> TODO(user):
- fix indentation / spacing / empty lines
- avoid unnamed parameters
- avoid non-recommended functions
BUG=none
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/11343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added verbose description in file_system_types.h.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10879002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We deprecated it when we added RevokeFileSystemByPath but it looks we still want it.
BUG=none
TEST=IsolatedContextTest.RegisterAndRevokeTest
Review URL: https://chromiumcodereview.appspot.com/10837217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
so that we can make sure we invalidate all file systems associated to a given path (e.g. for a detached device)
BUG=none
TEST=IsolatedContextTest.*
Review URL: https://chromiumcodereview.appspot.com/10829136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* cracks isolated path in FileSystemURL ctor
* FileUtils no longer need to crack the isolated path by themselves
* Make IsolatedFileUtil inherit from LocalFileUtil
* Have a separate FileUtil for DraggedFileUtil, which inherits from IsolatedFileUtil
BUG=134078,138022
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10810053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Separated from a bigger patch: https://chromiumcodereview.appspot.com/10810053)
BUG=138022
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10817006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* directory drag-and-drop should work for a USB drive etc
* Media device intent should work on Windows
BUG=134828,135010
TEST=manually tested
TEST=IsolatedContext\*
Review URL: https://chromiumcodereview.appspot.com/10713007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For regular chrome centralize the read/write permission to ChildProcessSecurityPolicy and do nothing in fileapi layer.
For DRT/content_shell disable writes at SimpleFileSystem layer as well as we do in FileAPIMessageFilter for chrome.
BUG=none
TEST=existing tests
TEST=layout tests https://bugs.webkit.org/show_bug.cgi?id=89981
Review URL: https://chromiumcodereview.appspot.com/10692005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- CreateFileStreamWriter wiring in FSO
- Add yet another write-protection at IsolatedContext (in addition to ChildProcessSecurityPolicy, so that we can make each fs read-only or writable in DRT/testing)
BUG=none
TEST=existing tests should pass
Original review URL: https://chromiumcodereview.appspot.com/10540070
Review URL: https://chromiumcodereview.appspot.com/10532085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use CreateFileStreamWriter in FSO
- Add yet another write-protection at IsolatedContext (in addition to ChildProcessSecurityPolicy, so that we can make each fs read-only or writable in DRT/testing)
BUG=none
TEST=none (will add layout_test)
Review URL: https://chromiumcodereview.appspot.com/10540070
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10534088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use CreateFileStreamWriter in FSO
- Add yet another write-protection at IsolatedContext (in addition to ChildProcessSecurityPolicy, so that we can make each fs read-only or writable in DRT/testing)
BUG=none
TEST=none (will add layout_test)
Review URL: https://chromiumcodereview.appspot.com/10540070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
patch from http://codereview.chromium.org/9204009/
BUG=99823
TEST=test_shell_tests:IsolatedFileUtil*
Review URL: https://chromiumcodereview.appspot.com/9272007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I assume the method FilePath::NormalizeWindowsPathSeparators() is intentionally defined only on Windows, but recently I found myself trying to add a static method (named NormalizePathSeparators()) which calls NormalizeWindowsPathSeparators() or does nothing with platform ifdefs, and then found that there's another place defining the same static method.
Maybe we could just add the common method in FilePath then? It'd at least make the code cleaner at several callsites. I don't think this has visible negative performance impact with optimization build.
BUG=none
TEST=FilePathTest.NormalizePathSeparators and all other existing tests
Review URL: https://chromiumcodereview.appspot.com/9320059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=IsolatedContext.*
Review URL: https://chromiumcodereview.appspot.com/9323013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=112568
TEST=green bots
TBR=ahendrickson
Review URL: https://chromiumcodereview.appspot.com/9310078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
- Adding IsolatedContext class which keeps track of the isolated filesystem namespaces for dropped files/directories
- Adding WebDropData.filesystem_id to send the filesystem ID to the renderer
- Adding GrantAccessFileSystem() method to ChildProcessSecurityPolicy (the permission is to be revoked when the child goes away)
design doc (internal): https://docs.google.com/a/google.com/document/d/1hSdCHy7qWXYSp9nlUT7JJd5Jli_fMWQxgyQBM1GhRVk/edit?hl=en_US
BUG=99823
TEST=test_shell_tests:IsolatedContextTest*
Review URL: https://chromiumcodereview.appspot.com/9204009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120178 0039d316-1c4b-4281-b951-d872f2087c98
|