1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/wm/window_positioner.h"
#include <string>
#include "ash/shell.h"
#include "ash/shell/toplevel_window.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/test_shell_delegate.h"
#include "ash/wm/window_positioner.h"
#include "ash/wm/window_state.h"
#include "base/strings/string_number_conversions.h"
#include "ui/aura/window_event_dispatcher.h"
#include "ui/gfx/screen.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
namespace ash {
typedef test::AshTestBase WindowPositionerTest;
TEST_F(WindowPositionerTest, OpenMaximizedWindowOnSecondDisplay) {
if (!SupportsMultipleDisplays())
return;
// Tests that for a screen that is narrower than kForceMaximizeWidthLimit
// a new window gets maximized.
UpdateDisplay("400x400,500x500");
Shell::GetInstance()->set_target_root_window(
Shell::GetAllRootWindows()[1]);
shell::ToplevelWindow::CreateParams params;
params.can_resize = true;
params.can_maximize = true;
views::Widget* widget =
shell::ToplevelWindow::CreateToplevelWindow(params);
EXPECT_EQ("400,0 500x453", widget->GetWindowBoundsInScreen().ToString());
}
TEST_F(WindowPositionerTest, OpenDefaultWindowOnSecondDisplay) {
if (!SupportsMultipleDisplays())
return;
#if defined(OS_WIN)
ash::WindowPositioner::SetMaximizeFirstWindow(true);
#endif
UpdateDisplay("400x400,1400x900");
aura::Window* second_root_window = Shell::GetAllRootWindows()[1];
Shell::GetInstance()->set_target_root_window(
second_root_window);
shell::ToplevelWindow::CreateParams params;
params.can_resize = true;
params.can_maximize = true;
views::Widget* widget =
shell::ToplevelWindow::CreateToplevelWindow(params);
gfx::Rect bounds = widget->GetWindowBoundsInScreen();
#if defined(OS_WIN)
EXPECT_TRUE(widget->IsMaximized());
#else
// The window should be in the 2nd display with the default size.
EXPECT_EQ("300x300", bounds.size().ToString());
#endif
EXPECT_TRUE(gfx::Screen::GetScreen()
->GetDisplayNearestWindow(second_root_window)
.bounds()
.Contains(bounds));
}
// Tests that second window inherits first window's maximized state as well as
// its restore bounds.
#if defined(OS_WIN) && !defined(USE_ASH)
// TODO(msw): Broken on Windows. http://crbug.com/584038
#define MAYBE_SecondMaximizedWindowHasProperRestoreSize \
DISABLED_SecondMaximizedWindowHasProperRestoreSize
#else
#define MAYBE_SecondMaximizedWindowHasProperRestoreSize \
SecondMaximizedWindowHasProperRestoreSize
#endif
TEST_F(WindowPositionerTest, MAYBE_SecondMaximizedWindowHasProperRestoreSize) {
#if defined(OS_WIN)
ash::WindowPositioner::SetMaximizeFirstWindow(true);
#endif
UpdateDisplay("1400x900");
shell::ToplevelWindow::CreateParams params;
params.can_resize = true;
params.can_maximize = true;
views::Widget* widget1 =
shell::ToplevelWindow::CreateToplevelWindow(params);
gfx::Rect bounds = widget1->GetWindowBoundsInScreen();
#if !defined(OS_WIN)
// The window should have default size.
EXPECT_FALSE(widget1->IsMaximized());
EXPECT_EQ("300x300", bounds.size().ToString());
widget1->Maximize();
#endif
// The window should be maximized.
bounds = widget1->GetWindowBoundsInScreen();
EXPECT_TRUE(widget1->IsMaximized());
EXPECT_EQ("0,0 1400x853", bounds.ToString());
// Create another window
views::Widget* widget2 =
shell::ToplevelWindow::CreateToplevelWindow(params);
// The second window should be maximized.
bounds = widget2->GetWindowBoundsInScreen();
EXPECT_TRUE(widget2->IsMaximized());
EXPECT_EQ("0,0 1400x853", bounds.ToString());
widget2->Restore();
// Second window's restored size should be set to default size.
bounds = widget2->GetWindowBoundsInScreen();
EXPECT_EQ("300x300", bounds.size().ToString());
}
namespace {
// A WidgetDelegate that returns the out of display saved bounds.
class OutOfDisplayDelegate : public views::WidgetDelegate {
public:
explicit OutOfDisplayDelegate(views::Widget* widget) : widget_(widget) {}
~OutOfDisplayDelegate() override {}
// Overridden from WidgetDelegate:
void DeleteDelegate() override { delete this; }
views::Widget* GetWidget() override { return widget_; }
const views::Widget* GetWidget() const override { return widget_; }
bool GetSavedWindowPlacement(const views::Widget* widget,
gfx::Rect* bounds,
ui::WindowShowState* show_state) const override {
bounds->SetRect(450, 10, 100, 100);
*show_state = ui::SHOW_STATE_NORMAL;
return true;
}
private:
views::Widget* widget_;
DISALLOW_COPY_AND_ASSIGN(OutOfDisplayDelegate);
};
} // namespace
TEST_F(WindowPositionerTest, EnsureMinimumVisibility) {
if (!SupportsHostWindowResize())
return;
UpdateDisplay("400x400");
views::Widget* widget = new views::Widget();
views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW);
params.delegate = new OutOfDisplayDelegate(widget);
params.context = Shell::GetPrimaryRootWindow();
widget->Init(params);
widget->SetBounds(gfx::Rect(450,10, 100, 100));
wm::GetWindowState(widget->GetNativeView())->set_minimum_visibility(true);
widget->Show();
// Make sure the bounds is adjusted to be inside the work area.
EXPECT_EQ("375,10 100x100", widget->GetWindowBoundsInScreen().ToString());
widget->CloseNow();
}
// In general case on first run the browser window will be maximized only for
// low resolution screens (width < 1366). In case of big screens the browser is
// opened being not maximized. To enforce maximization for all screen
// resolutions, one can set "ForceMaximizeBrowserWindowOnFirstRun"
// policy. In the following tests we check if the window will be opened in
// maximized mode for low and high resolution when this policy is set.
TEST_F(WindowPositionerTest, FirstRunMaximizeWindowHighResloution) {
const int width = ash::WindowPositioner::GetForceMaximizedWidthLimit() + 100;
// Set resolution to 1466x300.
const std::string resolution = base::IntToString(width) + "x300";
UpdateDisplay(resolution);
gfx::Rect bounds_in_out(0, 0, 320, 240); // Random bounds.
ui::WindowShowState show_state_out = ui::SHOW_STATE_DEFAULT;
test::TestShellDelegate* const delegate =
static_cast<test::TestShellDelegate*>(Shell::GetInstance()->delegate());
delegate->SetForceMaximizeOnFirstRun(true);
WindowPositioner::GetBoundsAndShowStateForNewWindow(
gfx::Screen::GetScreen(), nullptr, false, ui::SHOW_STATE_DEFAULT,
&bounds_in_out, &show_state_out);
EXPECT_EQ(show_state_out, ui::SHOW_STATE_MAXIMIZED);
}
// For detail see description of FirstRunMaximizeWindowHighResloution.
TEST_F(WindowPositionerTest, FirstRunMaximizeWindowLowResolution) {
const int width = ash::WindowPositioner::GetForceMaximizedWidthLimit() - 100;
// Set resolution to 1266x300.
const std::string resolution = base::IntToString(width) + "x300";
UpdateDisplay(resolution);
gfx::Rect bounds_in_out(0, 0, 320, 240); // Random bounds.
ui::WindowShowState show_state_out = ui::SHOW_STATE_DEFAULT;
test::TestShellDelegate* const delegate =
static_cast<test::TestShellDelegate*>(Shell::GetInstance()->delegate());
delegate->SetForceMaximizeOnFirstRun(true);
WindowPositioner::GetBoundsAndShowStateForNewWindow(
gfx::Screen::GetScreen(), nullptr, false, ui::SHOW_STATE_DEFAULT,
&bounds_in_out, &show_state_out);
EXPECT_EQ(show_state_out, ui::SHOW_STATE_MAXIMIZED);
}
TEST_F(WindowPositionerTest, IgnoreFullscreenInAutoRearrange) {
if (!SupportsHostWindowResize())
return;
// Set bigger than 1366 so that the new window is opened in normal state.
UpdateDisplay("1400x800");
// 1st window mimics fullscreen browser window behavior.
shell::ToplevelWindow::CreateParams params;
params.can_resize = true;
params.can_maximize = true;
views::Widget* widget1 = shell::ToplevelWindow::CreateToplevelWindow(params);
wm::WindowState* managed_state =
wm::GetWindowState(widget1->GetNativeWindow());
EXPECT_TRUE(managed_state->window_position_managed());
EXPECT_EQ("300x300", widget1->GetWindowBoundsInScreen().size().ToString());
widget1->SetFullscreen(true);
ASSERT_EQ("1400x800", widget1->GetWindowBoundsInScreen().size().ToString());
// 2nd window mimics windowed v1 app.
params.use_saved_placement = false;
views::Widget* widget2 = shell::ToplevelWindow::CreateToplevelWindow(params);
wm::WindowState* state_2 = wm::GetWindowState(widget2->GetNativeWindow());
EXPECT_TRUE(state_2->window_position_managed());
EXPECT_EQ("300x300", widget2->GetWindowBoundsInScreen().size().ToString());
// Restores to the original size.
widget1->SetFullscreen(false);
ASSERT_EQ("300x300", widget1->GetWindowBoundsInScreen().size().ToString());
// Closing 2nd widget triggers the rearrange logic but the 1st
// widget should stay in the current size.
widget2->CloseNow();
ASSERT_EQ("300x300", widget1->GetWindowBoundsInScreen().size().ToString());
}
} // namespace ash
|
