1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/test/launcher/unit_test_launcher.h"
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/format_macros.h"
#include "base/message_loop/message_loop.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/sys_info.h"
#include "base/test/gtest_xml_util.h"
#include "base/test/launcher/parallel_test_launcher.h"
#include "base/test/launcher/test_launcher.h"
#include "base/test/test_switches.h"
#include "base/test/test_timeouts.h"
#include "base/threading/thread_checker.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
namespace {
// This constant controls how many tests are run in a single batch by default.
const size_t kDefaultTestBatchLimit = 10;
const char kHelpFlag[] = "help";
// Flag to enable the new launcher logic.
// TODO(phajdan.jr): Remove it, http://crbug.com/236893 .
const char kBraveNewTestLauncherFlag[] = "brave-new-test-launcher";
// Flag to run all tests in a single process.
const char kSingleProcessTestsFlag[] = "single-process-tests";
void PrintUsage() {
fprintf(stdout,
"Runs tests using the gtest framework, each batch of tests being\n"
"run in their own process. Supported command-line flags:\n"
"\n"
" --single-process-tests\n"
" Runs the tests and the launcher in the same process. Useful\n"
" for debugging a specific test in a debugger.\n"
" --test-launcher-jobs=N\n"
" Sets the number of parallel test jobs to N.\n"
" --test-launcher-batch-limit=N\n"
" Sets the limit of test batch to run in a single process to N.\n"
" --gtest_filter=...\n"
" Runs a subset of tests (see --gtest_help for more info).\n"
" --help\n"
" Shows this message.\n"
" --gtest_help\n"
" Shows the gtest help message.\n");
fflush(stdout);
}
// Returns command line for child GTest process based on the command line
// of current process. |test_names| is a vector of test full names
// (e.g. "A.B"), |output_file| is path to the GTest XML output file.
CommandLine GetCommandLineForChildGTestProcess(
const std::vector<std::string>& test_names,
const base::FilePath& output_file) {
CommandLine new_cmd_line(*CommandLine::ForCurrentProcess());
new_cmd_line.AppendSwitchPath(switches::kTestLauncherOutput, output_file);
new_cmd_line.AppendSwitchASCII(kGTestFilterFlag, JoinString(test_names, ":"));
new_cmd_line.AppendSwitch(kSingleProcessTestsFlag);
new_cmd_line.AppendSwitch(kBraveNewTestLauncherFlag);
return new_cmd_line;
}
class UnitTestLauncherDelegate : public TestLauncherDelegate {
public:
UnitTestLauncherDelegate(size_t jobs, size_t batch_limit)
: parallel_launcher_(jobs),
batch_limit_(batch_limit) {
}
virtual ~UnitTestLauncherDelegate() {
DCHECK(thread_checker_.CalledOnValidThread());
}
private:
struct GTestCallbackState {
TestLauncher* test_launcher;
std::vector<std::string> test_names;
FilePath output_file;
};
virtual void OnTestIterationStarting() OVERRIDE {
// Nothing to do.
}
virtual std::string GetTestNameForFiltering(
const testing::TestCase* test_case,
const testing::TestInfo* test_info) OVERRIDE {
DCHECK(thread_checker_.CalledOnValidThread());
return std::string(test_case->name()) + "." + test_info->name();
}
virtual bool ShouldRunTest(const testing::TestCase* test_case,
const testing::TestInfo* test_info) OVERRIDE {
DCHECK(thread_checker_.CalledOnValidThread());
// There is no additional logic to disable specific tests.
return true;
}
virtual size_t RunTests(TestLauncher* test_launcher,
const std::vector<std::string>& test_names) OVERRIDE {
DCHECK(thread_checker_.CalledOnValidThread());
std::vector<std::string> batch;
for (size_t i = 0; i < test_names.size(); i++) {
batch.push_back(test_names[i]);
if (batch.size() >= batch_limit_) {
RunBatch(test_launcher, batch);
batch.clear();
}
}
RunBatch(test_launcher, batch);
return test_names.size();
}
virtual size_t RetryTests(
TestLauncher* test_launcher,
const std::vector<std::string>& test_names) OVERRIDE {
MessageLoop::current()->PostTask(
FROM_HERE,
Bind(&UnitTestLauncherDelegate::RunSerially,
Unretained(this),
test_launcher,
test_names));
return test_names.size();
}
void RunSerially(TestLauncher* test_launcher,
const std::vector<std::string>& test_names) {
if (test_names.empty())
return;
std::vector<std::string> new_test_names(test_names);
std::string test_name(new_test_names.back());
new_test_names.pop_back();
// Create a dedicated temporary directory to store the xml result data
// per run to ensure clean state and make it possible to launch multiple
// processes in parallel.
base::FilePath output_file;
CHECK(file_util::CreateNewTempDirectory(FilePath::StringType(),
&output_file));
output_file = output_file.AppendASCII("test_results.xml");
std::vector<std::string> current_test_names;
current_test_names.push_back(test_name);
CommandLine cmd_line(
GetCommandLineForChildGTestProcess(current_test_names, output_file));
GTestCallbackState callback_state;
callback_state.test_launcher = test_launcher;
callback_state.test_names = current_test_names;
callback_state.output_file = output_file;
parallel_launcher_.LaunchChildGTestProcess(
cmd_line,
std::string(),
TestTimeouts::test_launcher_timeout(),
Bind(&UnitTestLauncherDelegate::SerialGTestCallback,
Unretained(this),
callback_state,
new_test_names));
}
void RunBatch(TestLauncher* test_launcher,
const std::vector<std::string>& test_names) {
DCHECK(thread_checker_.CalledOnValidThread());
if (test_names.empty())
return;
// Create a dedicated temporary directory to store the xml result data
// per run to ensure clean state and make it possible to launch multiple
// processes in parallel.
base::FilePath output_file;
CHECK(file_util::CreateNewTempDirectory(FilePath::StringType(),
&output_file));
output_file = output_file.AppendASCII("test_results.xml");
CommandLine cmd_line(
GetCommandLineForChildGTestProcess(test_names, output_file));
// Adjust the timeout depending on how many tests we're running
// (note that e.g. the last batch of tests will be smaller).
// TODO(phajdan.jr): Consider an adaptive timeout, which can change
// depending on how many tests ran and how many remain.
// Note: do NOT parse child's stdout to do that, it's known to be
// unreliable (e.g. buffering issues can mix up the output).
base::TimeDelta timeout =
test_names.size() * TestTimeouts::test_launcher_timeout();
GTestCallbackState callback_state;
callback_state.test_launcher = test_launcher;
callback_state.test_names = test_names;
callback_state.output_file = output_file;
parallel_launcher_.LaunchChildGTestProcess(
cmd_line,
std::string(),
timeout,
Bind(&UnitTestLauncherDelegate::GTestCallback,
Unretained(this),
callback_state));
}
void GTestCallback(const GTestCallbackState& callback_state,
int exit_code,
const TimeDelta& elapsed_time,
bool was_timeout,
const std::string& output) {
DCHECK(thread_checker_.CalledOnValidThread());
std::vector<std::string> tests_to_relaunch_after_interruption;
bool called_any_callbacks =
ProcessTestResults(callback_state.test_launcher,
callback_state.test_names,
callback_state.output_file,
output,
exit_code,
was_timeout,
&tests_to_relaunch_after_interruption);
RunBatch(callback_state.test_launcher,
tests_to_relaunch_after_interruption);
if (called_any_callbacks)
parallel_launcher_.ResetOutputWatchdog();
// The temporary file's directory is also temporary.
DeleteFile(callback_state.output_file.DirName(), true);
}
void SerialGTestCallback(const GTestCallbackState& callback_state,
const std::vector<std::string>& test_names,
int exit_code,
const TimeDelta& elapsed_time,
bool was_timeout,
const std::string& output) {
DCHECK(thread_checker_.CalledOnValidThread());
std::vector<std::string> tests_to_relaunch_after_interruption;
bool called_any_callbacks =
ProcessTestResults(callback_state.test_launcher,
callback_state.test_names,
callback_state.output_file,
output,
exit_code,
was_timeout,
&tests_to_relaunch_after_interruption);
// There is only one test, there cannot be other tests to relaunch
// due to a crash.
DCHECK(tests_to_relaunch_after_interruption.empty());
if (called_any_callbacks) {
parallel_launcher_.ResetOutputWatchdog();
} else {
// There is only one test, we should have called back with its result.
NOTREACHED();
}
// The temporary file's directory is also temporary.
DeleteFile(callback_state.output_file.DirName(), true);
MessageLoop::current()->PostTask(
FROM_HERE,
Bind(&UnitTestLauncherDelegate::RunSerially,
Unretained(this),
callback_state.test_launcher,
test_names));
}
static bool ProcessTestResults(
TestLauncher* test_launcher,
const std::vector<std::string>& test_names,
const base::FilePath& output_file,
const std::string& output,
int exit_code,
bool was_timeout,
std::vector<std::string>* tests_to_relaunch_after_interruption) {
std::vector<TestResult> test_results;
bool crashed = false;
bool have_test_results =
ProcessGTestOutput(output_file, &test_results, &crashed);
bool called_any_callback = false;
if (have_test_results) {
// TODO(phajdan.jr): Check for duplicates and mismatches between
// the results we got from XML file and tests we intended to run.
std::map<std::string, TestResult> results_map;
for (size_t i = 0; i < test_results.size(); i++)
results_map[test_results[i].full_name] = test_results[i];
bool had_interrupted_test = false;
for (size_t i = 0; i < test_names.size(); i++) {
if (ContainsKey(results_map, test_names[i])) {
TestResult test_result = results_map[test_names[i]];
if (test_result.status == TestResult::TEST_CRASH) {
had_interrupted_test = true;
if (was_timeout) {
// Fix up the test status: we forcibly kill the child process
// after the timeout, so from XML results it looks just like
// a crash.
test_result.status = TestResult::TEST_TIMEOUT;
}
} else if (test_result.status == TestResult::TEST_SUCCESS ||
test_result.status == TestResult::TEST_FAILURE) {
// We run multiple tests in a batch with a timeout applied
// to the entire batch. It is possible that with other tests
// running quickly some tests take longer than the per-test timeout.
// For consistent handling of tests independent of order and other
// factors, mark them as timing out.
if (test_result.elapsed_time >
TestTimeouts::test_launcher_timeout()) {
test_result.status = TestResult::TEST_TIMEOUT;
}
}
test_result.output_snippet =
GetTestOutputSnippet(test_result, output);
test_launcher->OnTestFinished(test_result);
called_any_callback = true;
} else if (had_interrupted_test) {
tests_to_relaunch_after_interruption->push_back(test_names[i]);
} else {
// TODO(phajdan.jr): Explicitly pass the info that the test didn't
// run for a mysterious reason.
LOG(ERROR) << "no test result for " << test_names[i];
TestResult test_result;
test_result.full_name = test_names[i];
test_result.status = TestResult::TEST_UNKNOWN;
test_result.output_snippet =
GetTestOutputSnippet(test_result, output);
test_launcher->OnTestFinished(test_result);
called_any_callback = true;
}
}
// TODO(phajdan.jr): Handle the case where processing XML output
// indicates a crash but none of the test results is marked as crashing.
// TODO(phajdan.jr): Handle the case where the exit code is non-zero
// but results file indicates that all tests passed (e.g. crash during
// shutdown).
} else {
fprintf(stdout,
"Failed to get out-of-band test success data, "
"dumping full stdio below:\n%s\n",
output.c_str());
fflush(stdout);
// We do not have reliable details about test results (parsing test
// stdout is known to be unreliable), apply the executable exit code
// to all tests.
// TODO(phajdan.jr): Be smarter about this, e.g. retry each test
// individually.
for (size_t i = 0; i < test_names.size(); i++) {
TestResult test_result;
test_result.full_name = test_names[i];
test_result.status = TestResult::TEST_UNKNOWN;
test_launcher->OnTestFinished(test_result);
called_any_callback = true;
}
}
return called_any_callback;
}
ThreadChecker thread_checker_;
ParallelTestLauncher parallel_launcher_;
// Maximum number of tests to run in a single batch.
size_t batch_limit_;
};
bool GetSwitchValueAsInt(const std::string& switch_name, int* result) {
if (!CommandLine::ForCurrentProcess()->HasSwitch(switch_name))
return true;
std::string switch_value =
CommandLine::ForCurrentProcess()->GetSwitchValueASCII(switch_name);
if (!StringToInt(switch_value, result) || *result < 1) {
LOG(ERROR) << "Invalid value for " << switch_name << ": " << switch_value;
return false;
}
return true;
}
} // namespace
int LaunchUnitTests(int argc,
char** argv,
const RunTestSuiteCallback& run_test_suite) {
CommandLine::Init(argc, argv);
if (CommandLine::ForCurrentProcess()->HasSwitch(kGTestHelpFlag) ||
CommandLine::ForCurrentProcess()->HasSwitch(kSingleProcessTestsFlag) ||
!CommandLine::ForCurrentProcess()->HasSwitch(kBraveNewTestLauncherFlag)) {
return run_test_suite.Run();
}
if (CommandLine::ForCurrentProcess()->HasSwitch(kHelpFlag)) {
PrintUsage();
return 0;
}
base::TimeTicks start_time(base::TimeTicks::Now());
testing::InitGoogleTest(&argc, argv);
TestTimeouts::Initialize();
int jobs = SysInfo::NumberOfProcessors();
if (!GetSwitchValueAsInt(switches::kTestLauncherJobs, &jobs))
return 1;
int batch_limit = kDefaultTestBatchLimit;
if (!GetSwitchValueAsInt(switches::kTestLauncherBatchLimit, &batch_limit))
return 1;
fprintf(stdout,
"Starting tests (using %d parallel jobs)...\n"
"IMPORTANT DEBUGGING NOTE: batches of tests are run inside their\n"
"own process. For debugging a test inside a debugger, use the\n"
"--gtest_filter=<your_test_name> flag along with\n"
"--single-process-tests.\n", jobs);
fflush(stdout);
MessageLoopForIO message_loop;
base::UnitTestLauncherDelegate delegate(jobs, batch_limit);
base::TestLauncher launcher(&delegate);
bool success = launcher.Run(argc, argv);
fprintf(stdout,
"Tests took %" PRId64 " seconds.\n",
(base::TimeTicks::Now() - start_time).InSeconds());
fflush(stdout);
return (success ? 0 : 1);
}
} // namespace base
|