1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/autocomplete/history_url_provider.h"
#include <algorithm>
#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/prefs/pref_service.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
#include "chrome/browser/autocomplete/history_quick_provider.h"
#include "chrome/browser/history/history_service.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/search_engines/chrome_template_url_service_client.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "components/history/core/browser/url_database.h"
#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/metrics/proto/omnibox_input_type.pb.h"
#include "components/omnibox/autocomplete_match.h"
#include "components/omnibox/autocomplete_provider.h"
#include "components/omnibox/autocomplete_provider_listener.h"
#include "components/omnibox/autocomplete_result.h"
#include "components/search_engines/default_search_manager.h"
#include "components/search_engines/search_terms_data.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_service.h"
#include "components/url_fixer/url_fixer.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::ASCIIToUTF16;
using base::Time;
using base::TimeDelta;
using content::TestBrowserThreadBundle;
struct TestURLInfo {
const char* url;
const char* title;
int visit_count;
int typed_count;
int age_in_days;
} test_db[] = {
{"http://www.google.com/", "Google", 3, 3, 80},
// High-quality pages should get a host synthesized as a lower-quality match.
{"http://slashdot.org/favorite_page.html", "Favorite page", 200, 100, 80},
// Less popular pages should have hosts synthesized as higher-quality
// matches.
{"http://kerneltrap.org/not_very_popular.html", "Less popular", 4, 0, 80},
// Unpopular pages should not appear in the results at all.
{"http://freshmeat.net/unpopular.html", "Unpopular", 1, 0, 80},
// If a host has a match, we should pick it up during host synthesis.
{"http://news.google.com/?ned=us&topic=n", "Google News - U.S.", 2, 2, 80},
{"http://news.google.com/", "Google News", 1, 1, 80},
// Matches that are normally not inline-autocompletable should be
// autocompleted if they are shorter substitutes for longer matches that would
// have been inline autocompleted.
{"http://synthesisatest.com/foo/", "Test A", 1, 1, 80},
{"http://synthesisbtest.com/foo/", "Test B", 1, 1, 80},
{"http://synthesisbtest.com/foo/bar.html", "Test B Bar", 2, 2, 80},
// Suggested short URLs must be "good enough" and must match user input.
{"http://foo.com/", "Dir", 5, 5, 80},
{"http://foo.com/dir/", "Dir", 2, 2, 80},
{"http://foo.com/dir/another/", "Dir", 5, 1, 80},
{"http://foo.com/dir/another/again/", "Dir", 10, 0, 80},
{"http://foo.com/dir/another/again/myfile.html", "File", 10, 2, 80},
// We throw in a lot of extra URLs here to make sure we're testing the
// history database's query, not just the autocomplete provider.
{"http://startest.com/y/a", "A", 2, 2, 80},
{"http://startest.com/y/b", "B", 5, 2, 80},
{"http://startest.com/x/c", "C", 5, 2, 80},
{"http://startest.com/x/d", "D", 5, 5, 80},
{"http://startest.com/y/e", "E", 4, 2, 80},
{"http://startest.com/y/f", "F", 3, 2, 80},
{"http://startest.com/y/g", "G", 3, 2, 80},
{"http://startest.com/y/h", "H", 3, 2, 80},
{"http://startest.com/y/i", "I", 3, 2, 80},
{"http://startest.com/y/j", "J", 3, 2, 80},
{"http://startest.com/y/k", "K", 3, 2, 80},
{"http://startest.com/y/l", "L", 3, 2, 80},
{"http://startest.com/y/m", "M", 3, 2, 80},
// A file: URL is useful for testing that fixup does the right thing w.r.t.
// the number of trailing slashes on the user's input.
{"file:///C:/foo.txt", "", 2, 2, 80},
// Results with absurdly high typed_counts so that very generic queries like
// "http" will give consistent results even if more data is added above.
{"http://bogussite.com/a", "Bogus A", 10002, 10000, 80},
{"http://bogussite.com/b", "Bogus B", 10001, 10000, 80},
{"http://bogussite.com/c", "Bogus C", 10000, 10000, 80},
// Domain name with number.
{"http://www.17173.com/", "Domain with number", 3, 3, 80},
// URLs to test exact-matching behavior.
{"http://go/", "Intranet URL", 1, 1, 80},
{"http://gooey/", "Intranet URL 2", 5, 5, 80},
// URLs for testing offset adjustment.
{"http://www.\xEA\xB5\x90\xEC\x9C\xA1.kr/", "Korean", 2, 2, 80},
{"http://spaces.com/path%20with%20spaces/foo.html", "Spaces", 2, 2, 80},
{"http://ms/c++%20style%20guide", "Style guide", 2, 2, 80},
// URLs for testing ctrl-enter behavior.
{"http://binky/", "Intranet binky", 2, 2, 80},
{"http://winky/", "Intranet winky", 2, 2, 80},
{"http://www.winky.com/", "Internet winky", 5, 0, 80},
// URLs used by EmptyVisits.
{"http://pandora.com/", "Pandora", 2, 2, 80},
// This entry is explicitly added more recently than
// history::kLowQualityMatchAgeLimitInDays.
// {"http://p/", "p", 0, 0, 80},
// For intranet based tests.
{"http://intra/one", "Intranet", 2, 2, 80},
{"http://intra/two", "Intranet two", 1, 1, 80},
{"http://intra/three", "Intranet three", 2, 2, 80},
{"http://moo/bar", "Intranet moo", 1, 1, 80},
{"http://typedhost/typedpath", "Intranet typed", 1, 1, 80},
{"http://typedhost/untypedpath", "Intranet untyped", 1, 0, 80},
{"http://x.com/one", "Internet", 2, 2, 80},
{"http://x.com/two", "Internet two", 1, 1, 80},
{"http://x.com/three", "Internet three", 2, 2, 80},
// For experimental HUP scoring test.
{"http://7.com/1a", "One", 8, 4, 4},
{"http://7.com/2a", "Two A", 4, 2, 8},
{"http://7.com/2b", "Two B", 4, 1, 8},
{"http://7.com/3a", "Three", 2, 1, 16},
{"http://7.com/4a", "Four A", 1, 1, 32},
{"http://7.com/4b", "Four B", 1, 1, 64},
{"http://7.com/5a", "Five A", 8, 0, 64}, // never typed.
};
class HistoryURLProviderTest : public testing::Test,
public AutocompleteProviderListener {
public:
struct UrlAndLegalDefault {
std::string url;
bool allowed_to_be_default_match;
};
HistoryURLProviderTest()
: sort_matches_(false) {
HistoryQuickProvider::set_disabled(true);
}
virtual ~HistoryURLProviderTest() {
HistoryQuickProvider::set_disabled(false);
}
// AutocompleteProviderListener:
void OnProviderUpdate(bool updated_matches) override;
protected:
static KeyedService* CreateTemplateURLService(
content::BrowserContext* context) {
Profile* profile = static_cast<Profile*>(context);
return new TemplateURLService(
profile->GetPrefs(), make_scoped_ptr(new SearchTermsData), NULL,
scoped_ptr<TemplateURLServiceClient>(
new ChromeTemplateURLServiceClient(
HistoryServiceFactory::GetForProfile(
profile, Profile::EXPLICIT_ACCESS))),
NULL, NULL, base::Closure());
}
// testing::Test
void SetUp() override {
ASSERT_TRUE(SetUpImpl(false));
}
void TearDown() override;
// Does the real setup.
bool SetUpImpl(bool no_db) WARN_UNUSED_RESULT;
// Fills test data into the history system.
void FillData();
// Runs an autocomplete query on |text| and checks to see that the returned
// results' destination URLs match those provided. Also allows checking
// that the input type was identified correctly.
void RunTest(const base::string16& text,
const std::string& desired_tld,
bool prevent_inline_autocomplete,
const UrlAndLegalDefault* expected_urls,
size_t num_results,
metrics::OmniboxInputType::Type* identified_input_type);
// A version of the above without the final |type| output parameter.
void RunTest(const base::string16& text,
const std::string& desired_tld,
bool prevent_inline_autocomplete,
const UrlAndLegalDefault* expected_urls,
size_t num_results) {
metrics::OmniboxInputType::Type type;
return RunTest(text, desired_tld, prevent_inline_autocomplete,
expected_urls, num_results, &type);
}
content::TestBrowserThreadBundle thread_bundle_;
ACMatches matches_;
scoped_ptr<TestingProfile> profile_;
HistoryService* history_service_;
scoped_refptr<HistoryURLProvider> autocomplete_;
// Should the matches be sorted and duplicates removed?
bool sort_matches_;
};
class HistoryURLProviderTestNoDB : public HistoryURLProviderTest {
protected:
void SetUp() override {
ASSERT_TRUE(SetUpImpl(true));
}
};
class HistoryURLProviderTestNoSearchProvider : public HistoryURLProviderTest {
protected:
void SetUp() override {
DefaultSearchManager::SetFallbackSearchEnginesDisabledForTesting(true);
HistoryURLProviderTest::SetUp();
}
void TearDown() override {
HistoryURLProviderTest::TearDown();
DefaultSearchManager::SetFallbackSearchEnginesDisabledForTesting(false);
}
};
void HistoryURLProviderTest::OnProviderUpdate(bool updated_matches) {
if (autocomplete_->done())
base::MessageLoop::current()->Quit();
}
bool HistoryURLProviderTest::SetUpImpl(bool no_db) {
profile_.reset(new TestingProfile());
if (!(profile_->CreateHistoryService(true, no_db)))
return false;
if (!no_db) {
profile_->BlockUntilHistoryProcessesPendingRequests();
profile_->BlockUntilHistoryIndexIsRefreshed();
}
profile_->GetPrefs()->SetString(prefs::kAcceptLanguages, "en-US,en,ko");
history_service_ = HistoryServiceFactory::GetForProfile(
profile_.get(), Profile::EXPLICIT_ACCESS);
autocomplete_ = new HistoryURLProvider(this, profile_.get());
TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(
profile_.get(), &HistoryURLProviderTest::CreateTemplateURLService);
FillData();
return true;
}
void HistoryURLProviderTest::TearDown() {
autocomplete_ = NULL;
}
void HistoryURLProviderTest::FillData() {
// Most visits are a long time ago (some tests require this since we do some
// special logic for things visited very recently). Note that this time must
// be more recent than the "expire history" threshold for the data to be kept
// in the main database.
//
// TODO(brettw) It would be nice if we could test this behavior, in which
// case the time would be specifed in the test_db structure.
const Time now = Time::Now();
for (size_t i = 0; i < arraysize(test_db); ++i) {
const TestURLInfo& cur = test_db[i];
const GURL current_url(cur.url);
history_service_->AddPageWithDetails(
current_url, base::UTF8ToUTF16(cur.title), cur.visit_count,
cur.typed_count, now - TimeDelta::FromDays(cur.age_in_days), false,
history::SOURCE_BROWSED);
}
history_service_->AddPageWithDetails(
GURL("http://p/"), base::UTF8ToUTF16("p"), 0, 0,
Time::Now() -
TimeDelta::FromDays(history::kLowQualityMatchAgeLimitInDays - 1),
false, history::SOURCE_BROWSED);
}
void HistoryURLProviderTest::RunTest(
const base::string16& text,
const std::string& desired_tld,
bool prevent_inline_autocomplete,
const UrlAndLegalDefault* expected_urls,
size_t num_results,
metrics::OmniboxInputType::Type* identified_input_type) {
AutocompleteInput input(text, base::string16::npos, desired_tld, GURL(),
metrics::OmniboxEventProto::INVALID_SPEC,
prevent_inline_autocomplete, false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
*identified_input_type = input.type();
autocomplete_->Start(input, false);
if (!autocomplete_->done())
base::MessageLoop::current()->Run();
matches_ = autocomplete_->matches();
if (sort_matches_) {
TemplateURLService* service =
TemplateURLServiceFactory::GetForProfile(profile_.get());
for (ACMatches::iterator i = matches_.begin(); i != matches_.end(); ++i)
i->ComputeStrippedDestinationURL(service);
AutocompleteResult::DedupMatchesByDestination(
input.current_page_classification(), false, &matches_);
std::sort(matches_.begin(), matches_.end(),
&AutocompleteMatch::MoreRelevant);
}
ASSERT_EQ(num_results, matches_.size()) << "Input text: " << text
<< "\nTLD: \"" << desired_tld << "\"";
for (size_t i = 0; i < num_results; ++i) {
EXPECT_EQ(expected_urls[i].url, matches_[i].destination_url.spec());
EXPECT_EQ(expected_urls[i].allowed_to_be_default_match,
matches_[i].allowed_to_be_default_match);
}
}
TEST_F(HistoryURLProviderTest, PromoteShorterURLs) {
// Test that hosts get synthesized below popular pages.
const UrlAndLegalDefault expected_nonsynth[] = {
{ "http://slashdot.org/favorite_page.html", false },
{ "http://slashdot.org/", false }
};
RunTest(ASCIIToUTF16("slash"), std::string(), true, expected_nonsynth,
arraysize(expected_nonsynth));
// Test that hosts get synthesized above less popular pages.
const UrlAndLegalDefault expected_synth[] = {
{ "http://kerneltrap.org/", false },
{ "http://kerneltrap.org/not_very_popular.html", false }
};
RunTest(ASCIIToUTF16("kernel"), std::string(), true, expected_synth,
arraysize(expected_synth));
// Test that unpopular pages are ignored completely.
RunTest(ASCIIToUTF16("fresh"), std::string(), true, NULL, 0);
// Test that if we create or promote shorter suggestions that would not
// normally be inline autocompletable, we make them inline autocompletable if
// the original suggestion (that we replaced as "top") was inline
// autocompletable.
const UrlAndLegalDefault expected_synthesisa[] = {
{ "http://synthesisatest.com/", true },
{ "http://synthesisatest.com/foo/", true }
};
RunTest(ASCIIToUTF16("synthesisa"), std::string(), false, expected_synthesisa,
arraysize(expected_synthesisa));
EXPECT_LT(matches_.front().relevance, 1200);
const UrlAndLegalDefault expected_synthesisb[] = {
{ "http://synthesisbtest.com/foo/", true },
{ "http://synthesisbtest.com/foo/bar.html", true }
};
RunTest(ASCIIToUTF16("synthesisb"), std::string(), false, expected_synthesisb,
arraysize(expected_synthesisb));
EXPECT_GE(matches_.front().relevance, 1410);
// Test that if we have a synthesized host that matches a suggestion, they
// get combined into one.
const UrlAndLegalDefault expected_combine[] = {
{ "http://news.google.com/", false },
{ "http://news.google.com/?ned=us&topic=n", false },
};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("news"), std::string(), true,
expected_combine,
arraysize(expected_combine)));
// The title should also have gotten set properly on the host for the
// synthesized one, since it was also in the results.
EXPECT_EQ(ASCIIToUTF16("Google News"), matches_.front().description);
// Test that short URL matching works correctly as the user types more
// (several tests):
// The entry for foo.com is the best of all five foo.com* entries.
const UrlAndLegalDefault short_1[] = {
{ "http://foo.com/", false },
{ "http://foo.com/dir/another/again/myfile.html", false },
{ "http://foo.com/dir/", false }
};
RunTest(ASCIIToUTF16("foo"), std::string(), true, short_1,
arraysize(short_1));
// When the user types the whole host, make sure we don't get two results for
// it.
const UrlAndLegalDefault short_2[] = {
{ "http://foo.com/", true },
{ "http://foo.com/dir/another/again/myfile.html", false },
{ "http://foo.com/dir/", false },
{ "http://foo.com/dir/another/", false }
};
RunTest(ASCIIToUTF16("foo.com"), std::string(), true, short_2,
arraysize(short_2));
RunTest(ASCIIToUTF16("foo.com/"), std::string(), true, short_2,
arraysize(short_2));
// The filename is the second best of the foo.com* entries, but there is a
// shorter URL that's "good enough". The host doesn't match the user input
// and so should not appear.
const UrlAndLegalDefault short_3[] = {
{ "http://foo.com/d", true },
{ "http://foo.com/dir/another/", false },
{ "http://foo.com/dir/another/again/myfile.html", false },
{ "http://foo.com/dir/", false }
};
RunTest(ASCIIToUTF16("foo.com/d"), std::string(), true, short_3,
arraysize(short_3));
// We shouldn't promote shorter URLs than the best if they're not good
// enough.
const UrlAndLegalDefault short_4[] = {
{ "http://foo.com/dir/another/a", true },
{ "http://foo.com/dir/another/again/myfile.html", false },
{ "http://foo.com/dir/another/again/", false }
};
RunTest(ASCIIToUTF16("foo.com/dir/another/a"), std::string(), true, short_4,
arraysize(short_4));
// Exact matches should always be best no matter how much more another match
// has been typed.
const UrlAndLegalDefault short_5a[] = {
{ "http://gooey/", true },
{ "http://www.google.com/", true },
{ "http://go/", true }
};
const UrlAndLegalDefault short_5b[] = {
{ "http://go/", true },
{ "http://gooey/", true },
{ "http://www.google.com/", true }
};
RunTest(ASCIIToUTF16("g"), std::string(), false, short_5a,
arraysize(short_5a));
RunTest(ASCIIToUTF16("go"), std::string(), false, short_5b,
arraysize(short_5b));
}
TEST_F(HistoryURLProviderTest, CullRedirects) {
// URLs we will be using, plus the visit counts they will initially get
// (the redirect set below will also increment the visit counts). We want
// the results to be in A,B,C order. Note also that our visit counts are
// all high enough so that domain synthesizing won't get triggered.
struct TestCase {
const char* url;
int count;
} test_cases[] = {
{"http://redirects/A", 30},
{"http://redirects/B", 20},
{"http://redirects/C", 10}
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
history_service_->AddPageWithDetails(GURL(test_cases[i].url),
ASCIIToUTF16("Title"), test_cases[i].count, test_cases[i].count,
Time::Now(), false, history::SOURCE_BROWSED);
}
// Create a B->C->A redirect chain, but set the visit counts such that they
// will appear in A,B,C order in the results. The autocomplete query will
// search for the most recent visit when looking for redirects, so this will
// be found even though the previous visits had no redirects.
history::RedirectList redirects_to_a;
redirects_to_a.push_back(GURL(test_cases[1].url));
redirects_to_a.push_back(GURL(test_cases[2].url));
redirects_to_a.push_back(GURL(test_cases[0].url));
history_service_->AddPage(GURL(test_cases[0].url), base::Time::Now(),
NULL, 0, GURL(), redirects_to_a, ui::PAGE_TRANSITION_TYPED,
history::SOURCE_BROWSED, true);
// Because all the results are part of a redirect chain with other results,
// all but the first one (A) should be culled. We should get the default
// "what you typed" result, plus this one.
const base::string16 typing(ASCIIToUTF16("http://redirects/"));
const UrlAndLegalDefault expected_results[] = {
{ base::UTF16ToUTF8(typing), true },
{ test_cases[0].url, false }
};
RunTest(typing, std::string(), true, expected_results,
arraysize(expected_results));
}
TEST_F(HistoryURLProviderTestNoSearchProvider, WhatYouTypedNoSearchProvider) {
// When no search provider is available, make sure we provide WYT matches
// for text that could be a URL.
const UrlAndLegalDefault results_1[] = {
{ "http://wytmatch/", true }
};
RunTest(ASCIIToUTF16("wytmatch"), std::string(), false, results_1,
arraysize(results_1));
RunTest(ASCIIToUTF16("wytmatch foo bar"), std::string(), false, NULL, 0);
RunTest(ASCIIToUTF16("wytmatch+foo+bar"), std::string(), false, NULL, 0);
const UrlAndLegalDefault results_2[] = {
{ "http://wytmatch+foo+bar.com/", true }
};
RunTest(ASCIIToUTF16("wytmatch+foo+bar.com"), std::string(), false,
results_2, arraysize(results_2));
}
TEST_F(HistoryURLProviderTest, WhatYouTyped) {
// Make sure we suggest a What You Typed match at the right times.
RunTest(ASCIIToUTF16("wytmatch"), std::string(), false, NULL, 0);
RunTest(ASCIIToUTF16("wytmatch foo bar"), std::string(), false, NULL, 0);
RunTest(ASCIIToUTF16("wytmatch+foo+bar"), std::string(), false, NULL, 0);
RunTest(ASCIIToUTF16("wytmatch+foo+bar.com"), std::string(), false, NULL, 0);
const UrlAndLegalDefault results_1[] = {
{ "http://www.wytmatch.com/", true }
};
RunTest(ASCIIToUTF16("wytmatch"), "com", false, results_1,
arraysize(results_1));
const UrlAndLegalDefault results_2[] = {
{ "http://wytmatch%20foo%20bar/", true }
};
RunTest(ASCIIToUTF16("http://wytmatch foo bar"), std::string(), false,
results_2, arraysize(results_2));
const UrlAndLegalDefault results_3[] = {
{ "https://wytmatch%20foo%20bar/", true }
};
RunTest(ASCIIToUTF16("https://wytmatch foo bar"), std::string(), false,
results_3, arraysize(results_3));
}
TEST_F(HistoryURLProviderTest, Fixup) {
// Test for various past crashes we've had.
RunTest(ASCIIToUTF16("\\"), std::string(), false, NULL, 0);
RunTest(ASCIIToUTF16("#"), std::string(), false, NULL, 0);
RunTest(ASCIIToUTF16("%20"), std::string(), false, NULL, 0);
const UrlAndLegalDefault fixup_crash[] = {
{ "http://%EF%BD%A5@s/", true }
};
RunTest(base::WideToUTF16(L"\uff65@s"), std::string(), false, fixup_crash,
arraysize(fixup_crash));
RunTest(base::WideToUTF16(L"\u2015\u2015@ \uff7c"), std::string(), false,
NULL, 0);
// Fixing up "file:" should result in an inline autocomplete offset of just
// after "file:", not just after "file://".
const base::string16 input_1(ASCIIToUTF16("file:"));
const UrlAndLegalDefault fixup_1[] = {
{ "file:///C:/foo.txt", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(input_1, std::string(), false, fixup_1,
arraysize(fixup_1)));
EXPECT_EQ(ASCIIToUTF16("///C:/foo.txt"),
matches_.front().inline_autocompletion);
// Fixing up "http:/" should result in an inline autocomplete offset of just
// after "http:/", not just after "http:".
const base::string16 input_2(ASCIIToUTF16("http:/"));
const UrlAndLegalDefault fixup_2[] = {
{ "http://bogussite.com/a", true },
{ "http://bogussite.com/b", true },
{ "http://bogussite.com/c", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(input_2, std::string(), false, fixup_2,
arraysize(fixup_2)));
EXPECT_EQ(ASCIIToUTF16("/bogussite.com/a"),
matches_.front().inline_autocompletion);
// Adding a TLD to a small number like "56" should result in "www.56.com"
// rather than "0.0.0.56.com".
const UrlAndLegalDefault fixup_3[] = {
{ "http://www.56.com/", true }
};
RunTest(ASCIIToUTF16("56"), "com", true, fixup_3, arraysize(fixup_3));
// An input looks like a IP address like "127.0.0.1" should result in
// "http://127.0.0.1/".
const UrlAndLegalDefault fixup_4[] = {
{ "http://127.0.0.1/", true }
};
RunTest(ASCIIToUTF16("127.0.0.1"), std::string(), false, fixup_4,
arraysize(fixup_4));
// An number "17173" should result in "http://www.17173.com/" in db.
const UrlAndLegalDefault fixup_5[] = {
{ "http://www.17173.com/", true }
};
RunTest(ASCIIToUTF16("17173"), std::string(), false, fixup_5,
arraysize(fixup_5));
}
// Make sure the results for the input 'p' don't change between the first and
// second passes.
TEST_F(HistoryURLProviderTest, EmptyVisits) {
// Wait for history to create the in memory DB.
profile_->BlockUntilHistoryProcessesPendingRequests();
AutocompleteInput input(ASCIIToUTF16("p"), base::string16::npos,
std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
autocomplete_->Start(input, false);
// HistoryURLProvider shouldn't be done (waiting on async results).
EXPECT_FALSE(autocomplete_->done());
// We should get back an entry for pandora.
matches_ = autocomplete_->matches();
ASSERT_GT(matches_.size(), 0u);
EXPECT_EQ(GURL("http://pandora.com/"), matches_[0].destination_url);
int pandora_relevance = matches_[0].relevance;
// Run the message loop. When |autocomplete_| finishes the loop is quit.
base::MessageLoop::current()->Run();
EXPECT_TRUE(autocomplete_->done());
matches_ = autocomplete_->matches();
ASSERT_GT(matches_.size(), 0u);
EXPECT_EQ(GURL("http://pandora.com/"), matches_[0].destination_url);
EXPECT_EQ(pandora_relevance, matches_[0].relevance);
}
TEST_F(HistoryURLProviderTestNoDB, NavigateWithoutDB) {
// Ensure that we will still produce matches for navigation when there is no
// database.
UrlAndLegalDefault navigation_1[] = {
{ "http://test.com/", true }
};
RunTest(ASCIIToUTF16("test.com"), std::string(), false, navigation_1,
arraysize(navigation_1));
UrlAndLegalDefault navigation_2[] = {
{ "http://slash/", true }
};
RunTest(ASCIIToUTF16("slash"), std::string(), false, navigation_2,
arraysize(navigation_2));
RunTest(ASCIIToUTF16("this is a query"), std::string(), false, NULL, 0);
}
TEST_F(HistoryURLProviderTest, DontAutocompleteOnTrailingWhitespace) {
AutocompleteInput input(ASCIIToUTF16("slash "), base::string16::npos,
std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
autocomplete_->Start(input, false);
if (!autocomplete_->done())
base::MessageLoop::current()->Run();
// None of the matches should attempt to autocomplete.
matches_ = autocomplete_->matches();
for (size_t i = 0; i < matches_.size(); ++i) {
EXPECT_TRUE(matches_[i].inline_autocompletion.empty());
EXPECT_FALSE(matches_[i].allowed_to_be_default_match);
}
}
TEST_F(HistoryURLProviderTest, TreatEmailsAsSearches) {
// Visiting foo.com should not make this string be treated as a navigation.
// That means the result should be scored around 1200 ("what you typed")
// and not 1400+.
const UrlAndLegalDefault expected[] = {
{ "http://user@foo.com/", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("user@foo.com"), std::string(),
false, expected, arraysize(expected)));
EXPECT_LE(1200, matches_[0].relevance);
EXPECT_LT(matches_[0].relevance, 1210);
}
TEST_F(HistoryURLProviderTest, IntranetURLsWithPaths) {
struct TestCase {
const char* input;
int relevance;
} test_cases[] = {
{ "fooey", 0 },
{ "fooey/", 1200 }, // 1200 for URL would still navigate by default.
{ "fooey/a", 1200 }, // 1200 for UNKNOWN would not.
{ "fooey/a b", 1200 }, // Also UNKNOWN.
{ "gooey", 1410 },
{ "gooey/", 1410 },
{ "gooey/a", 1400 },
{ "gooey/a b", 1400 },
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
SCOPED_TRACE(test_cases[i].input);
if (test_cases[i].relevance == 0) {
RunTest(ASCIIToUTF16(test_cases[i].input), std::string(), false, NULL, 0);
} else {
const UrlAndLegalDefault output[] = {
{url_fixer::FixupURL(test_cases[i].input, std::string()).spec(),
true}};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16(test_cases[i].input),
std::string(), false, output, arraysize(output)));
// Actual relevance should be at least what test_cases expects and
// and no more than 10 more.
EXPECT_LE(test_cases[i].relevance, matches_[0].relevance);
EXPECT_LT(matches_[0].relevance, test_cases[i].relevance + 10);
}
}
}
// Makes sure autocompletion happens for intranet sites that have been
// previoulsy visited.
TEST_F(HistoryURLProviderTest, IntranetURLCompletion) {
sort_matches_ = true;
const UrlAndLegalDefault expected1[] = {
{ "http://intra/three", true },
{ "http://intra/two", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("intra/t"), std::string(), false,
expected1, arraysize(expected1)));
EXPECT_LE(1410, matches_[0].relevance);
EXPECT_LT(matches_[0].relevance, 1420);
EXPECT_EQ(matches_[0].relevance - 1, matches_[1].relevance);
const UrlAndLegalDefault expected2[] = {
{ "http://moo/b", true },
{ "http://moo/bar", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("moo/b"), std::string(), false,
expected2, arraysize(expected2)));
// The url what you typed match should be around 1400, otherwise the
// search what you typed match is going to be first.
EXPECT_LE(1400, matches_[0].relevance);
EXPECT_LT(matches_[0].relevance, 1410);
const UrlAndLegalDefault expected3[] = {
{ "http://intra/one", true },
{ "http://intra/three", true },
{ "http://intra/two", true }
};
RunTest(ASCIIToUTF16("intra"), std::string(), false, expected3,
arraysize(expected3));
const UrlAndLegalDefault expected4[] = {
{ "http://intra/one", true },
{ "http://intra/three", true },
{ "http://intra/two", true }
};
RunTest(ASCIIToUTF16("intra/"), std::string(), false, expected4,
arraysize(expected4));
const UrlAndLegalDefault expected5[] = {
{ "http://intra/one", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("intra/o"), std::string(), false,
expected5, arraysize(expected5)));
EXPECT_LE(1410, matches_[0].relevance);
EXPECT_LT(matches_[0].relevance, 1420);
const UrlAndLegalDefault expected6[] = {
{ "http://intra/x", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("intra/x"), std::string(), false,
expected6, arraysize(expected6)));
EXPECT_LE(1400, matches_[0].relevance);
EXPECT_LT(matches_[0].relevance, 1410);
const UrlAndLegalDefault expected7[] = {
{ "http://typedhost/untypedpath", true }
};
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("typedhost/untypedpath"),
std::string(), false, expected7,
arraysize(expected7)));
EXPECT_LE(1400, matches_[0].relevance);
EXPECT_LT(matches_[0].relevance, 1410);
}
TEST_F(HistoryURLProviderTest, CrashDueToFixup) {
// This test passes if we don't crash. The results don't matter.
const char* const test_cases[] = {
"//c",
"\\@st",
"view-source:x",
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
AutocompleteInput input(ASCIIToUTF16(test_cases[i]), base::string16::npos,
std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC,
false, false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
autocomplete_->Start(input, false);
if (!autocomplete_->done())
base::MessageLoop::current()->Run();
}
}
TEST_F(HistoryURLProviderTest, CullSearchResults) {
// Set up a default search engine.
TemplateURLData data;
data.SetKeyword(ASCIIToUTF16("TestEngine"));
data.SetURL("http://testsearch.com/?q={searchTerms}");
TemplateURLService* template_url_service =
TemplateURLServiceFactory::GetForProfile(profile_.get());
TemplateURL* template_url = new TemplateURL(data);
template_url_service->Add(template_url);
template_url_service->SetUserSelectedDefaultSearchProvider(template_url);
template_url_service->Load();
// URLs we will be using, plus the visit counts they will initially get
// (the redirect set below will also increment the visit counts). We want
// the results to be in A,B,C order. Note also that our visit counts are
// all high enough so that domain synthesizing won't get triggered.
struct TestCase {
const char* url;
int count;
} test_cases[] = {
{"https://testsearch.com/", 30},
{"https://testsearch.com/?q=foobar", 20},
{"http://foobar.com/", 10}
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
history_service_->AddPageWithDetails(GURL(test_cases[i].url),
base::UTF8ToUTF16("Title"), test_cases[i].count, test_cases[i].count,
Time::Now(), false, history::SOURCE_BROWSED);
}
// We should not see search URLs when typing a previously used query.
const UrlAndLegalDefault expected_when_searching_query[] = {
{ test_cases[2].url, false }
};
RunTest(ASCIIToUTF16("foobar"), std::string(), true,
expected_when_searching_query, arraysize(expected_when_searching_query));
// We should not see search URLs when typing the search engine name.
const UrlAndLegalDefault expected_when_searching_site[] = {
{ test_cases[0].url, false }
};
RunTest(ASCIIToUTF16("testsearch"), std::string(), true,
expected_when_searching_site, arraysize(expected_when_searching_site));
}
TEST_F(HistoryURLProviderTest, SuggestExactInput) {
const size_t npos = std::string::npos;
struct TestCase {
// Inputs:
const char* input;
bool trim_http;
// Expected Outputs:
const char* contents;
// Offsets of the ACMatchClassifications, terminated by npos.
size_t offsets[3];
// The index of the ACMatchClassification that should have the MATCH bit
// set, npos if no ACMatchClassification should have the MATCH bit set.
size_t match_classification_index;
} test_cases[] = {
{ "http://www.somesite.com", false,
"http://www.somesite.com", {0, npos, npos}, 0 },
{ "www.somesite.com", true,
"www.somesite.com", {0, npos, npos}, 0 },
{ "www.somesite.com", false,
"http://www.somesite.com", {0, 7, npos}, 1 },
{ "somesite.com", true,
"somesite.com", {0, npos, npos}, 0 },
{ "somesite.com", false,
"http://somesite.com", {0, 7, npos}, 1 },
{ "w", true,
"w", {0, npos, npos}, 0 },
{ "w", false,
"http://w", {0, 7, npos}, 1 },
{ "w.com", true,
"w.com", {0, npos, npos}, 0 },
{ "w.com", false,
"http://w.com", {0, 7, npos}, 1 },
{ "www.w.com", true,
"www.w.com", {0, npos, npos}, 0 },
{ "www.w.com", false,
"http://www.w.com", {0, 7, npos}, 1 },
{ "view-source:w", true,
"view-source:w", {0, npos, npos}, 0 },
{ "view-source:www.w.com/", true,
"view-source:www.w.com", {0, npos, npos}, npos },
{ "view-source:www.w.com/", false,
"view-source:http://www.w.com", {0, npos, npos}, npos },
{ "view-source:http://www.w.com/", false,
"view-source:http://www.w.com", {0, npos, npos}, 0 },
{ " view-source:", true,
"view-source:", {0, npos, npos}, 0 },
{ "http:////////w.com", false,
"http://w.com", {0, npos, npos}, npos },
{ " http:////////www.w.com", false,
"http://www.w.com", {0, npos, npos}, npos },
{ "http:a///www.w.com", false,
"http://a///www.w.com", {0, npos, npos}, npos },
{ "mailto://a@b.com", true,
"mailto://a@b.com", {0, npos, npos}, 0 },
{ "mailto://a@b.com", false,
"mailto://a@b.com", {0, npos, npos}, 0 },
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
SCOPED_TRACE(testing::Message() << "Index " << i << " input: "
<< test_cases[i].input << ", trim_http: "
<< test_cases[i].trim_http);
AutocompleteInput input(ASCIIToUTF16(test_cases[i].input),
base::string16::npos, std::string(),
GURL("about:blank"),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
AutocompleteMatch match(autocomplete_->SuggestExactInput(
input.text(), input.canonicalized_url(), test_cases[i].trim_http));
EXPECT_EQ(ASCIIToUTF16(test_cases[i].contents), match.contents);
for (size_t match_index = 0; match_index < match.contents_class.size();
++match_index) {
EXPECT_EQ(test_cases[i].offsets[match_index],
match.contents_class[match_index].offset);
EXPECT_EQ(ACMatchClassification::URL |
(match_index == test_cases[i].match_classification_index ?
ACMatchClassification::MATCH : 0),
match.contents_class[match_index].style);
}
EXPECT_EQ(npos, test_cases[i].offsets[match.contents_class.size()]);
}
}
TEST_F(HistoryURLProviderTest, HUPScoringExperiment) {
HUPScoringParams max_2000_no_time_decay;
max_2000_no_time_decay.typed_count_buckets.buckets().push_back(
std::make_pair(0.0, 2000));
HUPScoringParams max_1250_no_time_decay;
max_1250_no_time_decay.typed_count_buckets.buckets().push_back(
std::make_pair(0.0, 1250));
HUPScoringParams max_1000_no_time_decay;
max_1000_no_time_decay.typed_count_buckets.buckets().push_back(
std::make_pair(0.0, 1000));
HUPScoringParams max_1100_with_time_decay_and_max_cap;
max_1100_with_time_decay_and_max_cap.typed_count_buckets.
set_relevance_cap(1400);
max_1100_with_time_decay_and_max_cap.typed_count_buckets.
set_half_life_days(16);
max_1100_with_time_decay_and_max_cap.typed_count_buckets.buckets().push_back(
std::make_pair(0.5, 1100));
max_1100_with_time_decay_and_max_cap.typed_count_buckets.buckets().push_back(
std::make_pair(0.24, 200));
max_1100_with_time_decay_and_max_cap.typed_count_buckets.buckets().push_back(
std::make_pair(0.0, 100));
HUPScoringParams max_1100_visit_typed_decays;
max_1100_visit_typed_decays.typed_count_buckets.set_half_life_days(16);
max_1100_visit_typed_decays.typed_count_buckets.buckets().push_back(
std::make_pair(0.5, 1100));
max_1100_visit_typed_decays.typed_count_buckets.buckets().push_back(
std::make_pair(0.0, 100));
max_1100_visit_typed_decays.visited_count_buckets.set_half_life_days(16);
max_1100_visit_typed_decays.visited_count_buckets.buckets().push_back(
std::make_pair(0.5, 550));
max_1100_visit_typed_decays.visited_count_buckets.buckets().push_back(
std::make_pair(0.0, 50));
const int kMaxMatches = 3;
struct TestCase {
const char* input;
HUPScoringParams scoring_params;
struct ExpectedMatch {
const char* url;
int control_relevance;
int experiment_relevance;
};
ExpectedMatch matches[kMaxMatches];
} test_cases[] = {
// Max score 2000 -> no demotion.
{ "7.com/1", max_2000_no_time_decay,
{{"7.com/1a", 1413, 1413}, {NULL, 0, 0}, {NULL, 0, 0}} },
// Limit score to 1250/1000 and make sure that the top match is unchanged.
{ "7.com/1", max_1250_no_time_decay,
{{"7.com/1a", 1413, 1413}, {NULL, 0, 0}, {NULL, 0, 0}} },
{ "7.com/2", max_1250_no_time_decay,
{{"7.com/2a", 1413, 1413}, {"7.com/2b", 1412, 1250}, {NULL, 0, 0}} },
{ "7.com/4", max_1000_no_time_decay,
{{"7.com/4", 1203, 1203}, {"7.com/4a", 1202, 1000},
{"7.com/4b", 1201, 999}} },
// Max relevance cap is 1400 and half-life is 16 days.
{ "7.com/1", max_1100_with_time_decay_and_max_cap,
{{"7.com/1a", 1413, 1413}, {NULL, 0, 0}, {NULL, 0, 0}} },
{ "7.com/4", max_1100_with_time_decay_and_max_cap,
{{"7.com/4", 1203, 1203}, {"7.com/4a", 1202, 200},
{"7.com/4b", 1201, 100}} },
// Max relevance cap is 1400 and half-life is 16 days for both visit/typed.
{ "7.com/5", max_1100_visit_typed_decays,
{{"7.com/5", 1203, 1203}, {"7.com/5a", 1202, 50}, {NULL, 0, 0}} },
};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
SCOPED_TRACE(test_cases[i].input);
UrlAndLegalDefault output[kMaxMatches];
int max_matches;
for (max_matches = 0; max_matches < kMaxMatches; ++max_matches) {
if (test_cases[i].matches[max_matches].url == NULL)
break;
output[max_matches].url =
url_fixer::FixupURL(test_cases[i].matches[max_matches].url,
std::string()).spec();
output[max_matches].allowed_to_be_default_match = true;
}
autocomplete_->scoring_params_ = test_cases[i].scoring_params;
// Test the control (scoring disabled).
autocomplete_->scoring_params_.experimental_scoring_enabled = false;
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16(test_cases[i].input),
std::string(), false, output, max_matches));
for (int j = 0; j < max_matches; ++j) {
EXPECT_EQ(test_cases[i].matches[j].control_relevance,
matches_[j].relevance);
}
// Test the experiment (scoring enabled).
autocomplete_->scoring_params_.experimental_scoring_enabled = true;
ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16(test_cases[i].input),
std::string(), false, output, max_matches));
for (int j = 0; j < max_matches; ++j) {
EXPECT_EQ(test_cases[i].matches[j].experiment_relevance,
matches_[j].relevance);
}
}
}
|