1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
|
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/chromeos/drive/download_handler.h"
#include "base/files/scoped_temp_dir.h"
#include "base/message_loop.h"
#include "chrome/browser/chromeos/drive/file_system_util.h"
#include "chrome/browser/chromeos/drive/file_write_helper.h"
#include "chrome/browser/chromeos/drive/mock_file_system.h"
#include "chrome/browser/google_apis/test_util.h"
#include "content/public/test/mock_download_item.h"
#include "content/public/test/mock_download_manager.h"
#include "content/public/test/test_browser_thread.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::testing::Return;
using ::testing::SaveArg;
using ::testing::_;
namespace drive {
namespace {
// Copies |file_path| to |out_file_path|, is used as a
// SubstituteDriveDownloadPathCallback.
void CopySubstituteDriveDownloadPathResult(base::FilePath* out_file_path,
const base::FilePath& file_path) {
*out_file_path = file_path;
}
// Copies |value| to |out|, is used as a content::CheckForFileExistenceCallback.
void CopyCheckForFileExistenceResult(bool* out, bool value) {
*out = value;
}
} // namespace
class DownloadHandlerTest : public testing::Test {
public:
DownloadHandlerTest()
: ui_thread_(content::BrowserThread::UI, &message_loop_),
download_manager_(new content::MockDownloadManager) {}
virtual void SetUp() OVERRIDE {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
// Set expectations for download item.
EXPECT_CALL(download_item_, GetState())
.WillRepeatedly(Return(content::DownloadItem::IN_PROGRESS));
// Set expectations for file system to save argument callbacks.
EXPECT_CALL(file_system_, GetResourceEntryByPath(_, _))
.WillRepeatedly(SaveArg<1>(&get_entry_info_callback_));
EXPECT_CALL(file_system_, CreateDirectory(_, _, _, _))
.WillRepeatedly(SaveArg<3>(&create_directory_callback_));
file_write_helper_.reset(new FileWriteHelper(&file_system_));
download_handler_.reset(
new DownloadHandler(file_write_helper_.get(), &file_system_));
download_handler_->Initialize(download_manager_.get(), temp_dir_.path());
}
virtual void TearDown() OVERRIDE {
}
protected:
base::ScopedTempDir temp_dir_;
base::MessageLoopForUI message_loop_;
content::TestBrowserThread ui_thread_;
scoped_ptr<content::MockDownloadManager> download_manager_;
MockFileSystem file_system_;
scoped_ptr<FileWriteHelper> file_write_helper_;
scoped_ptr<DownloadHandler> download_handler_;
content::MockDownloadItem download_item_;
// Argument callbacks passed to the file system.
GetResourceEntryCallback get_entry_info_callback_;
FileOperationCallback create_directory_callback_;
};
TEST_F(DownloadHandlerTest, SubstituteDriveDownloadPathNonDrivePath) {
const base::FilePath non_drive_path(FILE_PATH_LITERAL("/foo/bar"));
ASSERT_FALSE(util::IsUnderDriveMountPoint(non_drive_path));
// Call SubstituteDriveDownloadPath()
base::FilePath substituted_path;
download_handler_->SubstituteDriveDownloadPath(
non_drive_path,
&download_item_,
base::Bind(&CopySubstituteDriveDownloadPathResult, &substituted_path));
google_apis::test_util::RunBlockingPoolTask();
// Check the result.
EXPECT_EQ(non_drive_path, substituted_path);
EXPECT_FALSE(download_handler_->IsDriveDownload(&download_item_));
}
TEST_F(DownloadHandlerTest, SubstituteDriveDownloadPath) {
const base::FilePath drive_path =
util::GetDriveMountPointPath().AppendASCII("test.dat");
// Call SubstituteDriveDownloadPath()
base::FilePath substituted_path;
download_handler_->SubstituteDriveDownloadPath(
drive_path,
&download_item_,
base::Bind(&CopySubstituteDriveDownloadPathResult, &substituted_path));
google_apis::test_util::RunBlockingPoolTask();
// Return result of GetResourceEntryByPath(), destination directory found.
scoped_ptr<ResourceEntry> entry(new ResourceEntry);
ASSERT_FALSE(get_entry_info_callback_.is_null());
get_entry_info_callback_.Run(FILE_ERROR_OK, entry.Pass());
google_apis::test_util::RunBlockingPoolTask();
// Check the result.
EXPECT_TRUE(temp_dir_.path().IsParent(substituted_path));
ASSERT_TRUE(download_handler_->IsDriveDownload(&download_item_));
EXPECT_EQ(drive_path, download_handler_->GetTargetPath(&download_item_));
}
TEST_F(DownloadHandlerTest, SubstituteDriveDownloadPathGetEntryFailure) {
const base::FilePath drive_path =
util::GetDriveMountPointPath().AppendASCII("test.dat");
// Call SubstituteDriveDownloadPath()
base::FilePath substituted_path;
download_handler_->SubstituteDriveDownloadPath(
drive_path,
&download_item_,
base::Bind(&CopySubstituteDriveDownloadPathResult, &substituted_path));
google_apis::test_util::RunBlockingPoolTask();
// Return result of GetResourceEntryByPath(), failing for some reason.
ASSERT_FALSE(get_entry_info_callback_.is_null());
get_entry_info_callback_.Run(FILE_ERROR_FAILED,
scoped_ptr<ResourceEntry>());
google_apis::test_util::RunBlockingPoolTask();
// Check the result.
EXPECT_TRUE(substituted_path.empty());
}
TEST_F(DownloadHandlerTest, SubstituteDriveDownloadPathCreateDirectory) {
const base::FilePath drive_path =
util::GetDriveMountPointPath().AppendASCII("test.dat");
// Call SubstituteDriveDownloadPath()
base::FilePath substituted_path;
download_handler_->SubstituteDriveDownloadPath(
drive_path,
&download_item_,
base::Bind(&CopySubstituteDriveDownloadPathResult, &substituted_path));
google_apis::test_util::RunBlockingPoolTask();
// Return result of GetResourceEntryByPath(), destination directory not found.
ASSERT_FALSE(get_entry_info_callback_.is_null());
get_entry_info_callback_.Run(FILE_ERROR_NOT_FOUND,
scoped_ptr<ResourceEntry>());
google_apis::test_util::RunBlockingPoolTask();
// Return result of CreateDirecotry().
ASSERT_FALSE(create_directory_callback_.is_null());
create_directory_callback_.Run(FILE_ERROR_OK);
google_apis::test_util::RunBlockingPoolTask();
// Check the result.
EXPECT_TRUE(temp_dir_.path().IsParent(substituted_path));
ASSERT_TRUE(download_handler_->IsDriveDownload(&download_item_));
EXPECT_EQ(drive_path, download_handler_->GetTargetPath(&download_item_));
}
TEST_F(DownloadHandlerTest,
SubstituteDriveDownloadPathCreateDirectoryFailure) {
const base::FilePath drive_path =
util::GetDriveMountPointPath().AppendASCII("test.dat");
// Call SubstituteDriveDownloadPath()
base::FilePath substituted_path;
download_handler_->SubstituteDriveDownloadPath(
drive_path,
&download_item_,
base::Bind(&CopySubstituteDriveDownloadPathResult, &substituted_path));
google_apis::test_util::RunBlockingPoolTask();
// Return result of GetResourceEntryByPath(), destination directory not found.
ASSERT_FALSE(get_entry_info_callback_.is_null());
get_entry_info_callback_.Run(FILE_ERROR_NOT_FOUND,
scoped_ptr<ResourceEntry>());
google_apis::test_util::RunBlockingPoolTask();
// Return result of CreateDirecotry().
ASSERT_FALSE(create_directory_callback_.is_null());
create_directory_callback_.Run(FILE_ERROR_FAILED);
google_apis::test_util::RunBlockingPoolTask();
// Check the result.
EXPECT_TRUE(substituted_path.empty());
}
// content::SavePackage calls SubstituteDriveDownloadPath before creating
// DownloadItem.
TEST_F(DownloadHandlerTest, SubstituteDriveDownloadPathForSavePackage) {
const base::FilePath drive_path =
util::GetDriveMountPointPath().AppendASCII("test.dat");
// Call SubstituteDriveDownloadPath()
base::FilePath substituted_path;
download_handler_->SubstituteDriveDownloadPath(
drive_path,
NULL, // DownloadItem is not available at this moment.
base::Bind(&CopySubstituteDriveDownloadPathResult, &substituted_path));
google_apis::test_util::RunBlockingPoolTask();
// Return result of GetResourceEntryByPath(), destination directory found.
scoped_ptr<ResourceEntry> entry(new ResourceEntry);
ASSERT_FALSE(get_entry_info_callback_.is_null());
get_entry_info_callback_.Run(FILE_ERROR_OK, entry.Pass());
google_apis::test_util::RunBlockingPoolTask();
// Check the result of SubstituteDriveDownloadPath().
EXPECT_TRUE(temp_dir_.path().IsParent(substituted_path));
// |download_item_| is not a drive download yet.
EXPECT_FALSE(download_handler_->IsDriveDownload(&download_item_));
// Call SetDownloadParams().
download_handler_->SetDownloadParams(drive_path, &download_item_);
// |download_item_| is a drive download now.
ASSERT_TRUE(download_handler_->IsDriveDownload(&download_item_));
EXPECT_EQ(drive_path, download_handler_->GetTargetPath(&download_item_));
}
TEST_F(DownloadHandlerTest, CheckForFileExistence) {
const base::FilePath drive_path =
util::GetDriveMountPointPath().AppendASCII("test.dat");
// Make |download_item_| a drive download.
download_handler_->SetDownloadParams(drive_path, &download_item_);
ASSERT_TRUE(download_handler_->IsDriveDownload(&download_item_));
EXPECT_EQ(drive_path, download_handler_->GetTargetPath(&download_item_));
// Call CheckForFileExistence.
bool file_exists = false;
download_handler_->CheckForFileExistence(
&download_item_,
base::Bind(&CopyCheckForFileExistenceResult, &file_exists));
google_apis::test_util::RunBlockingPoolTask();
// Return result of GetResourceEntryByPath(), file exists.
{
scoped_ptr<ResourceEntry> entry(new ResourceEntry);
ASSERT_FALSE(get_entry_info_callback_.is_null());
get_entry_info_callback_.Run(FILE_ERROR_OK, entry.Pass());
}
google_apis::test_util::RunBlockingPoolTask();
// Check the result.
EXPECT_TRUE(file_exists);
// Reset callback to call CheckForFileExistence again.
get_entry_info_callback_.Reset();
// Call CheckForFileExistence again.
download_handler_->CheckForFileExistence(
&download_item_,
base::Bind(&CopyCheckForFileExistenceResult, &file_exists));
google_apis::test_util::RunBlockingPoolTask();
// Return result of GetResourceEntryByPath(), file does not exist.
ASSERT_FALSE(get_entry_info_callback_.is_null());
get_entry_info_callback_.Run(FILE_ERROR_NOT_FOUND,
scoped_ptr<ResourceEntry>());
google_apis::test_util::RunBlockingPoolTask();
// Check the result.
EXPECT_FALSE(file_exists);
}
} // namespace drive
|
