1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <map>
#include <string>
#include "base/bind.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/stl_util.h"
#include "base/values.h"
#include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
#include "chrome/browser/chromeos/settings/cros_settings.h"
#include "chrome/browser/chromeos/settings/device_settings_service.h"
#include "chrome/browser/chromeos/settings/device_settings_test_helper.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chromeos/settings/cros_settings_names.h"
#include "components/policy/core/common/cloud/cloud_policy_constants.h"
#include "content/public/test/test_browser_thread.h"
#include "policy/proto/device_management_backend.pb.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace em = enterprise_management;
namespace chromeos {
class CrosSettingsTest : public testing::Test {
protected:
CrosSettingsTest()
: ui_thread_(content::BrowserThread::UI, &message_loop_),
local_state_(TestingBrowserProcess::GetGlobal()),
settings_(DeviceSettingsService::Get()),
weak_factory_(this) {}
virtual ~CrosSettingsTest() {}
virtual void TearDown() OVERRIDE {
ASSERT_TRUE(expected_props_.empty());
STLDeleteValues(&expected_props_);
expected_props_.clear();
}
void FetchPref(const std::string& pref) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
if (expected_props_.find(pref) == expected_props_.end())
return;
if (CrosSettingsProvider::TRUSTED ==
settings_.PrepareTrustedValues(
base::Bind(&CrosSettingsTest::FetchPref,
weak_factory_.GetWeakPtr(), pref))) {
scoped_ptr<base::Value> expected_value(
expected_props_.find(pref)->second);
const base::Value* pref_value = settings_.GetPref(pref);
if (expected_value.get()) {
ASSERT_TRUE(pref_value);
ASSERT_TRUE(expected_value->Equals(pref_value));
} else {
ASSERT_FALSE(pref_value);
}
expected_props_.erase(pref);
}
}
void SetPref(const std::string& pref_name, const base::Value* value) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
settings_.Set(pref_name, *value);
}
void AddExpectation(const std::string& pref_name, base::Value* value) {
base::Value*& entry = expected_props_[pref_name];
delete entry;
entry = value;
}
void PrepareEmptyPolicy(em::PolicyData* policy) {
// Prepare some policy blob.
em::PolicyFetchResponse response;
em::ChromeDeviceSettingsProto pol;
policy->set_policy_type(policy::dm_protocol::kChromeDevicePolicyType);
policy->set_username("me@owner");
policy->set_policy_value(pol.SerializeAsString());
// Wipe the signed settings store.
response.set_policy_data(policy->SerializeAsString());
response.set_policy_data_signature("false");
}
static bool IsWhitelisted(CrosSettings* cs, const std::string& username) {
return cs->FindEmailInList(kAccountsPrefUsers, username, NULL);
}
base::MessageLoopForUI message_loop_;
content::TestBrowserThread ui_thread_;
ScopedTestingLocalState local_state_;
ScopedDeviceSettingsTestHelper device_settings_test_helper_;
CrosSettings settings_;
base::WeakPtrFactory<CrosSettingsTest> weak_factory_;
std::map<std::string, base::Value*> expected_props_;
};
TEST_F(CrosSettingsTest, SetPref) {
// Change to something that is not the default.
AddExpectation(kAccountsPrefAllowGuest, new base::FundamentalValue(false));
SetPref(kAccountsPrefAllowGuest, expected_props_[kAccountsPrefAllowGuest]);
FetchPref(kAccountsPrefAllowGuest);
ASSERT_TRUE(expected_props_.empty());
}
TEST_F(CrosSettingsTest, GetPref) {
// We didn't change the default so look for it.
AddExpectation(kAccountsPrefAllowGuest, new base::FundamentalValue(true));
FetchPref(kAccountsPrefAllowGuest);
}
TEST_F(CrosSettingsTest, SetWhitelist) {
// Setting the whitelist should also switch the value of
// kAccountsPrefAllowNewUser to false.
base::ListValue whitelist;
whitelist.Append(new base::StringValue("me@owner"));
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
SetPref(kAccountsPrefUsers, &whitelist);
FetchPref(kAccountsPrefAllowNewUser);
FetchPref(kAccountsPrefUsers);
}
TEST_F(CrosSettingsTest, SetWhitelistWithListOps) {
base::ListValue* whitelist = new base::ListValue();
base::StringValue hacky_user("h@xxor");
whitelist->Append(hacky_user.DeepCopy());
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
AddExpectation(kAccountsPrefUsers, whitelist);
// Add some user to the whitelist.
settings_.AppendToList(kAccountsPrefUsers, &hacky_user);
FetchPref(kAccountsPrefAllowNewUser);
FetchPref(kAccountsPrefUsers);
}
TEST_F(CrosSettingsTest, SetWhitelistWithListOps2) {
base::ListValue whitelist;
base::StringValue hacky_user("h@xxor");
base::StringValue lamy_user("l@mer");
whitelist.Append(hacky_user.DeepCopy());
base::ListValue* expected_list = whitelist.DeepCopy();
whitelist.Append(lamy_user.DeepCopy());
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
SetPref(kAccountsPrefUsers, &whitelist);
FetchPref(kAccountsPrefAllowNewUser);
FetchPref(kAccountsPrefUsers);
ASSERT_TRUE(expected_props_.empty());
// Now try to remove one element from that list.
AddExpectation(kAccountsPrefUsers, expected_list);
settings_.RemoveFromList(kAccountsPrefUsers, &lamy_user);
FetchPref(kAccountsPrefAllowNewUser);
FetchPref(kAccountsPrefUsers);
}
TEST_F(CrosSettingsTest, SetEmptyWhitelist) {
// Setting the whitelist empty should switch the value of
// kAccountsPrefAllowNewUser to true.
base::ListValue whitelist;
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(true));
SetPref(kAccountsPrefUsers, &whitelist);
FetchPref(kAccountsPrefAllowNewUser);
FetchPref(kAccountsPrefUsers);
}
TEST_F(CrosSettingsTest, SetEmptyWhitelistAndNoNewUsers) {
// Setting the whitelist empty and disallowing new users should result in no
// new users allowed.
base::ListValue whitelist;
base::FundamentalValue disallow_new(false);
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
SetPref(kAccountsPrefUsers, &whitelist);
SetPref(kAccountsPrefAllowNewUser, &disallow_new);
FetchPref(kAccountsPrefAllowNewUser);
FetchPref(kAccountsPrefUsers);
}
TEST_F(CrosSettingsTest, SetWhitelistAndNoNewUsers) {
// Setting the whitelist should allow us to set kAccountsPrefAllowNewUser to
// false (which is the implicit value too).
base::ListValue whitelist;
whitelist.Append(new base::StringValue("me@owner"));
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
SetPref(kAccountsPrefUsers, &whitelist);
SetPref(kAccountsPrefAllowNewUser,
expected_props_[kAccountsPrefAllowNewUser]);
FetchPref(kAccountsPrefAllowNewUser);
FetchPref(kAccountsPrefUsers);
}
TEST_F(CrosSettingsTest, SetAllowNewUsers) {
// Setting kAccountsPrefAllowNewUser to true with no whitelist should be ok.
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(true));
SetPref(kAccountsPrefAllowNewUser,
expected_props_[kAccountsPrefAllowNewUser]);
FetchPref(kAccountsPrefAllowNewUser);
}
TEST_F(CrosSettingsTest, SetEphemeralUsersEnabled) {
base::FundamentalValue ephemeral_users_enabled(true);
AddExpectation(kAccountsPrefEphemeralUsersEnabled,
new base::FundamentalValue(true));
SetPref(kAccountsPrefEphemeralUsersEnabled, &ephemeral_users_enabled);
FetchPref(kAccountsPrefEphemeralUsersEnabled);
}
TEST_F(CrosSettingsTest, FindEmailInList) {
base::ListValue list;
list.Append(new base::StringValue("user@example.com"));
list.Append(new base::StringValue("nodomain"));
list.Append(new base::StringValue("with.dots@gmail.com"));
list.Append(new base::StringValue("Upper@example.com"));
CrosSettings* cs = &settings_;
cs->Set(kAccountsPrefUsers, list);
EXPECT_TRUE(IsWhitelisted(cs, "user@example.com"));
EXPECT_FALSE(IsWhitelisted(cs, "us.er@example.com"));
EXPECT_TRUE(IsWhitelisted(cs, "USER@example.com"));
EXPECT_FALSE(IsWhitelisted(cs, "user"));
EXPECT_TRUE(IsWhitelisted(cs, "nodomain"));
EXPECT_TRUE(IsWhitelisted(cs, "nodomain@gmail.com"));
EXPECT_TRUE(IsWhitelisted(cs, "no.domain@gmail.com"));
EXPECT_TRUE(IsWhitelisted(cs, "NO.DOMAIN"));
EXPECT_TRUE(IsWhitelisted(cs, "with.dots@gmail.com"));
EXPECT_TRUE(IsWhitelisted(cs, "withdots@gmail.com"));
EXPECT_TRUE(IsWhitelisted(cs, "WITH.DOTS@gmail.com"));
EXPECT_TRUE(IsWhitelisted(cs, "WITHDOTS"));
EXPECT_TRUE(IsWhitelisted(cs, "Upper@example.com"));
EXPECT_FALSE(IsWhitelisted(cs, "U.pper@example.com"));
EXPECT_FALSE(IsWhitelisted(cs, "Upper"));
EXPECT_TRUE(IsWhitelisted(cs, "upper@example.com"));
}
TEST_F(CrosSettingsTest, FindEmailInListWildcard) {
base::ListValue list;
list.Append(new base::StringValue("user@example.com"));
list.Append(new base::StringValue("*@example.com"));
CrosSettings* cs = &settings_;
cs->Set(kAccountsPrefUsers, list);
bool wildcard_match = false;
EXPECT_TRUE(cs->FindEmailInList(
kAccountsPrefUsers, "test@example.com", &wildcard_match));
EXPECT_TRUE(wildcard_match);
EXPECT_TRUE(cs->FindEmailInList(
kAccountsPrefUsers, "user@example.com", &wildcard_match));
EXPECT_FALSE(wildcard_match);
EXPECT_TRUE(cs->FindEmailInList(
kAccountsPrefUsers, "*@example.com", &wildcard_match));
EXPECT_TRUE(wildcard_match);
}
} // namespace chromeos
|
