1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "chrome/browser/cocoa/bookmark_bar_folder_controller.h"
#include "base/mac_util.h"
#include "base/sys_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_utils.h"
#import "chrome/browser/browser_theme_provider.h"
#import "chrome/browser/cocoa/bookmark_bar_constants.h" // namespace bookmarks
#import "chrome/browser/cocoa/bookmark_bar_controller.h" // namespace bookmarks
#import "chrome/browser/cocoa/bookmark_bar_folder_view.h"
#import "chrome/browser/cocoa/bookmark_bar_folder_button_cell.h"
#import "chrome/browser/cocoa/bookmark_bar_folder_hover_state.h"
#import "chrome/browser/cocoa/bookmark_folder_target.h"
#import "chrome/browser/cocoa/browser_window_controller.h"
#import "chrome/browser/cocoa/event_utils.h"
namespace {
// Frequency of the scrolling timer in seconds.
const NSTimeInterval kBookmarkBarFolderScrollInterval = 0.2;
// Amount to scroll by per timer fire. We scroll rather slowly; to
// accomodate we do 2 at a time.
const CGFloat kBookmarkBarFolderScrollAmount =
2 * (bookmarks::kBookmarkButtonHeight +
bookmarks::kBookmarkVerticalPadding);
// Amount to scroll for each scroll wheel delta.
const CGFloat kBookmarkBarFolderScrollWheelAmount =
1 * (bookmarks::kBookmarkButtonHeight +
bookmarks::kBookmarkVerticalPadding);
// Our NSScrollView is supposed to be just barely big enough to fit its
// contentView. It is actually a hair too small.
// This turns on horizontal scrolling which, although slight, is awkward.
// Make sure our window (and NSScrollView) are wider than its documentView
// by at least this much.
const CGFloat kScrollViewContentWidthMargin = 2;
// When constraining a scrolling bookmark bar folder window to the
// screen, shrink the "constrain" by this much vertically. Currently
// this is 0.0 to avoid a problem with tracking areas leaving the
// window, but should probably be 8.0 or something.
// TODO(jrg): http://crbug.com/36225
const CGFloat kScrollWindowVerticalMargin = 0.0;
} // namespace
@interface BookmarkBarFolderController(Private)
- (void)configureWindow;
- (void)addOrUpdateScrollTracking;
- (void)removeScrollTracking;
- (void)endScroll;
- (void)addScrollTimerWithDelta:(CGFloat)delta;
// Determine the best button width (which will be the widest button or the
// maximum allowable button width, whichever is less) and resize all buttons.
// Return the new width (so that the window can be adjusted, if necessary).
- (CGFloat)adjustButtonWidths;
@end
@implementation BookmarkBarFolderController
- (id)initWithParentButton:(BookmarkButton*)button
parentController:(BookmarkBarFolderController*)parentController
barController:(BookmarkBarController*)barController {
NSString* nibPath =
[mac_util::MainAppBundle() pathForResource:@"BookmarkBarFolderWindow"
ofType:@"nib"];
if ((self = [super initWithWindowNibPath:nibPath owner:self])) {
parentButton_.reset([button retain]);
parentController_.reset([parentController retain]);
barController_ = barController; // WEAK
buttons_.reset([[NSMutableArray alloc] init]);
folderTarget_.reset([[BookmarkFolderTarget alloc] initWithController:self]);
[self configureWindow];
hoverState_.reset([[BookmarkBarFolderHoverState alloc] init]);
if (scrollable_)
[self addOrUpdateScrollTracking];
}
return self;
}
- (void)dealloc {
[self removeScrollTracking];
[self endScroll];
[hoverState_ draggingExited];
// Note: we don't need to
// [NSObject cancelPreviousPerformRequestsWithTarget:self];
// Because all of our performSelector: calls use withDelay: which
// retains us.
[super dealloc];
}
// Overriden from NSWindowController to call childFolderWillShow: before showing
// the window.
- (void)showWindow:(id)sender {
[parentController_ childFolderWillShow:self];
[super showWindow:sender];
}
- (BookmarkButtonCell*)cellForBookmarkNode:(const BookmarkNode*)child {
NSImage* image = child ? [barController_ favIconForNode:child] : nil;
NSMenu* menu = child ? child->is_folder() ? folderMenu_ : buttonMenu_ : nil;
BookmarkBarFolderButtonCell* cell =
[BookmarkBarFolderButtonCell buttonCellForNode:child
contextMenu:menu
cellText:nil
cellImage:image];
return cell;
}
// Redirect to our logic shared with BookmarkBarController.
- (IBAction)openBookmarkFolderFromButton:(id)sender {
[folderTarget_ openBookmarkFolderFromButton:sender];
}
// Create a bookmark button for the given node using frame.
//
// If |node| is NULL this is an "(empty)" button.
// Does NOT add this button to our button list.
// Returns an autoreleased button.
// Adjusts the input frame width as appropriate.
//
// TODO(jrg): combine with addNodesToButtonList: code from
// bookmark_bar_controller.mm, and generalize that to use both x and y
// offsets.
// http://crbug.com/35966
- (BookmarkButton*)makeButtonForNode:(const BookmarkNode*)node
frame:(NSRect)frame {
BookmarkButtonCell* cell = [self cellForBookmarkNode:node];
DCHECK(cell);
// We must decide if we draw the folder arrow before we ask the cell
// how big it needs to be.
if (node && node->is_folder()) {
// Warning when combining code with bookmark_bar_controller.mm:
// this call should NOT be made for the bar buttons; only for the
// subfolder buttons.
[cell setDrawFolderArrow:YES];
}
// The "+2" is needed because, sometimes, Cocoa is off by a tad when
// returning the value it thinks it needs.
CGFloat desired = [cell cellSize].width + 2;
// The width is determined from the maximum of the proposed width
// (provided in |frame|) or the natural width of the title, then
// limited by the abolute minimum and maximum allowable widths.
frame.size.width =
std::min(std::max(bookmarks::kBookmarkMenuButtonMinimumWidth,
std::max(frame.size.width, desired)),
bookmarks::kBookmarkMenuButtonMaximumWidth);
BookmarkButton* button = [[[BookmarkButton alloc] initWithFrame:frame]
autorelease];
DCHECK(button);
[button setCell:cell];
[button setDelegate:self];
if (node) {
if (node->is_folder()) {
[button setTarget:self];
[button setAction:@selector(openBookmarkFolderFromButton:)];
} else {
// Make the button do something.
[button setTarget:self];
[button setAction:@selector(openBookmark:)];
// Add a tooltip.
NSString* title = base::SysWideToNSString(node->GetTitle());
std::string urlString = node->GetURL().possibly_invalid_spec();
NSString* tooltip = [NSString stringWithFormat:@"%@\n%s", title,
urlString.c_str()];
[button setToolTip:tooltip];
}
} else {
[button setEnabled:NO];
[button setBordered:NO];
}
return button;
}
// Exposed for testing.
- (NSView*)mainView {
return mainView_;
}
- (BookmarkBarFolderController*)folderController {
return folderController_;
}
- (id)folderTarget {
return folderTarget_.get();
}
// Compute and return the top left point of our window (screen
// coordinates). The top left is positioned in a manner similar to
// cascading menus.
- (NSPoint)windowTopLeft {
NSPoint newWindowTopLeft;
if (![parentController_ isKindOfClass:[self class]]) {
// If we're not popping up from one of ourselves, we must be
// popping up from the bookmark bar itself. In this case, start
// BELOW the parent button. Our left is the button left; our top
// is bottom of button's parent view.
NSPoint buttonBottomLeftInScreen =
[[parentButton_ window]
convertBaseToScreen:[parentButton_
convertPoint:NSZeroPoint toView:nil]];
NSPoint bookmarkBarBottomLeftInScreen =
[[parentButton_ window]
convertBaseToScreen:[[parentButton_ superview]
convertPoint:NSZeroPoint toView:nil]];
newWindowTopLeft = NSMakePoint(buttonBottomLeftInScreen.x,
bookmarkBarBottomLeftInScreen.y);
} else {
// Our parent controller is another BookmarkBarFolderController.
// In this case, start with a slight overlap on the RIGHT of the
// parent button, which looks much more menu-like than with none.
// Start to RIGHT of the button.
// TODO(jrg): If too far to right, pop left again.
// http://crbug.com/36225
newWindowTopLeft.x = NSMaxX([[parentButton_ window] frame]) -
bookmarks::kBookmarkMenuOverlap;
NSPoint top = NSMakePoint(0, (NSMaxY([parentButton_ frame]) +
bookmarks::kBookmarkVerticalPadding));
NSPoint topOfWindow =
[[parentButton_ window]
convertBaseToScreen:[[parentButton_ superview]
convertPoint:top toView:nil]];
newWindowTopLeft.y = topOfWindow.y;
}
return newWindowTopLeft;
}
// Set our window level to the right spot so we're above the menubar, dock, etc.
// Factored out so we can override/noop in a unit test.
- (void)configureWindowLevel {
[[self window] setLevel:NSPopUpMenuWindowLevel];
}
// Determine window size and position.
// Create buttons for all our nodes.
// TODO(jrg): break up into more and smaller routines for easier unit testing.
- (void)configureWindow {
NSPoint newWindowTopLeft = [self windowTopLeft];
const BookmarkNode* node = [parentButton_ bookmarkNode];
DCHECK(node);
int startingIndex = [[parentButton_ cell] startingChildIndex];
DCHECK_LE(startingIndex, node->GetChildCount());
// Must have at least 1 button (for "empty")
int buttons = std::max(node->GetChildCount() - startingIndex, 1);
// Prelim height of the window. We'll trim later as needed.
int height = buttons * bookmarks::kBookmarkButtonHeight;
// We'll need this soon...
[self window];
// TODO(jrg): combine with frame code in bookmark_bar_controller.mm
// http://crbug.com/35966
NSRect buttonsOuterFrame = NSMakeRect(
bookmarks::kBookmarkHorizontalPadding,
height - (bookmarks::kBookmarkBarHeight -
bookmarks::kBookmarkVerticalPadding),
bookmarks::kDefaultBookmarkWidth,
(bookmarks::kBookmarkBarHeight -
2 * bookmarks::kBookmarkVerticalPadding));
// TODO(jrg): combine with addNodesToButtonList: code from
// bookmark_bar_controller.mm (but use y offset)
// http://crbug.com/35966
if (!node->GetChildCount()) {
// If no children we are the empty button.
BookmarkButton* button = [self makeButtonForNode:nil
frame:buttonsOuterFrame];
[buttons_ addObject:button];
[mainView_ addSubview:button];
} else {
for (int i = startingIndex;
i < node->GetChildCount();
i++) {
const BookmarkNode* child = node->GetChild(i);
BookmarkButton* button = [self makeButtonForNode:child
frame:buttonsOuterFrame];
[buttons_ addObject:button];
[mainView_ addSubview:button];
buttonsOuterFrame.origin.y -= bookmarks::kBookmarkBarHeight;
}
}
// Now that all buttons have been installed, adjust their sizes to be
// consistent, determine the best size for the window, and set the window.
CGFloat width =
[self adjustButtonWidths] + (2 * bookmarks::kBookmarkVerticalPadding);
NSRect windowFrame = NSMakeRect(newWindowTopLeft.x,
newWindowTopLeft.y - height,
width + kScrollViewContentWidthMargin,
height);
// Make the window fit on screen, with a distance of at least |padding| from
// the sides.
DCHECK([[self window] screen]);
NSRect screenFrame = [[[self window] screen] frame];
const CGFloat padding = 8;
if (NSMaxX(windowFrame) + padding > NSMaxX(screenFrame))
windowFrame.origin.x -= NSMaxX(windowFrame) + padding - NSMaxX(screenFrame);
// No 'else' to provide preference for the left side of the menu
// being visible if neither one fits. Wish I had an "bool isL2R()"
// function right here.
if (NSMinX(windowFrame) - padding < NSMinX(screenFrame))
windowFrame.origin.x += NSMinX(screenFrame) - NSMinX(windowFrame) + padding;
// Make the scrolled content be the right size (full size).
NSRect mainViewFrame = NSMakeRect(0, 0,
NSWidth(windowFrame) -
kScrollViewContentWidthMargin,
NSHeight(windowFrame));
[mainView_ setFrame:mainViewFrame];
// Make sure the window fits on the screen. If not, constrain.
// We'll scroll to allow the user to see all the content.
screenFrame = NSInsetRect(screenFrame, 0, kScrollWindowVerticalMargin);
if (!NSContainsRect(screenFrame, windowFrame)) {
scrollable_ = YES;
windowFrame = NSIntersectionRect(screenFrame, windowFrame);
}
[[self window] setFrame:windowFrame display:YES];
if (scrollable_) {
[mainView_ scrollPoint:NSMakePoint(0, (NSHeight(mainViewFrame) -
NSHeight(windowFrame)))];
}
// Finally pop me up.
[self configureWindowLevel];
}
- (void)offsetFolderMenuWindow:(NSSize)offset {
NSWindow* window = [self window];
NSRect windowFrame = [window frame];
windowFrame.origin.x -= offset.width;
windowFrame.origin.y += offset.height; // Yes, in the opposite direction!
[window setFrame:windowFrame display:YES];
[folderController_ offsetFolderMenuWindow:offset];
}
// TODO(mrossetti): See if the following can be moved into view's viewWillDraw:.
- (CGFloat)adjustButtonWidths {
CGFloat width = 0.0;
for (BookmarkButton* button in buttons_.get()) {
width = std::max(width, NSWidth([button bounds]));
}
width = std::min(width, bookmarks::kBookmarkMenuButtonMaximumWidth);
// Things look and feel more menu-like if all the buttons are the
// full width of the window, especially if there are submenus.
for (BookmarkButton* button in buttons_.get()) {
NSRect buttonFrame = [button frame];
buttonFrame.size.width = width;
[button setFrame:buttonFrame];
}
return width;
}
#pragma mark BookmarkButtonControllerProtocol
- (void)addButtonForNode:(const BookmarkNode*)node
atIndex:(NSInteger)buttonIndex {
if (buttonIndex == -1)
buttonIndex = [buttons_ count];
// Remember the last moved button's frame or the default.
NSRect buttonFrame = NSMakeRect(bookmarks::kBookmarkHorizontalPadding,
NSHeight([mainView_ frame]) + bookmarks::kBookmarkBarHeight +
bookmarks::kBookmarkVerticalPadding,
NSWidth([mainView_ frame]) - 2 * bookmarks::kBookmarkHorizontalPadding
- kScrollViewContentWidthMargin,
bookmarks::kBookmarkBarHeight - 2 * bookmarks::kBookmarkVerticalPadding);
BookmarkButton* button = nil; // Remember so it can be inavalidated.
for (NSInteger i = 0; i < buttonIndex; ++i) {
button = [buttons_ objectAtIndex:i];
buttonFrame = [button frame];
buttonFrame.origin.y += bookmarks::kBookmarkBarHeight;
[button setFrame:buttonFrame];
}
[[button cell] mouseExited:nil]; // De-highlight.
buttonFrame.origin.y -= bookmarks::kBookmarkBarHeight;
BookmarkButton* newButton = [self makeButtonForNode:node
frame:buttonFrame];
[buttons_ insertObject:newButton atIndex:buttonIndex];
[mainView_ addSubview:newButton];
// Close any child folder(s) which may still be open.
[self closeBookmarkFolder:self];
// Update all button widths in case more width is needed.
CGFloat windowWidth =
[self adjustButtonWidths] + (2 * bookmarks::kBookmarkVerticalPadding) +
kScrollViewContentWidthMargin;
// Update vertical metrics of the window and the main view (using sizers
// does not do what we want).
NSWindow* window = [self window];
NSRect frame = [mainView_ frame];
const CGFloat verticalDelta =
bookmarks::kBookmarkBarHeight - bookmarks::kBookmarkVerticalPadding;
frame.size.height += verticalDelta;
frame.size.width = windowWidth;
[mainView_ setFrame:frame];
frame = [window frame];
frame.origin.y -= bookmarks::kBookmarkBarHeight;
frame.size.height += bookmarks::kBookmarkBarHeight;
frame.size.width = windowWidth;
[window setFrame:frame display:YES];
}
- (void)moveButtonFromIndex:(NSInteger)fromIndex toIndex:(NSInteger)toIndex {
if (fromIndex != toIndex) {
if (toIndex == -1)
toIndex = [buttons_ count];
BookmarkButton* movedButton = [buttons_ objectAtIndex:fromIndex];
[buttons_ removeObjectAtIndex:fromIndex];
NSRect movedFrame = [movedButton frame];
NSPoint toOrigin = movedFrame.origin;
[movedButton setHidden:YES];
if (fromIndex < toIndex) {
BookmarkButton* targetButton = [buttons_ objectAtIndex:toIndex - 1];
toOrigin = [targetButton frame].origin;
for (NSInteger i = fromIndex; i < toIndex; ++i) {
BookmarkButton* button = [buttons_ objectAtIndex:i];
NSRect frame = [button frame];
frame.origin.y += bookmarks::kBookmarkBarHeight;
[button setFrameOrigin:frame.origin];
}
} else {
BookmarkButton* targetButton = [buttons_ objectAtIndex:toIndex];
toOrigin = [targetButton frame].origin;
for (NSInteger i = fromIndex - 1; i >= toIndex; --i) {
BookmarkButton* button = [buttons_ objectAtIndex:i];
NSRect buttonFrame = [button frame];
buttonFrame.origin.y -= bookmarks::kBookmarkBarHeight;
[button setFrameOrigin:buttonFrame.origin];
}
}
[buttons_ insertObject:movedButton atIndex:toIndex];
[movedButton setFrameOrigin:toOrigin];
[movedButton setHidden:NO];
}
}
// TODO(jrg): Refactor BookmarkBarFolder common code. http://crbug.com/35966
- (void)removeButton:(NSInteger)buttonIndex animate:(BOOL)animate {
// TODO(mrossetti): Get disappearing animation to work. http://crbug.com/42360
NSWindow* window = [self window];
BookmarkButton* oldButton = [buttons_ objectAtIndex:buttonIndex];
NSRect poofFrame = [oldButton bounds];
NSPoint poofPoint = NSMakePoint(NSMidX(poofFrame), NSMidY(poofFrame));
poofPoint = [oldButton convertPoint:poofPoint toView:nil];
poofPoint = [[oldButton window] convertBaseToScreen:poofPoint];
[oldButton removeFromSuperview];
if (animate)
NSShowAnimationEffect(NSAnimationEffectDisappearingItemDefault, poofPoint,
NSZeroSize, nil, nil, nil);
[buttons_ removeObjectAtIndex:buttonIndex];
for (NSInteger i = 0; i < buttonIndex; ++i) {
BookmarkButton* button = [buttons_ objectAtIndex:i];
NSRect buttonFrame = [button frame];
buttonFrame.origin.y -= bookmarks::kBookmarkBarHeight;
[button setFrame:buttonFrame];
}
// Search for and adjust submenus, if necessary.
NSInteger buttonCount = [buttons_ count];
BookmarkButton* subButton = [folderController_ parentButton];
for (NSInteger i = buttonIndex; i < buttonCount; ++i) {
BookmarkButton* aButton = [buttons_ objectAtIndex:i];
// If this button is showing its menu then we need to move the menu, too.
if (aButton == subButton)
[folderController_ offsetFolderMenuWindow:NSMakeSize(0.0,
bookmarks::kBookmarkBarHeight)];
}
// Resize the window and the main view (using sizers does not work).
NSRect frame = [window frame];
frame.origin.y += bookmarks::kBookmarkBarHeight;
frame.size.height -= bookmarks::kBookmarkBarHeight;
[window setFrame:frame display:YES];
frame = [mainView_ frame];
frame.origin.y += bookmarks::kBookmarkBarHeight;
frame.size.height -= bookmarks::kBookmarkBarHeight;
[mainView_ setFrame:frame];
}
- (id<BookmarkButtonControllerProtocol>)controllerForNode:
(const BookmarkNode*)node {
// See if we are holding this node, otherwise see if it is in our
// hierarchy of visible folder menus.
if ([parentButton_ bookmarkNode] == node)
return self;
return [folderController_ controllerForNode:node];
}
// Start a "scroll up" timer.
- (void)beginScrollWindowUp {
[self addScrollTimerWithDelta:kBookmarkBarFolderScrollAmount];
}
// Start a "scroll down" timer.
- (void)beginScrollWindowDown {
[self addScrollTimerWithDelta:-kBookmarkBarFolderScrollAmount];
}
// End a scrolling timer. Can be called excessively with no harm.
- (void)endScroll {
if (scrollTimer_) {
[scrollTimer_ invalidate];
scrollTimer_ = nil;
verticalScrollDelta_ = 0;
}
}
// Perform a single scroll of the specified amount.
// Scroll up:
// Scroll the documentView by the growth amount.
// If we cannot grow the window, simply scroll the documentView.
// If we can grow the window up without falling off the screen, do it.
// Scroll down:
// Never change the window size; only scroll the documentView.
- (void)performOneScroll:(CGFloat)delta {
NSRect windowFrame = [[self window] frame];
NSRect screenFrame = [[[self window] screen] frame];
// First scroll the "document" area.
NSPoint scrollPosition = [scrollView_ documentVisibleRect].origin;
scrollPosition.y -= delta;
[[scrollView_ documentView] scrollPoint:scrollPosition];
// On 10.6 event dispatch for an NSButtonCell's
// showsBorderOnlyWhileMouseInside seems broken if scrolling the
// view that contains the button. It appears that a mouseExited:
// gets lost, so the button stays highlit forever. We accomodate
// here.
if (buttonThatMouseIsIn_) {
[[buttonThatMouseIsIn_ cell] setShowsBorderOnlyWhileMouseInside:NO];
[[buttonThatMouseIsIn_ cell] setShowsBorderOnlyWhileMouseInside:YES];
}
// We update the window size after shifting the scroll to avoid a race.
CGFloat screenHeightMinusMargin = (NSHeight(screenFrame) -
(2 * kScrollWindowVerticalMargin));
if (delta) {
// If we can, grow the window (up).
if (NSHeight(windowFrame) < screenHeightMinusMargin) {
CGFloat growAmount = delta;
// Don't scroll more than enough to "finish".
if (scrollPosition.y < 0)
growAmount += scrollPosition.y;
windowFrame.size.height += growAmount;
windowFrame.size.height = std::min(NSHeight(windowFrame),
screenHeightMinusMargin);
// Don't allow scrolling to make the window smaller, ever. This
// conditional is important when processing scrollWheel events.
if (windowFrame.size.height > [[self window] frame].size.height) {
[[self window] setFrame:windowFrame display:YES];
[self addOrUpdateScrollTracking];
}
}
}
// If we're at either end, happiness.
if ((scrollPosition.y <= 0) ||
((scrollPosition.y + NSHeight(windowFrame) >=
NSHeight([mainView_ frame])) &&
(windowFrame.size.height == screenHeightMinusMargin))) {
[self endScroll];
// If the entire view is now visible the window is no longer scrollable.
if (NSHeight([mainView_ visibleRect]) == NSHeight([mainView_ bounds])) {
scrollable_ = NO;
[self removeScrollTracking];
}
}
}
// Perform a scroll of the window on the screen.
// Called by a timer when scrolling.
- (void)performScroll:(NSTimer*)timer {
DCHECK(verticalScrollDelta_);
[self performOneScroll:verticalScrollDelta_];
}
// Add a timer to fire at a regular interveral which scrolls the
// window vertically |delta|.
- (void)addScrollTimerWithDelta:(CGFloat)delta {
if (scrollTimer_ && verticalScrollDelta_ == delta)
return;
[self endScroll];
verticalScrollDelta_ = delta;
scrollTimer_ =
[NSTimer scheduledTimerWithTimeInterval:kBookmarkBarFolderScrollInterval
target:self
selector:@selector(performScroll:)
userInfo:nil
repeats:YES];
}
// Called as a result of our tracking area. Warning: on the main
// screen (of a single-screened machine), the minimum mouse y value is
// 1, not 0. Also, we do not get events when the mouse is above the
// menubar (to be fixed by setting the proper window level; see
// initializer).
- (void)mouseMoved:(NSEvent*)theEvent {
DCHECK([theEvent window] == [self window]);
NSPoint eventScreenLocation =
[[theEvent window] convertBaseToScreen:[theEvent locationInWindow]];
NSRect visibleRect = [[[self window] screen] visibleFrame];
CGFloat closeToTopOfScreen = NSMaxY(visibleRect) -
kBookmarkBarFolderScrollAmount;
CGFloat closeToBottomOfScreen = NSMinY(visibleRect) +
kBookmarkBarFolderScrollAmount;
if (eventScreenLocation.y <= closeToBottomOfScreen) {
[self beginScrollWindowUp];
} else if (eventScreenLocation.y > closeToTopOfScreen) {
[self beginScrollWindowDown];
} else {
[self endScroll];
}
}
- (void)mouseExited:(NSEvent*)theEvent {
[self endScroll];
}
// Add a tracking area so we know when the mouse is pinned to the top
// or bottom of the screen. If that happens, and if the mouse
// position overlaps the window, scroll it.
- (void)addOrUpdateScrollTracking {
[self removeScrollTracking];
NSView* view = [[self window] contentView];
scrollTrackingArea_.reset([[NSTrackingArea alloc]
initWithRect:[view bounds]
options:(NSTrackingMouseMoved |
NSTrackingMouseEnteredAndExited |
NSTrackingActiveAlways)
owner:self
userInfo:nil]);
[view addTrackingArea:scrollTrackingArea_];
}
// Remove the tracking area associated with scrolling.
- (void)removeScrollTracking {
if (scrollTrackingArea_.get()) {
[[[self window] contentView] removeTrackingArea:scrollTrackingArea_];
}
scrollTrackingArea_.reset();
}
- (ThemeProvider*)themeProvider {
return [parentController_ themeProvider];
}
- (void)childFolderWillShow:(id<BookmarkButtonControllerProtocol>)child {
// Do nothing.
}
- (void)childFolderWillClose:(id<BookmarkButtonControllerProtocol>)child {
// Do nothing.
}
// Recursively close all bookmark folders.
- (void)closeAllBookmarkFolders {
// Closing the top level implicitly closes all children.
[barController_ closeAllBookmarkFolders];
}
// Close our bookmark folder (a sub-controller) if we have one.
- (void)closeBookmarkFolder:(id)sender {
// folderController_ may be nil but that's OK.
[[folderController_ window] close];
folderController_ = nil;
}
// Delegate callback.
- (void)windowWillClose:(NSNotification*)notification {
[parentController_ childFolderWillClose:self];
[self closeBookmarkFolder:self];
[self autorelease];
}
- (BookmarkButton*)parentButton {
return parentButton_.get();
}
// Delegate method. Shared implementation with BookmarkBarController.
- (void)fillPasteboard:(NSPasteboard*)pboard
forDragOfButton:(BookmarkButton*)button {
[[self folderTarget] fillPasteboard:pboard forDragOfButton:button];
// Close our folder menu and submenus since we know we're going to be dragged.
[self closeBookmarkFolder:self];
}
// Find something like std::is_between<T>? I can't believe one doesn't exist.
// http://crbug.com/35966
static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {
return ((value >= low) && (value <= high));
}
// Return the proposed drop target for a hover open button, or nil if none.
//
// TODO(jrg): this is just like the version in
// bookmark_bar_controller.mm, but vertical instead of horizontal.
// Generalize to be axis independent then share code.
// http://crbug.com/35966
// Get UI review on "middle half" ness.
// http://crbug.com/36276
- (BookmarkButton*)buttonForDroppingOnAtPoint:(NSPoint)point {
for (BookmarkButton* button in buttons_.get()) {
// No early break -- makes no assumption about button ordering.
// Intentionally NOT using NSPointInRect() so that scrolling into
// a submenu doesn't cause it to be closed.
if (ValueInRangeInclusive(NSMinY([button frame]),
point.y,
NSMaxY([button frame]))) {
// Over a button but let's be a little more specific
// (e.g. over the middle half).
NSRect frame = [button frame];
NSRect middleHalfOfButton = NSInsetRect(frame, 0, frame.size.height / 4);
if (ValueInRangeInclusive(NSMinY(middleHalfOfButton),
point.y,
NSMaxY(middleHalfOfButton))) {
// It makes no sense to drop on a non-folder; there is no hover.
if (![button isFolder])
return nil;
// Got it!
return button;
} else {
// Over a button but not over the middle half.
return nil;
}
}
}
// Not hovering over a button.
return nil;
}
// TODO(jrg): Refactor BookmarkBarFolder common code. http://crbug.com/35966
// Most of the work (e.g. drop indicator) is taken care of in the
// folder_view. Here we handle hover open issues for subfolders.
// Caution: there are subtle differences between this one and
// bookmark_bar_controller.mm's version.
- (NSDragOperation)draggingEntered:(id<NSDraggingInfo>)info {
NSPoint currentLocation = [info draggingLocation];
BookmarkButton* button = [self buttonForDroppingOnAtPoint:currentLocation];
// Don't allow drops that would result in cycles.
if (button) {
NSData* data = [[info draggingPasteboard]
dataForType:kBookmarkButtonDragType];
if (data && [info draggingSource]) {
BookmarkButton* sourceButton = nil;
[data getBytes:&sourceButton length:sizeof(sourceButton)];
const BookmarkNode* sourceNode = [sourceButton bookmarkNode];
const BookmarkNode* destNode = [button bookmarkNode];
if (destNode->HasAncestor(sourceNode))
button = nil;
}
}
// Delegate handling of dragging over a button to the |hoverState_| member.
return [hoverState_ draggingEnteredButton:button];
}
// Unlike bookmark_bar_controller, we need to keep track of dragging state.
// We also need to make sure we cancel the delayed hover close.
- (void)draggingExited:(id<NSDraggingInfo>)info {
// NOT the same as a cancel --> we may have moved the mouse into the submenu.
// Delegate handling of the hover button to the |hoverState_| member.
[hoverState_ draggingExited];
}
- (BOOL)dragShouldLockBarVisibility {
return [parentController_ dragShouldLockBarVisibility];
}
- (NSWindow*)browserWindow {
return [parentController_ browserWindow];
}
// TODO(jrg): again we have code dup, sort of, with
// bookmark_bar_controller.mm, but the axis is changed. One minor
// difference is accomodation for the "empty" button (which may not
// exist in the future).
// http://crbug.com/35966
- (int)indexForDragOfButton:(BookmarkButton*)sourceButton
toPoint:(NSPoint)point {
DCHECK([sourceButton isKindOfClass:[BookmarkButton class]]);
// Identify which buttons we are between. For now, assume a button
// location is at the center point of its view, and that an exact
// match means "place before".
// TODO(jrg): revisit position info based on UI team feedback.
// dropLocation is in bar local coordinates.
// http://crbug.com/36276
NSPoint dropLocation =
[mainView_ convertPoint:point
fromView:[[self window] contentView]];
BookmarkButton* buttonToTheTopOfDraggedButton = nil;
// Buttons are laid out in this array from top to bottom (screen
// wise), which means "biggest y" --> "smallest y".
for (BookmarkButton* button in buttons_.get()) {
CGFloat midpoint = NSMidY([button frame]);
if (dropLocation.y > midpoint) {
break;
}
buttonToTheTopOfDraggedButton = button;
}
// TODO(jrg): On Windows, dropping onto (empty) highlights the
// entire drop location and does not use an insertion point.
// http://crbug.com/35967
if (!buttonToTheTopOfDraggedButton) {
// We are at the very top (we broke out of the loop on the first try).
return 0;
}
if ([buttonToTheTopOfDraggedButton isEmpty]) {
// There is a button but it's an empty placeholder.
// Default to inserting on top of it.
return 0;
}
const BookmarkNode* beforeNode = [buttonToTheTopOfDraggedButton
bookmarkNode];
DCHECK(beforeNode);
// Be careful if the number of buttons != number of nodes.
return ((beforeNode->GetParent()->IndexOfChild(beforeNode) + 1) -
[[parentButton_ cell] startingChildIndex]);
}
- (BookmarkModel*)bookmarkModel {
return [barController_ bookmarkModel];
}
// TODO(jrg): ARGH more code dup.
// http://crbug.com/35966
- (BOOL)dragButton:(BookmarkButton*)sourceButton
to:(NSPoint)point
copy:(BOOL)copy {
DCHECK([sourceButton isKindOfClass:[BookmarkButton class]]);
const BookmarkNode* sourceNode = [sourceButton bookmarkNode];
DCHECK(sourceNode);
// Drop destination.
const BookmarkNode* destParent = NULL;
int destIndex = 0;
// First check if we're dropping on a button. If we have one, and
// it's a folder, drop in it.
BookmarkButton* button = [self buttonForDroppingOnAtPoint:point];
if ([button isFolder]) {
destParent = [button bookmarkNode];
// Drop it at the end.
destIndex = [button bookmarkNode]->GetChildCount();
} else {
// Else we're dropping somewhere in the folder, so find the right spot.
destParent = [parentButton_ bookmarkNode];
destIndex = [self indexForDragOfButton:sourceButton toPoint:point];
// Be careful if the number of buttons != number of nodes.
destIndex += [[parentButton_ cell] startingChildIndex];
}
// Prevent cycles.
BOOL wasCopiedOrMoved = NO;
if (!destParent->HasAncestor(sourceNode)) {
if (copy)
[self bookmarkModel]->Copy(sourceNode, destParent, destIndex);
else
[self bookmarkModel]->Move(sourceNode, destParent, destIndex);
wasCopiedOrMoved = YES;
// Movement of a node triggers observers (like us) to rebuild the
// bar so we don't have to do so explicitly.
}
return wasCopiedOrMoved;
}
// Return YES if we should show the drop indicator, else NO.
// TODO(jrg): ARGH code dup!
// http://crbug.com/35966
- (BOOL)shouldShowIndicatorShownForPoint:(NSPoint)point {
return ![self buttonForDroppingOnAtPoint:point];
}
// Return the y position for a drop indicator.
//
// TODO(jrg): again we have code dup, sort of, with
// bookmark_bar_controller.mm, but the axis is changed.
// http://crbug.com/35966
- (CGFloat)indicatorPosForDragOfButton:(BookmarkButton*)sourceButton
toPoint:(NSPoint)point {
CGFloat y = 0;
int destIndex = [self indexForDragOfButton:sourceButton toPoint:point];
int numButtons = static_cast<int>([buttons_ count]);
// If it's a drop strictly between existing buttons or at the very beginning
if (destIndex >= 0 && destIndex < numButtons) {
// ... put the indicator right between the buttons.
BookmarkButton* button =
[buttons_ objectAtIndex:static_cast<NSUInteger>(destIndex)];
DCHECK(button);
NSRect buttonFrame = [button frame];
y = buttonFrame.origin.y +
buttonFrame.size.height +
0.5 * bookmarks::kBookmarkVerticalPadding;
// If it's a drop at the end (past the last button, if there are any) ...
} else if (destIndex == numButtons) {
// and if it's past the last button ...
if (numButtons > 0) {
// ... find the last button, and put the indicator below it.
BookmarkButton* button =
[buttons_ objectAtIndex:static_cast<NSUInteger>(destIndex - 1)];
DCHECK(button);
NSRect buttonFrame = [button frame];
y = buttonFrame.origin.y -
0.5 * bookmarks::kBookmarkVerticalPadding;
}
} else {
NOTREACHED();
}
return y;
}
// Close the old hover-open bookmark folder, and open a new one. We
// do both in one step to allow for a delay in closing the old one.
// See comments above kDragHoverCloseDelay (bookmark_bar_controller.h)
// for more details.
- (void)openBookmarkFolderFromButtonAndCloseOldOne:(id)sender {
// If an old submenu exists, close it immediately.
[self closeBookmarkFolder:sender];
// Open a new one if meaningful.
if ([sender isFolder])
[folderTarget_ openBookmarkFolderFromButton:sender];
}
// Called from BookmarkButton.
// Unlike bookmark_bar_controller's version, we DO default to being enabled.
- (void)mouseEnteredButton:(id)sender event:(NSEvent*)event {
buttonThatMouseIsIn_ = sender;
// Cancel a previous hover if needed.
[NSObject cancelPreviousPerformRequestsWithTarget:self];
// If already opened, then we exited but re-entered the button
// (without entering another button open), do nothing.
if ([folderController_ parentButton] == sender)
return;
[self performSelector:@selector(openBookmarkFolderFromButtonAndCloseOldOne:)
withObject:sender
afterDelay:bookmarks::kHoverOpenDelay];
}
// Called from the BookmarkButton
- (void)mouseExitedButton:(id)sender event:(NSEvent*)event {
if (buttonThatMouseIsIn_ == sender)
buttonThatMouseIsIn_ = nil;
// Stop any timer about opening a new hover-open folder.
// Since a performSelector:withDelay: on self retains self, it is
// possible that a cancelPreviousPerformRequestsWithTarget: reduces
// the refcount to 0, releasing us. That's a bad thing to do while
// this object (or others it may own) is in the event chain. Thus
// we have a retain/autorelease.
[self retain];
[NSObject cancelPreviousPerformRequestsWithTarget:self];
[self autorelease];
}
- (void)openAll:(const BookmarkNode*)node
disposition:(WindowOpenDisposition)disposition {
[parentController_ openAll:node disposition:disposition];
}
// Add a new folder controller as triggered by the given folder button.
- (void)addNewFolderControllerWithParentButton:(BookmarkButton*)parentButton {
if (folderController_)
[self closeAllBookmarkFolders];
// Folder controller, like many window controllers, owns itself.
folderController_ =
[[BookmarkBarFolderController alloc] initWithParentButton:parentButton
parentController:self
barController:barController_];
[folderController_ showWindow:self];
}
- (NSArray*)buttons {
return buttons_.get();
}
- (void)close {
[folderController_ close];
[super close];
}
- (void)scrollWheel:(NSEvent *)theEvent {
if (scrollable_) {
// We go negative since an NSScrollView has a flipped coordinate frame.
CGFloat amt = kBookmarkBarFolderScrollWheelAmount * -[theEvent deltaY];
[self performOneScroll:amt];
}
}
- (void)reconfigureMenu {
for (BookmarkButton* button in buttons_.get())
[button removeFromSuperview];
[buttons_ removeAllObjects];
[self configureWindow];
}
#pragma mark Methods Forwarded to BookmarkBarController
- (IBAction)cutBookmark:(id)sender {
[self closeBookmarkFolder:self];
[barController_ cutBookmark:sender];
}
- (IBAction)copyBookmark:(id)sender {
[barController_ copyBookmark:sender];
}
- (IBAction)pasteBookmark:(id)sender {
[barController_ pasteBookmark:sender];
}
- (IBAction)deleteBookmark:(id)sender {
[self closeBookmarkFolder:self];
[barController_ deleteBookmark:sender];
}
- (IBAction)openBookmark:(id)sender {
[barController_ openBookmark:sender];
}
- (IBAction)addFolder:(id)sender {
[barController_ addFolder:sender];
}
- (IBAction)addPage:(id)sender {
[barController_ addPage:sender];
}
- (IBAction)editBookmark:(id)sender {
[barController_ editBookmark:sender];
}
- (IBAction)openAllBookmarks:(id)sender {
[barController_ openAllBookmarks:sender];
}
- (IBAction)openAllBookmarksIncognitoWindow:(id)sender {
[barController_ openAllBookmarksIncognitoWindow:sender];
}
- (IBAction)openAllBookmarksNewWindow:(id)sender {
[barController_ openAllBookmarksNewWindow:sender];
}
- (IBAction)openBookmarkInIncognitoWindow:(id)sender {
[barController_ openBookmarkInIncognitoWindow:sender];
}
- (IBAction)openBookmarkInNewForegroundTab:(id)sender {
[barController_ openBookmarkInNewForegroundTab:sender];
}
- (IBAction)openBookmarkInNewWindow:(id)sender {
[barController_ openBookmarkInNewWindow:sender];
}
@end // BookmarkBarFolderController
|