1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
|
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "app/l10n_util_mac.h"
#include "base/scoped_nsobject.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
#include "chrome/browser/cocoa/cocoa_test_helper.h"
#import "chrome/browser/cocoa/edit_search_engine_cocoa_controller.h"
#include "chrome/test/testing_profile.h"
#include "grit/generated_resources.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
@interface FakeEditSearchEngineController : EditSearchEngineCocoaController {
}
@property (readonly) NSTextField* nameField;
@property (readonly) NSTextField* keywordField;
@property (readonly) NSTextField* urlField;
@property (readonly) NSImageView* nameImage;
@property (readonly) NSImageView* keywordImage;
@property (readonly) NSImageView* urlImage;
@property (readonly) NSButton* doneButton;
@property (readonly) NSImage* goodImage;
@property (readonly) NSImage* badImage;
@end
@implementation FakeEditSearchEngineController
@synthesize nameField = nameField_;
@synthesize keywordField = keywordField_;
@synthesize urlField = urlField_;
@synthesize nameImage = nameImage_;
@synthesize keywordImage = keywordImage_;
@synthesize urlImage = urlImage_;
@synthesize doneButton = doneButton_;
- (NSImage*)goodImage {
return goodImage_.get();
}
- (NSImage*)badImage {
return badImage_.get();
}
@end
namespace {
class EditSearchEngineControllerTest : public CocoaTest {
public:
virtual void SetUp() {
CocoaTest::SetUp();
TestingProfile* profile =
static_cast<TestingProfile*>(browser_helper_.profile());
profile->CreateTemplateURLModel();
controller_ = [[FakeEditSearchEngineController alloc]
initWithProfile:profile
delegate:nil
templateURL:nil];
}
virtual void TearDown() {
// Force the window to load so we hit |-awakeFromNib| to register as the
// window's delegate so that the controller can clean itself up in
// |-windowWillClose:|.
ASSERT_TRUE([controller_ window]);
[controller_ close];
CocoaTest::TearDown();
}
BrowserTestHelper browser_helper_;
FakeEditSearchEngineController* controller_;
};
TEST_F(EditSearchEngineControllerTest, ValidImageOriginals) {
EXPECT_FALSE([controller_ goodImage]);
EXPECT_FALSE([controller_ badImage]);
EXPECT_TRUE([controller_ window]); // Force the window to load.
EXPECT_TRUE([[controller_ goodImage] isKindOfClass:[NSImage class]]);
EXPECT_TRUE([[controller_ badImage] isKindOfClass:[NSImage class]]);
// Test window title is set correctly.
NSString* title = l10n_util::GetNSString(
IDS_SEARCH_ENGINES_EDITOR_NEW_WINDOW_TITLE);
EXPECT_TRUE([title isEqualToString:[[controller_ window] title]]);
}
TEST_F(EditSearchEngineControllerTest, SetImageViews) {
EXPECT_TRUE([controller_ window]); // Force the window to load.
EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
// An empty keyword is not OK.
EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
}
// This test ensures that on creating a new keyword, we are in an "invalid"
// state that cannot save.
TEST_F(EditSearchEngineControllerTest, InvalidState) {
EXPECT_TRUE([controller_ window]); // Force window to load.
NSString* toolTip = nil;
EXPECT_FALSE([controller_ validateFields]);
EXPECT_TRUE([@"" isEqualToString:[[controller_ nameField] stringValue]]);
EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
toolTip = l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_TITLE_TT);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameField] toolTip]]);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameImage] toolTip]]);
// Keywords can not be empty strings.
EXPECT_TRUE([@"" isEqualToString:[[controller_ keywordField] stringValue]]);
EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
EXPECT_TRUE([[controller_ keywordField] toolTip]);
EXPECT_TRUE([[controller_ keywordImage] toolTip]);
EXPECT_TRUE([@"" isEqualToString:[[controller_ urlField] stringValue]]);
EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
toolTip = l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_URL_TT);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlField] toolTip]]);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlImage] toolTip]]);
}
// Tests that the single name field validates.
TEST_F(EditSearchEngineControllerTest, ValidateName) {
EXPECT_TRUE([controller_ window]); // Force window to load.
EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
EXPECT_FALSE([controller_ validateFields]);
NSString* toolTip =
l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_TITLE_TT);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameField] toolTip]]);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameImage] toolTip]]);
[[controller_ nameField] setStringValue:@"Test Name"];
EXPECT_FALSE([controller_ validateFields]);
EXPECT_EQ([controller_ goodImage], [[controller_ nameImage] image]);
EXPECT_FALSE([[controller_ nameField] toolTip]);
EXPECT_FALSE([[controller_ nameImage] toolTip]);
EXPECT_FALSE([[controller_ doneButton] isEnabled]);
}
// The keyword field is not valid if it is empty.
TEST_F(EditSearchEngineControllerTest, ValidateKeyword) {
EXPECT_TRUE([controller_ window]); // Force window load.
EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
EXPECT_FALSE([controller_ validateFields]);
EXPECT_TRUE([[controller_ keywordField] toolTip]);
EXPECT_TRUE([[controller_ keywordImage] toolTip]);
[[controller_ keywordField] setStringValue:@"foobar"];
EXPECT_FALSE([controller_ validateFields]);
EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
EXPECT_FALSE([[controller_ keywordField] toolTip]);
EXPECT_FALSE([[controller_ keywordImage] toolTip]);
EXPECT_FALSE([[controller_ doneButton] isEnabled]);
}
// Tests that the URL field validates.
TEST_F(EditSearchEngineControllerTest, ValidateURL) {
EXPECT_TRUE([controller_ window]); // Force window to load.
EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
EXPECT_FALSE([controller_ validateFields]);
NSString* toolTip =
l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_URL_TT);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlField] toolTip]]);
EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlImage] toolTip]]);
[[controller_ urlField] setStringValue:@"http://foo-bar.com"];
EXPECT_FALSE([controller_ validateFields]);
EXPECT_EQ([controller_ goodImage], [[controller_ urlImage] image]);
EXPECT_FALSE([[controller_ urlField] toolTip]);
EXPECT_FALSE([[controller_ urlImage] toolTip]);
EXPECT_FALSE([[controller_ doneButton] isEnabled]);
}
// Tests that if the user enters all valid data that the UI reflects that
// and that they can save.
TEST_F(EditSearchEngineControllerTest, ValidateFields) {
EXPECT_TRUE([controller_ window]); // Force window to load.
// State before entering data.
EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
EXPECT_FALSE([[controller_ doneButton] isEnabled]);
EXPECT_FALSE([controller_ validateFields]);
[[controller_ nameField] setStringValue:@"Test Name"];
EXPECT_FALSE([controller_ validateFields]);
EXPECT_EQ([controller_ goodImage], [[controller_ nameImage] image]);
EXPECT_FALSE([[controller_ doneButton] isEnabled]);
[[controller_ keywordField] setStringValue:@"foobar"];
EXPECT_FALSE([controller_ validateFields]);
EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
EXPECT_FALSE([[controller_ doneButton] isEnabled]);
// Once the URL is entered, we should have all 3 valid fields.
[[controller_ urlField] setStringValue:@"http://foo-bar.com"];
EXPECT_TRUE([controller_ validateFields]);
EXPECT_EQ([controller_ goodImage], [[controller_ urlImage] image]);
EXPECT_TRUE([[controller_ doneButton] isEnabled]);
}
// Tests editing an existing TemplateURL.
TEST_F(EditSearchEngineControllerTest, EditTemplateURL) {
TemplateURL url;
url.set_short_name(L"Foobar");
url.set_keyword(L"keyword");
std::wstring urlString = TemplateURLRef::DisplayURLToURLRef(
L"http://foo-bar.com");
url.SetURL(urlString, 0, 1);
TestingProfile* profile = browser_helper_.profile();
FakeEditSearchEngineController *controller =
[[FakeEditSearchEngineController alloc] initWithProfile:profile
delegate:nil
templateURL:&url];
EXPECT_TRUE([controller window]);
NSString* title = l10n_util::GetNSString(
IDS_SEARCH_ENGINES_EDITOR_EDIT_WINDOW_TITLE);
EXPECT_TRUE([title isEqualToString:[[controller window] title]]);
NSString* nameString = [[controller nameField] stringValue];
EXPECT_TRUE([@"Foobar" isEqualToString:nameString]);
NSString* keywordString = [[controller keywordField] stringValue];
EXPECT_TRUE([@"keyword" isEqualToString:keywordString]);
NSString* urlValueString = [[controller urlField] stringValue];
EXPECT_TRUE([@"http://foo-bar.com" isEqualToString:urlValueString]);
EXPECT_TRUE([controller validateFields]);
[controller close];
}
} // namespace
|
