1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string.h>
#include "base/command_line.h"
#include "base/guid.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/dom_distiller/dom_distiller_service_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/dom_distiller/content/dom_distiller_viewer_source.h"
#include "components/dom_distiller/core/article_entry.h"
#include "components/dom_distiller/core/distilled_page_prefs.h"
#include "components/dom_distiller/core/distiller.h"
#include "components/dom_distiller/core/dom_distiller_service.h"
#include "components/dom_distiller/core/dom_distiller_store.h"
#include "components/dom_distiller/core/dom_distiller_test_util.h"
#include "components/dom_distiller/core/fake_distiller.h"
#include "components/dom_distiller/core/fake_distiller_page.h"
#include "components/dom_distiller/core/task_tracker.h"
#include "components/dom_distiller/core/url_constants.h"
#include "components/dom_distiller/core/url_utils.h"
#include "components/leveldb_proto/testing/fake_db.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/url_data_source.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/browser_test_utils.h"
#include "grit/components_strings.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
namespace dom_distiller {
using leveldb_proto::test::FakeDB;
using test::FakeDistiller;
using test::MockDistillerPage;
using test::MockDistillerFactory;
using test::MockDistillerPageFactory;
using test::util::CreateStoreWithFakeDB;
using testing::HasSubstr;
using testing::Not;
namespace {
const char kGetLoadIndicatorClassName[] =
"window.domAutomationController.send("
"document.getElementById('loadingIndicator').className)";
const char kGetContent[] =
"window.domAutomationController.send("
"document.getElementById('content').innerHTML)";
const char kGetBodyClass[] =
"window.domAutomationController.send("
"document.body.className)";
void AddEntry(const ArticleEntry& e, FakeDB<ArticleEntry>::EntryMap* map) {
(*map)[e.entry_id()] = e;
}
ArticleEntry CreateEntry(std::string entry_id, std::string page_url) {
ArticleEntry entry;
entry.set_entry_id(entry_id);
if (!page_url.empty()) {
ArticleEntryPage* page = entry.add_pages();
page->set_url(page_url);
}
return entry;
}
} // namespace
class DomDistillerViewerSourceBrowserTest : public InProcessBrowserTest {
public:
DomDistillerViewerSourceBrowserTest() {}
~DomDistillerViewerSourceBrowserTest() override {}
void SetUpOnMainThread() override {
database_model_ = new FakeDB<ArticleEntry>::EntryMap;
}
void TearDownOnMainThread() override { delete database_model_; }
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(switches::kEnableDomDistiller);
}
static KeyedService* Build(content::BrowserContext* context) {
FakeDB<ArticleEntry>* fake_db = new FakeDB<ArticleEntry>(database_model_);
distiller_factory_ = new MockDistillerFactory();
MockDistillerPageFactory* distiller_page_factory_ =
new MockDistillerPageFactory();
DomDistillerContextKeyedService* service =
new DomDistillerContextKeyedService(
scoped_ptr<DomDistillerStoreInterface>(
CreateStoreWithFakeDB(fake_db,
FakeDB<ArticleEntry>::EntryMap())),
scoped_ptr<DistillerFactory>(distiller_factory_),
scoped_ptr<DistillerPageFactory>(distiller_page_factory_),
scoped_ptr<DistilledPagePrefs>(
new DistilledPagePrefs(
Profile::FromBrowserContext(
context)->GetPrefs())));
fake_db->InitCallback(true);
fake_db->LoadCallback(true);
if (expect_distillation_) {
// There will only be destillation of an article if the database contains
// the article.
FakeDistiller* distiller = new FakeDistiller(true);
EXPECT_CALL(*distiller_factory_, CreateDistillerImpl())
.WillOnce(testing::Return(distiller));
}
if (expect_distiller_page_) {
MockDistillerPage* distiller_page = new MockDistillerPage();
EXPECT_CALL(*distiller_page_factory_, CreateDistillerPageImpl())
.WillOnce(testing::Return(distiller_page));
}
return service;
}
void ViewSingleDistilledPage(const GURL& url,
const std::string& expected_mime_type);
// Database entries.
static FakeDB<ArticleEntry>::EntryMap* database_model_;
static bool expect_distillation_;
static bool expect_distiller_page_;
static MockDistillerFactory* distiller_factory_;
};
FakeDB<ArticleEntry>::EntryMap*
DomDistillerViewerSourceBrowserTest::database_model_;
bool DomDistillerViewerSourceBrowserTest::expect_distillation_ = false;
bool DomDistillerViewerSourceBrowserTest::expect_distiller_page_ = false;
MockDistillerFactory* DomDistillerViewerSourceBrowserTest::distiller_factory_ =
NULL;
// The DomDistillerViewerSource renders untrusted content, so ensure no bindings
// are enabled when the article exists in the database.
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
NoWebUIBindingsArticleExists) {
// Ensure there is one item in the database, which will trigger distillation.
const ArticleEntry entry = CreateEntry("DISTILLED", "http://example.com/1");
AddEntry(entry, database_model_);
expect_distillation_ = true;
expect_distiller_page_ = true;
const GURL url = url_utils::GetDistillerViewUrlFromEntryId(
kDomDistillerScheme, entry.entry_id());
ViewSingleDistilledPage(url, "text/html");
}
// The DomDistillerViewerSource renders untrusted content, so ensure no bindings
// are enabled when the article is not found.
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
NoWebUIBindingsArticleNotFound) {
// The article does not exist, so assume no distillation will happen.
expect_distillation_ = false;
expect_distiller_page_ = false;
const GURL url = url_utils::GetDistillerViewUrlFromEntryId(
kDomDistillerScheme, "DOES_NOT_EXIST");
ViewSingleDistilledPage(url, "text/html");
}
// The DomDistillerViewerSource renders untrusted content, so ensure no bindings
// are enabled when requesting to view an arbitrary URL.
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
NoWebUIBindingsViewUrl) {
// We should expect distillation for any valid URL.
expect_distillation_ = true;
expect_distiller_page_ = true;
GURL view_url("http://www.example.com/1");
const GURL url =
url_utils::GetDistillerViewUrlFromUrl(kDomDistillerScheme, view_url);
ViewSingleDistilledPage(url, "text/html");
}
void DomDistillerViewerSourceBrowserTest::ViewSingleDistilledPage(
const GURL& url,
const std::string& expected_mime_type) {
// Ensure the correct factory is used for the DomDistillerService.
dom_distiller::DomDistillerServiceFactory::GetInstance()
->SetTestingFactoryAndUse(browser()->profile(), &Build);
// Navigate to a URL which the source should respond to.
ui_test_utils::NavigateToURL(browser(), url);
// Ensure no bindings for the loaded |url|.
content::WebContents* contents_after_nav =
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(contents_after_nav != NULL);
EXPECT_EQ(url, contents_after_nav->GetLastCommittedURL());
const content::RenderViewHost* render_view_host =
contents_after_nav->GetRenderViewHost();
EXPECT_EQ(0, render_view_host->GetEnabledBindings());
EXPECT_EQ(expected_mime_type, contents_after_nav->GetContentsMimeType());
}
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
TestBadUrlErrorPage) {
GURL url("chrome-distiller://bad");
// Navigate to a distiller URL.
ui_test_utils::NavigateToURL(browser(), url);
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
// Wait for the page load to complete as the first page completes the root
// document.
content::WaitForLoadStop(contents);
ASSERT_TRUE(contents != NULL);
EXPECT_EQ(url, contents->GetLastCommittedURL());
std::string result;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetContent , &result));
EXPECT_THAT(result, HasSubstr(l10n_util::GetStringUTF8(
IDS_DOM_DISTILLER_VIEWER_FAILED_TO_FIND_ARTICLE_CONTENT)));
}
// The DomDistillerViewerSource renders untrusted content, so ensure no bindings
// are enabled when the CSS resource is loaded. This CSS might be bundle with
// Chrome or provided by an extension.
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
NoWebUIBindingsDisplayCSS) {
expect_distillation_ = false;
expect_distiller_page_ = false;
// Navigate to a URL which the source should respond to with CSS.
std::string url_without_scheme = std::string("://foobar/") + kViewerCssPath;
GURL url(kDomDistillerScheme + url_without_scheme);
ViewSingleDistilledPage(url, "text/css");
}
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
EmptyURLShouldNotCrash) {
// This is a bogus URL, so no distillation will happen.
expect_distillation_ = false;
expect_distiller_page_ = false;
const GURL url(std::string(kDomDistillerScheme) + "://bogus/");
ViewSingleDistilledPage(url, "text/html");
}
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
InvalidURLShouldNotCrash) {
// This is a bogus URL, so no distillation will happen.
expect_distillation_ = false;
expect_distiller_page_ = false;
const GURL url(std::string(kDomDistillerScheme) + "://bogus/foobar");
ViewSingleDistilledPage(url, "text/html");
}
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
MultiPageArticle) {
expect_distillation_ = false;
expect_distiller_page_ = true;
dom_distiller::DomDistillerServiceFactory::GetInstance()
->SetTestingFactoryAndUse(browser()->profile(), &Build);
scoped_refptr<content::MessageLoopRunner> distillation_done_runner =
new content::MessageLoopRunner;
FakeDistiller* distiller = new FakeDistiller(
false,
distillation_done_runner->QuitClosure());
EXPECT_CALL(*distiller_factory_, CreateDistillerImpl())
.WillOnce(testing::Return(distiller));
// Setup observer to inspect the RenderViewHost after committed navigation.
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
// Navigate to a URL and wait for the distiller to flush contents to the page.
GURL url(dom_distiller::url_utils::GetDistillerViewUrlFromUrl(
kDomDistillerScheme, GURL("http://urlthatlooksvalid.com")));
chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_TYPED);
chrome::Navigate(¶ms);
distillation_done_runner->Run();
// Fake a multi-page response from distiller.
std::vector<scoped_refptr<ArticleDistillationUpdate::RefCountedPageProto> >
update_pages;
scoped_ptr<DistilledArticleProto> article(new DistilledArticleProto());
// Flush page 1.
{
scoped_refptr<base::RefCountedData<DistilledPageProto> > page_proto =
new base::RefCountedData<DistilledPageProto>();
page_proto->data.set_url("http://foobar.1.html");
page_proto->data.set_html("<div>Page 1 content</div>");
update_pages.push_back(page_proto);
*(article->add_pages()) = page_proto->data;
ArticleDistillationUpdate update(update_pages, true, false);
distiller->RunDistillerUpdateCallback(update);
// Wait for the page load to complete as the first page completes the root
// document.
content::WaitForLoadStop(contents);
std::string result;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetLoadIndicatorClassName , &result));
EXPECT_EQ("visible", result);
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetContent , &result));
EXPECT_THAT(result, HasSubstr("Page 1 content"));
EXPECT_THAT(result, Not(HasSubstr("Page 2 content")));
}
// Flush page 2.
{
scoped_refptr<base::RefCountedData<DistilledPageProto> > page_proto =
new base::RefCountedData<DistilledPageProto>();
page_proto->data.set_url("http://foobar.2.html");
page_proto->data.set_html("<div>Page 2 content</div>");
update_pages.push_back(page_proto);
*(article->add_pages()) = page_proto->data;
ArticleDistillationUpdate update(update_pages, false, false);
distiller->RunDistillerUpdateCallback(update);
std::string result;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetLoadIndicatorClassName , &result));
EXPECT_EQ("visible", result);
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetContent , &result));
EXPECT_THAT(result, HasSubstr("Page 1 content"));
EXPECT_THAT(result, HasSubstr("Page 2 content"));
}
// Complete the load.
distiller->RunDistillerCallback(article.Pass());
base::RunLoop().RunUntilIdle();
std::string result;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetLoadIndicatorClassName, &result));
EXPECT_EQ("hidden", result);
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetContent , &result));
EXPECT_THAT(result, HasSubstr("Page 1 content"));
EXPECT_THAT(result, HasSubstr("Page 2 content"));
}
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest, PrefChange) {
expect_distillation_ = true;
expect_distiller_page_ = true;
GURL view_url("http://www.example.com/1");
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
const GURL url =
url_utils::GetDistillerViewUrlFromUrl(kDomDistillerScheme, view_url);
ViewSingleDistilledPage(url, "text/html");
content::WaitForLoadStop(contents);
std::string result;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetBodyClass, &result));
EXPECT_EQ("light sans-serif", result);
DistilledPagePrefs* distilled_page_prefs =
DomDistillerServiceFactory::GetForBrowserContext(
browser()->profile())->GetDistilledPagePrefs();
distilled_page_prefs->SetTheme(DistilledPagePrefs::DARK);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
contents, kGetBodyClass, &result));
EXPECT_EQ("dark sans-serif", result);
distilled_page_prefs->SetFontFamily(DistilledPagePrefs::SERIF);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(
content::ExecuteScriptAndExtractString(contents, kGetBodyClass, &result));
EXPECT_EQ("dark serif", result);
}
} // namespace dom_distiller
|