1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
|
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/test/simple_test_clock.h"
#include "base/values.h"
#include "chrome/browser/engagement/site_engagement_helper.h"
#include "chrome/browser/engagement/site_engagement_service.h"
#include "chrome/browser/engagement/site_engagement_service_factory.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
const int kLessNavigationsThanNeededToMaxDailyEngagement = 2;
const int kMoreNavigationsThanNeededToMaxDailyEngagement = 20;
const int kMoreNavigationsThanNeededToMaxTotalEngagement = 200;
const int kLessDaysThanNeededToMaxTotalEngagement = 4;
const int kMoreDaysThanNeededToMaxTotalEngagement = 40;
const int kLessPeriodsThanNeededToDecayMaxScore = 2;
const int kMorePeriodsThanNeededToDecayMaxScore = 40;
base::Time GetReferenceTime() {
base::Time::Exploded exploded_reference_time;
exploded_reference_time.year = 2015;
exploded_reference_time.month = 1;
exploded_reference_time.day_of_month = 30;
exploded_reference_time.day_of_week = 5;
exploded_reference_time.hour = 11;
exploded_reference_time.minute = 0;
exploded_reference_time.second = 0;
exploded_reference_time.millisecond = 0;
return base::Time::FromLocalExploded(exploded_reference_time);
}
} // namespace
class SiteEngagementScoreTest : public testing::Test {
public:
SiteEngagementScoreTest() : score_(&test_clock_) {}
protected:
void VerifyScore(const SiteEngagementScore& score,
double expected_raw_score,
double expected_points_added_today,
base::Time expected_last_engagement_time) {
EXPECT_EQ(expected_raw_score, score.raw_score_);
EXPECT_EQ(expected_points_added_today, score.points_added_today_);
EXPECT_EQ(expected_last_engagement_time, score.last_engagement_time_);
}
void UpdateScore(SiteEngagementScore* score,
double raw_score,
double points_added_today,
base::Time last_engagement_time) {
score->raw_score_ = raw_score;
score->points_added_today_ = points_added_today;
score->last_engagement_time_ = last_engagement_time;
}
void TestScoreInitializesAndUpdates(
base::DictionaryValue* settings_dict,
double expected_raw_score,
double expected_points_added_today,
base::Time expected_last_engagement_time) {
SiteEngagementScore initial_score(&test_clock_, *settings_dict);
VerifyScore(initial_score, expected_raw_score, expected_points_added_today,
expected_last_engagement_time);
// Updating the settings dict should return false, as the score shouldn't
// have changed at this point.
EXPECT_FALSE(initial_score.UpdateSettings(settings_dict));
// Update the score to new values and verify it updates the settings dict
// correctly.
base::Time different_day =
GetReferenceTime() + base::TimeDelta::FromDays(1);
UpdateScore(&initial_score, 5, 10, different_day);
EXPECT_TRUE(initial_score.UpdateSettings(settings_dict));
SiteEngagementScore updated_score(&test_clock_, *settings_dict);
VerifyScore(updated_score, 5, 10, different_day);
}
base::SimpleTestClock test_clock_;
SiteEngagementScore score_;
};
// Navigate many times on the same day. Ensure each time the score goes up by
// kNavigationPoints, but not more than kMaxPointsPerDay.
TEST_F(SiteEngagementScoreTest, NavigateOnSameDay) {
base::Time reference_time = GetReferenceTime();
test_clock_.SetNow(reference_time);
for (int i = 0; i < kMoreNavigationsThanNeededToMaxDailyEngagement; ++i) {
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(std::min(SiteEngagementScore::kMaxPointsPerDay,
(i + 1) * SiteEngagementScore::kNavigationPoints),
score_.Score());
}
EXPECT_EQ(SiteEngagementScore::kMaxPointsPerDay, score_.Score());
}
// Navigate on the first day to max that day's engagement, then navigate on a
// different day.
TEST_F(SiteEngagementScoreTest, NavigateOnTwoDays) {
base::Time reference_time = GetReferenceTime();
base::Time later_date = reference_time + base::TimeDelta::FromDays(2);
test_clock_.SetNow(reference_time);
for (int i = 0; i < kMoreNavigationsThanNeededToMaxDailyEngagement; ++i)
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(SiteEngagementScore::kMaxPointsPerDay, score_.Score());
test_clock_.SetNow(later_date);
for (int i = 0; i < kMoreNavigationsThanNeededToMaxDailyEngagement; ++i) {
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
double day_score =
std::min(SiteEngagementScore::kMaxPointsPerDay,
(i + 1) * SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(day_score + SiteEngagementScore::kMaxPointsPerDay,
score_.Score());
}
EXPECT_EQ(2 * SiteEngagementScore::kMaxPointsPerDay, score_.Score());
}
// Navigate a lot on many consecutive days and ensure the score doesn't exceed
// the maximum allowed.
TEST_F(SiteEngagementScoreTest, NavigateALotOnManyDays) {
base::Time current_day = GetReferenceTime();
for (int i = 0; i < kMoreDaysThanNeededToMaxTotalEngagement; ++i) {
current_day += base::TimeDelta::FromDays(1);
test_clock_.SetNow(current_day);
for (int j = 0; j < kMoreNavigationsThanNeededToMaxDailyEngagement; ++j)
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(std::min(SiteEngagementScore::kMaxPoints,
(i + 1) * SiteEngagementScore::kMaxPointsPerDay),
score_.Score());
}
EXPECT_EQ(SiteEngagementScore::kMaxPoints, score_.Score());
}
// Navigate a little on many consecutive days and ensure the score doesn't
// exceed the maximum allowed.
TEST_F(SiteEngagementScoreTest, NavigateALittleOnManyDays) {
base::Time current_day = GetReferenceTime();
for (int i = 0; i < kMoreNavigationsThanNeededToMaxTotalEngagement; ++i) {
current_day += base::TimeDelta::FromDays(1);
test_clock_.SetNow(current_day);
for (int j = 0; j < kLessNavigationsThanNeededToMaxDailyEngagement; ++j)
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(
std::min(SiteEngagementScore::kMaxPoints,
(i + 1) * kLessNavigationsThanNeededToMaxDailyEngagement *
SiteEngagementScore::kNavigationPoints),
score_.Score());
}
EXPECT_EQ(SiteEngagementScore::kMaxPoints, score_.Score());
}
// Navigate a bit, then check the score decays properly for a range of times.
TEST_F(SiteEngagementScoreTest, ScoresDecayOverTime) {
base::Time current_day = GetReferenceTime();
// First max the score.
for (int i = 0; i < kMoreDaysThanNeededToMaxTotalEngagement; ++i) {
current_day += base::TimeDelta::FromDays(1);
test_clock_.SetNow(current_day);
for (int j = 0; j < kMoreNavigationsThanNeededToMaxDailyEngagement; ++j)
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
}
EXPECT_EQ(SiteEngagementScore::kMaxPoints, score_.Score());
// The score should not have decayed before the first decay period has
// elapsed.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(SiteEngagementScore::kDecayPeriodInDays - 1));
EXPECT_EQ(SiteEngagementScore::kMaxPoints, score_.Score());
// The score should have decayed by one chunk after one decay period has
// elapsed.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(SiteEngagementScore::kDecayPeriodInDays));
EXPECT_EQ(SiteEngagementScore::kMaxPoints - SiteEngagementScore::kDecayPoints,
score_.Score());
// The score should have decayed by the right number of chunks after a few
// decay periods have elapsed.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(kLessPeriodsThanNeededToDecayMaxScore *
SiteEngagementScore::kDecayPeriodInDays));
EXPECT_EQ(SiteEngagementScore::kMaxPoints -
kLessPeriodsThanNeededToDecayMaxScore *
SiteEngagementScore::kDecayPoints,
score_.Score());
// The score should not decay below zero.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(kMorePeriodsThanNeededToDecayMaxScore *
SiteEngagementScore::kDecayPeriodInDays));
EXPECT_EQ(0, score_.Score());
}
// Test that any expected decays are applied before adding points.
TEST_F(SiteEngagementScoreTest, DecaysAppliedBeforeAdd) {
base::Time current_day = GetReferenceTime();
// Get the score up to something that can handle a bit of decay before
for (int i = 0; i < kLessDaysThanNeededToMaxTotalEngagement; ++i) {
current_day += base::TimeDelta::FromDays(1);
test_clock_.SetNow(current_day);
for (int j = 0; j < kMoreNavigationsThanNeededToMaxDailyEngagement; ++j)
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
}
double initial_score = kLessDaysThanNeededToMaxTotalEngagement *
SiteEngagementScore::kMaxPointsPerDay;
EXPECT_EQ(initial_score, score_.Score());
// Go forward a few decay periods.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(kLessPeriodsThanNeededToDecayMaxScore *
SiteEngagementScore::kDecayPeriodInDays));
double decayed_score =
initial_score -
kLessPeriodsThanNeededToDecayMaxScore * SiteEngagementScore::kDecayPoints;
EXPECT_EQ(decayed_score, score_.Score());
// Now add some points.
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(decayed_score + SiteEngagementScore::kNavigationPoints,
score_.Score());
}
// Test that going back in time is handled properly.
TEST_F(SiteEngagementScoreTest, GoBackInTime) {
base::Time current_day = GetReferenceTime();
test_clock_.SetNow(current_day);
for (int i = 0; i < kMoreNavigationsThanNeededToMaxDailyEngagement; ++i)
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(SiteEngagementScore::kMaxPointsPerDay, score_.Score());
// Adding to the score on an earlier date should be treated like another day,
// and should not cause any decay.
test_clock_.SetNow(current_day - base::TimeDelta::FromDays(
kMorePeriodsThanNeededToDecayMaxScore *
SiteEngagementScore::kDecayPoints));
for (int i = 0; i < kMoreNavigationsThanNeededToMaxDailyEngagement; ++i) {
score_.AddPoints(SiteEngagementScore::kNavigationPoints);
double day_score =
std::min(SiteEngagementScore::kMaxPointsPerDay,
(i + 1) * SiteEngagementScore::kNavigationPoints);
EXPECT_EQ(day_score + SiteEngagementScore::kMaxPointsPerDay,
score_.Score());
}
EXPECT_EQ(2 * SiteEngagementScore::kMaxPointsPerDay, score_.Score());
}
// Test that scores are read / written correctly from / to empty settings
// dictionaries.
TEST_F(SiteEngagementScoreTest, EmptyDictionary) {
base::DictionaryValue dict;
TestScoreInitializesAndUpdates(&dict, 0, 0, base::Time());
}
// Test that scores are read / written correctly from / to partially empty
// settings dictionaries.
TEST_F(SiteEngagementScoreTest, PartiallyEmptyDictionary) {
base::DictionaryValue dict;
dict.SetDouble(SiteEngagementScore::kPointsAddedTodayKey, 2);
TestScoreInitializesAndUpdates(&dict, 0, 2, base::Time());
}
// Test that scores are read / written correctly from / to populated settings
// dictionaries.
TEST_F(SiteEngagementScoreTest, PopulatedDictionary) {
base::DictionaryValue dict;
dict.SetDouble(SiteEngagementScore::kRawScoreKey, 1);
dict.SetDouble(SiteEngagementScore::kPointsAddedTodayKey, 2);
dict.SetDouble(SiteEngagementScore::kLastEngagementTimeKey,
GetReferenceTime().ToInternalValue());
TestScoreInitializesAndUpdates(&dict, 1, 2, GetReferenceTime());
}
using SiteEngagementServiceTest = BrowserWithTestWindowTest;
// Tests that the Site Engagement service is hooked up properly to navigations
// by performing two navigations and checking the engagement score increases
// both times.
TEST_F(SiteEngagementServiceTest, ScoreIncrementsOnPageRequest) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableSiteEngagementService);
SiteEngagementService* service =
SiteEngagementServiceFactory::GetForProfile(profile());
DCHECK(service);
GURL url("http://www.google.com/");
AddTab(browser(), GURL("about:blank"));
EXPECT_EQ(0, service->GetScore(url));
int prev_score = service->GetScore(url);
NavigateAndCommitActiveTab(url);
EXPECT_LT(prev_score, service->GetScore(url));
prev_score = service->GetScore(url);
NavigateAndCommitActiveTab(url);
EXPECT_LT(prev_score, service->GetScore(url));
}
|