1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/api/storage/policy_value_store.h"
#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "components/policy/core/common/external_data_fetcher.h"
#include "components/policy/core/common/policy_map.h"
#include "components/policy/core/common/policy_types.h"
#include "content/public/test/test_browser_thread.h"
#include "extensions/browser/api/storage/settings_observer.h"
#include "extensions/browser/value_store/leveldb_value_store.h"
#include "extensions/browser/value_store/value_store_unittest.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using testing::_;
using testing::Mock;
namespace extensions {
namespace {
const char kTestExtensionId[] = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
const char kDatabaseUMAClientName[] = "Test";
class MockSettingsObserver : public SettingsObserver {
public:
MOCK_METHOD3(OnSettingsChanged, void(
const std::string& extension_id,
settings_namespace::Namespace settings_namespace,
const std::string& changes_json));
};
// Extends PolicyValueStore by overriding the mutating methods, so that the
// Get() base implementation can be tested with the ValueStoreTest parameterized
// tests.
class MutablePolicyValueStore : public PolicyValueStore {
public:
explicit MutablePolicyValueStore(const base::FilePath& path)
: PolicyValueStore(
kTestExtensionId,
make_scoped_refptr(new SettingsObserverList()),
make_scoped_ptr(
new LeveldbValueStore(kDatabaseUMAClientName, path))) {}
~MutablePolicyValueStore() override {}
WriteResult Set(WriteOptions options,
const std::string& key,
const base::Value& value) override {
return delegate()->Set(options, key, value);
}
WriteResult Set(WriteOptions options,
const base::DictionaryValue& values) override {
return delegate()->Set(options, values);
}
WriteResult Remove(const std::string& key) override {
return delegate()->Remove(key);
}
WriteResult Remove(const std::vector<std::string>& keys) override {
return delegate()->Remove(keys);
}
WriteResult Clear() override { return delegate()->Clear(); }
private:
DISALLOW_COPY_AND_ASSIGN(MutablePolicyValueStore);
};
ValueStore* Param(const base::FilePath& file_path) {
return new MutablePolicyValueStore(file_path);
}
} // namespace
INSTANTIATE_TEST_CASE_P(
PolicyValueStoreTest,
ValueStoreTest,
testing::Values(&Param));
class PolicyValueStoreTest : public testing::Test {
public:
PolicyValueStoreTest()
: file_thread_(content::BrowserThread::FILE, &loop_) {}
~PolicyValueStoreTest() override {}
void SetUp() override {
ASSERT_TRUE(scoped_temp_dir_.CreateUniqueTempDir());
observers_ = new SettingsObserverList();
observers_->AddObserver(&observer_);
store_.reset(new PolicyValueStore(
kTestExtensionId, observers_,
make_scoped_ptr(new LeveldbValueStore(kDatabaseUMAClientName,
scoped_temp_dir_.path()))));
}
void TearDown() override {
observers_->RemoveObserver(&observer_);
store_.reset();
}
protected:
base::ScopedTempDir scoped_temp_dir_;
base::MessageLoop loop_;
content::TestBrowserThread file_thread_;
scoped_ptr<PolicyValueStore> store_;
MockSettingsObserver observer_;
scoped_refptr<SettingsObserverList> observers_;
};
TEST_F(PolicyValueStoreTest, DontProvideRecommendedPolicies) {
policy::PolicyMap policies;
base::FundamentalValue expected(123);
policies.Set("must", policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
expected.DeepCopy(), nullptr);
policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,
policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
new base::FundamentalValue(456), NULL);
store_->SetCurrentPolicy(policies);
ValueStore::ReadResult result = store_->Get();
ASSERT_TRUE(result->status().ok());
EXPECT_EQ(1u, result->settings().size());
base::Value* value = NULL;
EXPECT_FALSE(result->settings().Get("may", &value));
EXPECT_TRUE(result->settings().Get("must", &value));
EXPECT_TRUE(base::Value::Equals(&expected, value));
}
TEST_F(PolicyValueStoreTest, ReadOnly) {
ValueStore::WriteOptions options = ValueStore::DEFAULTS;
base::StringValue string_value("value");
EXPECT_FALSE(store_->Set(options, "key", string_value)->status().ok());
base::DictionaryValue dict;
dict.SetString("key", "value");
EXPECT_FALSE(store_->Set(options, dict)->status().ok());
EXPECT_FALSE(store_->Remove("key")->status().ok());
std::vector<std::string> keys;
keys.push_back("key");
EXPECT_FALSE(store_->Remove(keys)->status().ok());
EXPECT_FALSE(store_->Clear()->status().ok());
}
TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
// Notify when setting the initial policy.
const base::StringValue value("111");
{
ValueStoreChangeList changes;
changes.push_back(ValueStoreChange("aaa", NULL, value.DeepCopy()));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
ValueStoreChange::ToJson(changes)));
}
policy::PolicyMap policies;
policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);
store_->SetCurrentPolicy(policies);
loop_.RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Notify when new policies are added.
{
ValueStoreChangeList changes;
changes.push_back(ValueStoreChange("bbb", NULL, value.DeepCopy()));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
ValueStoreChange::ToJson(changes)));
}
policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);
store_->SetCurrentPolicy(policies);
loop_.RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Notify when policies change.
const base::StringValue new_value("222");
{
ValueStoreChangeList changes;
changes.push_back(
ValueStoreChange("bbb", value.DeepCopy(), new_value.DeepCopy()));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
ValueStoreChange::ToJson(changes)));
}
policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD, new_value.DeepCopy(), nullptr);
store_->SetCurrentPolicy(policies);
loop_.RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Notify when policies are removed.
{
ValueStoreChangeList changes;
changes.push_back(ValueStoreChange("bbb", new_value.DeepCopy(), NULL));
EXPECT_CALL(observer_,
OnSettingsChanged(kTestExtensionId,
settings_namespace::MANAGED,
ValueStoreChange::ToJson(changes)));
}
policies.Erase("bbb");
store_->SetCurrentPolicy(policies);
loop_.RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Don't notify when there aren't any changes.
EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
store_->SetCurrentPolicy(policies);
loop_.RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
}
} // namespace extensions
|
