1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/error_console/error_console.h"
#include <stddef.h>
#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "chrome/common/extensions/features/feature_channel.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
#include "components/crx_file/id_util.h"
#include "components/prefs/pref_service.h"
#include "components/version_info/version_info.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "extensions/browser/extension_error.h"
#include "extensions/browser/extension_error_test_util.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/feature_switch.h"
#include "extensions/common/value_builder.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
using error_test_util::CreateNewManifestError;
using error_test_util::CreateNewRuntimeError;
class ErrorConsoleUnitTest : public testing::Test {
public:
ErrorConsoleUnitTest() : error_console_(NULL) { }
~ErrorConsoleUnitTest() override {}
void SetUp() override {
testing::Test::SetUp();
// Errors are only kept if we have the FeatureSwitch and have Developer Mode
// enabled.
FeatureSwitch::error_console()->SetOverrideValue(
FeatureSwitch::OVERRIDE_ENABLED);
profile_.reset(new TestingProfile);
profile_->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
error_console_ = ErrorConsole::Get(profile_.get());
}
protected:
content::TestBrowserThreadBundle thread_bundle_;
scoped_ptr<TestingProfile> profile_;
ErrorConsole* error_console_;
};
// Test that the error console is enabled/disabled appropriately.
TEST_F(ErrorConsoleUnitTest, EnableAndDisableErrorConsole) {
// Start in Dev Channel, without the feature switch.
scoped_ptr<ScopedCurrentChannel> channel_override(
new ScopedCurrentChannel(version_info::Channel::DEV));
ASSERT_EQ(version_info::Channel::DEV, GetCurrentChannel());
FeatureSwitch::error_console()->SetOverrideValue(
FeatureSwitch::OVERRIDE_DISABLED);
// At the start, the error console should be enabled, and specifically
// enabled for the chrome:extensions page.
EXPECT_TRUE(error_console_->enabled());
EXPECT_TRUE(error_console_->IsEnabledForChromeExtensionsPage());
EXPECT_FALSE(error_console_->IsEnabledForAppsDeveloperTools());
// If we disable developer mode, we should disable error console.
profile_->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, false);
EXPECT_FALSE(error_console_->enabled());
EXPECT_FALSE(error_console_->IsEnabledForChromeExtensionsPage());
EXPECT_FALSE(error_console_->IsEnabledForAppsDeveloperTools());
// Similarly, if we change the current to less fun than Dev, ErrorConsole
// should be disabled.
channel_override.reset();
channel_override.reset(
new ScopedCurrentChannel(version_info::Channel::BETA));
profile_->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
EXPECT_FALSE(error_console_->enabled());
EXPECT_FALSE(error_console_->IsEnabledForChromeExtensionsPage());
EXPECT_FALSE(error_console_->IsEnabledForAppsDeveloperTools());
// But if we add the feature switch, that should override the channel.
FeatureSwitch::error_console()->SetOverrideValue(
FeatureSwitch::OVERRIDE_ENABLED);
ASSERT_TRUE(FeatureSwitch::error_console()->IsEnabled());
// We use a pref mod to "poke" the ErrorConsole, because it needs an
// indication that something changed (FeatureSwitches don't change in a real
// environment, so ErrorConsole doesn't listen for them).
profile_->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, false);
profile_->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
EXPECT_TRUE(error_console_->enabled());
EXPECT_TRUE(error_console_->IsEnabledForChromeExtensionsPage());
EXPECT_FALSE(error_console_->IsEnabledForAppsDeveloperTools());
// Next, remove the feature switch (turning error console off), and install
// the Apps Developer Tools. If we have Apps Developer Tools, Error Console
// should be enabled by default.
FeatureSwitch::error_console()->SetOverrideValue(
FeatureSwitch::OVERRIDE_DISABLED);
const char kAppsDeveloperToolsExtensionId[] =
"ohmmkhmmmpcnpikjeljgnaoabkaalbgc";
scoped_refptr<Extension> adt =
ExtensionBuilder()
.SetManifest(
DictionaryBuilder().Set("name", "apps dev tools")
.Set("version", "0.2.0")
.Set("manifest_version", 2)
.Build())
.SetID(kAppsDeveloperToolsExtensionId)
.Build();
ExtensionRegistry* registry = ExtensionRegistry::Get(profile_.get());
registry->AddEnabled(adt);
registry->TriggerOnLoaded(adt.get());
EXPECT_TRUE(error_console_->enabled());
EXPECT_FALSE(error_console_->IsEnabledForChromeExtensionsPage());
EXPECT_TRUE(error_console_->IsEnabledForAppsDeveloperTools());
// Unloading the Apps Developer Tools should disable error console.
registry->RemoveEnabled(adt->id());
registry->TriggerOnUnloaded(adt.get(), UnloadedExtensionInfo::REASON_DISABLE);
EXPECT_FALSE(error_console_->enabled());
EXPECT_FALSE(error_console_->IsEnabledForChromeExtensionsPage());
EXPECT_FALSE(error_console_->IsEnabledForAppsDeveloperTools());
}
// Test that errors are successfully reported. This is a simple test, since it
// is tested more thoroughly in extensions/browser/error_map_unittest.cc
TEST_F(ErrorConsoleUnitTest, ReportErrors) {
const size_t kNumTotalErrors = 6;
const std::string kId = crx_file::id_util::GenerateId("id");
error_console_->set_default_reporting_for_test(ExtensionError::MANIFEST_ERROR,
true);
ASSERT_EQ(0u, error_console_->GetErrorsForExtension(kId).size());
for (size_t i = 0; i < kNumTotalErrors; ++i) {
error_console_->ReportError(
CreateNewManifestError(kId, base::SizeTToString(i)));
}
ASSERT_EQ(kNumTotalErrors, error_console_->GetErrorsForExtension(kId).size());
}
TEST_F(ErrorConsoleUnitTest, DontStoreErrorsWithoutEnablingType) {
// Disable default runtime error reporting, and enable default manifest error
// reporting.
error_console_->set_default_reporting_for_test(ExtensionError::RUNTIME_ERROR,
false);
error_console_->set_default_reporting_for_test(ExtensionError::MANIFEST_ERROR,
true);
const std::string kId = crx_file::id_util::GenerateId("id");
// Try to report a runtime error - it should be ignored.
error_console_->ReportError(CreateNewRuntimeError(kId, "a"));
ASSERT_EQ(0u, error_console_->GetErrorsForExtension(kId).size());
// Check that manifest errors are reported successfully.
error_console_->ReportError(CreateNewManifestError(kId, "b"));
ASSERT_EQ(1u, error_console_->GetErrorsForExtension(kId).size());
// We should still ignore runtime errors.
error_console_->ReportError(CreateNewRuntimeError(kId, "c"));
ASSERT_EQ(1u, error_console_->GetErrorsForExtension(kId).size());
// Enable runtime errors specifically for this extension, and disable the use
// of the default mask.
error_console_->SetReportingForExtension(
kId, ExtensionError::RUNTIME_ERROR, true);
// We should now accept runtime and manifest errors.
error_console_->ReportError(CreateNewManifestError(kId, "d"));
ASSERT_EQ(2u, error_console_->GetErrorsForExtension(kId).size());
error_console_->ReportError(CreateNewRuntimeError(kId, "e"));
ASSERT_EQ(3u, error_console_->GetErrorsForExtension(kId).size());
// All other extensions should still use the default mask, and ignore runtime
// errors but report manifest errors.
const std::string kId2 = crx_file::id_util::GenerateId("id2");
error_console_->ReportError(CreateNewRuntimeError(kId2, "f"));
ASSERT_EQ(0u, error_console_->GetErrorsForExtension(kId2).size());
error_console_->ReportError(CreateNewManifestError(kId2, "g"));
ASSERT_EQ(1u, error_console_->GetErrorsForExtension(kId2).size());
// By reverting to default reporting, we should again allow manifest errors,
// but not runtime errors.
error_console_->UseDefaultReportingForExtension(kId);
error_console_->ReportError(CreateNewManifestError(kId, "h"));
ASSERT_EQ(4u, error_console_->GetErrorsForExtension(kId).size());
error_console_->ReportError(CreateNewRuntimeError(kId, "i"));
ASSERT_EQ(4u, error_console_->GetErrorsForExtension(kId).size());
}
// Test that we only store errors by default for unpacked extensions, and that
// assigning a preference to any extension overrides the defaults.
TEST_F(ErrorConsoleUnitTest, TestDefaultStoringPrefs) {
// For this, we need actual extensions.
scoped_refptr<const Extension> unpacked_extension =
ExtensionBuilder()
.SetManifest(DictionaryBuilder()
.Set("name", "unpacked")
.Set("version", "0.0.1")
.Set("manifest_version", 2)
.Build())
.SetLocation(Manifest::UNPACKED)
.SetID(crx_file::id_util::GenerateId("unpacked"))
.Build();
scoped_refptr<const Extension> packed_extension =
ExtensionBuilder()
.SetManifest(DictionaryBuilder()
.Set("name", "packed")
.Set("version", "0.0.1")
.Set("manifest_version", 2)
.Build())
.SetLocation(Manifest::INTERNAL)
.SetID(crx_file::id_util::GenerateId("packed"))
.Build();
ExtensionRegistry* registry = ExtensionRegistry::Get(profile_.get());
registry->AddEnabled(unpacked_extension);
registry->AddEnabled(packed_extension);
// We should start with a clean slate.
EXPECT_EQ(0u, error_console_->GetErrorsForExtension(
unpacked_extension->id()).size());
EXPECT_EQ(0u, error_console_->GetErrorsForExtension(
packed_extension->id()).size());
// Errors should be ignored by default for the packed extension.
error_console_->ReportError(
CreateNewManifestError(packed_extension->id(), "manifest error 1"));
error_console_->ReportError(
CreateNewRuntimeError(packed_extension->id(), "runtime error 1"));
EXPECT_EQ(0u, error_console_->GetErrorsForExtension(
packed_extension->id()).size());
// Also check that reporting settings are correctly returned.
EXPECT_FALSE(error_console_->IsReportingEnabledForExtension(
packed_extension->id()));
// Errors should be reported by default for the unpacked extension.
error_console_->ReportError(
CreateNewManifestError(unpacked_extension->id(), "manifest error 2"));
error_console_->ReportError(
CreateNewRuntimeError(unpacked_extension->id(), "runtime error 2"));
EXPECT_EQ(2u, error_console_->GetErrorsForExtension(
unpacked_extension->id()).size());
// Also check that reporting settings are correctly returned.
EXPECT_TRUE(error_console_->IsReportingEnabledForExtension(
unpacked_extension->id()));
// Registering a preference should override this for both types of extensions
// (should be able to enable errors for packed, or disable errors for
// unpacked).
error_console_->SetReportingForExtension(packed_extension->id(),
ExtensionError::RUNTIME_ERROR,
true);
error_console_->ReportError(
CreateNewRuntimeError(packed_extension->id(), "runtime error 3"));
EXPECT_EQ(1u, error_console_->GetErrorsForExtension(
packed_extension->id()).size());
EXPECT_TRUE(error_console_->IsReportingEnabledForExtension(
packed_extension->id()));
error_console_->SetReportingForExtension(unpacked_extension->id(),
ExtensionError::RUNTIME_ERROR,
false);
error_console_->ReportError(
CreateNewRuntimeError(packed_extension->id(), "runtime error 4"));
EXPECT_EQ(2u, // We should still have the first two errors.
error_console_->GetErrorsForExtension(
unpacked_extension->id()).size());
EXPECT_FALSE(error_console_->IsReportingEnabledForExtension(
unpacked_extension->id()));
}
} // namespace extensions
|
