1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/test/browser_test_utils.h"
#include "extensions/common/manifest_handlers/options_page_info.h"
namespace extensions {
namespace {
const GURL& GetActiveUrl(Browser* browser) {
return browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL();
}
} // namespace
using ExtensionTabUtilBrowserTest = ExtensionBrowserTest;
IN_PROC_BROWSER_TEST_F(ExtensionTabUtilBrowserTest, OpenExtensionsOptionsPage) {
// Load an extension with an options page that opens in a tab and one that
// opens in the chrome://extensions page in a view.
const Extension* options_in_tab =
LoadExtension(test_data_dir_.AppendASCII("options_page"));
const Extension* options_in_view =
LoadExtension(test_data_dir_.AppendASCII("options_page_in_view"));
ASSERT_TRUE(options_in_tab);
ASSERT_TRUE(options_in_view);
ASSERT_TRUE(OptionsPageInfo::HasOptionsPage(options_in_tab));
ASSERT_TRUE(OptionsPageInfo::HasOptionsPage(options_in_view));
// Start at the new tab page, and then open the extension options page.
ui_test_utils::NavigateToURL(browser(), GURL("chrome://newtab"));
EXPECT_EQ(1, browser()->tab_strip_model()->count());
GURL options_url = OptionsPageInfo::GetOptionsPage(options_in_tab);
EXPECT_TRUE(ExtensionTabUtil::OpenOptionsPage(options_in_tab, browser()));
// Opening the options page should take the new tab and use it, so we should
// have only one tab, and it should be open to the options page.
EXPECT_EQ(1, browser()->tab_strip_model()->count());
EXPECT_TRUE(content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents()));
EXPECT_EQ(options_url, GetActiveUrl(browser()));
// Calling OpenOptionsPage again shouldn't result in any new tabs, since we
// re-use the existing options page.
EXPECT_TRUE(ExtensionTabUtil::OpenOptionsPage(options_in_tab, browser()));
EXPECT_EQ(1, browser()->tab_strip_model()->count());
EXPECT_TRUE(content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents()));
EXPECT_EQ(options_url, GetActiveUrl(browser()));
// Navigate to google.com (something non-newtab, non-options). Calling
// OpenOptionsPage() should create a new tab and navigate it to the options
// page. So we should have two total tabs, with the active tab pointing to
// options.
ui_test_utils::NavigateToURL(browser(), GURL("http://www.google.com/"));
EXPECT_TRUE(ExtensionTabUtil::OpenOptionsPage(options_in_tab, browser()));
EXPECT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_TRUE(content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents()));
EXPECT_EQ(options_url, GetActiveUrl(browser()));
// Navigate the tab to a different extension URL, and call OpenOptionsPage().
// We should not reuse the current tab since it's opened to a page that isn't
// the options page, and we don't want to arbitrarily close extension content.
// Regression test for crbug.com/587581.
ui_test_utils::NavigateToURL(browser(),
options_in_tab->GetResourceURL("other.html"));
EXPECT_TRUE(ExtensionTabUtil::OpenOptionsPage(options_in_tab, browser()));
EXPECT_EQ(3, browser()->tab_strip_model()->count());
EXPECT_TRUE(content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents()));
EXPECT_EQ(options_url, GetActiveUrl(browser()));
// If the user navigates to the options page e.g. by typing in the url, it
// should not override the currently-open tab.
ui_test_utils::NavigateToURLWithDisposition(
browser(),
options_url,
NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
EXPECT_EQ(4, browser()->tab_strip_model()->count());
EXPECT_EQ(options_url, GetActiveUrl(browser()));
// Test the extension that has the options page open in a view inside
// chrome://extensions.
// Triggering OpenOptionsPage() should create a new tab, since there are none
// to override.
options_url = GURL("chrome://extensions/?options=" + options_in_view->id());
EXPECT_TRUE(ExtensionTabUtil::OpenOptionsPage(options_in_view, browser()));
EXPECT_EQ(5, browser()->tab_strip_model()->count());
EXPECT_TRUE(content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents()));
EXPECT_EQ(options_url, GetActiveUrl(browser()));
// Calling it a second time should not create a new tab, since one already
// exists with that options page open.
EXPECT_TRUE(ExtensionTabUtil::OpenOptionsPage(options_in_view, browser()));
EXPECT_EQ(5, browser()->tab_strip_model()->count());
EXPECT_TRUE(content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents()));
EXPECT_EQ(options_url, GetActiveUrl(browser()));
// Navigate to chrome://extensions (no options). Calling OpenOptionsPage()
// should override that tab rather than opening a new tab. crbug.com/595253.
ui_test_utils::NavigateToURL(browser(), GURL("chrome://extensions"));
EXPECT_TRUE(ExtensionTabUtil::OpenOptionsPage(options_in_view, browser()));
EXPECT_EQ(5, browser()->tab_strip_model()->count());
EXPECT_TRUE(content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents()));
EXPECT_EQ(options_url, GetActiveUrl(browser()));
}
} // namespace extensions
|
