1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/favicon_downloader.h"
#include "base/files/scoped_temp_dir.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/common/favicon_url.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
using content::RenderViewHostTester;
namespace {
// Creates valid SkBitmaps of the dimensions found in |sizes| and pushes them
// into |bitmaps|.
std::vector<SkBitmap> CreateTestBitmaps(const std::vector<gfx::Size>& sizes) {
std::vector<SkBitmap> bitmaps(sizes.size());
for (size_t i = 0; i < sizes.size(); ++i) {
SkBitmap& bitmap = bitmaps[i];
bitmap.allocN32Pixels(sizes[i].width(), sizes[i].height());
bitmap.eraseColor(SK_ColorRED);
}
return bitmaps;
}
class FaviconDownloaderTest : public ChromeRenderViewHostTestHarness {
protected:
FaviconDownloaderTest() {
}
~FaviconDownloaderTest() override {}
private:
DISALLOW_COPY_AND_ASSIGN(FaviconDownloaderTest);
};
} // namespace
class TestFaviconDownloader : public FaviconDownloader {
public:
TestFaviconDownloader(content::WebContents* web_contents,
std::vector<GURL> extra_favicon_urls)
: FaviconDownloader(
web_contents,
extra_favicon_urls,
base::Bind(&TestFaviconDownloader::DownloadsComplete,
base::Unretained(this))),
id_counter_(0) {
}
~TestFaviconDownloader() override {}
int DownloadImage(const GURL& url) override { return id_counter_++; }
std::vector<content::FaviconURL> GetFaviconURLsFromWebContents() override {
return initial_favicon_urls_;
}
size_t pending_requests() const {
return in_progress_requests_.size();
}
void DownloadsComplete(bool success,
const FaviconDownloader::FaviconMap& map) {
favicon_map_ = map;
}
FaviconDownloader::FaviconMap favicon_map() const {
return favicon_map_;
}
void CompleteImageDownload(
int id,
const GURL& image_url,
const std::vector<gfx::Size>& original_bitmap_sizes) {
FaviconDownloader::DidDownloadFavicon(id, 200, image_url,
CreateTestBitmaps(original_bitmap_sizes), original_bitmap_sizes);
}
void UpdateFaviconURLs(const std::vector<content::FaviconURL>& candidates) {
FaviconDownloader::DidUpdateFaviconURL(candidates);
}
void set_initial_favicon_urls(const std::vector<content::FaviconURL>& urls) {
initial_favicon_urls_ = urls;
}
private:
std::vector<content::FaviconURL> initial_favicon_urls_;
FaviconDownloader::FaviconMap favicon_map_;
int id_counter_;
DISALLOW_COPY_AND_ASSIGN(TestFaviconDownloader);
};
TEST_F(FaviconDownloaderTest, SimpleDownload) {
const GURL favicon_url("http://www.google.com/favicon.ico");
TestFaviconDownloader downloader(web_contents(), std::vector<GURL>());
std::vector<content::FaviconURL> favicon_urls;
favicon_urls.push_back(content::FaviconURL(
favicon_url, content::FaviconURL::FAVICON, std::vector<gfx::Size>()));
downloader.set_initial_favicon_urls(favicon_urls);
EXPECT_EQ(0u, downloader.pending_requests());
downloader.Start();
EXPECT_EQ(1u, downloader.pending_requests());
std::vector<gfx::Size> sizes(1, gfx::Size(32, 32));
downloader.CompleteImageDownload(0, favicon_urls[0].icon_url, sizes);
EXPECT_EQ(0u, downloader.pending_requests());
EXPECT_EQ(1u, downloader.favicon_map().size());
EXPECT_EQ(1u, downloader.favicon_map()[favicon_url].size());
}
TEST_F(FaviconDownloaderTest, DownloadWithUrlsFromWebContentsNotification) {
const GURL favicon_url("http://www.google.com/favicon.ico");
TestFaviconDownloader downloader(web_contents(), std::vector<GURL>());
std::vector<content::FaviconURL> favicon_urls;
favicon_urls.push_back(content::FaviconURL(
favicon_url, content::FaviconURL::FAVICON, std::vector<gfx::Size>()));
EXPECT_EQ(0u, downloader.pending_requests());
// Start downloader before favicon URLs are loaded.
downloader.Start();
EXPECT_EQ(0u, downloader.pending_requests());
downloader.UpdateFaviconURLs(favicon_urls);
EXPECT_EQ(1u, downloader.pending_requests());
std::vector<gfx::Size> sizes(1, gfx::Size(32, 32));
downloader.CompleteImageDownload(0, favicon_urls[0].icon_url, sizes);
EXPECT_EQ(0u, downloader.pending_requests());
EXPECT_EQ(1u, downloader.favicon_map().size());
EXPECT_EQ(1u, downloader.favicon_map()[favicon_url].size());
}
TEST_F(FaviconDownloaderTest, DownloadMultipleUrls) {
const GURL empty_favicon("http://www.google.com/empty_favicon.ico");
const GURL favicon_url_1("http://www.google.com/favicon.ico");
const GURL favicon_url_2("http://www.google.com/favicon2.ico");
std::vector<GURL> extra_urls;
// This should get downloaded.
extra_urls.push_back(favicon_url_2);
// This is duplicated in the favicon urls and should only be downloaded once.
extra_urls.push_back(empty_favicon);
TestFaviconDownloader downloader(web_contents(), extra_urls);
std::vector<content::FaviconURL> favicon_urls;
favicon_urls.push_back(content::FaviconURL(
favicon_url_1, content::FaviconURL::FAVICON, std::vector<gfx::Size>()));
// This is duplicated in the favicon urls and should only be downloaded once.
favicon_urls.push_back(content::FaviconURL(
empty_favicon, content::FaviconURL::FAVICON, std::vector<gfx::Size>()));
// Invalid icons shouldn't get put into the download queue.
favicon_urls.push_back(
content::FaviconURL(GURL("http://www.google.com/invalid.ico"),
content::FaviconURL::INVALID_ICON,
std::vector<gfx::Size>()));
downloader.set_initial_favicon_urls(favicon_urls);
downloader.Start();
EXPECT_EQ(3u, downloader.pending_requests());
std::vector<gfx::Size> sizes_1(1, gfx::Size(16, 16));
downloader.CompleteImageDownload(0, favicon_url_1, sizes_1);
std::vector<gfx::Size> sizes_2;
sizes_2.push_back(gfx::Size(32, 32));
sizes_2.push_back(gfx::Size(64, 64));
downloader.CompleteImageDownload(1, favicon_url_2, sizes_2);
// Only 1 download should have been initiated for |empty_favicon| even though
// the URL was in both the web app info and the favicon urls.
downloader.CompleteImageDownload(2, empty_favicon, std::vector<gfx::Size>());
EXPECT_EQ(0u, downloader.pending_requests());
EXPECT_EQ(3u, downloader.favicon_map().size());
EXPECT_EQ(0u, downloader.favicon_map()[empty_favicon].size());
EXPECT_EQ(1u, downloader.favicon_map()[favicon_url_1].size());
EXPECT_EQ(2u, downloader.favicon_map()[favicon_url_2].size());
}
|
