1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/permissions_updater.h"
#include "chrome/browser/extensions/test_extension_environment.h"
#include "chrome/common/extensions/permissions/chrome_permission_message_provider.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/testing_profile.h"
#include "components/crx_file/id_util.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/manifest.h"
#include "extensions/common/manifest_handlers/permissions_parser.h"
#include "extensions/common/permissions/permission_set.h"
#include "extensions/common/permissions/permissions_data.h"
#include "extensions/common/test_util.h"
#include "extensions/common/value_builder.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
namespace extensions {
// Tests that ChromePermissionMessageProvider provides not only correct, but
// meaningful permission messages that coalesce correctly where appropriate.
// There are 3 types of permission messages that need to be tested:
// 1. The combined list of active permissions, displayed at install time (or
// when the app has been disabled automatically and needs to be re-enabled)
// 2. The split list of active permissions, displayed in the App Info dialog,
// where the optional permissions are individually revokable
// 3. The list of requested optional permissions, displayed in a prompt to the
// user when the app requests these during runtime
// Some of these tests are prefixed AntiTest_, since they demonstrate existing
// problematic functionality. These tests are prefixed with AntiTest_ and will
// be changed as the correct behaviour is implemented. TODOs in the test explain
// the currently problematic behaviour.
class PermissionMessagesUnittest : public testing::Test {
public:
PermissionMessagesUnittest()
: message_provider_(new ChromePermissionMessageProvider()) {}
~PermissionMessagesUnittest() override {}
// Overridden from testing::Test:
void SetUp() override {
testing::Test::SetUp();
}
protected:
void CreateAndInstallAppWithPermissions(ListBuilder& required_permissions,
ListBuilder& optional_permissions) {
app_ = test_util::BuildApp(ExtensionBuilder().Pass())
.MergeManifest(
DictionaryBuilder()
.Set("permissions", required_permissions)
.Set("optional_permissions", optional_permissions))
.SetID(crx_file::id_util::GenerateId("app"))
.SetLocation(Manifest::INTERNAL)
.Build();
env_.GetExtensionService()->AddExtension(app_.get());
}
void CreateAndInstallExtensionWithPermissions(
ListBuilder& required_permissions,
ListBuilder& optional_permissions) {
app_ = test_util::BuildExtension(ExtensionBuilder().Pass())
.MergeManifest(
DictionaryBuilder()
.Set("permissions", required_permissions)
.Set("optional_permissions", optional_permissions))
.SetID(crx_file::id_util::GenerateId("extension"))
.SetLocation(Manifest::INTERNAL)
.Build();
env_.GetExtensionService()->AddExtension(app_.get());
}
// Returns the permission messages that would display in the prompt that
// requests all the optional permissions for the current |app_|.
std::vector<base::string16> GetOptionalPermissionMessages() {
scoped_refptr<const PermissionSet> granted_permissions =
env_.GetExtensionPrefs()->GetGrantedPermissions(app_->id());
scoped_refptr<const PermissionSet> optional_permissions =
PermissionsParser::GetOptionalPermissions(app_.get());
scoped_refptr<const PermissionSet> requested_permissions =
PermissionSet::CreateDifference(optional_permissions.get(),
granted_permissions.get());
return GetMessages(requested_permissions);
}
void GrantOptionalPermissions() {
PermissionsUpdater perms_updater(env_.profile());
perms_updater.AddPermissions(
app_.get(),
PermissionsParser::GetOptionalPermissions(app_.get()).get());
}
std::vector<base::string16> active_permissions() {
return GetMessages(app_->permissions_data()->active_permissions());
}
std::vector<base::string16> required_permissions() {
return GetMessages(PermissionsParser::GetRequiredPermissions(app_.get()));
}
std::vector<base::string16> optional_permissions() {
return GetMessages(PermissionsParser::GetOptionalPermissions(app_.get()));
}
private:
std::vector<base::string16> GetMessages(
scoped_refptr<const PermissionSet> permissions) {
std::vector<base::string16> messages;
for (const PermissionMessageString& str :
message_provider_->GetPermissionMessageStrings(permissions.get(),
app_->GetType())) {
messages.push_back(str.message);
}
return messages;
}
extensions::TestExtensionEnvironment env_;
scoped_ptr<ChromePermissionMessageProvider> message_provider_;
scoped_refptr<const Extension> app_;
DISALLOW_COPY_AND_ASSIGN(PermissionMessagesUnittest);
};
// If an app has both the 'history' and 'tabs' permission, one should hide the
// other (the 'history' permission has superset permissions).
TEST_F(PermissionMessagesUnittest, HistoryHidesTabsMessage) {
CreateAndInstallExtensionWithPermissions(
ListBuilder().Append("tabs").Append("history").Pass(),
ListBuilder().Pass());
ASSERT_EQ(1U, required_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE),
required_permissions()[0]);
ASSERT_EQ(0U, optional_permissions().size());
}
// If an app requests the 'history' permission, but already has the 'tabs'
// permission, only the new coalesced message is displayed.
TEST_F(PermissionMessagesUnittest, MixedPermissionMessagesCoalesceOnceGranted) {
CreateAndInstallExtensionWithPermissions(
ListBuilder().Append("tabs").Pass(),
ListBuilder().Append("history").Pass());
ASSERT_EQ(1U, required_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ),
required_permissions()[0]);
ASSERT_EQ(1U, optional_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE),
optional_permissions()[0]);
ASSERT_EQ(1U, active_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ),
active_permissions()[0]);
ASSERT_EQ(1U, GetOptionalPermissionMessages().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE),
GetOptionalPermissionMessages()[0]);
GrantOptionalPermissions();
ASSERT_EQ(1U, active_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE),
active_permissions()[0]);
}
// AntiTest: This behavior should be changed and improved.
// If an app requests the 'tabs' permission but already has the 'history'
// permission, a prompt is displayed. However, no prompt should appear at all,
// since 'tabs' is a subset of 'history' and the final list of permissions are
// not affected by this grant.
TEST_F(PermissionMessagesUnittest,
AntiTest_PromptCanRequestSubsetOfAlreadyGrantedPermissions) {
CreateAndInstallExtensionWithPermissions(
ListBuilder().Append("history").Pass(),
ListBuilder().Append("tabs").Pass());
ASSERT_EQ(1U, required_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE),
required_permissions()[0]);
ASSERT_EQ(1U, optional_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ),
optional_permissions()[0]);
ASSERT_EQ(1U, active_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE),
active_permissions()[0]);
// TODO(sashab): This prompt should display no permissions, since READ is a
// subset permission of WRITE.
ASSERT_EQ(1U, GetOptionalPermissionMessages().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ),
GetOptionalPermissionMessages()[0]);
GrantOptionalPermissions();
ASSERT_EQ(1U, active_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE),
active_permissions()[0]);
}
// AntiTest: This behavior should be changed and improved.
// If an app requests the 'sessions' permission, nothing is displayed in the
// permission request prompt. However, the required permissions for the app are
// actually modified, so the prompt *should* display a message to prevent this
// permission from being granted for free.
TEST_F(PermissionMessagesUnittest,
AntiTest_PromptCanBeEmptyButCausesChangeInPermissions) {
CreateAndInstallExtensionWithPermissions(
ListBuilder().Append("tabs").Pass(),
ListBuilder().Append("sessions").Pass());
ASSERT_EQ(1U, required_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ),
required_permissions()[0]);
ASSERT_EQ(0U, optional_permissions().size());
ASSERT_EQ(1U, active_permissions().size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ),
active_permissions()[0]);
// TODO(sashab): This prompt should display the sessions permission message,
// as well as warn the user that it can affect the existing 'tab' permission.
ASSERT_EQ(0U, GetOptionalPermissionMessages().size());
GrantOptionalPermissions();
ASSERT_EQ(1U, active_permissions().size());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS),
active_permissions()[0]);
}
} // namespace extensions
|
