1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/files/file_path.h"
#include "base/json/json_file_value_serializer.h"
#include "base/memory/ref_counted.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_unittest.h"
#include "chrome/browser/extensions/permissions_updater.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/permissions/permission_set.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/notification_service.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace {
// A helper class that listens for NOTIFICATION_EXTENSION_PERMISSIONS_UPDATED.
class PermissionsUpdaterListener : public content::NotificationObserver {
public:
PermissionsUpdaterListener()
: received_notification_(false), waiting_(false) {
registrar_.Add(this,
chrome::NOTIFICATION_EXTENSION_PERMISSIONS_UPDATED,
content::NotificationService::AllSources());
}
void Reset() {
received_notification_ = false;
waiting_ = false;
extension_ = NULL;
permissions_ = NULL;
}
void Wait() {
if (received_notification_)
return;
waiting_ = true;
base::RunLoop run_loop;
run_loop.Run();
}
bool received_notification() const { return received_notification_; }
const Extension* extension() const { return extension_; }
const PermissionSet* permissions() const { return permissions_; }
UpdatedExtensionPermissionsInfo::Reason reason() const {
return reason_;
}
private:
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE {
received_notification_ = true;
UpdatedExtensionPermissionsInfo* info =
content::Details<UpdatedExtensionPermissionsInfo>(details).ptr();
extension_ = info->extension;
permissions_ = info->permissions;
reason_ = info->reason;
if (waiting_) {
waiting_ = false;
MessageLoopForUI::current()->Quit();
}
}
bool received_notification_;
bool waiting_;
content::NotificationRegistrar registrar_;
scoped_refptr<const Extension> extension_;
scoped_refptr<const PermissionSet> permissions_;
UpdatedExtensionPermissionsInfo::Reason reason_;
};
class PermissionsUpdaterTest : public ExtensionServiceTestBase {
};
scoped_refptr<Extension> LoadManifest(std::string* error) {
base::FilePath path;
PathService::Get(chrome::DIR_TEST_DATA, &path);
path = path.AppendASCII("extensions")
.AppendASCII("api_test")
.AppendASCII("permissions")
.AppendASCII("optional")
.AppendASCII("manifest.json");
JSONFileValueSerializer serializer(path);
scoped_ptr<Value> result(serializer.Deserialize(NULL, error));
if (!result)
return NULL;
scoped_refptr<Extension> extension = Extension::Create(
path.DirName(), Manifest::INTERNAL,
*static_cast<DictionaryValue*>(result.get()), Extension::NO_FLAGS, error);
return extension;
}
void AddPattern(URLPatternSet* extent, const std::string& pattern) {
int schemes = URLPattern::SCHEME_ALL;
extent->AddPattern(URLPattern(schemes, pattern));
}
} // namespace
// Test that the PermissionUpdater can correctly add and remove active
// permissions. This tests all of PermissionsUpdater's public methods because
// GrantActivePermissions and UpdateActivePermissions are used by
// AddPermissions.
TEST_F(PermissionsUpdaterTest, AddAndRemovePermissions) {
InitializeEmptyExtensionService();
// Load the test extension.
std::string error;
scoped_refptr<Extension> extension = LoadManifest(&error);
ASSERT_TRUE(error.empty()) << error;
APIPermissionSet default_apis;
default_apis.insert(APIPermission::kManagement);
URLPatternSet default_hosts;
AddPattern(&default_hosts, "http://a.com/*");
scoped_refptr<PermissionSet> default_permissions =
new PermissionSet(default_apis, default_hosts, URLPatternSet());
// Make sure it loaded properly.
scoped_refptr<const PermissionSet> permissions =
extension->GetActivePermissions();
ASSERT_EQ(*default_permissions, *extension->GetActivePermissions());
// Add a few permissions.
APIPermissionSet apis;
apis.insert(APIPermission::kTab);
apis.insert(APIPermission::kNotification);
URLPatternSet hosts;
AddPattern(&hosts, "http://*.c.com/*");
scoped_refptr<PermissionSet> delta =
new PermissionSet(apis, hosts, URLPatternSet());
PermissionsUpdaterListener listener;
PermissionsUpdater updater(profile_.get());
updater.AddPermissions(extension.get(), delta.get());
listener.Wait();
// Verify that the permission notification was sent correctly.
ASSERT_TRUE(listener.received_notification());
ASSERT_EQ(extension, listener.extension());
ASSERT_EQ(UpdatedExtensionPermissionsInfo::ADDED, listener.reason());
ASSERT_EQ(*delta, *listener.permissions());
// Make sure the extension's active permissions reflect the change.
scoped_refptr<PermissionSet> active_permissions =
PermissionSet::CreateUnion(default_permissions, delta);
ASSERT_EQ(*active_permissions, *extension->GetActivePermissions());
// Verify that the new granted and active permissions were also stored
// in the extension preferences. In this case, the granted permissions should
// be equal to the active permissions.
ExtensionPrefs* prefs = service_->extension_prefs();
scoped_refptr<PermissionSet> granted_permissions =
active_permissions;
scoped_refptr<PermissionSet> from_prefs =
prefs->GetActivePermissions(extension->id());
ASSERT_EQ(*active_permissions, *from_prefs);
from_prefs = prefs->GetGrantedPermissions(extension->id());
ASSERT_EQ(*active_permissions, *from_prefs);
// In the second part of the test, we'll remove the permissions that we
// just added except for 'notification'.
apis.erase(APIPermission::kNotification);
delta = new PermissionSet(apis, hosts, URLPatternSet());
listener.Reset();
updater.RemovePermissions(extension, delta);
listener.Wait();
// Verify that the notification was correct.
ASSERT_TRUE(listener.received_notification());
ASSERT_EQ(extension, listener.extension());
ASSERT_EQ(UpdatedExtensionPermissionsInfo::REMOVED, listener.reason());
ASSERT_EQ(*delta, *listener.permissions());
// Make sure the extension's active permissions reflect the change.
active_permissions =
PermissionSet::CreateDifference(active_permissions, delta);
ASSERT_EQ(*active_permissions, *extension->GetActivePermissions());
// Verify that the extension prefs hold the new active permissions and the
// same granted permissions.
from_prefs = prefs->GetActivePermissions(extension->id());
ASSERT_EQ(*active_permissions, *from_prefs);
from_prefs = prefs->GetGrantedPermissions(extension->id());
ASSERT_EQ(*granted_permissions, *from_prefs);
}
} // namespace extensions
|
