1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "chrome/browser/history/android/visit_sql_handler.h"
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/history/android/urls_sql_handler.h"
#include "chrome/browser/history/history_database.h"
#include "chrome/common/chrome_constants.h"
#include "components/history/core/browser/history_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::Time;
using base::TimeDelta;
namespace history {
class VisitSQLHandlerTest : public testing::Test {
public:
VisitSQLHandlerTest()
: urls_sql_handler_(&history_db_),
visit_sql_handler_(&history_db_) {
}
virtual ~VisitSQLHandlerTest() {}
protected:
virtual void SetUp() {
// Get a temporary directory for the test DB files.
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
base::FilePath history_db_name =
temp_dir_.path().AppendASCII(kHistoryFilename);
ASSERT_EQ(sql::INIT_OK, history_db_.Init(history_db_name));
}
virtual void TearDown() {
}
HistoryDatabase history_db_;
base::ScopedTempDir temp_dir_;
UrlsSQLHandler urls_sql_handler_;
VisitSQLHandler visit_sql_handler_;
private:
DISALLOW_COPY_AND_ASSIGN(VisitSQLHandlerTest);
};
// Insert a url with only url set to verify no visit was inserted in visit
// table.
TEST_F(VisitSQLHandlerTest, InsertURL) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
// Noting should be inserted to visit table.
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
EXPECT_EQ(0u, visits.size());
}
// Insert a url with last visit time set to verify a visit was inserted.
TEST_F(VisitSQLHandlerTest, InsertURLWithLastVisitTime) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_last_visit_time(Time::Now());
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
EXPECT_EQ(1u, visits.size());
EXPECT_EQ(row.last_visit_time(), visits[0].visit_time);
}
// Insert a urls with created time to verify the a visit was inserted.
TEST_F(VisitSQLHandlerTest, InsertURLWithCreatedTime) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_title(base::UTF8ToUTF16("Google"));
row.set_created(Time::Now());
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
EXPECT_EQ(1u, visits.size());
EXPECT_EQ(row.created(), visits[0].visit_time);
}
// Insert a URL with visit count as 1 to verify a visit was inserted.
TEST_F(VisitSQLHandlerTest, InsertURLWithVisitCount) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_visit_count(1);
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
EXPECT_EQ(1u, visits.size());
EXPECT_NE(Time(), visits[0].visit_time);
}
// Insert a URL with all values set to verify the visit rows
// were inserted correctly.
TEST_F(VisitSQLHandlerTest, Insert) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_visit_count(10);
row.set_last_visit_time(Time::Now());
row.set_created(Time::Now() - TimeDelta::FromDays(1));
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
// 10 row were inserted.
EXPECT_EQ(10u, visits.size());
// The earlies one has created time set.
EXPECT_EQ(row.created(), visits[0].visit_time);
// The latest one has last visit time set.
EXPECT_EQ(row.last_visit_time(), visits[9].visit_time);
}
// Test the case that both visit time and visit count updated.
TEST_F(VisitSQLHandlerTest, UpdateVisitTimeAndVisitCount) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_title(base::UTF8ToUTF16("Google"));
row.set_visit_count(10);
row.set_last_visit_time(Time::Now() - TimeDelta::FromDays(10));
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
HistoryAndBookmarkRow update_row;
update_row.set_last_visit_time(Time::Now());
update_row.set_visit_count(1);
TableIDRow id;
id.url_id = url_row.id();
TableIDRows ids;
ids.push_back(id);
ASSERT_TRUE(urls_sql_handler_.Update(update_row, ids));
ASSERT_TRUE(visit_sql_handler_.Update(update_row, ids));
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
EXPECT_EQ(1u, visits.size());
EXPECT_EQ(update_row.last_visit_time(), visits[0].visit_time);
}
// Update visit count to zero to verify the visit rows of this url
// were removed.
TEST_F(VisitSQLHandlerTest, UpdateVisitCountZero) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_visit_count(10);
row.set_last_visit_time(Time::Now() - TimeDelta::FromDays(10));
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
HistoryAndBookmarkRow update_row;
update_row.set_visit_count(0);
TableIDRow id;
id.url_id = url_row.id();
TableIDRows ids;
ids.push_back(id);
ASSERT_TRUE(urls_sql_handler_.Update(update_row, ids));
ASSERT_TRUE(visit_sql_handler_.Update(update_row, ids));
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
EXPECT_EQ(0, url_row.visit_count());
// Last visit is reset.
EXPECT_EQ(Time(), url_row.last_visit());
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
EXPECT_EQ(0u, visits.size());
}
// Update both last visit time and created time to verify
// that visits row are updated correctly.
TEST_F(VisitSQLHandlerTest, UpdateBothTime) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_visit_count(10);
row.set_last_visit_time(Time::Now() - TimeDelta::FromDays(10));
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
ASSERT_TRUE(visit_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
HistoryAndBookmarkRow update_row;
update_row.set_last_visit_time(Time::Now() - TimeDelta::FromDays(9));
update_row.set_created(Time::Now() - TimeDelta::FromDays(10));
TableIDRow id;
id.url_id = url_row.id();
TableIDRows ids;
ids.push_back(id);
ASSERT_TRUE(urls_sql_handler_.Update(update_row, ids));
ASSERT_TRUE(visit_sql_handler_.Update(update_row, ids));
VisitVector visits;
ASSERT_TRUE(history_db_.GetVisitsForURL(row.url_id(), &visits));
// Though both time are updated, visit count was increase by 1 because of
// last visit time's change.
EXPECT_EQ(11u, visits.size());
EXPECT_EQ(update_row.created(), visits[0].visit_time);
EXPECT_EQ(update_row.last_visit_time(), visits[10].visit_time);
}
// Update the visit count to verify the new visits are inserted.
TEST_F(VisitSQLHandlerTest, UpdateVisitCountIncreased) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_visit_count(10);
row.set_last_visit_time(Time::Now() - TimeDelta::FromDays(10));
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
EXPECT_EQ(row.url(), url_row.url());
EXPECT_EQ(10, url_row.visit_count());
EXPECT_EQ(row.last_visit_time(), url_row.last_visit());
HistoryAndBookmarkRow update_row;
update_row.set_visit_count(11);
TableIDRow id;
id.url_id = url_row.id();
TableIDRows ids;
ids.push_back(id);
ASSERT_TRUE(urls_sql_handler_.Update(update_row, ids));
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
EXPECT_EQ(row.url(), url_row.url());
EXPECT_EQ(11, url_row.visit_count());
EXPECT_LT(row.last_visit_time(), url_row.last_visit());
}
TEST_F(VisitSQLHandlerTest, Delete) {
HistoryAndBookmarkRow row;
row.set_raw_url("http://google.com");
row.set_url(GURL("http://google.com"));
row.set_visit_count(10);
row.set_last_visit_time(Time::Now() - TimeDelta::FromDays(10));
ASSERT_TRUE(urls_sql_handler_.Insert(&row));
URLRow url_row;
ASSERT_TRUE(history_db_.GetURLRow(row.url_id(), &url_row));
EXPECT_EQ(row.url(), url_row.url());
EXPECT_EQ(10, url_row.visit_count());
EXPECT_EQ(row.last_visit_time(), url_row.last_visit());
TableIDRow id;
id.url_id = url_row.id();
TableIDRows ids;
ids.push_back(id);
ASSERT_TRUE(urls_sql_handler_.Delete(ids));
EXPECT_FALSE(history_db_.GetURLRow(row.url_id(), &url_row));
}
} // namespace history
|
