1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/media_galleries/fileapi/picasa_data_provider.h"
#include <utility>
#include <vector>
#include "base/files/file_enumerator.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "build/build_config.h"
#include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
#include "chrome/common/media_galleries/picasa_test_util.h"
#include "chrome/common/media_galleries/picasa_types.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/test/test_browser_thread.h"
namespace picasa {
namespace {
void VerifyTestAlbumTable(PicasaDataProvider* data_provider,
base::FilePath test_folder_1_path,
base::FilePath test_folder_2_path) {
scoped_ptr<AlbumMap> folders = data_provider->GetFolders();
ASSERT_TRUE(folders.get());
EXPECT_EQ(2u, folders->size());
AlbumMap::const_iterator folder_1 = folders->find(
test_folder_1_path.BaseName().AsUTF8Unsafe() + " 1899-12-30");
EXPECT_NE(folders->end(), folder_1);
EXPECT_EQ(test_folder_1_path.BaseName().AsUTF8Unsafe(),
folder_1->second.name);
EXPECT_EQ(test_folder_1_path, folder_1->second.path);
EXPECT_EQ("uid1", folder_1->second.uid);
AlbumMap::const_iterator folder_2 = folders->find(
test_folder_2_path.BaseName().AsUTF8Unsafe() + " 1899-12-30");
EXPECT_NE(folders->end(), folder_2);
EXPECT_EQ(test_folder_2_path.BaseName().AsUTF8Unsafe(),
folder_2->second.name);
EXPECT_EQ(test_folder_2_path, folder_2->second.path);
EXPECT_EQ("uid4", folder_2->second.uid);
scoped_ptr<AlbumMap> albums = data_provider->GetAlbums();
ASSERT_TRUE(albums.get());
EXPECT_EQ(2u, albums->size());
AlbumMap::const_iterator album_1 = albums->find("Album 1 Name 1899-12-30");
EXPECT_NE(albums->end(), album_1);
EXPECT_EQ("Album 1 Name", album_1->second.name);
EXPECT_EQ(base::FilePath(), album_1->second.path);
EXPECT_EQ("uid3", album_1->second.uid);
AlbumMap::const_iterator album_2 = albums->find("Album 2 Name 1899-12-30");
EXPECT_NE(albums->end(), album_2);
EXPECT_EQ("Album 2 Name", album_2->second.name);
EXPECT_EQ(base::FilePath(), album_2->second.path);
EXPECT_EQ("uid5", album_2->second.uid);
}
void VerifyTestAlbumsImagesIndex(PicasaDataProvider* data_provider,
base::FilePath test_folder_1_path,
base::FilePath test_folder_2_path) {
base::File::Error error;
scoped_ptr<AlbumImages> album_1_images =
data_provider->FindAlbumImages("uid3", &error);
ASSERT_TRUE(album_1_images);
EXPECT_EQ(base::File::FILE_OK, error);
EXPECT_EQ(2u, album_1_images->size());
EXPECT_NE(album_1_images->end(), album_1_images->find("InBoth.jpg"));
EXPECT_EQ(test_folder_1_path.AppendASCII("InBoth.jpg"),
(*album_1_images)["InBoth.jpg"]);
EXPECT_NE(album_1_images->end(),
album_1_images->find("InFirstAlbumOnly.jpg"));
EXPECT_EQ(test_folder_2_path.AppendASCII("InFirstAlbumOnly.jpg"),
(*album_1_images)["InFirstAlbumOnly.jpg"]);
scoped_ptr<AlbumImages> album_2_images =
data_provider->FindAlbumImages("uid5", &error);
ASSERT_TRUE(album_2_images);
EXPECT_EQ(base::File::FILE_OK, error);
EXPECT_EQ(2u, album_2_images->size());
EXPECT_NE(album_2_images->end(), album_2_images->find("InBoth.jpg"));
EXPECT_EQ(test_folder_1_path.AppendASCII("InBoth.jpg"),
(*album_2_images)["InBoth.jpg"]);
EXPECT_NE(album_2_images->end(),
album_2_images->find("InSecondAlbumOnly.jpg"));
EXPECT_EQ(test_folder_1_path.AppendASCII("InSecondAlbumOnly.jpg"),
(*album_2_images)["InSecondAlbumOnly.jpg"]);
}
} // namespace
class TestPicasaDataProvider : public PicasaDataProvider {
public:
explicit TestPicasaDataProvider(const base::FilePath& database_path)
: PicasaDataProvider(database_path),
file_watch_request_returned_(false) {
}
~TestPicasaDataProvider() override {}
// |ready_callback| called with true if and when the file watch is started
// successfully. If the file watch fails, it's called with false.
void EnsureFileWatchStartedForTesting(const ReadyCallback& ready_callback) {
if (!file_watch_request_returned_) {
file_watch_started_callbacks_.push_back(ready_callback);
return;
}
ready_callback.Run(temp_dir_watcher_.get() != NULL);
}
// Simulates the actual writing process of moving all the database files
// from the temporary directory to the database directory in a loop.
void MoveTempFilesToDatabase() {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
base::FileEnumerator file_enumerator(
database_path_.DirName().AppendASCII(kPicasaTempDirName),
false /* recursive */,
base::FileEnumerator::FILES);
for (base::FilePath src_path = file_enumerator.Next(); !src_path.empty();
src_path = file_enumerator.Next()) {
ASSERT_TRUE(
base::Move(src_path, database_path_.Append(src_path.BaseName())));
}
}
void SetInvalidateCallback(const base::Closure& callback) {
DCHECK(invalidate_callback_.is_null());
invalidate_callback_ = callback;
}
void InvalidateData() override {
PicasaDataProvider::InvalidateData();
if (!invalidate_callback_.is_null()) {
invalidate_callback_.Run();
invalidate_callback_.Reset();
}
}
void SetAlbumMapsForTesting(const AlbumMap& album_map,
const AlbumMap& folder_map) {
album_map_ = album_map;
folder_map_ = folder_map;
}
private:
void OnTempDirWatchStarted(
scoped_ptr<base::FilePathWatcher> temp_dir_watcher) override {
PicasaDataProvider::OnTempDirWatchStarted(std::move(temp_dir_watcher));
file_watch_request_returned_ = true;
for (std::vector<ReadyCallback>::const_iterator it =
file_watch_started_callbacks_.begin();
it != file_watch_started_callbacks_.end();
++it) {
it->Run(temp_dir_watcher_.get() != NULL);
}
file_watch_started_callbacks_.clear();
}
// Used for test that utilizes file watch
bool file_watch_request_returned_;
std::vector<ReadyCallback> file_watch_started_callbacks_;
base::Closure invalidate_callback_;
};
class PicasaDataProviderTest : public InProcessBrowserTest {
public:
PicasaDataProviderTest() {}
~PicasaDataProviderTest() override {}
protected:
// Runs on the MediaTaskRunner and designed to be overridden by subclasses.
virtual void InitializeTestData() {}
void RunTest() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
base::RunLoop loop;
quit_closure_ = loop.QuitClosure();
MediaFileSystemBackend::MediaTaskRunner()->PostTask(
FROM_HERE,
base::Bind(&PicasaDataProviderTest::SetupFoldersAndDataProvider,
base::Unretained(this)));
MediaFileSystemBackend::MediaTaskRunner()->PostTask(
FROM_HERE,
base::Bind(&PicasaDataProviderTest::InitializeTestData,
base::Unretained(this)));
MediaFileSystemBackend::MediaTaskRunner()->PostTask(
FROM_HERE,
base::Bind(&PicasaDataProviderTest::StartTestOnMediaTaskRunner,
base::Unretained(this)));
loop.Run();
}
virtual PicasaDataProvider::DataType RequestedDataType() const = 0;
// Start the test. The data provider is refreshed before calling StartTest
// and the result of the refresh is passed in.
virtual void VerifyRefreshResults(bool parse_success) {};
void TestDone() {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
// The data provider must be destructed on the MediaTaskRunner. This is done
// in a posted task rather than directly because TestDone is called by
// PicasaDataProvider. The callee should not destroy the caller.
MediaFileSystemBackend::MediaTaskRunner()->PostTask(
FROM_HERE,
base::Bind(&PicasaDataProviderTest::DestructDataProviderThenQuit,
base::Unretained(this)));
}
const base::FilePath& test_folder_1_path() { return test_folder_1_.path(); }
const base::FilePath& test_folder_2_path() { return test_folder_2_.path(); }
TestPicasaDataProvider* data_provider() const {
return picasa_data_provider_.get();
}
const base::FilePath GetTempDirPath() const {
return picasa_root_dir_.path().AppendASCII(kPicasaTempDirName);
}
virtual base::FilePath GetColumnFileDestination() const {
return picasa_root_dir_.path().AppendASCII(kPicasaDatabaseDirName);
}
private:
void SetupFoldersAndDataProvider() {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
ASSERT_TRUE(test_folder_1_.CreateUniqueTempDir());
ASSERT_TRUE(test_folder_2_.CreateUniqueTempDir());
ASSERT_TRUE(picasa_root_dir_.CreateUniqueTempDir());
ASSERT_TRUE(base::CreateDirectory(
picasa_root_dir_.path().AppendASCII(kPicasaDatabaseDirName)));
ASSERT_TRUE(base::CreateDirectory(
picasa_root_dir_.path().AppendASCII(kPicasaTempDirName)));
picasa_data_provider_.reset(new TestPicasaDataProvider(
picasa_root_dir_.path().AppendASCII(kPicasaDatabaseDirName)));
}
virtual void StartTestOnMediaTaskRunner() {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
data_provider()->RefreshData(
RequestedDataType(),
base::Bind(&PicasaDataProviderTest::VerifyRefreshResults,
base::Unretained(this)));
}
void DestructDataProviderThenQuit() {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
picasa_data_provider_.reset();
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE, quit_closure_);
}
base::ScopedTempDir test_folder_1_;
base::ScopedTempDir test_folder_2_;
base::ScopedTempDir picasa_root_dir_;
scoped_ptr<TestPicasaDataProvider> picasa_data_provider_;
base::Closure quit_closure_;
DISALLOW_COPY_AND_ASSIGN(PicasaDataProviderTest);
};
class PicasaDataProviderNoDatabaseGetListTest : public PicasaDataProviderTest {
protected:
PicasaDataProvider::DataType RequestedDataType() const override {
return PicasaDataProvider::LIST_OF_ALBUMS_AND_FOLDERS_DATA;
}
void VerifyRefreshResults(bool parse_success) override {
EXPECT_FALSE(parse_success);
TestDone();
}
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderNoDatabaseGetListTest,
NoDatabaseGetList) {
RunTest();
}
class PicasaDataProviderNoDatabaseGetAlbumsImagesTest
: public PicasaDataProviderTest {
protected:
PicasaDataProvider::DataType RequestedDataType() const override {
return PicasaDataProvider::ALBUMS_IMAGES_DATA;
}
void VerifyRefreshResults(bool parse_success) override {
EXPECT_FALSE(parse_success);
TestDone();
}
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderNoDatabaseGetAlbumsImagesTest,
NoDatabaseGetAlbumsImages) {
RunTest();
}
class PicasaDataProviderGetListTest : public PicasaDataProviderTest {
protected:
void InitializeTestData() override {
WriteTestAlbumTable(GetColumnFileDestination(), test_folder_1_path(),
test_folder_2_path());
}
PicasaDataProvider::DataType RequestedDataType() const override {
return PicasaDataProvider::LIST_OF_ALBUMS_AND_FOLDERS_DATA;
}
void VerifyRefreshResults(bool parse_success) override {
ASSERT_TRUE(parse_success);
VerifyTestAlbumTable(
data_provider(), test_folder_1_path(), test_folder_2_path());
TestDone();
}
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderGetListTest, GetListTest) {
RunTest();
}
class PicasaDataProviderGetAlbumsImagesTest : public PicasaDataProviderTest {
protected:
void InitializeTestData() override {
WriteTestAlbumTable(GetColumnFileDestination(), test_folder_1_path(),
test_folder_2_path());
WriteTestAlbumsImagesIndex(test_folder_1_path(), test_folder_2_path());
}
PicasaDataProvider::DataType RequestedDataType() const override {
return PicasaDataProvider::ALBUMS_IMAGES_DATA;
}
void VerifyRefreshResults(bool parse_success) override {
ASSERT_TRUE(parse_success);
VerifyTestAlbumTable(
data_provider(), test_folder_1_path(), test_folder_2_path());
VerifyTestAlbumsImagesIndex(
data_provider(), test_folder_1_path(), test_folder_2_path());
TestDone();
}
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderGetAlbumsImagesTest,
GetAlbumsImagesTest) {
RunTest();
}
class PicasaDataProviderMultipleMixedCallbacksTest
: public PicasaDataProviderTest {
public:
PicasaDataProviderMultipleMixedCallbacksTest()
: list_callbacks_called_(0), albums_images_callbacks_called_(0) {}
void InitializeTestData() override {
WriteTestAlbumTable(GetColumnFileDestination(), test_folder_1_path(),
test_folder_2_path());
WriteTestAlbumsImagesIndex(test_folder_1_path(), test_folder_2_path());
}
PicasaDataProvider::DataType RequestedDataType() const override {
return PicasaDataProvider::ALBUMS_IMAGES_DATA;
}
protected:
virtual void ListCallback(int expected_list_callbacks_called,
bool parse_success) {
ASSERT_TRUE(parse_success);
ASSERT_EQ(expected_list_callbacks_called, ++list_callbacks_called_);
VerifyTestAlbumTable(
data_provider(), test_folder_1_path(), test_folder_2_path());
CheckTestDone();
}
virtual void AlbumsImagesCallback(int expected_albums_images_callbacks_called,
bool parse_success) {
ASSERT_TRUE(parse_success);
ASSERT_EQ(expected_albums_images_callbacks_called,
++albums_images_callbacks_called_);
VerifyTestAlbumsImagesIndex(
data_provider(), test_folder_1_path(), test_folder_2_path());
CheckTestDone();
}
private:
void CheckTestDone() {
ASSERT_LE(list_callbacks_called_, 2);
ASSERT_LE(albums_images_callbacks_called_, 2);
if (list_callbacks_called_ == 2 && albums_images_callbacks_called_ == 2)
TestDone();
}
void StartTestOnMediaTaskRunner() override {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
data_provider()->RefreshData(
PicasaDataProvider::LIST_OF_ALBUMS_AND_FOLDERS_DATA,
base::Bind(&PicasaDataProviderMultipleMixedCallbacksTest::ListCallback,
base::Unretained(this),
1));
data_provider()->RefreshData(
PicasaDataProvider::ALBUMS_IMAGES_DATA,
base::Bind(
&PicasaDataProviderMultipleMixedCallbacksTest::AlbumsImagesCallback,
base::Unretained(this),
1));
data_provider()->RefreshData(
PicasaDataProvider::LIST_OF_ALBUMS_AND_FOLDERS_DATA,
base::Bind(&PicasaDataProviderMultipleMixedCallbacksTest::ListCallback,
base::Unretained(this),
2));
data_provider()->RefreshData(
PicasaDataProvider::ALBUMS_IMAGES_DATA,
base::Bind(
&PicasaDataProviderMultipleMixedCallbacksTest::AlbumsImagesCallback,
base::Unretained(this),
2));
}
int list_callbacks_called_;
int albums_images_callbacks_called_;
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderMultipleMixedCallbacksTest,
MultipleMixedCallbacks) {
RunTest();
}
class PicasaDataProviderFileWatcherInvalidateTest
: public PicasaDataProviderGetListTest {
protected:
virtual void ListCallback(bool parse_success) {
ASSERT_FALSE(parse_success);
data_provider()->EnsureFileWatchStartedForTesting(
base::Bind(&PicasaDataProviderFileWatcherInvalidateTest::
OnPicasaTempDirWatchStarted,
base::Unretained(this)));
}
void OnPicasaTempDirWatchStarted(bool file_watch_successful) {
ASSERT_TRUE(file_watch_successful);
// Validate the list after the file move triggers an invalidate.
data_provider()->SetInvalidateCallback(base::Bind(
&PicasaDataProvider::RefreshData,
base::Unretained(data_provider()),
RequestedDataType(),
base::Bind(
&PicasaDataProviderFileWatcherInvalidateTest::VerifyRefreshResults,
base::Unretained(this))));
data_provider()->MoveTempFilesToDatabase();
}
base::FilePath GetColumnFileDestination() const override {
return GetTempDirPath();
}
private:
void StartTestOnMediaTaskRunner() override {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
// Refresh before moving album table to database dir, guaranteeing failure.
data_provider()->RefreshData(
RequestedDataType(),
base::Bind(
&PicasaDataProviderFileWatcherInvalidateTest::ListCallback,
base::Unretained(this)));
}
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderFileWatcherInvalidateTest,
FileWatcherInvalidateTest) {
RunTest();
}
class PicasaDataProviderInvalidateInflightTableReaderTest
: public PicasaDataProviderGetListTest {
protected:
// Don't write the database files until later.
void InitializeTestData() override {}
private:
void StartTestOnMediaTaskRunner() override {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
// Refresh before the database files have been written.
// This is guaranteed to fail to read the album table.
data_provider()->RefreshData(
RequestedDataType(),
base::Bind(&PicasaDataProviderInvalidateInflightTableReaderTest::
VerifyRefreshResults,
base::Unretained(this)));
// Now write the album table and invalidate the inflight table reader.
PicasaDataProviderGetListTest::InitializeTestData();
data_provider()->InvalidateData();
// VerifyRefreshResults callback should receive correct results now.
}
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderInvalidateInflightTableReaderTest,
InvalidateInflightTableReaderTest) {
RunTest();
}
class PicasaDataProviderInvalidateInflightAlbumsIndexerTest
: public PicasaDataProviderGetAlbumsImagesTest {
protected:
virtual void ListCallback(bool parse_success) {
ASSERT_TRUE(parse_success);
// Empty the album maps to guarantee that the first utility process will
// fail to get the correct albums-images index.
data_provider()->SetAlbumMapsForTesting(AlbumMap(), AlbumMap());
data_provider()->RefreshData(
PicasaDataProvider::ALBUMS_IMAGES_DATA,
base::Bind(&PicasaDataProviderInvalidateInflightAlbumsIndexerTest::
VerifyRefreshResults,
base::Unretained(this)));
// Now invalidate all the data. The album maps will be re-read.
data_provider()->InvalidateData();
// VerifyRefreshResults callback should receive correct results now.
}
private:
void StartTestOnMediaTaskRunner() override {
DCHECK(MediaFileSystemBackend::CurrentlyOnMediaTaskRunnerThread());
data_provider()->RefreshData(
PicasaDataProvider::LIST_OF_ALBUMS_AND_FOLDERS_DATA,
base::Bind(&PicasaDataProviderInvalidateInflightAlbumsIndexerTest::
ListCallback,
base::Unretained(this)));
}
};
IN_PROC_BROWSER_TEST_F(PicasaDataProviderInvalidateInflightAlbumsIndexerTest,
InvalidateInflightAlbumsIndexerTest) {
RunTest();
}
} // namespace picasa
|