1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/policy/device_status_collector.h"
#include "base/message_loop.h"
#include "base/time.h"
#include "chrome/browser/idle.h"
#include "chrome/browser/chromeos/cros_settings.h"
#include "chrome/browser/chromeos/cros_settings_names.h"
#include "chrome/browser/chromeos/cros_settings_provider.h"
#include "chrome/browser/chromeos/stub_cros_settings_provider.h"
#include "chrome/browser/chromeos/system/mock_statistics_provider.h"
#include "chrome/browser/policy/proto/device_management_backend.pb.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/test/base/testing_pref_service.h"
#include "content/test/test_browser_thread.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::TimeDelta;
using base::Time;
namespace em = enterprise_management;
namespace {
const int64 kMillisecondsPerDay = Time::kMicrosecondsPerDay / 1000;
class TestingDeviceStatusCollector : public policy::DeviceStatusCollector {
public:
TestingDeviceStatusCollector(
PrefService* local_state,
chromeos::system::StatisticsProvider* provider)
: policy::DeviceStatusCollector(local_state, provider),
local_state_(local_state) {
// Set the baseline time to a fixed value (1 AM) to prevent test flakiness
// due to a single activity period spanning two days.
SetBaselineTime(Time::Now().LocalMidnight() + TimeDelta::FromHours(1));
}
void Simulate(IdleState* states, int len) {
for (int i = 0; i < len; i++)
IdleStateCallback(states[i]);
}
void set_max_stored_past_activity_days(unsigned int value) {
max_stored_past_activity_days_ = value;
}
void set_max_stored_future_activity_days(unsigned int value) {
max_stored_future_activity_days_ = value;
}
// Reset the baseline time.
void SetBaselineTime(Time time) {
baseline_time_ = time;
baseline_offset_periods_ = 0;
}
protected:
virtual void CheckIdleState() OVERRIDE {
// This should never be called in testing, as it results in a dbus call.
NOTREACHED();
}
// Each time this is called, returns a time that is a fixed increment
// later than the previous time.
virtual Time GetCurrentTime() OVERRIDE {
int poll_interval = policy::DeviceStatusCollector::kPollIntervalSeconds;
return baseline_time_ +
TimeDelta::FromSeconds(poll_interval * baseline_offset_periods_++);
}
private:
PrefService* local_state_;
// Baseline time for the fake times returned from GetCurrentTime().
Time baseline_time_;
// The number of simulated periods since the baseline time.
int baseline_offset_periods_;
};
// Return the total number of active milliseconds contained in a device
// status report.
int64 GetActiveMilliseconds(em::DeviceStatusReportRequest& status) {
int64 active_milliseconds = 0;
for (int i = 0; i < status.active_period_size(); i++) {
active_milliseconds += status.active_period(i).active_duration();
}
return active_milliseconds;
}
} // namespace
namespace policy {
using ::testing::_;
using ::testing::NotNull;
using ::testing::Return;
using ::testing::SetArgPointee;
class DeviceStatusCollectorTest : public testing::Test {
public:
DeviceStatusCollectorTest()
: message_loop_(MessageLoop::TYPE_UI),
ui_thread_(content::BrowserThread::UI, &message_loop_),
file_thread_(content::BrowserThread::FILE, &message_loop_),
status_collector_(&prefs_, &statistics_provider_) {
DeviceStatusCollector::RegisterPrefs(&prefs_);
EXPECT_CALL(statistics_provider_, GetMachineStatistic(_, NotNull()))
.WillRepeatedly(Return(false));
cros_settings_ = chromeos::CrosSettings::Get();
// Remove the real DeviceSettingsProvider and replace it with a stub.
device_settings_provider_ =
cros_settings_->GetProvider(chromeos::kReportDeviceVersionInfo);
EXPECT_TRUE(device_settings_provider_ != NULL);
EXPECT_TRUE(
cros_settings_->RemoveSettingsProvider(device_settings_provider_));
cros_settings_->AddSettingsProvider(&stub_settings_provider_);
}
~DeviceStatusCollectorTest() {
// Restore the real DeviceSettingsProvider.
EXPECT_TRUE(
cros_settings_->RemoveSettingsProvider(&stub_settings_provider_));
cros_settings_->AddSettingsProvider(device_settings_provider_);
}
protected:
// Convenience method.
int64 ActivePeriodMilliseconds() {
return policy::DeviceStatusCollector::kPollIntervalSeconds * 1000;
}
MessageLoop message_loop_;
content::TestBrowserThread ui_thread_;
content::TestBrowserThread file_thread_;
TestingPrefService prefs_;
chromeos::system::MockStatisticsProvider statistics_provider_;
TestingDeviceStatusCollector status_collector_;
em::DeviceStatusReportRequest status_;
chromeos::CrosSettings* cros_settings_;
chromeos::CrosSettingsProvider* device_settings_provider_;
chromeos::StubCrosSettingsProvider stub_settings_provider_;
};
TEST_F(DeviceStatusCollectorTest, AllIdle) {
IdleState test_states[] = {
IDLE_STATE_IDLE,
IDLE_STATE_IDLE,
IDLE_STATE_IDLE
};
cros_settings_->SetBoolean(chromeos::kReportDeviceActivityTimes, true);
// Test reporting with no data.
status_collector_.GetStatus(&status_);
EXPECT_EQ(0, status_.active_period_size());
EXPECT_EQ(0, GetActiveMilliseconds(status_));
// Test reporting with a single idle sample.
status_collector_.Simulate(test_states, 1);
status_collector_.GetStatus(&status_);
EXPECT_EQ(0, status_.active_period_size());
EXPECT_EQ(0, GetActiveMilliseconds(status_));
// Test reporting with multiple consecutive idle samples.
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
status_collector_.GetStatus(&status_);
EXPECT_EQ(0, status_.active_period_size());
EXPECT_EQ(0, GetActiveMilliseconds(status_));
}
TEST_F(DeviceStatusCollectorTest, AllActive) {
IdleState test_states[] = {
IDLE_STATE_ACTIVE,
IDLE_STATE_ACTIVE,
IDLE_STATE_ACTIVE
};
cros_settings_->SetBoolean(chromeos::kReportDeviceActivityTimes, true);
// Test a single active sample.
status_collector_.Simulate(test_states, 1);
status_collector_.GetStatus(&status_);
EXPECT_EQ(1, status_.active_period_size());
EXPECT_EQ(1 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
status_.clear_active_period(); // Clear the result protobuf.
// Test multiple consecutive active samples.
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
status_collector_.GetStatus(&status_);
EXPECT_EQ(1, status_.active_period_size());
EXPECT_EQ(3 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
}
TEST_F(DeviceStatusCollectorTest, MixedStates) {
IdleState test_states[] = {
IDLE_STATE_ACTIVE,
IDLE_STATE_IDLE,
IDLE_STATE_ACTIVE,
IDLE_STATE_ACTIVE,
IDLE_STATE_IDLE,
IDLE_STATE_IDLE,
IDLE_STATE_ACTIVE
};
cros_settings_->SetBoolean(chromeos::kReportDeviceActivityTimes, true);
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
status_collector_.GetStatus(&status_);
EXPECT_EQ(4 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
}
TEST_F(DeviceStatusCollectorTest, StateKeptInPref) {
IdleState test_states[] = {
IDLE_STATE_ACTIVE,
IDLE_STATE_IDLE,
IDLE_STATE_ACTIVE,
IDLE_STATE_ACTIVE,
IDLE_STATE_IDLE,
IDLE_STATE_IDLE
};
cros_settings_->SetBoolean(chromeos::kReportDeviceActivityTimes, true);
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
// Process the list a second time with a different collector.
// It should be able to count the active periods found by the first
// collector, because the results are stored in a pref.
TestingDeviceStatusCollector second_collector(&prefs_,
&statistics_provider_);
second_collector.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
second_collector.GetStatus(&status_);
EXPECT_EQ(6 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
}
TEST_F(DeviceStatusCollectorTest, Times) {
IdleState test_states[] = {
IDLE_STATE_ACTIVE,
IDLE_STATE_IDLE,
IDLE_STATE_ACTIVE,
IDLE_STATE_ACTIVE,
IDLE_STATE_IDLE,
IDLE_STATE_IDLE
};
cros_settings_->SetBoolean(chromeos::kReportDeviceActivityTimes, true);
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
status_collector_.GetStatus(&status_);
EXPECT_EQ(3 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
}
TEST_F(DeviceStatusCollectorTest, MaxStoredPeriods) {
IdleState test_states[] = {
IDLE_STATE_ACTIVE,
IDLE_STATE_IDLE
};
unsigned int max_days = 10;
cros_settings_->SetBoolean(chromeos::kReportDeviceActivityTimes, true);
status_collector_.set_max_stored_past_activity_days(max_days - 1);
status_collector_.set_max_stored_future_activity_days(1);
Time baseline = Time::Now().LocalMidnight();
// Simulate 12 active periods.
for (int i = 0; i < static_cast<int>(max_days) + 2; i++) {
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
// Advance the simulated clock by a day.
baseline += TimeDelta::FromDays(1);
status_collector_.SetBaselineTime(baseline);
}
// Check that we don't exceed the max number of periods.
status_collector_.GetStatus(&status_);
EXPECT_EQ(static_cast<int>(max_days), status_.active_period_size());
// Simulate some future times.
for (int i = 0; i < static_cast<int>(max_days) + 2; i++) {
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
// Advance the simulated clock by a day.
baseline += TimeDelta::FromDays(1);
status_collector_.SetBaselineTime(baseline);
}
// Set the clock back so the previous simulated times are in the future.
baseline -= TimeDelta::FromDays(20);
status_collector_.SetBaselineTime(baseline);
// Collect one more data point to trigger pruning.
status_collector_.Simulate(test_states, 1);
// Check that we don't exceed the max number of periods.
status_.clear_active_period();
status_collector_.GetStatus(&status_);
EXPECT_LT(status_.active_period_size(), static_cast<int>(max_days));
}
TEST_F(DeviceStatusCollectorTest, ActivityTimesDisabledByDefault) {
// If the pref for collecting device activity times isn't explicitly turned
// on, no data on activity times should be reported.
IdleState test_states[] = {
IDLE_STATE_ACTIVE,
IDLE_STATE_ACTIVE,
IDLE_STATE_ACTIVE
};
status_collector_.Simulate(test_states,
sizeof(test_states) / sizeof(IdleState));
status_collector_.GetStatus(&status_);
EXPECT_EQ(0, status_.active_period_size());
EXPECT_EQ(0, GetActiveMilliseconds(status_));
}
TEST_F(DeviceStatusCollectorTest, ActivityCrossingMidnight) {
IdleState test_states[] = {
IDLE_STATE_ACTIVE
};
cros_settings_->SetBoolean(chromeos::kReportDeviceActivityTimes, true);
// Set the baseline time to 10 seconds after midnight.
status_collector_.SetBaselineTime(
Time::Now().LocalMidnight() + TimeDelta::FromSeconds(10));
status_collector_.Simulate(test_states, 1);
status_collector_.GetStatus(&status_);
ASSERT_EQ(2, status_.active_period_size());
em::ActiveTimePeriod period0 = status_.active_period(0);
em::ActiveTimePeriod period1 = status_.active_period(1);
EXPECT_EQ(ActivePeriodMilliseconds() - 10000, period0.active_duration());
EXPECT_EQ(10000, period1.active_duration());
em::TimePeriod time_period0 = period0.time_period();
em::TimePeriod time_period1 = period1.time_period();
EXPECT_EQ(time_period0.end_timestamp(), time_period1.start_timestamp());
// Ensure that the start and end times for the period are a day apart.
EXPECT_EQ(time_period0.end_timestamp() - time_period0.start_timestamp(),
kMillisecondsPerDay);
EXPECT_EQ(time_period1.end_timestamp() - time_period1.start_timestamp(),
kMillisecondsPerDay);
}
TEST_F(DeviceStatusCollectorTest, DevSwitchBootMode) {
// Test that boot mode data is not reported if the pref is not turned on.
status_collector_.GetStatus(&status_);
EXPECT_EQ(false, status_.has_boot_mode());
EXPECT_CALL(statistics_provider_,
GetMachineStatistic("devsw_boot", NotNull()))
.WillRepeatedly(DoAll(SetArgPointee<1>("0"), Return(true)));
EXPECT_EQ(false, status_.has_boot_mode());
// Turn the pref on, and check that the status is reported iff the
// statistics provider returns valid data.
cros_settings_->SetBoolean(chromeos::kReportDeviceBootMode, true);
EXPECT_CALL(statistics_provider_,
GetMachineStatistic("devsw_boot", NotNull()))
.WillOnce(DoAll(SetArgPointee<1>("(error)"), Return(true)));
status_collector_.GetStatus(&status_);
EXPECT_EQ(false, status_.has_boot_mode());
EXPECT_CALL(statistics_provider_,
GetMachineStatistic("devsw_boot", NotNull()))
.WillOnce(DoAll(SetArgPointee<1>(" "), Return(true)));
status_collector_.GetStatus(&status_);
EXPECT_EQ(false, status_.has_boot_mode());
EXPECT_CALL(statistics_provider_,
GetMachineStatistic("devsw_boot", NotNull()))
.WillOnce(DoAll(SetArgPointee<1>("0"), Return(true)));
status_collector_.GetStatus(&status_);
EXPECT_EQ("Verified", status_.boot_mode());
EXPECT_CALL(statistics_provider_,
GetMachineStatistic("devsw_boot", NotNull()))
.WillOnce(DoAll(SetArgPointee<1>("1"), Return(true)));
status_collector_.GetStatus(&status_);
EXPECT_EQ("Dev", status_.boot_mode());
}
TEST_F(DeviceStatusCollectorTest, VersionInfo) {
// When the pref to collect this data is not enabled, expect that none of
// the fields are present in the protobuf.
status_collector_.GetStatus(&status_);
EXPECT_EQ(false, status_.has_browser_version());
EXPECT_EQ(false, status_.has_os_version());
EXPECT_EQ(false, status_.has_firmware_version());
cros_settings_->SetBoolean(chromeos::kReportDeviceVersionInfo, true);
status_collector_.GetStatus(&status_);
EXPECT_EQ(true, status_.has_browser_version());
EXPECT_EQ(true, status_.has_os_version());
EXPECT_EQ(true, status_.has_firmware_version());
// Check that the browser version is not empty. OS version & firmware
// don't have any reasonable values inside the unit test, so those
// aren't checked.
EXPECT_NE("", status_.browser_version());
}
} // namespace policy
|