1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
|
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/values.h"
#include "chrome/browser/prefs/overlay_persistent_pref_store.h"
#include "chrome/browser/prefs/testing_pref_store.h"
#include "chrome/common/pref_store_observer_mock.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::testing::Mock;
using ::testing::StrEq;
const char key[] = "test.key";
class OverlayPersistentPrefStoreTest : public testing::Test {
public:
OverlayPersistentPrefStoreTest()
: underlay_(new TestingPrefStore()),
overlay_(new OverlayPersistentPrefStore(underlay_.get())) {
}
scoped_refptr<TestingPrefStore> underlay_;
scoped_refptr<OverlayPersistentPrefStore> overlay_;
};
TEST_F(OverlayPersistentPrefStoreTest, Observer) {
PrefStoreObserverMock obs;
overlay_->AddObserver(&obs);
// Check that underlay first value is reported.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(1);
underlay_->SetValue(key, Value::CreateIntegerValue(42));
Mock::VerifyAndClearExpectations(&obs);
// Check that underlay overwriting is reported.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(1);
underlay_->SetValue(key, Value::CreateIntegerValue(43));
Mock::VerifyAndClearExpectations(&obs);
// Check that overwriting change in overlay is reported.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(1);
overlay_->SetValue(key, Value::CreateIntegerValue(44));
Mock::VerifyAndClearExpectations(&obs);
// Check that hidden underlay change is not reported.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(0);
underlay_->SetValue(key, Value::CreateIntegerValue(45));
Mock::VerifyAndClearExpectations(&obs);
// Check that overlay remove is reported.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(1);
overlay_->RemoveValue(key);
Mock::VerifyAndClearExpectations(&obs);
// Check that underlay remove is reported.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(1);
underlay_->RemoveValue(key);
Mock::VerifyAndClearExpectations(&obs);
// Check respecting of silence.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(0);
overlay_->SetValueSilently(key, Value::CreateIntegerValue(46));
Mock::VerifyAndClearExpectations(&obs);
overlay_->RemoveObserver(&obs);
// Check successful unsubscription.
EXPECT_CALL(obs, OnPrefValueChanged(StrEq(key))).Times(0);
underlay_->SetValue(key, Value::CreateIntegerValue(47));
overlay_->SetValue(key, Value::CreateIntegerValue(48));
Mock::VerifyAndClearExpectations(&obs);
}
TEST_F(OverlayPersistentPrefStoreTest, GetAndSet) {
const Value* value = NULL;
int i = -1;
EXPECT_EQ(PrefStore::READ_NO_VALUE, overlay_->GetValue(key, &value));
EXPECT_EQ(PrefStore::READ_NO_VALUE, underlay_->GetValue(key, &value));
underlay_->SetValue(key, Value::CreateIntegerValue(42));
// Value shines through:
EXPECT_EQ(PrefStore::READ_OK, overlay_->GetValue(key, &value));
ASSERT_TRUE(value);
EXPECT_TRUE(value->GetAsInteger(&i));
EXPECT_EQ(42, i);
EXPECT_EQ(PrefStore::READ_OK, underlay_->GetValue(key, &value));
ASSERT_TRUE(value);
EXPECT_TRUE(value->GetAsInteger(&i));
EXPECT_EQ(42, i);
overlay_->SetValue(key, Value::CreateIntegerValue(43));
EXPECT_EQ(PrefStore::READ_OK, overlay_->GetValue(key, &value));
ASSERT_TRUE(value);
EXPECT_TRUE(value->GetAsInteger(&i));
EXPECT_EQ(43, i);
EXPECT_EQ(PrefStore::READ_OK, underlay_->GetValue(key, &value));
ASSERT_TRUE(value);
EXPECT_TRUE(value->GetAsInteger(&i));
EXPECT_EQ(42, i);
overlay_->RemoveValue(key);
// Value shines through:
EXPECT_EQ(PrefStore::READ_OK, overlay_->GetValue(key, &value));
ASSERT_TRUE(value);
EXPECT_TRUE(value->GetAsInteger(&i));
EXPECT_EQ(42, i);
EXPECT_EQ(PrefStore::READ_OK, underlay_->GetValue(key, &value));
ASSERT_TRUE(value);
EXPECT_TRUE(value->GetAsInteger(&i));
EXPECT_EQ(42, i);
}
// Check that GetMutableValue does not return the dictionary of the underlay.
TEST_F(OverlayPersistentPrefStoreTest, ModifyDictionaries) {
underlay_->SetValue(key, new DictionaryValue);
Value* modify = NULL;
EXPECT_EQ(PrefStore::READ_OK, overlay_->GetMutableValue(key, &modify));
ASSERT_TRUE(modify);
ASSERT_TRUE(modify->GetType() == Value::TYPE_DICTIONARY);
static_cast<DictionaryValue*>(modify)->SetInteger(key, 42);
Value* original_in_underlay = NULL;
EXPECT_EQ(PrefStore::READ_OK,
underlay_->GetMutableValue(key, &original_in_underlay));
ASSERT_TRUE(original_in_underlay);
ASSERT_TRUE(original_in_underlay->GetType() == Value::TYPE_DICTIONARY);
EXPECT_TRUE(static_cast<DictionaryValue*>(original_in_underlay)->empty());
Value* modified = NULL;
EXPECT_EQ(PrefStore::READ_OK, overlay_->GetMutableValue(key, &modified));
ASSERT_TRUE(modified);
ASSERT_TRUE(modified->GetType() == Value::TYPE_DICTIONARY);
EXPECT_TRUE(Value::Equals(modify, static_cast<DictionaryValue*>(modified)));
}
|
