1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/json/json_file_value_serializer.h"
#include "base/path_service.h"
#include "base/test/test_file_util.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/browser_window_state.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/test_switches.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/base/ui_test_utils.h"
#include "ui/gfx/geometry/rect.h"
typedef InProcessBrowserTest PreservedWindowPlacement;
IN_PROC_BROWSER_TEST_F(PreservedWindowPlacement, PRE_Test) {
browser()->window()->SetBounds(gfx::Rect(20, 30, 400, 500));
}
// Fails on Chrome OS as the browser thinks it is restarting after a crash, see
// http://crbug.com/168044
#if defined(OS_CHROMEOS)
#define MAYBE_Test DISABLED_Test
#else
#define MAYBE_Test Test
#endif
IN_PROC_BROWSER_TEST_F(PreservedWindowPlacement, MAYBE_Test) {
#if defined(OS_WIN) && defined(USE_ASH)
// Disable this test in Metro+Ash for now (http://crbug.com/262796).
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshBrowserTests))
return;
#endif
gfx::Rect bounds = browser()->window()->GetBounds();
gfx::Rect expected_bounds(gfx::Rect(20, 30, 400, 500));
ASSERT_EQ(expected_bounds.ToString(), bounds.ToString());
}
class PreferenceServiceTest : public InProcessBrowserTest {
public:
bool SetUpUserDataDirectory() override {
base::FilePath user_data_directory;
PathService::Get(chrome::DIR_USER_DATA, &user_data_directory);
original_pref_file_ = ui_test_utils::GetTestFilePath(
base::FilePath()
.AppendASCII("profiles")
.AppendASCII("window_placement")
.AppendASCII("Default"),
base::FilePath().Append(chrome::kPreferencesFilename));
tmp_pref_file_ =
user_data_directory.AppendASCII(TestingProfile::kTestUserProfileDir);
EXPECT_TRUE(base::CreateDirectory(tmp_pref_file_));
tmp_pref_file_ = tmp_pref_file_.Append(chrome::kPreferencesFilename);
EXPECT_TRUE(base::PathExists(original_pref_file_));
EXPECT_TRUE(base::CopyFile(original_pref_file_, tmp_pref_file_));
#if defined(OS_WIN)
// Make the copy writable. On POSIX we assume the umask allows files
// we create to be writable.
EXPECT_TRUE(::SetFileAttributesW(tmp_pref_file_.value().c_str(),
FILE_ATTRIBUTE_NORMAL));
#endif
return true;
}
protected:
base::FilePath original_pref_file_;
base::FilePath tmp_pref_file_;
};
#if defined(OS_WIN) || defined(OS_MACOSX)
// This test verifies that the window position from the prefs file is restored
// when the app restores. This doesn't really make sense on Linux, where
// the window manager might fight with you over positioning. However, we
// might be able to make this work on buildbots.
// TODO(port): revisit this.
IN_PROC_BROWSER_TEST_F(PreferenceServiceTest, Test) {
#if defined(OS_WIN) && defined(USE_ASH)
// Disable this test in Metro+Ash for now (http://crbug.com/262796).
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshBrowserTests))
return;
#endif
// The window should open with the new reference profile, with window
// placement values stored in the user data directory.
JSONFileValueDeserializer deserializer(original_pref_file_);
scoped_ptr<base::Value> root = deserializer.Deserialize(NULL, NULL);
ASSERT_TRUE(root.get());
ASSERT_TRUE(root->IsType(base::Value::TYPE_DICTIONARY));
base::DictionaryValue* root_dict =
static_cast<base::DictionaryValue*>(root.get());
// Retrieve the screen rect for the launched window
gfx::Rect bounds = browser()->window()->GetRestoredBounds();
// Retrieve the expected rect values from "Preferences"
int bottom = 0;
std::string kBrowserWindowPlacement(prefs::kBrowserWindowPlacement);
EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".bottom",
&bottom));
EXPECT_EQ(bottom, bounds.y() + bounds.height());
int top = 0;
EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".top",
&top));
EXPECT_EQ(top, bounds.y());
int left = 0;
EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".left",
&left));
EXPECT_EQ(left, bounds.x());
int right = 0;
EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".right",
&right));
EXPECT_EQ(right, bounds.x() + bounds.width());
// Find if launched window is maximized.
bool is_window_maximized = browser()->window()->IsMaximized();
bool is_maximized = false;
EXPECT_TRUE(root_dict->GetBoolean(kBrowserWindowPlacement + ".maximized",
&is_maximized));
EXPECT_EQ(is_maximized, is_window_maximized);
}
#endif
|
