1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_pref_service_syncable.h"
#include "components/pref_registry/pref_registry_syncable.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#if defined(OS_MACOSX)
#include "chrome/browser/ui/cocoa/window_restore_utils.h"
#endif
// Unit tests for SessionStartupPref.
class SessionStartupPrefTest : public testing::Test {
public:
virtual void SetUp() {
pref_service_.reset(new TestingPrefServiceSyncable);
SessionStartupPref::RegisterProfilePrefs(registry());
registry()->RegisterBooleanPref(
prefs::kHomePageIsNewTabPage,
true,
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
// Make the tests independent of the Mac startup pref migration (see
// SessionStartupPref::MigrateMacDefaultPrefIfNecessary).
registry()->RegisterStringPref(
prefs::kProfileCreatedByVersion,
"22.0.0.0",
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
}
bool IsUseLastOpenDefault() {
// On ChromeOS, the default SessionStartupPref is LAST.
#if defined(OS_CHROMEOS)
return true;
#else
return false;
#endif
}
user_prefs::PrefRegistrySyncable* registry() {
return pref_service_->registry();
}
scoped_ptr<TestingPrefServiceSyncable> pref_service_;
};
TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
base::ListValue* url_pref_list = new base::ListValue;
url_pref_list->Set(0, base::Value::CreateStringValue("google.com"));
url_pref_list->Set(1, base::Value::CreateStringValue("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list);
SessionStartupPref result =
SessionStartupPref::GetStartupPref(pref_service_.get());
EXPECT_EQ(2u, result.urls.size());
EXPECT_EQ("http://google.com/", result.urls[0].spec());
EXPECT_EQ("http://chromium.org/", result.urls[1].spec());
}
TEST_F(SessionStartupPrefTest, URLListManagedOverridesUser) {
base::ListValue* url_pref_list1 = new base::ListValue;
url_pref_list1->Set(0, base::Value::CreateStringValue("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list1);
base::ListValue* url_pref_list2 = new base::ListValue;
url_pref_list2->Set(0, base::Value::CreateStringValue("chromium.org"));
url_pref_list2->Set(1, base::Value::CreateStringValue("chromium.org"));
url_pref_list2->Set(2, base::Value::CreateStringValue("chromium.org"));
pref_service_->SetManagedPref(prefs::kURLsToRestoreOnStartup,
url_pref_list2);
SessionStartupPref result =
SessionStartupPref::GetStartupPref(pref_service_.get());
EXPECT_EQ(3u, result.urls.size());
SessionStartupPref override_test =
SessionStartupPref(SessionStartupPref::URLS);
override_test.urls.push_back(GURL("dev.chromium.org"));
SessionStartupPref::SetStartupPref(pref_service_.get(), override_test);
result = SessionStartupPref::GetStartupPref(pref_service_.get());
EXPECT_EQ(3u, result.urls.size());
}
// Checks to make sure that if the user had previously not selected anything
// (so that, in effect, the default value "Open the homepage" was selected),
// their preferences are migrated on upgrade to m19.
TEST_F(SessionStartupPrefTest, DefaultMigration) {
registry()->RegisterStringPref(
prefs::kHomePage,
"http://google.com/",
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
pref_service_->SetString(prefs::kHomePage, "http://chromium.org/");
pref_service_->SetBoolean(prefs::kHomePageIsNewTabPage, false);
EXPECT_FALSE(pref_service_->HasPrefPath(prefs::kRestoreOnStartup));
SessionStartupPref pref = SessionStartupPref::GetStartupPref(
pref_service_.get());
if (IsUseLastOpenDefault()) {
EXPECT_EQ(SessionStartupPref::LAST, pref.type);
EXPECT_EQ(0U, pref.urls.size());
} else {
EXPECT_EQ(SessionStartupPref::URLS, pref.type);
EXPECT_EQ(1U, pref.urls.size());
EXPECT_EQ(GURL("http://chromium.org/"), pref.urls[0]);
}
}
// Checks to make sure that if the user had previously not selected anything
// (so that, in effect, the default value "Open the homepage" was selected),
// and the NTP is being used for the homepage, their preferences are migrated
// to "Open the New Tab Page" on upgrade to M19.
TEST_F(SessionStartupPrefTest, DefaultMigrationHomepageIsNTP) {
registry()->RegisterStringPref(
prefs::kHomePage,
"http://google.com/",
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
pref_service_->SetString(prefs::kHomePage, "http://chromium.org/");
pref_service_->SetBoolean(prefs::kHomePageIsNewTabPage, true);
EXPECT_FALSE(pref_service_->HasPrefPath(prefs::kRestoreOnStartup));
SessionStartupPref pref = SessionStartupPref::GetStartupPref(
pref_service_.get());
if (IsUseLastOpenDefault())
EXPECT_EQ(SessionStartupPref::LAST, pref.type);
else
EXPECT_EQ(SessionStartupPref::DEFAULT, pref.type);
// The "URLs to restore on startup" shouldn't get migrated.
EXPECT_EQ(0U, pref.urls.size());
}
// Checks to make sure that if the user had previously selected "Open the
// "homepage", their preferences are migrated on upgrade to M19.
TEST_F(SessionStartupPrefTest, HomePageMigration) {
registry()->RegisterStringPref(
prefs::kHomePage,
"http://google.com/",
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
// By design, it's impossible to set the 'restore on startup' pref to 0
// ("open the homepage") using SessionStartupPref::SetStartupPref(), so set it
// using the pref service directly.
pref_service_->SetInteger(prefs::kRestoreOnStartup, /*kPrefValueHomePage*/ 0);
pref_service_->SetString(prefs::kHomePage, "http://chromium.org/");
pref_service_->SetBoolean(prefs::kHomePageIsNewTabPage, false);
SessionStartupPref pref = SessionStartupPref::GetStartupPref(
pref_service_.get());
EXPECT_EQ(SessionStartupPref::URLS, pref.type);
EXPECT_EQ(1U, pref.urls.size());
EXPECT_EQ(GURL("http://chromium.org/"), pref.urls[0]);
}
// Checks to make sure that if the user had previously selected "Open the
// "homepage", and the NTP is being used for the homepage, their preferences
// are migrated on upgrade to M19.
TEST_F(SessionStartupPrefTest, HomePageMigrationHomepageIsNTP) {
registry()->RegisterStringPref(
prefs::kHomePage,
"http://google.com/",
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
// By design, it's impossible to set the 'restore on startup' pref to 0
// ("open the homepage") using SessionStartupPref::SetStartupPref(), so set it
// using the pref service directly.
pref_service_->SetInteger(prefs::kRestoreOnStartup, /*kPrefValueHomePage*/ 0);
pref_service_->SetString(prefs::kHomePage, "http://chromium.org/");
pref_service_->SetBoolean(prefs::kHomePageIsNewTabPage, true);
SessionStartupPref pref = SessionStartupPref::GetStartupPref(
pref_service_.get());
EXPECT_EQ(SessionStartupPref::DEFAULT, pref.type);
}
#if defined(OS_MACOSX)
// See SessionStartupPref::MigrateMacDefaultPrefIfNecessary.
TEST_F(SessionStartupPrefTest, MacDefaultStartupPrefMigration) {
if (!restore_utils::IsWindowRestoreEnabled())
return;
// Use an old profile.
pref_service_->SetString(prefs::kProfileCreatedByVersion, "19.0.0.0");
ASSERT_TRUE(SessionStartupPref::TypeIsDefault(pref_service_.get()));
// Trigger the migration.
SessionStartupPref pref = SessionStartupPref::GetStartupPref(
pref_service_.get());
// The pref is now explicit.
EXPECT_EQ(SessionStartupPref::LAST, pref.type);
EXPECT_FALSE(SessionStartupPref::TypeIsDefault(pref_service_.get()));
}
#endif
|
