1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/message_loop.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_prefs.h"
#include "chrome/browser/extensions/extension_pref_value_map.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/prefs/scoped_user_pref_update.h"
#include "chrome/browser/protector/protected_prefs_watcher.h"
#include "chrome/browser/protector/protector_service_factory.h"
#include "chrome/browser/protector/protector_service.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
#include "content/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace protector {
namespace {
const char kBackupSignature[] = "backup._signature";
const char kNewHomePage[] = "http://example.com";
}
class ProtectedPrefsWatcherTest : public testing::Test {
public:
virtual void SetUp() OVERRIDE {
prefs_watcher_ =
ProtectorServiceFactory::GetForProfile(&profile_)->GetPrefsWatcher();
prefs_ = profile_.GetPrefs();
}
bool IsSignatureValid() {
return prefs_watcher_->IsSignatureValid();
}
bool HasBackup() {
return prefs_watcher_->HasBackup();
}
void RevalidateBackup() {
prefs_watcher_->ValidateBackup();
}
void ForceUpdateSignature() {
prefs_watcher_->UpdateBackupSignature();
}
protected:
ProtectedPrefsWatcher* prefs_watcher_;
TestingProfile profile_;
PrefService* prefs_;
};
TEST_F(ProtectedPrefsWatcherTest, ValidOnCleanProfile) {
EXPECT_TRUE(HasBackup());
EXPECT_TRUE(prefs_watcher_->is_backup_valid());
}
TEST_F(ProtectedPrefsWatcherTest, ValidAfterPrefChange) {
// Signature is still valid after a protected pref has been changed.
base::StringValue new_homepage(kNewHomePage);
EXPECT_NE(prefs_->GetString(prefs::kHomePage), kNewHomePage);
EXPECT_FALSE(new_homepage.Equals(
prefs_watcher_->GetBackupForPref(prefs::kHomePage)));
prefs_->SetString(prefs::kHomePage, kNewHomePage);
EXPECT_TRUE(HasBackup());
EXPECT_TRUE(prefs_watcher_->is_backup_valid());
EXPECT_EQ(prefs_->GetString(prefs::kHomePage), kNewHomePage);
// Backup is updated accordingly.
EXPECT_TRUE(new_homepage.Equals(
prefs_watcher_->GetBackupForPref(prefs::kHomePage)));
}
TEST_F(ProtectedPrefsWatcherTest, InvalidSignature) {
// Make backup invalid by changing one of its members directly.
prefs_->SetString("backup.homepage", kNewHomePage);
RevalidateBackup();
EXPECT_TRUE(HasBackup());
EXPECT_FALSE(prefs_watcher_->is_backup_valid());
// No backup values available.
EXPECT_FALSE(prefs_watcher_->GetBackupForPref(prefs::kHomePage));
// Now change the corresponding protected prefernce: backup should be signed
// again but still invalid.
prefs_->SetString(prefs::kHomePage, kNewHomePage);
EXPECT_TRUE(IsSignatureValid());
EXPECT_FALSE(prefs_watcher_->is_backup_valid());
EXPECT_FALSE(prefs_watcher_->GetBackupForPref(prefs::kHomePage));
}
TEST_F(ProtectedPrefsWatcherTest, ExtensionPrefChange) {
// Changes to extensions data (but not to extension IDs) do not update
// the backup and its signature.
MessageLoopForUI message_loop;
content::TestBrowserThread ui_thread(content::BrowserThread::UI,
&message_loop);
FilePath extensions_install_dir =
profile_.GetPath().AppendASCII(ExtensionService::kInstallDirectoryName);
scoped_ptr<ExtensionPrefValueMap> extension_pref_value_map_(
new ExtensionPrefValueMap);
scoped_ptr<ExtensionPrefs> extension_prefs(
new ExtensionPrefs(profile_.GetPrefs(),
extensions_install_dir,
extension_pref_value_map_.get()));
std::string sample_id = extension_misc::kWebStoreAppId;
extension_prefs->Init(false);
// Flip a pref value of an extension (this will actually add it to the list).
extension_prefs->SetAppNotificationDisabled(
sample_id, !extension_prefs->IsAppNotificationDisabled(sample_id));
// Backup is still valid.
EXPECT_TRUE(prefs_watcher_->is_backup_valid());
// Make signature invalid by changing it directly.
prefs_->SetString(kBackupSignature, "INVALID");
EXPECT_FALSE(IsSignatureValid());
// Flip another pref value of that extension.
extension_prefs->SetIsIncognitoEnabled(
sample_id, !extension_prefs->IsIncognitoEnabled(sample_id));
// No changes to the backup and signature.
EXPECT_FALSE(IsSignatureValid());
// Blacklisting the extension does update the backup and signature.
std::set<std::string> blacklist;
blacklist.insert(sample_id);
extension_prefs->UpdateBlacklist(blacklist);
EXPECT_TRUE(IsSignatureValid());
}
// Verify that version bigger than 1 is included in the signature.
TEST_F(ProtectedPrefsWatcherTest, VersionIsSigned) {
// Reset version to 1.
prefs_->ClearPref("backup._version");
// This should make the backup invalid.
EXPECT_FALSE(IsSignatureValid());
// "Migrate" the backup back to the latest version.
RevalidateBackup();
EXPECT_FALSE(prefs_watcher_->is_backup_valid());
EXPECT_EQ(ProtectedPrefsWatcher::kCurrentVersionNumber,
prefs_->GetInteger("backup._version"));
}
// Verify that backup for "pinned_tabs" is added during version 2 migration.
TEST_F(ProtectedPrefsWatcherTest, MigrationToVersion2) {
// Add a pinned tab.
{
ListPrefUpdate pinned_tabs_update(prefs_, prefs::kPinnedTabs);
base::ListValue* pinned_tabs = pinned_tabs_update.Get();
pinned_tabs->Clear();
base::DictionaryValue* tab = new base::DictionaryValue;
tab->SetString("url", "http://example.com/");
pinned_tabs->Append(tab);
}
EXPECT_TRUE(prefs_watcher_->is_backup_valid());
scoped_ptr<base::Value> pinned_tabs_copy(
prefs_->GetList(prefs::kPinnedTabs)->DeepCopy());
// Reset version to 1, remove "pinned_tabs" and overwrite the signature.
// Store the old signature (without "pinned_tabs").
prefs_->ClearPref("backup._version");
prefs_->ClearPref("backup.pinned_tabs");
ForceUpdateSignature();
EXPECT_TRUE(IsSignatureValid());
// This will migrate backup to the latest version.
RevalidateBackup();
// Now the backup should be valid and "pinned_tabs" is added back.
EXPECT_TRUE(prefs_watcher_->is_backup_valid());
EXPECT_TRUE(pinned_tabs_copy->Equals(prefs_->GetList("backup.pinned_tabs")));
EXPECT_TRUE(pinned_tabs_copy->Equals(prefs_->GetList(prefs::kPinnedTabs)));
EXPECT_FALSE(prefs_watcher_->DidPrefChange(prefs::kPinnedTabs));
EXPECT_EQ(ProtectedPrefsWatcher::kCurrentVersionNumber,
prefs_->GetInteger("backup._version"));
}
} // namespace protector
|
