1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include <string>
#include <vector>
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/run_loop.h"
#include "chrome/browser/safe_browsing/local_database_manager.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#include "url/gurl.h"
using content::TestBrowserThreadBundle;
namespace safe_browsing {
class SafeBrowsingDatabaseManagerTest : public PlatformTest {
public:
struct HostListPair {
std::string host;
std::string list_type;
};
bool RunSBHashTest(const ListType list_type,
const std::vector<SBThreatType>& expected_threats,
const std::vector<std::string>& result_lists);
bool RunUrlTest(
const GURL& url, ListType list_type,
const std::vector<SBThreatType>& expected_threats,
const std::vector<HostListPair>& host_list_results);
private:
bool RunTest(LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck* check,
const std::vector<SBFullHashResult>& hash_results);
TestBrowserThreadBundle thread_bundle_;
};
bool SafeBrowsingDatabaseManagerTest::RunSBHashTest(
const ListType list_type,
const std::vector<SBThreatType>& expected_threats,
const std::vector<std::string>& result_lists) {
const SBFullHash same_full_hash = {};
scoped_ptr<LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck> check(
new LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck(
std::vector<GURL>(), std::vector<SBFullHash>(1, same_full_hash), NULL,
list_type, expected_threats));
std::vector<SBFullHashResult> fake_results;
for (const auto& result_list : result_lists) {
const SBFullHashResult full_hash_result = {same_full_hash,
GetListId(result_list)};
fake_results.push_back(full_hash_result);
}
return RunTest(check.get(), fake_results);
}
bool SafeBrowsingDatabaseManagerTest::RunUrlTest(
const GURL& url, ListType list_type,
const std::vector<SBThreatType>& expected_threats,
const std::vector<HostListPair>& host_list_results) {
scoped_ptr<LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck> check(
new LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck(
std::vector<GURL>(1, url), std::vector<SBFullHash>(), NULL,
list_type, expected_threats));
std::vector<SBFullHashResult> full_hash_results;
for (const auto& host_list : host_list_results) {
SBFullHashResult hash_result =
{SBFullHashForString(host_list.host), GetListId(host_list.list_type)};
full_hash_results.push_back(hash_result);
}
return RunTest(check.get(), full_hash_results);
}
bool SafeBrowsingDatabaseManagerTest::RunTest(
LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck* check,
const std::vector<SBFullHashResult>& hash_results) {
scoped_refptr<SafeBrowsingService> sb_service_(
SafeBrowsingService::CreateSafeBrowsingService());
scoped_refptr<LocalSafeBrowsingDatabaseManager> db_manager_(
new LocalSafeBrowsingDatabaseManager(sb_service_));
db_manager_->checks_.insert(check);
bool result = db_manager_->HandleOneCheck(check, hash_results);
db_manager_->checks_.erase(check);
return result;
}
TEST_F(SafeBrowsingDatabaseManagerTest, CheckCorrespondsListTypeForHash) {
std::vector<SBThreatType> malware_threat(1,
SB_THREAT_TYPE_BINARY_MALWARE_URL);
EXPECT_FALSE(RunSBHashTest(BINURL, malware_threat, {kMalwareList}));
EXPECT_TRUE(RunSBHashTest(BINURL, malware_threat, {kBinUrlList}));
// Check for multiple threats
std::vector<SBThreatType> multiple_threats;
multiple_threats.push_back(SB_THREAT_TYPE_URL_MALWARE);
multiple_threats.push_back(SB_THREAT_TYPE_URL_PHISHING);
EXPECT_FALSE(RunSBHashTest(MALWARE, multiple_threats, {kBinUrlList}));
EXPECT_TRUE(RunSBHashTest(MALWARE, multiple_threats, {kMalwareList}));
// Check for multiple hash hits
std::vector<SBThreatType> unwanted_threat = {SB_THREAT_TYPE_URL_UNWANTED};
std::vector<std::string> hash_hits = {kMalwareList, kUnwantedUrlList};
EXPECT_TRUE(RunSBHashTest(UNWANTEDURL, unwanted_threat, hash_hits));
}
TEST_F(SafeBrowsingDatabaseManagerTest, CheckCorrespondsListTypeForUrl) {
const GURL url("http://www.host.com/index.html");
const std::string host1 = "host.com/";
const std::string host2 = "www.host.com/";
const std::vector<HostListPair> malware_list_result =
{{host1, kMalwareList}};
const std::vector<HostListPair> binurl_list_result =
{{host2, kBinUrlList}};
std::vector<SBThreatType> malware_threat =
{SB_THREAT_TYPE_BINARY_MALWARE_URL};
EXPECT_FALSE(RunUrlTest(url, BINURL, malware_threat, malware_list_result));
EXPECT_TRUE(RunUrlTest(url, BINURL, malware_threat, binurl_list_result));
// Check for multiple expected threats
std::vector<SBThreatType> multiple_threats =
{SB_THREAT_TYPE_URL_MALWARE, SB_THREAT_TYPE_URL_PHISHING};
EXPECT_FALSE(RunUrlTest(url, MALWARE, multiple_threats, binurl_list_result));
EXPECT_TRUE(RunUrlTest(url, MALWARE, multiple_threats, malware_list_result));
// Check for multiple database hits
std::vector<SBThreatType> unwanted_threat = {SB_THREAT_TYPE_URL_UNWANTED};
std::vector<HostListPair> multiple_results = {
{host1, kMalwareList}, {host2, kUnwantedUrlList}};
EXPECT_TRUE(RunUrlTest(url, UNWANTEDURL, unwanted_threat, multiple_results));
}
TEST_F(SafeBrowsingDatabaseManagerTest, GetUrlSeverestThreatType) {
std::vector<SBFullHashResult> full_hashes;
const GURL kMalwareUrl("http://www.malware.com/page.html");
const GURL kPhishingUrl("http://www.phishing.com/page.html");
const GURL kUnwantedUrl("http://www.unwanted.com/page.html");
const GURL kUnwantedAndMalwareUrl(
"http://www.unwantedandmalware.com/page.html");
const GURL kBlacklistedResourceUrl("http://www.blacklisted.com/script.js");
const GURL kUnwantedResourceUrl("http://www.unwantedresource.com/script.js");
const GURL kMalwareResourceUrl("http://www.malwareresource.com/script.js");
const GURL kSafeUrl("http://www.safe.com/page.html");
const SBFullHash kMalwareHostHash = SBFullHashForString("malware.com/");
const SBFullHash kPhishingHostHash = SBFullHashForString("phishing.com/");
const SBFullHash kUnwantedHostHash = SBFullHashForString("unwanted.com/");
const SBFullHash kUnwantedAndMalwareHostHash =
SBFullHashForString("unwantedandmalware.com/");
const SBFullHash kBlacklistedResourceHostHash =
SBFullHashForString("blacklisted.com/");
const SBFullHash kUnwantedResourceHostHash =
SBFullHashForString("unwantedresource.com/");
const SBFullHash kMalwareResourceHostHash =
SBFullHashForString("malwareresource.com/");
const SBFullHash kSafeHostHash = SBFullHashForString("www.safe.com/");
{
SBFullHashResult full_hash;
full_hash.hash = kMalwareHostHash;
full_hash.list_id = static_cast<int>(MALWARE);
full_hashes.push_back(full_hash);
}
{
SBFullHashResult full_hash;
full_hash.hash = kPhishingHostHash;
full_hash.list_id = static_cast<int>(PHISH);
full_hashes.push_back(full_hash);
}
{
SBFullHashResult full_hash;
full_hash.hash = kUnwantedHostHash;
full_hash.list_id = static_cast<int>(UNWANTEDURL);
full_hashes.push_back(full_hash);
}
{
SBFullHashResult full_hash;
full_hash.hash = kBlacklistedResourceHostHash;
full_hash.list_id = static_cast<int>(RESOURCEBLACKLIST);
full_hashes.push_back(full_hash);
}
{
// Add both MALWARE and UNWANTEDURL list IDs for
// kUnwantedAndMalwareHostHash.
SBFullHashResult full_hash_malware;
full_hash_malware.hash = kUnwantedAndMalwareHostHash;
full_hash_malware.list_id = static_cast<int>(MALWARE);
full_hashes.push_back(full_hash_malware);
SBFullHashResult full_hash_unwanted;
full_hash_unwanted.hash = kUnwantedAndMalwareHostHash;
full_hash_unwanted.list_id = static_cast<int>(UNWANTEDURL);
full_hashes.push_back(full_hash_unwanted);
}
{
SBFullHashResult full_hash_unwanted =
{kUnwantedResourceHostHash, static_cast<int>(UNWANTEDURL)};
full_hashes.push_back(full_hash_unwanted);
SBFullHashResult full_hash_resource =
{kUnwantedResourceHostHash, static_cast<int>(RESOURCEBLACKLIST)};
full_hashes.push_back(full_hash_resource);
}
{
SBFullHashResult full_hash_malware =
{kMalwareResourceHostHash, static_cast<int>(MALWARE)};
full_hashes.push_back(full_hash_malware);
SBFullHashResult full_hash_resource =
{kMalwareResourceHostHash, static_cast<int>(RESOURCEBLACKLIST)};
full_hashes.push_back(full_hash_resource);
}
EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kMalwareHostHash, full_hashes));
EXPECT_EQ(SB_THREAT_TYPE_URL_PHISHING,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kPhishingHostHash, full_hashes));
EXPECT_EQ(SB_THREAT_TYPE_URL_UNWANTED,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kUnwantedHostHash, full_hashes));
EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kUnwantedAndMalwareHostHash, full_hashes));
EXPECT_EQ(SB_THREAT_TYPE_BLACKLISTED_RESOURCE,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kBlacklistedResourceHostHash, full_hashes));
EXPECT_EQ(SB_THREAT_TYPE_URL_UNWANTED,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kUnwantedResourceHostHash, full_hashes));
EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kMalwareResourceHostHash, full_hashes));
EXPECT_EQ(SB_THREAT_TYPE_SAFE,
LocalSafeBrowsingDatabaseManager::GetHashSeverestThreatType(
kSafeHostHash, full_hashes));
const size_t kArbitraryValue = 123456U;
size_t index = kArbitraryValue;
EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kMalwareUrl, full_hashes, &index));
EXPECT_EQ(0U, index);
EXPECT_EQ(SB_THREAT_TYPE_URL_PHISHING,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kPhishingUrl, full_hashes, &index));
EXPECT_EQ(1U, index);
EXPECT_EQ(SB_THREAT_TYPE_URL_UNWANTED,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kUnwantedUrl, full_hashes, &index));
EXPECT_EQ(2U, index);
EXPECT_EQ(SB_THREAT_TYPE_BLACKLISTED_RESOURCE,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kBlacklistedResourceUrl, full_hashes, &index));
EXPECT_EQ(3U, index);
EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kUnwantedAndMalwareUrl, full_hashes, &index));
EXPECT_EQ(4U, index);
EXPECT_EQ(SB_THREAT_TYPE_URL_UNWANTED,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kUnwantedResourceUrl, full_hashes, &index));
EXPECT_EQ(6U, index);
EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kMalwareResourceUrl, full_hashes, &index));
EXPECT_EQ(8U, index);
index = kArbitraryValue;
EXPECT_EQ(SB_THREAT_TYPE_SAFE,
LocalSafeBrowsingDatabaseManager::GetUrlSeverestThreatType(
kSafeUrl, full_hashes, &index));
EXPECT_EQ(kArbitraryValue, index);
}
TEST_F(SafeBrowsingDatabaseManagerTest, ServiceStopWithPendingChecks) {
scoped_refptr<SafeBrowsingService> sb_service(
SafeBrowsingService::CreateSafeBrowsingService());
scoped_refptr<LocalSafeBrowsingDatabaseManager> db_manager(
new LocalSafeBrowsingDatabaseManager(sb_service));
SafeBrowsingDatabaseManager::Client client;
// Start the service and flush tasks to ensure database is made available.
db_manager->StartOnIOThread();
content::RunAllBlockingPoolTasksUntilIdle();
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(db_manager->DatabaseAvailable());
// Start an extension check operation, which is done asynchronously.
std::set<std::string> extension_ids;
extension_ids.insert("testtesttesttesttesttesttesttest");
db_manager->CheckExtensionIDs(extension_ids, &client);
// Stop the service without first flushing above tasks.
db_manager->StopOnIOThread(false);
// Now run posted tasks, whish should include the extension check which has
// been posted to the safe browsing task runner. This should not crash.
content::RunAllBlockingPoolTasksUntilIdle();
base::RunLoop().RunUntilIdle();
}
} // namespace safe_browsing
|