1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include <vector>
#include "base/memory/scoped_ptr.h"
#include "base/metrics/field_trial.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/search/instant_service.h"
#include "chrome/browser/search/instant_service_observer.h"
#include "chrome/browser/search/instant_unittest_base.h"
#include "chrome/browser/search/search.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/search/instant_search_prerenderer.h"
#include "chrome/common/render_messages.h"
#include "components/variations/entropy_provider.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "content/public/test/mock_render_process_host.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_test_sink.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "url/gurl.h"
class MockInstantServiceObserver : public InstantServiceObserver {
public:
MOCK_METHOD1(DefaultSearchProviderChanged, void(bool));
};
class InstantServiceTest : public InstantUnitTestBase {
protected:
void SetUp() override {
InstantUnitTestBase::SetUp();
instant_service_observer_.reset(new MockInstantServiceObserver());
instant_service_->AddObserver(instant_service_observer_.get());
}
void TearDown() override {
instant_service_->RemoveObserver(instant_service_observer_.get());
InstantUnitTestBase::TearDown();
}
InstantSearchPrerenderer* GetInstantSearchPrerenderer() {
return instant_service_->instant_search_prerenderer();
}
std::vector<InstantMostVisitedItem>& most_visited_items() {
return instant_service_->most_visited_items_;
}
std::vector<InstantMostVisitedItem>& suggestions_items() {
return instant_service_->suggestions_items_;
}
scoped_ptr<MockInstantServiceObserver> instant_service_observer_;
};
class InstantServiceEnabledTest : public InstantServiceTest {
protected:
void SetUp() override {
ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
"EmbeddedSearch", "Group1 use_cacheable_ntp:1"));
InstantServiceTest::SetUp();
}
};
TEST_F(InstantServiceEnabledTest, DispatchDefaultSearchProviderChanged) {
EXPECT_CALL(*instant_service_observer_.get(),
DefaultSearchProviderChanged(false)).Times(1);
const std::string new_base_url = "https://bar.com/";
SetUserSelectedDefaultSearchProvider(new_base_url);
}
TEST_F(InstantServiceTest, DontDispatchGoogleURLUpdatedForNonGoogleURLs) {
EXPECT_CALL(*instant_service_observer_.get(),
DefaultSearchProviderChanged(false)).Times(1);
const std::string new_dsp_url = "https://bar.com/";
SetUserSelectedDefaultSearchProvider(new_dsp_url);
testing::Mock::VerifyAndClearExpectations(instant_service_observer_.get());
EXPECT_CALL(*instant_service_observer_.get(),
DefaultSearchProviderChanged(false)).Times(0);
const std::string new_base_url = "https://www.google.es/";
NotifyGoogleBaseURLUpdate(new_base_url);
}
TEST_F(InstantServiceTest, DispatchGoogleURLUpdated) {
EXPECT_CALL(*instant_service_observer_.get(),
DefaultSearchProviderChanged(true)).Times(1);
const std::string new_base_url = "https://www.google.es/";
NotifyGoogleBaseURLUpdate(new_base_url);
}
TEST_F(InstantServiceEnabledTest, SendsSearchURLsToRenderer) {
scoped_ptr<content::MockRenderProcessHost> rph(
new content::MockRenderProcessHost(profile()));
rph->sink().ClearMessages();
instant_service_->Observe(
content::NOTIFICATION_RENDERER_PROCESS_CREATED,
content::Source<content::MockRenderProcessHost>(rph.get()),
content::NotificationService::NoDetails());
EXPECT_EQ(1U, rph->sink().message_count());
const IPC::Message* msg = rph->sink().GetMessageAt(0);
ASSERT_TRUE(msg);
ChromeViewMsg_SetSearchURLs::Param params;
ChromeViewMsg_SetSearchURLs::Read(msg, ¶ms);
std::vector<GURL> search_urls = base::get<0>(params);
GURL new_tab_page_url = base::get<1>(params);
EXPECT_EQ(2U, search_urls.size());
EXPECT_EQ("https://www.google.com/alt#quux=", search_urls[0].spec());
EXPECT_EQ("https://www.google.com/url?bar=", search_urls[1].spec());
EXPECT_EQ("https://www.google.com/newtab", new_tab_page_url.spec());
}
TEST_F(InstantServiceTest, InstantSearchEnabled) {
EXPECT_NE(static_cast<InstantSearchPrerenderer*>(NULL),
GetInstantSearchPrerenderer());
}
TEST_F(InstantServiceEnabledTest,
ResetInstantSearchPrerenderer_DefaultProviderChanged) {
EXPECT_CALL(*instant_service_observer_.get(),
DefaultSearchProviderChanged(false)).Times(2);
// Set a default search provider that doesn't support Instant.
TemplateURLData data;
data.SetShortName(base::ASCIIToUTF16("foobar.com"));
data.SetURL("https://foobar.com/url?bar={searchTerms}");
TemplateURL* template_url = new TemplateURL(data);
// Takes ownership of |template_url|.
template_url_service_->Add(template_url);
template_url_service_->SetUserSelectedDefaultSearchProvider(template_url);
EXPECT_EQ(static_cast<InstantSearchPrerenderer*>(NULL),
GetInstantSearchPrerenderer());
// Set a default search provider that supports Instant and make sure
// InstantSearchPrerenderer is valid.
SetUserSelectedDefaultSearchProvider("https://google.com/");
EXPECT_NE(static_cast<InstantSearchPrerenderer*>(NULL),
GetInstantSearchPrerenderer());
}
TEST_F(InstantServiceEnabledTest,
ResetInstantSearchPrerenderer_GoogleBaseURLUpdated) {
EXPECT_CALL(*instant_service_observer_.get(),
DefaultSearchProviderChanged(true)).Times(1);
InstantSearchPrerenderer* old_prerenderer = GetInstantSearchPrerenderer();
EXPECT_TRUE(old_prerenderer != NULL);
const std::string new_base_url = "https://www.google.es/";
NotifyGoogleBaseURLUpdate(new_base_url);
EXPECT_NE(old_prerenderer, GetInstantSearchPrerenderer());
}
TEST_F(InstantServiceTest, GetSuggestionFromServiceSide) {
auto profile = suggestions::SuggestionsProfile();
profile.add_suggestions();
instant_service_->OnSuggestionsAvailable(profile);
auto items = instant_service_->suggestions_items_;
ASSERT_EQ(1, (int)items.size());
ASSERT_TRUE(items[0].is_server_side_suggestion);
}
TEST_F(InstantServiceTest, GetSuggestionFromClientSide) {
history::MostVisitedURLList url_list;
url_list.push_back(history::MostVisitedURL());
instant_service_->OnMostVisitedItemsReceived(url_list);
auto items = instant_service_->most_visited_items_;
ASSERT_EQ(1, (int)items.size());
ASSERT_FALSE(items[0].is_server_side_suggestion);
}
TEST_F(InstantServiceTest, IsValidURLForNavigation) {
// chrome:// URLs should never appear in the most visited items list, but even
// if it does, deny navigation anyway.
InstantMostVisitedItem settings_item;
settings_item.url = GURL("chrome://settings");
most_visited_items().push_back(settings_item);
EXPECT_FALSE(instant_service_->IsValidURLForNavigation(settings_item.url));
// If a chrome-extension:// URL appears in the most visited items list, allow
// navigation to it.
InstantMostVisitedItem extension_item;
extension_item.url = GURL("chrome-extension://awesome");
most_visited_items().push_back(extension_item);
EXPECT_TRUE(instant_service_->IsValidURLForNavigation(extension_item.url));
// The renderer filters out javascript:// URLs so we should never receive a
// request to navigate to one. But if we do, deny it.
InstantMostVisitedItem js_item;
js_item.url = GURL("javascript:'moo'");
most_visited_items().push_back(js_item);
EXPECT_FALSE(instant_service_->IsValidURLForNavigation(js_item.url));
// Normal case: a request for a web safe URL in the most visited items should
// be allowed.
InstantMostVisitedItem example_item;
example_item.url = GURL("https://example.com");
most_visited_items().push_back(example_item);
EXPECT_TRUE(instant_service_->IsValidURLForNavigation(example_item.url));
// Normal case: a request for a web safe URL in the most visited items should
// be allowed as well.
InstantMostVisitedItem chromium_item;
chromium_item.url = GURL("https://chromium.org");
suggestions_items().push_back(chromium_item);
EXPECT_TRUE(instant_service_->IsValidURLForNavigation(chromium_item.url));
// http://chromium.org is web safe, but not in |suggestions_items_| or
// |most_visited_items_|, so it should be denied.
EXPECT_FALSE(
instant_service_->IsValidURLForNavigation(GURL("http://chromium.org")));
}
|
