1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
|
// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_
#define CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_
#include <utility>
#include <vector>
#include "chrome/browser/sync/engine/syncer_command.h"
#include "chrome/browser/sync/engine/syncer_util.h"
#include "chrome/browser/sync/sessions/sync_session.h"
#include "chrome/browser/sync/util/sync_types.h"
using std::pair;
using std::vector;
namespace browser_sync {
class GetCommitIdsCommand : public SyncerCommand {
friend class SyncerTest;
public:
explicit GetCommitIdsCommand(int commit_batch_size);
virtual ~GetCommitIdsCommand();
// SyncerCommand implementation.
virtual void ExecuteImpl(sessions::SyncSession* session);
// Builds a vector of IDs that should be committed.
void BuildCommitIds(const vector<int64>& unsynced_handles,
syncable::WriteTransaction* write_transaction);
// These classes are public for testing.
// TODO(ncarter): This code is more generic than just Commit and can
// be reused elsewhere (e.g. ChangeReorderBuffer do similar things). Merge
// all these implementations.
class OrderedCommitSet {
public:
// TODO(chron): Reserve space according to batch size?
OrderedCommitSet() {}
~OrderedCommitSet() {}
bool HaveCommitItem(const int64 metahandle) const {
return inserted_metahandles_.count(metahandle) > 0;
}
void AddCommitItem(const int64 metahandle, const syncable::Id& commit_id) {
if (!HaveCommitItem(metahandle)) {
inserted_metahandles_.insert(metahandle);
metahandle_order_.push_back(metahandle);
commit_ids_.push_back(commit_id);
}
}
const vector<syncable::Id>& GetCommitIds() const {
return commit_ids_;
}
pair<int64, syncable::Id> GetCommitItemAt(const int position) const {
DCHECK(position < Size());
return pair<int64, syncable::Id> (
metahandle_order_[position], commit_ids_[position]);
}
int Size() const {
return commit_ids_.size();
}
void AppendReverse(const OrderedCommitSet& other) {
for (int i = other.Size() - 1; i >= 0; i--) {
pair<int64, syncable::Id> item = other.GetCommitItemAt(i);
AddCommitItem(item.first, item.second);
}
}
void Truncate(size_t max_size) {
if (max_size < metahandle_order_.size()) {
for (size_t i = max_size; i < metahandle_order_.size(); ++i) {
inserted_metahandles_.erase(metahandle_order_[i]);
}
commit_ids_.resize(max_size);
metahandle_order_.resize(max_size);
}
}
private:
// These three lists are different views of the same data; e.g they are
// isomorphic.
syncable::MetahandleSet inserted_metahandles_;
vector<syncable::Id> commit_ids_;
vector<int64> metahandle_order_;
DISALLOW_COPY_AND_ASSIGN(OrderedCommitSet);
};
// TODO(chron): Remove writes from this iterator. As a warning, this
// iterator causes writes to entries and so isn't a pure iterator.
// It will do Put(IS_UNSYNCED). Refactor this out later.
class CommitMetahandleIterator {
public:
// TODO(chron): Cache ValidateCommitEntry responses across iterators to save
// UTF8 conversion and filename checking
CommitMetahandleIterator(const vector<int64>& unsynced_handles,
syncable::WriteTransaction* write_transaction,
OrderedCommitSet* commit_set)
: write_transaction_(write_transaction),
handle_iterator_(unsynced_handles.begin()),
unsynced_handles_end_(unsynced_handles.end()),
commit_set_(commit_set) {
// TODO(chron): Remove writes from this iterator.
DCHECK(write_transaction_);
if (Valid() && !ValidateMetahandleForCommit(*handle_iterator_))
Increment();
}
~CommitMetahandleIterator() {}
int64 Current() const {
DCHECK(Valid());
return *handle_iterator_;
}
bool Increment() {
if (!Valid())
return false;
for (++handle_iterator_;
handle_iterator_ != unsynced_handles_end_;
++handle_iterator_) {
if (ValidateMetahandleForCommit(*handle_iterator_))
return true;
}
return false;
}
bool Valid() const {
return !(handle_iterator_ == unsynced_handles_end_);
}
private:
bool ValidateMetahandleForCommit(int64 metahandle) {
if (commit_set_->HaveCommitItem(metahandle))
return false;
// We should really not WRITE in this iterator, but we can fix that
// later. We should move that somewhere else later.
syncable::MutableEntry entry(write_transaction_,
syncable::GET_BY_HANDLE, metahandle);
VerifyCommitResult verify_result =
SyncerUtil::ValidateCommitEntry(&entry);
if (verify_result == VERIFY_UNSYNCABLE) {
// Drop unsyncable entries.
entry.Put(syncable::IS_UNSYNCED, false);
}
return verify_result == VERIFY_OK;
}
syncable::WriteTransaction* const write_transaction_;
vector<int64>::const_iterator handle_iterator_;
vector<int64>::const_iterator unsynced_handles_end_;
OrderedCommitSet* commit_set_;
DISALLOW_COPY_AND_ASSIGN(CommitMetahandleIterator);
};
private:
void AddUncommittedParentsAndTheirPredecessors(
syncable::BaseTransaction* trans,
syncable::Id parent_id);
// OrderedCommitSet helpers for adding predecessors in order.
// TODO(ncarter): Refactor these so that the |result| parameter goes away,
// and AddItem doesn't need to consider two OrderedCommitSets.
bool AddItem(syncable::Entry* item, OrderedCommitSet* result);
bool AddItemThenPredecessors(syncable::BaseTransaction* trans,
syncable::Entry* item,
syncable::IndexedBitField inclusion_filter,
OrderedCommitSet* result);
void AddPredecessorsThenItem(syncable::BaseTransaction* trans,
syncable::Entry* item,
syncable::IndexedBitField inclusion_filter);
bool IsCommitBatchFull();
void AddCreatesAndMoves(const vector<int64>& unsynced_handles,
syncable::WriteTransaction* write_transaction);
void AddDeletes(const vector<int64>& unsynced_handles,
syncable::WriteTransaction* write_transaction);
OrderedCommitSet ordered_commit_set_;
int requested_commit_batch_size_;
DISALLOW_COPY_AND_ASSIGN(GetCommitIdsCommand);
};
} // namespace browser_sync
#endif // CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_
|
