1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/browser_thread.h"
#include "chrome/browser/browser_url_handler.h"
#include "chrome/browser/renderer_host/site_instance.h"
#include "chrome/browser/renderer_host/test/test_render_view_host.h"
#include "chrome/browser/tab_contents/navigation_controller.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
#include "chrome/browser/tab_contents/render_view_host_manager.h"
#include "chrome/browser/tab_contents/test_tab_contents.h"
#include "chrome/common/notification_details.h"
#include "chrome/common/notification_source.h"
#include "chrome/common/render_messages.h"
#include "chrome/common/render_messages_params.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/test_notification_tracker.h"
#include "chrome/test/testing_profile.h"
#include "ipc/ipc_message.h"
#include "testing/gtest/include/gtest/gtest.h"
class RenderViewHostManagerTest : public RenderViewHostTestHarness {
public:
void NavigateActiveAndCommit(const GURL& url) {
// Note: we navigate the active RenderViewHost because previous navigations
// won't have committed yet, so NavigateAndCommit does the wrong thing
// for us.
controller().LoadURL(url, GURL(), 0);
active_rvh()->SendNavigate(
static_cast<MockRenderProcessHost*>(active_rvh()->process())->
max_page_id() + 1,
url);
}
bool ShouldSwapProcesses(RenderViewHostManager* manager,
const NavigationEntry* cur_entry,
const NavigationEntry* new_entry) const {
return manager->ShouldSwapProcessesForNavigation(cur_entry, new_entry);
}
};
// Tests that when you navigate from the New TabPage to another page, and
// then do that same thing in another tab, that the two resulting pages have
// different SiteInstances, BrowsingInstances, and RenderProcessHosts. This is
// a regression test for bug 9364.
TEST_F(RenderViewHostManagerTest, NewTabPageProcesses) {
BrowserThread ui_thread(BrowserThread::UI, MessageLoop::current());
GURL ntp(chrome::kChromeUINewTabURL);
GURL dest("http://www.google.com/");
// Navigate our first tab to the new tab page and then to the destination.
NavigateActiveAndCommit(ntp);
NavigateActiveAndCommit(dest);
// Make a second tab.
TestTabContents contents2(profile_.get(), NULL);
// Load the two URLs in the second tab. Note that the first navigation creates
// a RVH that's not pending (since there is no cross-site transition), so
// we use the committed one, but the second one is the opposite.
contents2.controller().LoadURL(ntp, GURL(), PageTransition::LINK);
static_cast<TestRenderViewHost*>(contents2.render_manager()->
current_host())->SendNavigate(100, ntp);
contents2.controller().LoadURL(dest, GURL(), PageTransition::LINK);
static_cast<TestRenderViewHost*>(contents2.render_manager()->
pending_render_view_host())->SendNavigate(101, dest);
// The two RVH's should be different in every way.
EXPECT_NE(active_rvh()->process(), contents2.render_view_host()->process());
EXPECT_NE(active_rvh()->site_instance(),
contents2.render_view_host()->site_instance());
EXPECT_NE(active_rvh()->site_instance()->browsing_instance(),
contents2.render_view_host()->site_instance()->browsing_instance());
// Navigate both to the new tab page, and verify that they share a
// SiteInstance.
NavigateActiveAndCommit(ntp);
contents2.controller().LoadURL(ntp, GURL(), PageTransition::LINK);
static_cast<TestRenderViewHost*>(contents2.render_manager()->
pending_render_view_host())->SendNavigate(102, ntp);
EXPECT_EQ(active_rvh()->site_instance(),
contents2.render_view_host()->site_instance());
}
// When there is an error with the specified page, renderer exits view-source
// mode. See WebFrameImpl::DidFail(). We check by this test that
// EnableViewSourceMode message is sent on every navigation regardless
// RenderView is being newly created or reused.
TEST_F(RenderViewHostManagerTest, AlwaysSendEnableViewSourceMode) {
BrowserThread ui_thread(BrowserThread::UI, MessageLoop::current());
const GURL kNtpUrl(chrome::kChromeUINewTabURL);
const GURL kUrl("view-source:http://foo");
// We have to navigate to some page at first since without this, the first
// navigation will reuse the SiteInstance created by Init(), and the second
// one will create a new SiteInstance. Because current_instance and
// new_instance will be different, a new RenderViewHost will be created for
// the second navigation. We have to avoid this in order to exercise the
// target code patch.
NavigateActiveAndCommit(kNtpUrl);
// Navigate.
controller().LoadURL(kUrl, GURL() /* referer */, PageTransition::TYPED);
// Simulate response from RenderView for FirePageBeforeUnload.
rvh()->TestOnMessageReceived(
ViewHostMsg_ShouldClose_ACK(rvh()->routing_id(), true));
ASSERT_TRUE(pending_rvh()); // New pending RenderViewHost will be created.
RenderViewHost* last_rvh = pending_rvh();
int new_id = static_cast<MockRenderProcessHost*>(pending_rvh()->process())->
max_page_id() + 1;
pending_rvh()->SendNavigate(new_id, kUrl);
EXPECT_EQ(controller().last_committed_entry_index(), 1);
ASSERT_TRUE(controller().GetLastCommittedEntry());
EXPECT_TRUE(kUrl == controller().GetLastCommittedEntry()->url());
EXPECT_FALSE(controller().pending_entry());
// Because we're using TestTabContents and TestRenderViewHost in this
// unittest, no one calls TabContents::RenderViewCreated(). So, we see no
// EnableViewSourceMode message, here.
// Clear queued messages before load.
process()->sink().ClearMessages();
// Navigate, again.
controller().LoadURL(kUrl, GURL() /* referer */, PageTransition::TYPED);
// The same RenderViewHost should be reused.
EXPECT_FALSE(pending_rvh());
EXPECT_TRUE(last_rvh == rvh());
rvh()->SendNavigate(new_id, kUrl); // The same page_id returned.
EXPECT_EQ(controller().last_committed_entry_index(), 1);
EXPECT_FALSE(controller().pending_entry());
// New message should be sent out to make sure to enter view-source mode.
EXPECT_TRUE(process()->sink().GetUniqueMessageMatching(
ViewMsg_EnableViewSourceMode::ID));
}
// Tests the Init function by checking the initial RenderViewHost.
TEST_F(RenderViewHostManagerTest, Init) {
// Using TestingProfile.
SiteInstance* instance = SiteInstance::CreateSiteInstance(profile_.get());
EXPECT_FALSE(instance->has_site());
TestTabContents tab_contents(profile_.get(), instance);
RenderViewHostManager manager(&tab_contents, &tab_contents);
manager.Init(profile_.get(), instance, MSG_ROUTING_NONE);
RenderViewHost* host = manager.current_host();
ASSERT_TRUE(host);
EXPECT_TRUE(instance == host->site_instance());
EXPECT_TRUE(&tab_contents == host->delegate());
EXPECT_TRUE(manager.GetRenderWidgetHostView());
EXPECT_FALSE(manager.pending_render_view_host());
}
// Tests the Navigate function. We navigate three sites consecutively and check
// how the pending/committed RenderViewHost are modified.
TEST_F(RenderViewHostManagerTest, Navigate) {
TestNotificationTracker notifications;
SiteInstance* instance = SiteInstance::CreateSiteInstance(profile_.get());
TestTabContents tab_contents(profile_.get(), instance);
notifications.ListenFor(NotificationType::RENDER_VIEW_HOST_CHANGED,
Source<NavigationController>(&tab_contents.controller()));
// Create.
RenderViewHostManager manager(&tab_contents, &tab_contents);
manager.Init(profile_.get(), instance, MSG_ROUTING_NONE);
RenderViewHost* host;
// 1) The first navigation. --------------------------
GURL url1("http://www.google.com/");
NavigationEntry entry1(NULL /* instance */, -1 /* page_id */, url1,
GURL() /* referrer */, string16() /* title */,
PageTransition::TYPED);
host = manager.Navigate(entry1);
// The RenderViewHost created in Init will be reused.
EXPECT_TRUE(host == manager.current_host());
EXPECT_FALSE(manager.pending_render_view_host());
// Commit.
manager.DidNavigateMainFrame(host);
// Commit to SiteInstance should be delayed until RenderView commit.
EXPECT_TRUE(host == manager.current_host());
ASSERT_TRUE(host);
EXPECT_FALSE(host->site_instance()->has_site());
host->site_instance()->SetSite(url1);
// 2) Navigate to next site. -------------------------
GURL url2("http://www.google.com/foo");
NavigationEntry entry2(NULL /* instance */, -1 /* page_id */, url2,
url1 /* referrer */, string16() /* title */,
PageTransition::LINK);
host = manager.Navigate(entry2);
// The RenderViewHost created in Init will be reused.
EXPECT_TRUE(host == manager.current_host());
EXPECT_FALSE(manager.pending_render_view_host());
// Commit.
manager.DidNavigateMainFrame(host);
EXPECT_TRUE(host == manager.current_host());
ASSERT_TRUE(host);
EXPECT_TRUE(host->site_instance()->has_site());
// 3) Cross-site navigate to next site. --------------
GURL url3("http://webkit.org/");
NavigationEntry entry3(NULL /* instance */, -1 /* page_id */, url3,
url2 /* referrer */, string16() /* title */,
PageTransition::LINK);
host = manager.Navigate(entry3);
// A new RenderViewHost should be created.
EXPECT_TRUE(manager.pending_render_view_host());
EXPECT_TRUE(host == manager.pending_render_view_host());
notifications.Reset();
// Commit.
manager.DidNavigateMainFrame(manager.pending_render_view_host());
EXPECT_TRUE(host == manager.current_host());
ASSERT_TRUE(host);
EXPECT_TRUE(host->site_instance()->has_site());
// Check the pending RenderViewHost has been committed.
EXPECT_FALSE(manager.pending_render_view_host());
// We should observe a notification.
EXPECT_TRUE(notifications.Check1AndReset(
NotificationType::RENDER_VIEW_HOST_CHANGED));
}
// Tests DOMUI creation.
TEST_F(RenderViewHostManagerTest, DOMUI) {
BrowserThread ui_thread(BrowserThread::UI, MessageLoop::current());
SiteInstance* instance = SiteInstance::CreateSiteInstance(profile_.get());
TestTabContents tab_contents(profile_.get(), instance);
RenderViewHostManager manager(&tab_contents, &tab_contents);
manager.Init(profile_.get(), instance, MSG_ROUTING_NONE);
GURL url(chrome::kChromeUINewTabURL);
NavigationEntry entry(NULL /* instance */, -1 /* page_id */, url,
GURL() /* referrer */, string16() /* title */,
PageTransition::TYPED);
RenderViewHost* host = manager.Navigate(entry);
EXPECT_TRUE(host);
EXPECT_TRUE(host == manager.current_host());
EXPECT_FALSE(manager.pending_render_view_host());
// It's important that the site instance get set on the Web UI page as soon
// as the navigation starts, rather than lazily after it commits, so we don't
// try to re-use the SiteInstance/process for non DOM-UI things that may
// get loaded in between.
EXPECT_TRUE(host->site_instance()->has_site());
EXPECT_EQ(url, host->site_instance()->site());
// The Web UI is committed immediately because the RenderViewHost has not been
// used yet. UpdateRendererStateForNavigate() took the short cut path.
EXPECT_FALSE(manager.pending_dom_ui());
EXPECT_TRUE(manager.dom_ui());
// Commit.
manager.DidNavigateMainFrame(host);
}
// Tests that chrome: URLs that are not Web UI pages do not get grouped into
// Web UI renderers, even if --process-per-tab is enabled. In that mode, we
// still swap processes if ShouldSwapProcessesForNavigation is true.
// Regression test for bug 46290.
TEST_F(RenderViewHostManagerTest, NonDOMUIChromeURLs) {
SiteInstance* instance = SiteInstance::CreateSiteInstance(profile_.get());
TestTabContents tab_contents(profile_.get(), instance);
RenderViewHostManager manager(&tab_contents, &tab_contents);
manager.Init(profile_.get(), instance, MSG_ROUTING_NONE);
// NTP is a Web UI page.
GURL ntp_url(chrome::kChromeUINewTabURL);
NavigationEntry ntp_entry(NULL /* instance */, -1 /* page_id */, ntp_url,
GURL() /* referrer */, string16() /* title */,
PageTransition::TYPED);
// about: URLs are not Web UI pages.
GURL about_url(chrome::kAboutMemoryURL);
// Rewrite so it looks like chrome://about/memory
bool reverse_on_redirect = false;
BrowserURLHandler::RewriteURLIfNecessary(
&about_url, profile_.get(), &reverse_on_redirect);
NavigationEntry about_entry(NULL /* instance */, -1 /* page_id */, about_url,
GURL() /* referrer */, string16() /* title */,
PageTransition::TYPED);
EXPECT_TRUE(ShouldSwapProcesses(&manager, &ntp_entry, &about_entry));
}
// Tests that we don't end up in an inconsistent state if a page does a back and
// then reload. http://crbug.com/51680
TEST_F(RenderViewHostManagerTest, PageDoesBackAndReload) {
GURL url1("http://www.google.com/");
GURL url2("http://www.evil-site.com/");
// Navigate to a safe site, then an evil site.
// This will switch RenderViewHosts. We cannot assert that the first and
// second RVHs are different, though, because the first one may be promptly
// deleted.
contents()->NavigateAndCommit(url1);
contents()->NavigateAndCommit(url2);
RenderViewHost* evil_rvh = contents()->render_view_host();
// Now let's simulate the evil page calling history.back().
contents()->OnGoToEntryAtOffset(-1);
// We should have a new pending RVH.
// Note that in this case, the navigation has not committed, so evil_rvh will
// not be deleted yet.
EXPECT_NE(evil_rvh, contents()->render_manager()->pending_render_view_host());
// Before that RVH has committed, the evil page reloads itself.
ViewHostMsg_FrameNavigate_Params params;
params.page_id = 1;
params.url = url2;
params.transition = PageTransition::CLIENT_REDIRECT;
params.should_update_history = false;
params.gesture = NavigationGestureAuto;
params.was_within_same_page = false;
params.is_post = false;
contents()->TestDidNavigate(evil_rvh, params);
// That should have cancelled the pending RVH, and the evil RVH should be the
// current one.
EXPECT_TRUE(contents()->render_manager()->pending_render_view_host() == NULL);
EXPECT_EQ(evil_rvh, contents()->render_manager()->current_host());
// Also we should not have a pending navigation entry.
NavigationEntry* entry = contents()->controller().GetActiveEntry();
ASSERT_TRUE(entry != NULL);
EXPECT_EQ(url2, entry->url());
}
|