1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/ash/launcher/launcher_favicon_loader.h"
#include "ash/shelf/shelf_constants.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/stringprintf.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "third_party/skia/include/core/SkBitmap.h"
using content::WebContents;
using content::WebContentsObserver;
namespace {
// Observer class to determine when favicons have completed loading.
class ContentsObserver : public WebContentsObserver {
public:
explicit ContentsObserver(WebContents* web_contents)
: WebContentsObserver(web_contents),
loaded_(false),
got_favicons_(false) {
}
virtual ~ContentsObserver() {}
void Reset() {
got_favicons_ = false;
}
bool loaded() const { return loaded_; }
bool got_favicons() const { return got_favicons_; }
// WebContentsObserver overrides.
virtual void DidFinishLoad(
int64 frame_id,
const GURL& validated_url,
bool is_main_frame,
content::RenderViewHost* render_view_host) OVERRIDE {
loaded_ = true;
}
virtual void DidUpdateFaviconURL(int32 page_id,
const std::vector<content::FaviconURL>& candidates) OVERRIDE {
if (!candidates.empty())
got_favicons_ = true;
}
private:
bool loaded_;
bool got_favicons_;
};
} // namespace
class LauncherFaviconLoaderBrowsertest
: public InProcessBrowserTest,
public LauncherFaviconLoader::Delegate {
public:
LauncherFaviconLoaderBrowsertest() : favicon_updated_(false) {
}
virtual ~LauncherFaviconLoaderBrowsertest() {
}
virtual void SetUpOnMainThread() OVERRIDE {
WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
contents_observer_.reset(new ContentsObserver(web_contents));
favicon_loader_.reset(new LauncherFaviconLoader(this, web_contents));
}
// LauncherFaviconLoader::Delegate overrides:
virtual void FaviconUpdated() OVERRIDE {
favicon_updated_ = true;
}
protected:
bool NavigateTo(const char* url) {
std::string url_path = base::StringPrintf("files/ash/launcher/%s", url);
ui_test_utils::NavigateToURL(browser(), test_server()->GetURL(url_path));
return true;
}
bool WaitForContentsLoaded() {
const int64 max_seconds = 10;
base::Time start_time = base::Time::Now();
while (!(contents_observer_->loaded() &&
contents_observer_->got_favicons())) {
content::RunAllPendingInMessageLoop();
base::TimeDelta delta = base::Time::Now() - start_time;
if (delta.InSeconds() >= max_seconds) {
LOG(ERROR) << " WaitForContentsLoaded timed out.";
return false;
}
}
return true;
}
bool WaitForFaviconUpdated() {
const int64 max_seconds = 10;
base::Time start_time = base::Time::Now();
while (favicon_loader_->HasPendingDownloads()) {
content::RunAllPendingInMessageLoop();
base::TimeDelta delta = base::Time::Now() - start_time;
if (delta.InSeconds() >= max_seconds) {
LOG(ERROR) << " WaitForFaviconDownlads timed out.";
return false;
}
}
return true;
}
void ResetDownloads() {
contents_observer_->Reset();
}
bool favicon_updated_;
scoped_ptr<ContentsObserver> contents_observer_;
scoped_ptr<LauncherFaviconLoader> favicon_loader_;
private:
DISALLOW_COPY_AND_ASSIGN(LauncherFaviconLoaderBrowsertest);
};
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, SmallLauncherIcon) {
ASSERT_TRUE(test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-smallfavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
// No large favicons specified, bitmap should be empty.
EXPECT_TRUE(favicon_loader_->GetFavicon().empty());
}
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, LargeLauncherIcon) {
ASSERT_TRUE(test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-largefavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
EXPECT_FALSE(favicon_loader_->GetFavicon().empty());
EXPECT_EQ(128, favicon_loader_->GetFavicon().height());
}
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, ManyLauncherIcons) {
ASSERT_TRUE(test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-manyfavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
EXPECT_FALSE(favicon_loader_->GetFavicon().empty());
// When multiple favicons are present, the correctly sized icon should be
// chosen. The icons are sized assuming ash::kShelfPreferredSize < 128.
EXPECT_GT(128, ash::kShelfPreferredSize);
EXPECT_EQ(48, favicon_loader_->GetFavicon().height());
}
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, ChangeLauncherIcons) {
ASSERT_TRUE(test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-manyfavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
EXPECT_FALSE(favicon_loader_->GetFavicon().empty());
EXPECT_EQ(48, favicon_loader_->GetFavicon().height());
ASSERT_NO_FATAL_FAILURE(ResetDownloads());
ASSERT_TRUE(NavigateTo("launcher-smallfavicon.html"));
ASSERT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
EXPECT_TRUE(favicon_loader_->GetFavicon().empty());
ASSERT_NO_FATAL_FAILURE(ResetDownloads());
ASSERT_TRUE(NavigateTo("launcher-largefavicon.html"));
ASSERT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
EXPECT_FALSE(favicon_loader_->GetFavicon().empty());
EXPECT_EQ(128, favicon_loader_->GetFavicon().height());
}
|
