1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/ui/autofill/autofill_popup_view.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/autofill/content/browser/content_autofill_driver.h"
#include "components/autofill/content/browser/content_autofill_driver_factory.h"
#include "components/autofill/core/browser/autofill_manager.h"
#include "components/autofill/core/browser/test_autofill_external_delegate.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/test_utils.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/vector2d.h"
namespace autofill {
namespace {
class TestAutofillExternalDelegate : public AutofillExternalDelegate {
public:
TestAutofillExternalDelegate(content::WebContents* web_contents,
AutofillManager* autofill_manager,
AutofillDriver* autofill_driver)
: AutofillExternalDelegate(autofill_manager, autofill_driver),
popup_hidden_(true) {}
~TestAutofillExternalDelegate() override {}
void OnPopupShown() override {
popup_hidden_ = false;
AutofillExternalDelegate::OnPopupShown();
}
void OnPopupHidden() override {
popup_hidden_ = true;
if (message_loop_runner_.get())
message_loop_runner_->Quit();
}
void WaitForPopupHidden() {
if (popup_hidden_)
return;
message_loop_runner_ = new content::MessageLoopRunner;
message_loop_runner_->Run();
}
bool popup_hidden() const { return popup_hidden_; }
private:
bool popup_hidden_;
scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
DISALLOW_COPY_AND_ASSIGN(TestAutofillExternalDelegate);
};
} // namespace
class AutofillPopupControllerBrowserTest
: public InProcessBrowserTest,
public content::WebContentsObserver {
public:
AutofillPopupControllerBrowserTest() {}
~AutofillPopupControllerBrowserTest() override {}
void SetUpOnMainThread() override {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(web_contents != NULL);
Observe(web_contents);
ContentAutofillDriver* driver =
ContentAutofillDriverFactory::FromWebContents(web_contents)
->DriverForFrame(web_contents->GetMainFrame());
autofill_external_delegate_.reset(
new TestAutofillExternalDelegate(
web_contents,
driver->autofill_manager(),
driver));
}
// Normally the WebContents will automatically delete the delegate, but here
// the delegate is owned by this test, so we have to manually destroy.
void RenderFrameDeleted(content::RenderFrameHost* rfh) override {
if (!rfh->GetParent())
autofill_external_delegate_.reset();
}
protected:
scoped_ptr<TestAutofillExternalDelegate> autofill_external_delegate_;
};
#if defined(OS_MACOSX)
// Fails on Mac OS, see crbug/453256
#define MAYBE_DoNotHidePopupOnWindowMove DISABLED_DoNotHidePopupOnWindowMove
#else
#define MAYBE_DoNotHidePopupOnWindowMove DoNotHidePopupOnWindowMove
#endif
IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest,
MAYBE_DoNotHidePopupOnWindowMove) {
GenerateTestAutofillPopup(autofill_external_delegate_.get());
EXPECT_FALSE(autofill_external_delegate_->popup_hidden());
// Move the window, which should not cause the popup to hide.
gfx::Rect new_bounds = browser()->window()->GetBounds() - gfx::Vector2d(1, 1);
browser()->window()->SetBounds(new_bounds);
EXPECT_FALSE(autofill_external_delegate_->popup_hidden());
}
IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest,
HidePopupOnWindowResize) {
GenerateTestAutofillPopup(autofill_external_delegate_.get());
EXPECT_FALSE(autofill_external_delegate_->popup_hidden());
// Resize the window, which should cause the popup to hide.
gfx::Rect new_bounds = browser()->window()->GetBounds();
new_bounds.Inset(1, 1);
browser()->window()->SetBounds(new_bounds);
autofill_external_delegate_->WaitForPopupHidden();
EXPECT_TRUE(autofill_external_delegate_->popup_hidden());
}
// This test checks that the browser doesn't crash if the delegate is deleted
// before the popup is hidden.
IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest,
DeleteDelegateBeforePopupHidden){
GenerateTestAutofillPopup(autofill_external_delegate_.get());
// Delete the external delegate here so that is gets deleted before popup is
// hidden. This can happen if the web_contents are destroyed before the popup
// is hidden. See http://crbug.com/232475
autofill_external_delegate_.reset();
}
} // namespace autofill
|
