1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/mac/scoped_nsobject.h"
#include "base/macros.h"
#include "base/run_loop.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_list_observer.h"
#import "chrome/browser/ui/cocoa/app_menu/app_menu_controller.h"
#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
#include "chrome/browser/ui/cocoa/run_loop_testing.h"
#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
#import "chrome/browser/ui/cocoa/view_resizer_pong.h"
#include "chrome/browser/ui/sync/browser_synced_window_delegates_getter.h"
#include "chrome/browser/ui/toolbar/app_menu_model.h"
#include "chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.h"
#include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/testing_profile.h"
#include "components/browser_sync/browser/profile_sync_service.h"
#include "components/sync_driver/local_device_info_provider_mock.h"
#include "components/sync_driver/sync_client.h"
#include "components/sync_driver/sync_prefs.h"
#include "components/sync_sessions/fake_sync_sessions_client.h"
#include "components/sync_sessions/sessions_sync_manager.h"
#include "grit/theme_resources.h"
#include "sync/api/fake_sync_change_processor.h"
#include "sync/api/sync_error_factory_mock.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest_mac.h"
#include "testing/platform_test.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
namespace {
class MockAppMenuModel : public AppMenuModel {
public:
MockAppMenuModel() : AppMenuModel() {}
~MockAppMenuModel() {}
MOCK_METHOD2(ExecuteCommand, void(int command_id, int event_flags));
};
class DummyRouter : public browser_sync::LocalSessionEventRouter {
public:
~DummyRouter() override {}
void StartRoutingTo(
browser_sync::LocalSessionEventHandler* handler) override {}
void Stop() override {}
};
class AppMenuControllerTest : public CocoaProfileTest {
public:
AppMenuControllerTest()
: local_device_(new sync_driver::LocalDeviceInfoProviderMock(
"AppMenuControllerTest",
"Test Machine",
"Chromium 10k",
"Chrome 10k",
sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
"device_id")) {
}
void SetUp() override {
CocoaProfileTest::SetUp();
ASSERT_TRUE(browser());
controller_.reset([[AppMenuController alloc] initWithBrowser:browser()]);
fake_model_.reset(new MockAppMenuModel);
sync_prefs_.reset(new sync_driver::SyncPrefs(profile()->GetPrefs()));
manager_.reset(new browser_sync::SessionsSyncManager(
ProfileSyncServiceFactory::GetForProfile(profile())
->GetSyncClient()
->GetSyncSessionsClient(),
sync_prefs_.get(), local_device_.get(),
scoped_ptr<browser_sync::LocalSessionEventRouter>(new DummyRouter()),
base::Closure(), base::Closure()));
manager_->MergeDataAndStartSyncing(
syncer::SESSIONS,
syncer::SyncDataList(),
scoped_ptr<syncer::SyncChangeProcessor>(
new syncer::FakeSyncChangeProcessor),
scoped_ptr<syncer::SyncErrorFactory>(
new syncer::SyncErrorFactoryMock));
}
void RegisterRecentTabs(RecentTabsBuilderTestHelper* helper) {
helper->ExportToSessionsSyncManager(manager_.get());
}
sync_driver::OpenTabsUIDelegate* GetOpenTabsDelegate() {
return manager_.get();
}
void TearDown() override {
fake_model_.reset();
controller_.reset();
manager_.reset();
CocoaProfileTest::TearDown();
}
AppMenuController* controller() {
return controller_.get();
}
base::scoped_nsobject<AppMenuController> controller_;
scoped_ptr<MockAppMenuModel> fake_model_;
private:
scoped_ptr<sync_driver::SyncPrefs> sync_prefs_;
scoped_ptr<browser_sync::SessionsSyncManager> manager_;
scoped_ptr<sync_driver::LocalDeviceInfoProviderMock> local_device_;
};
TEST_F(AppMenuControllerTest, Initialized) {
EXPECT_TRUE([controller() menu]);
EXPECT_GE([[controller() menu] numberOfItems], 5);
}
TEST_F(AppMenuControllerTest, DispatchSimple) {
base::scoped_nsobject<NSButton> button([[NSButton alloc] init]);
[button setTag:IDC_ZOOM_PLUS];
// Set fake model to test dispatching.
EXPECT_CALL(*fake_model_, ExecuteCommand(IDC_ZOOM_PLUS, 0));
[controller() setModel:fake_model_.get()];
[controller() dispatchAppMenuCommand:button.get()];
chrome::testing::NSRunLoopRunAllPending();
}
TEST_F(AppMenuControllerTest, RecentTabsFavIcon) {
RecentTabsBuilderTestHelper recent_tabs_builder;
recent_tabs_builder.AddSession();
recent_tabs_builder.AddWindow(0);
recent_tabs_builder.AddTab(0, 0);
RegisterRecentTabs(&recent_tabs_builder);
RecentTabsSubMenuModel recent_tabs_sub_menu_model(
NULL, browser(), GetOpenTabsDelegate());
fake_model_->AddSubMenuWithStringId(
IDC_RECENT_TABS_MENU, IDS_RECENT_TABS_MENU,
&recent_tabs_sub_menu_model);
[controller() setModel:fake_model_.get()];
NSMenu* menu = [controller() menu];
[controller() updateRecentTabsSubmenu];
NSString* title = l10n_util::GetNSStringWithFixup(IDS_RECENT_TABS_MENU);
NSMenu* recent_tabs_menu = [[menu itemWithTitle:title] submenu];
EXPECT_TRUE(recent_tabs_menu);
EXPECT_EQ(6, [recent_tabs_menu numberOfItems]);
// Send a icon changed event and verify that the icon is updated.
gfx::Image icon(ResourceBundle::GetSharedInstance().GetNativeImageNamed(
IDR_BOOKMARKS_FAVICON));
recent_tabs_sub_menu_model.SetIcon(3, icon);
EXPECT_NSNE(icon.ToNSImage(), [[recent_tabs_menu itemAtIndex:3] image]);
recent_tabs_sub_menu_model.GetMenuModelDelegate()->OnIconChanged(3);
EXPECT_TRUE([[recent_tabs_menu itemAtIndex:3] image]);
EXPECT_NSEQ(icon.ToNSImage(), [[recent_tabs_menu itemAtIndex:3] image]);
controller_.reset();
fake_model_.reset();
}
TEST_F(AppMenuControllerTest, RecentTabsElideTitle) {
// Add 1 session with 1 window and 2 tabs.
RecentTabsBuilderTestHelper recent_tabs_builder;
recent_tabs_builder.AddSession();
recent_tabs_builder.AddWindow(0);
base::string16 tab1_short_title = base::ASCIIToUTF16("Short");
recent_tabs_builder.AddTabWithInfo(0, 0, base::Time::Now(), tab1_short_title);
base::string16 tab2_long_title = base::ASCIIToUTF16(
"Very very very very very very very very very very very very long");
recent_tabs_builder.AddTabWithInfo(0, 0,
base::Time::Now() - base::TimeDelta::FromMinutes(10), tab2_long_title);
RegisterRecentTabs(&recent_tabs_builder);
RecentTabsSubMenuModel recent_tabs_sub_menu_model(
NULL, browser(), GetOpenTabsDelegate());
fake_model_->AddSubMenuWithStringId(
IDC_RECENT_TABS_MENU, IDS_RECENT_TABS_MENU,
&recent_tabs_sub_menu_model);
[controller() setModel:fake_model_.get()];
NSMenu* menu = [controller() menu];
[controller() updateRecentTabsSubmenu];
NSString* title = l10n_util::GetNSStringWithFixup(IDS_RECENT_TABS_MENU);
NSMenu* recent_tabs_menu = [[menu itemWithTitle:title] submenu];
EXPECT_TRUE(recent_tabs_menu);
EXPECT_EQ(7, [recent_tabs_menu numberOfItems]);
// Item 1: separator.
EXPECT_TRUE([[recent_tabs_menu itemAtIndex:1] isSeparatorItem]);
// Index 2: restore tabs menu item.
NSString* restore_tab_label = l10n_util::FixUpWindowsStyleLabel(
recent_tabs_sub_menu_model.GetLabelAt(2));
EXPECT_NSEQ(restore_tab_label, [[recent_tabs_menu itemAtIndex:2] title]);
// Item 3: separator.
EXPECT_TRUE([[recent_tabs_menu itemAtIndex:3] isSeparatorItem]);
// Item 4: window title.
EXPECT_NSEQ(
base::SysUTF16ToNSString(recent_tabs_sub_menu_model.GetLabelAt(4)),
[[recent_tabs_menu itemAtIndex:4] title]);
// Item 5: short tab title.
EXPECT_NSEQ(base::SysUTF16ToNSString(tab1_short_title),
[[recent_tabs_menu itemAtIndex:5] title]);
// Item 6: long tab title.
NSString* tab2_actual_title = [[recent_tabs_menu itemAtIndex:6] title];
NSUInteger title_length = [tab2_actual_title length];
EXPECT_GT(tab2_long_title.size(), title_length);
NSString* actual_substring =
[tab2_actual_title substringToIndex:title_length - 1];
NSString* expected_substring = [base::SysUTF16ToNSString(tab2_long_title)
substringToIndex:title_length - 1];
EXPECT_NSEQ(expected_substring, actual_substring);
controller_.reset();
fake_model_.reset();
}
// Verify that |RecentTabsMenuModelDelegate| is deleted before the model
// it's observing.
TEST_F(AppMenuControllerTest, RecentTabDeleteOrder) {
[controller_ menuNeedsUpdate:[controller_ menu]];
// If the delete order is wrong then the test will crash on exit.
}
class BrowserRemovedObserver : public chrome::BrowserListObserver {
public:
BrowserRemovedObserver() { BrowserList::AddObserver(this); }
~BrowserRemovedObserver() override { BrowserList::RemoveObserver(this); }
void WaitUntilBrowserRemoved() { run_loop_.Run(); }
void OnBrowserRemoved(Browser* browser) override { run_loop_.Quit(); }
private:
base::RunLoop run_loop_;
DISALLOW_COPY_AND_ASSIGN(BrowserRemovedObserver);
};
// Test that AppMenuController can be destroyed after the Browser.
// This can happen because the AppMenuController's owner (ToolbarController)
// can outlive the Browser.
TEST_F(AppMenuControllerTest, DestroyedAfterBrowser) {
BrowserRemovedObserver observer;
// This is normally called by ToolbarController, but since |controller_| is
// not owned by one, call it here.
[controller_ browserWillBeDestroyed];
CloseBrowserWindow();
observer.WaitUntilBrowserRemoved();
// |controller_| is released in TearDown().
}
} // namespace
|