1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h"
#include <stddef.h>
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
#include "testing/gtest_mac.h"
@interface WebsiteSettingsBubbleController (ExposedForTesting)
- (NSView*)permissionsView;
- (NSButton*)resetDecisionsButton;
- (NSButton*)securityDetailsButton;
@end
@implementation WebsiteSettingsBubbleController (ExposedForTesting)
- (NSView*)permissionsView {
return permissionsView_;
}
- (NSButton*)resetDecisionsButton {
return resetDecisionsButton_;
}
- (NSButton*)securityDetailsButton {
return securityDetailsButton_;
}
@end
@interface WebsiteSettingsBubbleControllerForTesting
: WebsiteSettingsBubbleController {
@private
CGFloat defaultWindowWidth_;
}
@end
@implementation WebsiteSettingsBubbleControllerForTesting
- (void)setDefaultWindowWidth:(CGFloat)width {
defaultWindowWidth_ = width;
}
- (CGFloat)defaultWindowWidth {
// If |defaultWindowWidth_| is 0, use the superclass implementation.
return defaultWindowWidth_ ?
defaultWindowWidth_ : [super defaultWindowWidth];
}
@end
namespace {
// Indices of the menu items in the permission menu.
enum PermissionMenuIndices {
kMenuIndexContentSettingAllow = 0,
kMenuIndexContentSettingBlock,
kMenuIndexContentSettingDefault
};
const ContentSettingsType kTestPermissionTypes[] = {
// NOTE: FULLSCREEN does not support "Always block", so it must appear as
// one of the first three permissions.
CONTENT_SETTINGS_TYPE_FULLSCREEN,
CONTENT_SETTINGS_TYPE_IMAGES,
CONTENT_SETTINGS_TYPE_JAVASCRIPT,
CONTENT_SETTINGS_TYPE_PLUGINS,
CONTENT_SETTINGS_TYPE_POPUPS,
CONTENT_SETTINGS_TYPE_GEOLOCATION,
CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
CONTENT_SETTINGS_TYPE_MOUSELOCK,
CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC
};
const ContentSetting kTestSettings[] = {
CONTENT_SETTING_DEFAULT,
CONTENT_SETTING_DEFAULT,
CONTENT_SETTING_DEFAULT,
CONTENT_SETTING_ALLOW,
CONTENT_SETTING_BLOCK,
CONTENT_SETTING_ALLOW,
CONTENT_SETTING_BLOCK,
CONTENT_SETTING_ALLOW,
CONTENT_SETTING_BLOCK
};
const ContentSetting kTestDefaultSettings[] = {
CONTENT_SETTING_ALLOW,
CONTENT_SETTING_BLOCK,
CONTENT_SETTING_ASK
};
const content_settings::SettingSource kTestSettingSources[] = {
content_settings::SETTING_SOURCE_USER,
content_settings::SETTING_SOURCE_USER,
content_settings::SETTING_SOURCE_USER,
content_settings::SETTING_SOURCE_USER,
content_settings::SETTING_SOURCE_USER,
content_settings::SETTING_SOURCE_POLICY,
content_settings::SETTING_SOURCE_POLICY,
content_settings::SETTING_SOURCE_EXTENSION,
content_settings::SETTING_SOURCE_EXTENSION
};
class WebsiteSettingsBubbleControllerTest : public CocoaTest {
public:
WebsiteSettingsBubbleControllerTest() {
controller_ = nil;
}
void TearDown() override {
[controller_ close];
CocoaTest::TearDown();
}
protected:
WebsiteSettingsUIBridge* bridge_; // Weak, owned by controller.
enum MatchType {
TEXT_EQUAL = 0,
TEXT_NOT_EQUAL
};
// Creates a new website settings bubble, with the given default width.
// If |default_width| is 0, the *default* default width will be used.
void CreateBubbleWithWidth(CGFloat default_width) {
bridge_ = new WebsiteSettingsUIBridge(nullptr);
// The controller cleans up after itself when the window closes.
controller_ = [WebsiteSettingsBubbleControllerForTesting alloc];
[controller_ setDefaultWindowWidth:default_width];
[controller_ initWithParentWindow:test_window()
websiteSettingsUIBridge:bridge_
webContents:nil
isInternalPage:NO
isDevToolsDisabled:NO];
window_ = [controller_ window];
[controller_ showWindow:nil];
}
void CreateBubble() {
CreateBubbleWithWidth(0.0);
}
// Return a pointer to the first NSTextField found that either matches, or
// doesn't match, the given text.
NSTextField* FindTextField(MatchType match_type, NSString* text) {
// The window's only immediate child is an invisible view that has a flipped
// coordinate origin. It is into this that all views get placed.
NSArray* window_subviews = [[window_ contentView] subviews];
EXPECT_EQ(1U, [window_subviews count]);
NSArray* bubble_subviews = [[window_subviews lastObject] subviews];
NSArray* security_section_subviews =
[[bubble_subviews firstObject] subviews];
/**
*Expect 3 views:
* - the identity
* - identity status
* - security details link
*/
EXPECT_EQ(3U, [security_section_subviews count]);
bool desired_result = match_type == TEXT_EQUAL;
for (NSView* view in security_section_subviews) {
if ([view isKindOfClass:[NSTextField class]]) {
NSTextField* text_field = static_cast<NSTextField*>(view);
if ([[text_field stringValue] isEqual:text] == desired_result)
return text_field;
}
}
return nil;
}
NSMutableArray* FindAllSubviewsOfClass(NSView* parent_view, Class a_class) {
NSMutableArray* views = [NSMutableArray array];
for (NSView* view in [parent_view subviews]) {
if ([view isKindOfClass:a_class])
[views addObject:view];
}
return views;
}
// Sets up the dialog with some test permission settings.
void SetTestPermissions() {
// Create a list of 5 different permissions, corresponding to all the
// possible settings:
// - [allow, block, ask] by default
// - [block, allow] * [by user, by policy, by extension]
PermissionInfoList permission_info_list;
WebsiteSettingsUI::PermissionInfo info;
for (size_t i = 0; i < arraysize(kTestPermissionTypes); ++i) {
info.type = kTestPermissionTypes[i];
info.setting = kTestSettings[i];
if (info.setting == CONTENT_SETTING_DEFAULT)
info.default_setting = kTestDefaultSettings[i];
info.source = kTestSettingSources[i];
info.is_incognito = false;
permission_info_list.push_back(info);
}
ChosenObjectInfoList chosen_object_info_list;
bridge_->SetPermissionInfo(permission_info_list, chosen_object_info_list);
}
WebsiteSettingsBubbleControllerForTesting* controller_; // Weak, owns self.
NSWindow* window_; // Weak, owned by controller.
};
TEST_F(WebsiteSettingsBubbleControllerTest, BasicIdentity) {
WebsiteSettingsUI::IdentityInfo info;
info.site_identity = std::string("nhl.com");
info.identity_status = WebsiteSettings::SITE_IDENTITY_STATUS_UNKNOWN;
CreateBubble();
// Test setting the site identity.
bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));
NSTextField* identity_field = FindTextField(TEXT_EQUAL, @"nhl.com");
ASSERT_TRUE(identity_field != nil);
// Test changing the site identity, and ensure that the UI is updated.
info.site_identity = std::string("google.com");
bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));
EXPECT_EQ(identity_field, FindTextField(TEXT_EQUAL, @"google.com"));
// Find the identity status field.
NSTextField* identity_status_field =
FindTextField(TEXT_NOT_EQUAL, @"google.com");
ASSERT_NE(identity_field, identity_status_field);
// Ensure the text of the identity status field changes when the status does.
NSString* status = [identity_status_field stringValue];
info.identity_status = WebsiteSettings::SITE_IDENTITY_STATUS_CERT;
bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));
EXPECT_NSNE(status, [identity_status_field stringValue]);
}
TEST_F(WebsiteSettingsBubbleControllerTest, SecurityDetailsButton) {
WebsiteSettingsUI::IdentityInfo info;
info.site_identity = std::string("example.com");
info.identity_status = WebsiteSettings::SITE_IDENTITY_STATUS_UNKNOWN;
CreateBubble();
bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));
EXPECT_EQ([[controller_ securityDetailsButton] action],
@selector(showSecurityDetails:));
}
TEST_F(WebsiteSettingsBubbleControllerTest, ResetDecisionsButton) {
WebsiteSettingsUI::IdentityInfo info;
info.site_identity = std::string("example.com");
info.identity_status = WebsiteSettings::SITE_IDENTITY_STATUS_UNKNOWN;
CreateBubble();
// Set identity info, specifying that the button should not be shown.
info.show_ssl_decision_revoke_button = false;
bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));
EXPECT_EQ([controller_ resetDecisionsButton], nil);
// Set identity info, specifying that the button should be shown.
info.cert_id = 1;
info.show_ssl_decision_revoke_button = true;
bridge_->SetIdentityInfo(const_cast<WebsiteSettingsUI::IdentityInfo&>(info));
EXPECT_NE([controller_ resetDecisionsButton], nil);
// Check that clicking the button calls the right selector.
EXPECT_EQ([[controller_ resetDecisionsButton] action],
@selector(resetCertificateDecisions:));
// Since the bubble is only created once per identity, we only need to check
// the button is *added* when needed. So we don't check that it's removed
// when we set an identity with `show_ssl_decision_revoke_button == false`
// again.
}
TEST_F(WebsiteSettingsBubbleControllerTest, SetPermissionInfo) {
CreateBubble();
SetTestPermissions();
// There should be three subviews per permission (an icon, a label and a
// select box), plus a text label for the Permission section.
NSArray* subviews = [[controller_ permissionsView] subviews];
EXPECT_EQ(arraysize(kTestPermissionTypes) * 3 + 1, [subviews count]);
// Ensure that there is a distinct label for each permission.
NSMutableSet* labels = [NSMutableSet set];
for (NSView* view in subviews) {
if ([view isKindOfClass:[NSTextField class]])
[labels addObject:[static_cast<NSTextField*>(view) stringValue]];
}
// The section header ("Permissions") will also be found, hence the +1.
EXPECT_EQ(arraysize(kTestPermissionTypes) + 1, [labels count]);
// Ensure that the button labels are distinct, and look for the correct
// number of disabled buttons.
int disabled_count = 0;
[labels removeAllObjects];
for (NSView* view in subviews) {
if ([view isKindOfClass:[NSPopUpButton class]]) {
NSPopUpButton* button = static_cast<NSPopUpButton*>(view);
[labels addObject:[[button selectedCell] title]];
if (![button isEnabled])
++disabled_count;
}
}
EXPECT_EQ(arraysize(kTestPermissionTypes), [labels count]);
// 4 of the buttons should be disabled -- the ones that have a setting source
// of SETTING_SOURCE_POLICY or SETTING_SOURCE_EXTENSION.
EXPECT_EQ(4, disabled_count);
}
TEST_F(WebsiteSettingsBubbleControllerTest, WindowWidth) {
const CGFloat kBigEnoughBubbleWidth = 310;
// Creating a window that should fit everything.
CreateBubbleWithWidth(kBigEnoughBubbleWidth);
SetTestPermissions();
CGFloat window_width = NSWidth([[controller_ window] frame]);
// Check the window was made bigger to fit the content.
EXPECT_EQ(kBigEnoughBubbleWidth, window_width);
// Check that the window is wider than the right edge of all the permission
// popup buttons (LTR locales) or wider than the left edge (RTL locales).
bool is_rtl = base::i18n::IsRTL();
for (NSView* view in [[controller_ permissionsView] subviews]) {
if (is_rtl) {
if ([view isKindOfClass:[NSPopUpButton class]]) {
NSPopUpButton* button = static_cast<NSPopUpButton*>(view);
EXPECT_GT(NSMinX([button frame]), 0);
}
if ([view isKindOfClass:[NSImageView class]]) {
NSImageView* icon = static_cast<NSImageView*>(view);
EXPECT_LT(NSMaxX([icon frame]), window_width);
}
} else {
if ([view isKindOfClass:[NSImageView class]]) {
NSImageView* icon = static_cast<NSImageView*>(view);
EXPECT_GT(NSMinX([icon frame]), 0);
}
if ([view isKindOfClass:[NSPopUpButton class]]) {
NSPopUpButton* button = static_cast<NSPopUpButton*>(view);
EXPECT_LT(NSMaxX([button frame]), window_width);
}
}
}
}
} // namespace
|