1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h"
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/bookmark_stats.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/testing_profile.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "ui/views/controls/menu/menu_item_view.h"
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/controls/menu/submenu_view.h"
using base::ASCIIToUTF16;
using bookmarks::BookmarkModel;
using bookmarks::BookmarkNode;
class BookmarkMenuDelegateTest : public BrowserWithTestWindowTest {
public:
BookmarkMenuDelegateTest() : model_(NULL) {}
void SetUp() override {
BrowserWithTestWindowTest::SetUp();
profile()->CreateBookmarkModel(true);
model_ = BookmarkModelFactory::GetForProfile(profile());
bookmarks::test::WaitForBookmarkModelToLoad(model_);
AddTestData();
}
void TearDown() override {
DestroyDelegate();
BrowserWithTestWindowTest::TearDown();
}
protected:
bool ShouldCloseOnRemove(const bookmarks::BookmarkNode* node) const {
return bookmark_menu_delegate_->ShouldCloseOnRemove(node);
}
// Destroys the delegate. Do this rather than directly deleting
// |bookmark_menu_delegate_| as otherwise the menu is leaked.
void DestroyDelegate() {
if (!bookmark_menu_delegate_.get())
return;
// Since we never show the menu we need to pass the MenuItemView to
// MenuRunner so that the MenuItemView is destroyed.
views::MenuRunner menu_runner(bookmark_menu_delegate_->menu(), 0);
bookmark_menu_delegate_.reset();
}
void NewDelegate() {
DestroyDelegate();
bookmark_menu_delegate_.reset(
new BookmarkMenuDelegate(browser(), nullptr, nullptr));
}
void NewAndInitDelegateForPermanent() {
const BookmarkNode* node = model_->bookmark_bar_node();
NewDelegate();
bookmark_menu_delegate_->Init(&test_delegate_, NULL, node, 0,
BookmarkMenuDelegate::SHOW_PERMANENT_FOLDERS,
BOOKMARK_LAUNCH_LOCATION_NONE);
}
const BookmarkNode* GetNodeForMenuItem(views::MenuItemView* menu) {
const auto& node_map = bookmark_menu_delegate_->menu_id_to_node_map_;
auto iter = node_map.find(menu->GetCommand());
return (iter == node_map.end()) ? nullptr : iter->second;
}
int next_menu_id() { return bookmark_menu_delegate_->next_menu_id_; }
// Forces all the menus to load by way of invoking WillShowMenu() on all menu
// items of tyep SUBMENU.
void LoadAllMenus() { LoadAllMenus(bookmark_menu_delegate_->menu()); }
BookmarkModel* model_;
scoped_ptr<BookmarkMenuDelegate> bookmark_menu_delegate_;
private:
void LoadAllMenus(views::MenuItemView* menu) {
EXPECT_EQ(views::MenuItemView::SUBMENU, menu->GetType());
for (int i = 0; i < menu->GetSubmenu()->GetMenuItemCount(); ++i) {
views::MenuItemView* child = menu->GetSubmenu()->GetMenuItemAt(i);
if (child->GetType() == views::MenuItemView::SUBMENU) {
bookmark_menu_delegate_->WillShowMenu(child);
LoadAllMenus(child);
}
}
}
std::string base_path() const { return "file:///c:/tmp/"; }
// Creates the following structure:
// bookmark bar node
// a
// F1
// f1a
// F11
// f11a
// F2
// other node
// oa
// OF1
// of1a
void AddTestData() {
const BookmarkNode* bb_node = model_->bookmark_bar_node();
std::string test_base = base_path();
model_->AddURL(bb_node, 0, ASCIIToUTF16("a"), GURL(test_base + "a"));
const BookmarkNode* f1 = model_->AddFolder(bb_node, 1, ASCIIToUTF16("F1"));
model_->AddURL(f1, 0, ASCIIToUTF16("f1a"), GURL(test_base + "f1a"));
const BookmarkNode* f11 = model_->AddFolder(f1, 1, ASCIIToUTF16("F11"));
model_->AddURL(f11, 0, ASCIIToUTF16("f11a"), GURL(test_base + "f11a"));
model_->AddFolder(bb_node, 2, ASCIIToUTF16("F2"));
// Children of the other node.
model_->AddURL(model_->other_node(), 0, ASCIIToUTF16("oa"),
GURL(test_base + "oa"));
const BookmarkNode* of1 =
model_->AddFolder(model_->other_node(), 1, ASCIIToUTF16("OF1"));
model_->AddURL(of1, 0, ASCIIToUTF16("of1a"), GURL(test_base + "of1a"));
}
views::MenuDelegate test_delegate_;
DISALLOW_COPY_AND_ASSIGN(BookmarkMenuDelegateTest);
};
TEST_F(BookmarkMenuDelegateTest, VerifyLazyLoad) {
NewAndInitDelegateForPermanent();
views::MenuItemView* root_item = bookmark_menu_delegate_->menu();
ASSERT_TRUE(root_item->HasSubmenu());
EXPECT_EQ(4, root_item->GetSubmenu()->GetMenuItemCount());
EXPECT_EQ(5, root_item->GetSubmenu()->child_count()); // Includes separator.
views::MenuItemView* f1_item = root_item->GetSubmenu()->GetMenuItemAt(1);
ASSERT_TRUE(f1_item->HasSubmenu());
// f1 hasn't been loaded yet.
EXPECT_EQ(0, f1_item->GetSubmenu()->GetMenuItemCount());
// Will show triggers a load.
int next_id_before_load = next_menu_id();
bookmark_menu_delegate_->WillShowMenu(f1_item);
// f1 should have loaded its children.
EXPECT_EQ(next_id_before_load + 2, next_menu_id());
ASSERT_EQ(2, f1_item->GetSubmenu()->GetMenuItemCount());
const BookmarkNode* f1_node = model_->bookmark_bar_node()->GetChild(1);
EXPECT_EQ(f1_node->GetChild(0),
GetNodeForMenuItem(f1_item->GetSubmenu()->GetMenuItemAt(0)));
EXPECT_EQ(f1_node->GetChild(1),
GetNodeForMenuItem(f1_item->GetSubmenu()->GetMenuItemAt(1)));
// F11 shouldn't have loaded yet.
views::MenuItemView* f11_item = f1_item->GetSubmenu()->GetMenuItemAt(1);
ASSERT_TRUE(f11_item->HasSubmenu());
EXPECT_EQ(0, f11_item->GetSubmenu()->GetMenuItemCount());
next_id_before_load = next_menu_id();
bookmark_menu_delegate_->WillShowMenu(f11_item);
// Invoke WillShowMenu() twice to make sure the second call doesn't cause
// problems.
bookmark_menu_delegate_->WillShowMenu(f11_item);
// F11 should have loaded its single child (f11a).
EXPECT_EQ(next_id_before_load + 1, next_menu_id());
ASSERT_EQ(1, f11_item->GetSubmenu()->GetMenuItemCount());
const BookmarkNode* f11_node = f1_node->GetChild(1);
EXPECT_EQ(f11_node->GetChild(0),
GetNodeForMenuItem(f11_item->GetSubmenu()->GetMenuItemAt(0)));
}
// Verifies WillRemoveBookmarks() doesn't attempt to access MenuItemViews that
// have since been deleted.
TEST_F(BookmarkMenuDelegateTest, RemoveBookmarks) {
views::MenuDelegate test_delegate;
const BookmarkNode* node = model_->bookmark_bar_node()->GetChild(1);
NewDelegate();
bookmark_menu_delegate_->Init(&test_delegate, NULL, node, 0,
BookmarkMenuDelegate::HIDE_PERMANENT_FOLDERS,
BOOKMARK_LAUNCH_LOCATION_NONE);
LoadAllMenus();
std::vector<const BookmarkNode*> nodes_to_remove;
nodes_to_remove.push_back(node->GetChild(1));
bookmark_menu_delegate_->WillRemoveBookmarks(nodes_to_remove);
nodes_to_remove.clear();
bookmark_menu_delegate_->DidRemoveBookmarks();
}
// Verifies WillRemoveBookmarks() doesn't attempt to access MenuItemViews that
// have since been deleted.
TEST_F(BookmarkMenuDelegateTest, CloseOnRemove) {
views::MenuDelegate test_delegate;
const BookmarkNode* node = model_->bookmark_bar_node()->GetChild(1);
NewDelegate();
bookmark_menu_delegate_->Init(&test_delegate, nullptr, node, 0,
BookmarkMenuDelegate::HIDE_PERMANENT_FOLDERS,
BOOKMARK_LAUNCH_LOCATION_NONE);
// Any nodes on the bookmark bar should close on remove.
EXPECT_TRUE(ShouldCloseOnRemove(model_->bookmark_bar_node()->GetChild(2)));
// Descendants of the bookmark should not close on remove.
EXPECT_FALSE(ShouldCloseOnRemove(
model_->bookmark_bar_node()->GetChild(1)->GetChild(0)));
EXPECT_FALSE(ShouldCloseOnRemove(model_->other_node()->GetChild(0)));
// Make it so the other node only has one child.
// Destroy the current delegate so that it doesn't have any references to
// deleted nodes.
DestroyDelegate();
while (model_->other_node()->child_count() > 1)
model_->Remove(model_->other_node()->GetChild(1));
NewDelegate();
bookmark_menu_delegate_->Init(&test_delegate, nullptr, node, 0,
BookmarkMenuDelegate::HIDE_PERMANENT_FOLDERS,
BOOKMARK_LAUNCH_LOCATION_NONE);
// Any nodes on the bookmark bar should close on remove.
EXPECT_TRUE(ShouldCloseOnRemove(model_->other_node()->GetChild(0)));
}
|
