1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/message_loop/message_loop.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/webui/chrome_web_contents_handler.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/test_utils.h"
#include "ui/views/controls/webview/web_dialog_view.h"
#include "ui/views/widget/widget.h"
#include "ui/web_dialogs/test/test_web_dialog_delegate.h"
namespace {
// Initial size of WebDialog for SizeWindow test case. Note the height must be
// at least 59 on Windows.
const int kInitialWidth = 60;
const int kInitialHeight = 60;
class TestWebDialogView : public views::WebDialogView {
public:
TestWebDialogView(content::BrowserContext* context,
ui::WebDialogDelegate* delegate,
bool* observed_destroy)
: views::WebDialogView(context, delegate, new ChromeWebContentsHandler),
should_quit_on_size_change_(false),
observed_destroy_(observed_destroy) {
EXPECT_FALSE(*observed_destroy_);
delegate->GetDialogSize(&last_size_);
}
~TestWebDialogView() override { *observed_destroy_ = true; }
void set_should_quit_on_size_change(bool should_quit) {
should_quit_on_size_change_ = should_quit;
}
private:
// TODO(xiyuan): Update this when WidgetDelegate has bounds change hook.
void SaveWindowPlacement(const gfx::Rect& bounds,
ui::WindowShowState show_state) override {
if (should_quit_on_size_change_ && last_size_ != bounds.size()) {
// Schedule message loop quit because we could be called while
// the bounds change call is on the stack and not in the nested message
// loop.
base::MessageLoop::current()->PostTask(
FROM_HERE,
base::Bind(&base::MessageLoop::Quit,
base::Unretained(base::MessageLoop::current())));
}
last_size_ = bounds.size();
}
void OnDialogClosed(const std::string& json_retval) override {
should_quit_on_size_change_ = false; // No quit when we are closing.
views::WebDialogView::OnDialogClosed(json_retval); // Deletes this.
}
// Whether we should quit message loop when size change is detected.
bool should_quit_on_size_change_;
gfx::Size last_size_;
bool* observed_destroy_;
DISALLOW_COPY_AND_ASSIGN(TestWebDialogView);
};
class WebDialogBrowserTest : public InProcessBrowserTest {
public:
WebDialogBrowserTest() {}
// content::BrowserTestBase:
void SetUpOnMainThread() override;
protected:
TestWebDialogView* view_ = nullptr;
bool web_dialog_delegate_destroyed_ = false;
bool web_dialog_view_destroyed_ = false;
private:
DISALLOW_COPY_AND_ASSIGN(WebDialogBrowserTest);
};
void WebDialogBrowserTest::SetUpOnMainThread() {
ui::test::TestWebDialogDelegate* delegate =
new ui::test::TestWebDialogDelegate(GURL(chrome::kChromeUIChromeURLsURL));
delegate->set_size(kInitialWidth, kInitialHeight);
delegate->SetDeleteOnClosedAndObserve(&web_dialog_delegate_destroyed_);
view_ = new TestWebDialogView(browser()->profile(), delegate,
&web_dialog_view_destroyed_);
gfx::NativeView parent_view =
browser()->tab_strip_model()->GetActiveWebContents()->GetNativeView();
views::Widget::CreateWindowWithParent(view_, parent_view);
view_->GetWidget()->Show();
}
} // namespace
// Windows has some issues resizing windows. An off by one problem, and a
// minimum size that seems too big. See http://crbug.com/52602.
#if defined(OS_WIN)
#define MAYBE_SizeWindow DISABLED_SizeWindow
#else
#define MAYBE_SizeWindow SizeWindow
#endif
IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {
// TestWebDialogView should quit current message loop on size change.
view_->set_should_quit_on_size_change(true);
gfx::Rect set_bounds = view_->GetWidget()->GetClientAreaBoundsInScreen();
gfx::Rect actual_bounds, rwhv_bounds;
// Bigger than the default in both dimensions.
set_bounds.set_width(400);
set_bounds.set_height(300);
// WebDialogView ignores the WebContents* |source| argument to MoveContents.
// We could pass view_->web_contents(), but it's not relevant for the test.
view_->MoveContents(nullptr, set_bounds);
content::RunMessageLoop(); // TestWebDialogView will quit.
actual_bounds = view_->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(set_bounds, actual_bounds);
rwhv_bounds =
view_->web_contents()->GetRenderWidgetHostView()->GetViewBounds();
EXPECT_LT(0, rwhv_bounds.width());
EXPECT_LT(0, rwhv_bounds.height());
EXPECT_GE(set_bounds.width(), rwhv_bounds.width());
EXPECT_GE(set_bounds.height(), rwhv_bounds.height());
// Larger in one dimension and smaller in the other.
set_bounds.set_width(550);
set_bounds.set_height(250);
view_->MoveContents(nullptr, set_bounds);
content::RunMessageLoop(); // TestWebDialogView will quit.
actual_bounds = view_->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(set_bounds, actual_bounds);
rwhv_bounds =
view_->web_contents()->GetRenderWidgetHostView()->GetViewBounds();
EXPECT_LT(0, rwhv_bounds.width());
EXPECT_LT(0, rwhv_bounds.height());
EXPECT_GE(set_bounds.width(), rwhv_bounds.width());
EXPECT_GE(set_bounds.height(), rwhv_bounds.height());
// Get very small.
const gfx::Size min_size = view_->GetWidget()->GetMinimumSize();
EXPECT_LT(0, min_size.width());
EXPECT_LT(0, min_size.height());
set_bounds.set_size(min_size);
view_->MoveContents(nullptr, set_bounds);
content::RunMessageLoop(); // TestWebDialogView will quit.
actual_bounds = view_->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(set_bounds, actual_bounds);
rwhv_bounds =
view_->web_contents()->GetRenderWidgetHostView()->GetViewBounds();
EXPECT_LT(0, rwhv_bounds.width());
EXPECT_LT(0, rwhv_bounds.height());
EXPECT_GE(set_bounds.width(), rwhv_bounds.width());
EXPECT_GE(set_bounds.height(), rwhv_bounds.height());
// Check to make sure we can't get to 0x0. First expand beyond the minimum
// size that was set above so that TestWebDialogView has a change to pick up.
set_bounds.set_height(250);
view_->MoveContents(nullptr, set_bounds);
content::RunMessageLoop(); // TestWebDialogView will quit.
actual_bounds = view_->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(set_bounds, actual_bounds);
// Now verify that attempts to re-size to 0x0 enforces the minimum size.
set_bounds.set_width(0);
set_bounds.set_height(0);
view_->MoveContents(nullptr, set_bounds);
content::RunMessageLoop(); // TestWebDialogView will quit.
actual_bounds = view_->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(min_size, actual_bounds.size());
// And that the render view is also non-zero.
rwhv_bounds =
view_->web_contents()->GetRenderWidgetHostView()->GetViewBounds();
EXPECT_LT(0, rwhv_bounds.width());
EXPECT_LT(0, rwhv_bounds.height());
// WebDialogView::CanClose() returns true only after before-unload handlers
// have run (or the dialog has none and gets fast-closed via
// RenderViewHostImpl::ClosePageIgnoringUnloadEvents which is the case here).
// Close via WebContents for more authentic coverage (vs Widget::CloseNow()).
EXPECT_FALSE(web_dialog_delegate_destroyed_);
view_->web_contents()->Close();
EXPECT_TRUE(web_dialog_delegate_destroyed_);
// The close of the actual widget should happen asynchronously.
EXPECT_FALSE(web_dialog_view_destroyed_);
content::RunAllPendingInMessageLoop();
EXPECT_TRUE(web_dialog_view_destroyed_);
}
// Test that closing the parent of a window-modal web dialog properly destroys
// the dialog and delegate.
IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, CloseParentWindow) {
// Open a second browser window so we don't trigger shutdown.
ui_test_utils::NavigateToURLWithDisposition(
browser(), GURL(url::kAboutBlankURL), NEW_WINDOW,
ui_test_utils::BROWSER_TEST_NONE);
// TestWebDialogDelegate defaults to window-modal, so closing the browser
// Window (as opposed to closing merely the tab) should close the dialog.
EXPECT_EQ(ui::MODAL_TYPE_WINDOW,
view_->GetWidget()->widget_delegate()->GetModalType());
// Close the parent window. Tear down may happen asynchronously.
EXPECT_FALSE(web_dialog_delegate_destroyed_);
EXPECT_FALSE(web_dialog_view_destroyed_);
browser()->window()->Close();
content::RunAllPendingInMessageLoop();
EXPECT_TRUE(web_dialog_delegate_destroyed_);
EXPECT_TRUE(web_dialog_view_destroyed_);
}
|
