1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/auto_reset.h"
#include "base/files/scoped_temp_dir.h"
#include "base/json/json_reader.h"
#include "base/prefs/pref_service.h"
#include "base/values.h"
#include "chrome/browser/history/download_row.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/webui/downloads_dom_handler.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/web_contents.h"
namespace {
// Reads |right_json| into a ListValue |left_list|; returns true if all
// key-value pairs in in all dictionaries in |right_list| are also in the
// corresponding dictionary in |left_list|. Ignores keys in dictionaries in
// |left_list| that are not in the corresponding dictionary in |right_list|.
bool ListMatches(base::ListValue* left_list, const std::string& right_json) {
scoped_ptr<base::Value> right_value(base::JSONReader::Read(right_json));
base::ListValue* right_list = NULL;
CHECK(right_value->GetAsList(&right_list));
for (size_t i = 0; i < left_list->GetSize(); ++i) {
base::DictionaryValue* left_dict = NULL;
base::DictionaryValue* right_dict = NULL;
CHECK(left_list->GetDictionary(i, &left_dict));
CHECK(right_list->GetDictionary(i, &right_dict));
for (base::DictionaryValue::Iterator iter(*right_dict);
!iter.IsAtEnd(); iter.Advance()) {
base::Value* left_value = NULL;
if (left_dict->HasKey(iter.key()) &&
left_dict->Get(iter.key(), &left_value) &&
!iter.value().Equals(left_value)) {
LOG(WARNING) << iter.key();
return false;
}
}
}
return true;
}
// A |DownloadsDOMHandler| that doesn't use a real WebUI object, but is real in
// all other respects.
class MockDownloadsDOMHandler : public DownloadsDOMHandler {
public:
explicit MockDownloadsDOMHandler(content::DownloadManager* dlm)
: DownloadsDOMHandler(dlm),
waiting_list_(false),
waiting_updated_(false) {
}
virtual ~MockDownloadsDOMHandler() {}
base::ListValue* downloads_list() { return downloads_list_.get(); }
base::ListValue* download_updated() { return download_updated_.get(); }
void WaitForDownloadsList() {
if (downloads_list_.get())
return;
base::AutoReset<bool> reset_waiting(&waiting_list_, true);
content::RunMessageLoop();
}
void WaitForDownloadUpdated() {
if (download_updated_.get())
return;
base::AutoReset<bool> reset_waiting(&waiting_updated_, true);
content::RunMessageLoop();
}
void reset_downloads_list() { downloads_list_.reset(); }
void reset_download_updated() { download_updated_.reset(); }
protected:
virtual content::WebContents* GetWebUIWebContents() OVERRIDE {
return NULL;
}
virtual void CallDownloadsList(const base::ListValue& downloads) OVERRIDE {
downloads_list_.reset(downloads.DeepCopy());
if (waiting_list_) {
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE, MessageLoop::QuitClosure());
}
}
virtual void CallDownloadUpdated(const base::ListValue& download) OVERRIDE {
download_updated_.reset(download.DeepCopy());
if (waiting_updated_) {
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE, MessageLoop::QuitClosure());
}
}
private:
scoped_ptr<base::ListValue> downloads_list_;
scoped_ptr<base::ListValue> download_updated_;
bool waiting_list_;
bool waiting_updated_;
DISALLOW_COPY_AND_ASSIGN(MockDownloadsDOMHandler);
};
} // namespace
class DownloadsDOMHandlerTest : public InProcessBrowserTest {
public:
DownloadsDOMHandlerTest() {}
virtual ~DownloadsDOMHandlerTest() {}
virtual void SetUpOnMainThread() OVERRIDE {
CHECK(downloads_directory_.CreateUniqueTempDir());
browser()->profile()->GetPrefs()->SetFilePath(
prefs::kDownloadDefaultDirectory,
downloads_directory_.path());
CHECK(test_server()->Start());
}
content::DownloadManager* download_manager() {
return content::BrowserContext::GetDownloadManager(browser()->profile());
}
private:
base::ScopedTempDir downloads_directory_;
DISALLOW_COPY_AND_ASSIGN(DownloadsDOMHandlerTest);
};
// Tests that DownloadsDOMHandler detects new downloads and relays them to the
// renderer.
// crbug.com/159390: This test fails when daylight savings time ends.
IN_PROC_BROWSER_TEST_F(DownloadsDOMHandlerTest,
DownloadsDOMHandlerTest_Created) {
MockDownloadsDOMHandler mddh(download_manager());
GURL url = test_server()->GetURL("files/downloads/image.jpg");
std::vector<GURL> url_chain;
url_chain.push_back(url);
base::Time current(base::Time::Now());
download_manager()->CreateDownloadItem(
base::FilePath(FILE_PATH_LITERAL("/path/to/file")),
base::FilePath(FILE_PATH_LITERAL("/path/to/file")),
url_chain,
GURL(std::string()),
current,
current,
128,
128,
content::DownloadItem::COMPLETE,
content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
content::DOWNLOAD_INTERRUPT_REASON_NONE,
false);
mddh.WaitForDownloadsList();
ASSERT_EQ(1, static_cast<int>(mddh.downloads_list()->GetSize()));
EXPECT_TRUE(ListMatches(
mddh.downloads_list(),
"[{\"file_externally_removed\": false,"
" \"file_name\": \"file\","
" \"id\": 0,"
" \"otr\": false,"
" \"since_string\": \"Today\","
" \"state\": \"COMPLETE\","
" \"total\": 128}]"));
mddh.WaitForDownloadUpdated();
ASSERT_EQ(1, static_cast<int>(mddh.download_updated()->GetSize()));
EXPECT_TRUE(ListMatches(
mddh.download_updated(),
"[{\"file_externally_removed\": true,"
" \"id\": 0}]"));
mddh.reset_downloads_list();
mddh.HandleClearAll(NULL);
mddh.WaitForDownloadsList();
EXPECT_EQ(0, static_cast<int>(mddh.downloads_list()->GetSize()));
}
// TODO(benjhayden): Test the extension downloads filter for both
// mddh.downloads_list() and mddh.download_updated().
// TODO(benjhayden): Test incognito, both downloads_list() and that on-record
// calls can't access off-record items.
// TODO(benjhayden): Test that bad download ids incoming from the javascript are
// dropped on the floor.
// TODO(benjhayden): Test that IsTemporary() downloads are not shown.
// TODO(benjhayden): Test that RemoveObserver is called on all download items,
// including items that crossed IsTemporary() and back.
|
